anastasiamacaxw_: wallyworld: cleaned up apiserver storage dynamic add...  :D http://reviews.vapour.ws/r/1563/00:19
mupBug #1452511 was opened: jujud does not restart after upgrade-juju on systemd hosts <regression> <systemd> <vivid> <juju-core:New> <juju-core 1.23:New> <juju-core 1.24:New> <https://launchpad.net/bugs/1452511>00:32
menn0wallyworld: ^^^ another critical systemd bug that I just ran across00:33
wallyworldaxw_: i didn't realise in the standup - looking at the code now, i see we already have a "maas" provider type defined00:43
axw_wallyworld: we do? where?00:44
wallyworldaxw_: oh wait, we have some infrastructure code to register00:45
wallyworldbut nothing fully defined yet00:45
menn0wallyworld: so I've got my fix for bug 1441913 ready. it's quite an extensive change but it looks like this area has no tests as I haven't had to change a single machine agent test :(01:03
mupBug #1441913: juju upgrade-juju failed to configure mongodb replicasets <canonical-is> <mongodb> <upgrade-juju> <juju-core:In Progress by menno.smits> <juju-core 1.23:In Progress by menno.smits> <juju-core 1.24:In Progress by menno.smits> <https://launchpad.net/bugs/1441913>01:03
wallyworldmenn0: sadly that doesn't surprise me01:03
wallyworldi'll look as soon as i can, just in the middle of something01:04
menn0wallyworld: no need for you to do anything right now. i'm just moaning :)01:05
wallyworldaxw_: i've pushed the changes to plug in the maas storage provider to the provisioner, but i think there's a bug in state/storage.go default pool processing. got a sec to discuss in standup hangout?01:33
dpb1wallyworld: hey re: #1349949 -- I'm easily reproducing on 1.23.202:24
mupBug #1349949: Juju's mongodb does not need to log every command in syslog <cloud-installer> <landscape> <logging> <mongodb> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1349949>02:24
wallyworlddpb1: it's easy to reproduce. but, there's no obvious mongo setting to turn it off and i recall one time i used google to try and solve many others were having the same issue with no resolution02:25
dpb1wallyworld: ah, I was just commenting on this update: "I wasn't able to reproduce the messages on a recent02:26
dpb1version of Juju (so maybe we can mark it invalid?)02:26
wallyworldoh, ok, i didn't see that comment02:26
wallyworldi would not say it is invalid :-)02:26
dpb1ok, great. :)02:26
natefinchbah, I knew I should have gotten rid of the part of the upstart script that redirects stderr to the machine log.... it was masking the fact that someone overrode the lumberjack logger and sent logs back to stderr02:53
wallyworldaxw_: i've tweaked storage constraints defaults, no bug yet, will raise one if we want to proceed with the PR02:56
wallyworldaxw_: at one stage, i had a recollection that AWS was different but i think uniform behaviours for all providers is best02:57
axw_wallyworld: if no *contsraints* are specified, we should use loop. so you could specify count only, and we should still use the env default02:57
axw_(just reading your description, not code yet)02:58
wallyworldaxw_: ok, i was just basing on size and pool02:58
wallyworldi can tweak further02:58
axw_wallyworld: also, it shouldn't be loop for filesystem type02:59
axw_this needs to be done in defaultStragePool I think02:59
wallyworldah yeah, true03:00
wallyworldi'll fix03:00
thumpernatefinch: how early in the jujud process does the default logger get replaced?03:00
menn0wallyworld, thumper or axw: fix for bug 1441913: http://reviews.vapour.ws/r/1599/03:20
mupBug #1441913: juju upgrade-juju failed to configure mongodb replicasets <canonical-is> <mongodb> <upgrade-juju> <juju-core:In Progress by menno.smits> <juju-core 1.23:In Progress by menno.smits> <juju-core 1.24:In Progress by menno.smits> <https://launchpad.net/bugs/1441913>03:20
wallyworldaxw_: changes pushed03:21
axw_wallyworld: ok. just reviewing your maas changes03:22
wallyworldno rush03:22
axw_wallyworld: what did you base your code on? spec? docs?03:22
wallyworldaxw_: the maas roadmap doc03:22
axw_wallyworld: got a link handy?03:22
anastasiamacaxw_: wallyworld: charm url on storage instance http://reviews.vapour.ws/r/1600/03:29
anastasiamacaxw_: wallyworld: btw, would i need an upgrade step even tho storage was behind dev flag prior to 1.24?03:32
wallyworldalready looking03:32
mupBug #1452535 was opened: default storage constraints are not quite correct <juju-core:Triaged by wallyworld> <juju-core 1.24:In Progress by wallyworld> <https://launchpad.net/bugs/1452535>03:33
davecheneysinzui: --- FAIL: TestPackage (0.00s) mgo.go:350: exec: "/usr/lib/juju/bin/mongod": stat /usr/lib/juju/bin/mongod: no such file or directory03:34
davecheneyhow do I get this version of mongodb ?03:34
davecheneyit's not documented in CONTRIBUTING.md03:35
anastasiamacdavecheney: my understand was that in featuretest package03:36
anastasiamacdavecheney: we want to test "glue" btw diff layers03:36
anastasiamacdavecheney: hence usage ofJujuConnSuite is k03:37
anastasiamacdavecheney: ?03:37
davecheneyanastasiamac: are we talking about the same thing ?03:39
davecheneyi was having a whinge about http://reviews.vapour.ws/r/1597/03:39
davecheneyi see what you're talking about03:40
davecheneyjuju conn suite still sucks03:40
anastasiamacdavecheney: yes :D03:40
anastasiamacdavecheney: NOOOOO in featuretest pkg :D03:40
anastasiamacdavecheney: :)) yes, it does but full stack testing needs to happen too :D03:41
anastasiamacwallyworld: thnx for review :D i'll wait for 2nd opinion then :D03:43
cheryljdavecheney:  changing repo suite to conn suite in that pkg was something I did because I needed to be able to create a new environment to really test the full stack03:44
davecheneyit's not a serious objection03:44
davecheneythumper knows that03:44
davecheney--- FAIL: TestPackage (0.00s) mgo.go:350: exec: "/usr/lib/juju/bin/mongod": stat /usr/lib/juju/bin/mongod: no such file or directory03:44
cheryljwell I don't03:44
davecheneydoes anyone know where to get the compatible version of mongo03:45
cheryljBut I guess I do now :)03:45
anastasiamaccherylj: sounds like a perfect candiddate to add to our "reviewer tips" document :D03:45
anastasiamaccherylj: if only i could type :D03:45
anastasiamaccherylj: *candidate03:46
wallyworlddavecheney: isn't there a juju-mongodb package?03:49
davecheneywhere do I get it ?03:49
davecheneythis isn't the system one, the system one doesn't install into /usr/lib/juju03:49
menn0davecheney: on any recent Ubuntu: apt-get install juju-mongodb03:50
menn0wallyworld: do you have a moment to look at that replicaset init review?03:52
* menn0 is itching to be done with bug fixes03:52
wallyworldsorta, will look now03:52
menn0wallyworld: sorry, I know you're super busy03:52
davecheneymenn0: thanks03:53
davecheneythat's the answer03:53
wallyworldmenn0: np, i just saw the description, test time reduction :-)03:53
menn0wallyworld: yeah, the test was a bit dumb. even without my fix the test should have patched the retry strategy to reduce the test time03:54
wallyworlddavecheney: i'm surprised juju package doesn't require juju-mongodb. but then again, i'm not a packaging expert03:54
menn0davecheney, wallyworld: i'm pretty sure the juju-local package does03:54
wallyworldah yes, that rings a bell03:55
menn0davecheney, wallyworld: for non-local providers juju installs juju-mongodb itself03:55
wallyworldso why was dave not having it on his system?03:55
menn0juju-local not installed?03:56
menn0cosmic rays?03:56
wallyworldor juju hadn't been run03:56
menn0I just checked apt-cache and juju-local definitely depends on juju-mongodb03:57
davecheneymenn0: this is a fresh machine03:59
davecheneyi'm building from source03:59
menn0davecheney: ok so you need to install juju-local03:59
menn0davecheney: i'm pretty sure the local provider tells you this if you try to bootstrap and it's not there04:00
menn0davecheney: it installs the deps that the local provider needs04:00
davecheneyi'm not bootstrapping04:02
davecheneyjust running the tests04:02
axw_wallyworld: sent a bunch of comments04:06
axw_wallyworld anastasiamac: I don't think we need to add the charm URL/rev/anything to output at all04:07
axw_wallyworld anastasiamac: it was just an internal detail, so we can track it in case we need to perform upgrade steps04:07
menn0davecheney: ok right. well just install juju-mongodb or juju-local. this should be better documented.04:08
anastasiamacaxw_: tyvm :D04:08
wallyworldaxw_:  might be nice for a verbose option later, so worth keeping in api result even if we don't display04:08
axw_wallyworld: I don't see what a user is ever going to do with that information04:08
wallyworldsee what version of the charm their storage was made from?04:09
wallyworldfor debugging problems04:09
wallyworldmaybe i'm not a normal user04:09
wallyworldwe wouldn't show it by default04:09
axw_ok, as long as it's not shown, I don't care much04:10
wallyworldbut i'm not fussed either way04:10
wallyworldprobs best to leave it out f everything then if there's no use for it04:10
wallyworldapiserver i mean04:10
anastasiamacaxw_: wallyworld: k, i'll keep it in state on creation but will remove any mention of it from apiserver and above :D04:12
wallyworldmenn0: review done, tyvm04:14
menn0wallyworld: cheers04:16
menn0looks like the network from CI to the ubuntu archives is sick. apt-get is running very slow and/or failing05:02
wallyworldaxw_: i've updated both my PRs from before if you are free to look05:21
axw_wallyworld: ok. just trying to figure out why my PR is failing: http://juju-ci.vapour.ws:8080/job/github-merge-juju/3123/consoleFull05:22
axw_works here :/05:22
wallyworldi'll take a look05:22
axw_seems related to leadership, but no idea why05:22
axw_there's an extra leader-settings-changed hook in the failing test05:23
axw_wallyworld: are you saying that MAAS doesn't currently support specifying the root disk size?05:25
axw_or we don't05:25
wallyworldaxw_: maas doesn't05:25
axw_okey dokey05:25
wallyworldwe have root disk constraint of course05:25
wallyworldmaas in the last X days landed some code to allow it05:26
axw_I take it the "root" label is just a placeholder for now then05:26
axw_ah right, you did mention that05:26
wallyworldaxw_: i *think* i've seen TestUniterRelations fail intermittently05:28
axw_wallyworld: it's happened twice in a row on my branch on the bot, seems too much of a coincidence05:28
wallyworldoh :-(05:28
wallyworldmight be subtle timing issue05:29
axw_unless someone else merged some crap into 1.24 and they were luck05:29
axw_could be that too, anyway I'll look after I finish reviewing this05:30
=== urulama__ is now known as urulama
axw_wallyworld: reviewed MAAS one again05:34
wallyworldaxw_: hopefully you are making progress with the test failure? anyway, i think/hope the maas one is ok now when you get a chance06:03
axw_wallyworld: nope :/06:03
wallyworldaxw_: fwiw, i pulled your branch and it works for me too06:11
axw_wallyworld: seems whether the leader-settings-changed hook runs before stop is non-deterministic. see "unit becomes dying while in a relation" directly below the failing test in worker/uniter/uniter_test.go06:31
axw_wallyworld: I'll propose a change for that separately06:32
axw_wallyworld: please, http://reviews.vapour.ws/r/1603/06:38
axw_or davecheney ^^06:38
wallyworldaxw_: sorry, just got back from school pick up07:07
wallyworldaxw_: nice pickup, lgtm07:09
axw_wallyworld: thanks07:09
TheMuemorning o/07:37
davecheneyjam: you're on call reviewer today07:57
davecheneycan you have a look at07:57
jamdavecheney: looking08:07
jamdavecheney: reviewed http://reviews.vapour.ws/r/1592/08:11
=== liam_ is now known as Guest73172
davecheneyjam: thanks08:49
jamvoidspace: TheMue: I won't be able to make the standup today, looking into sky issues08:55
TheMuejam: ok, thanks for the info08:55
TheMuejam: what does it mean "looking into sky issues" (for a non-native speaker)?08:56
voidspacejam: ok08:56
voidspacejam: I'd like some input on bug 1435283 when you have time08:57
mupBug #1435283: juju occasionally switches a units public-address if an additional interface is added post-deployment <network> <juju-core:Triaged> <juju-core 1.24:Triaged by mfoord> <https://launchpad.net/bugs/1435283>08:57
voidspacejam: preserving the first entry (in state.Machine.SetAddresses I assume) is a very simple change08:57
voidspacejam: but overly simplistic08:57
voidspacejam: should we prefer the first public address for example08:57
dooferladvoidspace: doc updated09:41
mupBug #1450631 changed: Something is injecting gopkg.in/juju/charm.v6-unstable into the tree <blocker> <ci> <packaging> <juju-core:Fix Released by makyo> <juju-release-tools:Fix Released by gz> <https://launchpad.net/bugs/1450631>09:43
voidspacedooferlad: cool09:53
voidspacedooferlad: those proliants are designed for dual-ranked ecc memory09:53
voidspacedooferlad: so buying the right ram is either expensive (HP official) or non-trivial09:54
mupBug #1452649 was opened: storage: loop devices leaked by LXC containers <local> <lxc> <storage> <juju-core:Triaged> <https://launchpad.net/bugs/1452649>09:55
dooferladvoidspace: http://uk.crucial.com/gbr/en/compatible-upgrade-for/HP-Compaq/proliant-microserver-gen809:58
dooferladvoidspace: easy, £40 each09:58
dooferladvoidspace: It is just DDE3 1600 ECC RAM in normal DIMM form.09:58
voidspacedooferlad: heh, yeah I'm on that site now09:59
voidspacedooferlad: it needs to be "unregistered ecc" though apparently, but crucial tell you which memory to buy anyway09:59
voidspacedooferlad: so server, ram and ssd come in something under half the budget - so if it works I can duplicate it10:01
dooferladvoidspace, TheMue: https://plus.google.com/hangouts/_/canonical.com/juju-core-team10:02
voidspacedooferlad: thanks10:02
TheMuedooferlad: already there10:02
voidspacedooferlad: ordered memory, SSD and server10:19
dooferladvoidspace: sweet! Will be interested to hear how it goes.10:20
jamvoidspace: so IIRC the idea from jamespage is that just because we see a new device we shouldn't think that it is a device that we can use11:12
jamat least one idea is that the device has only shown up after we connected, which means we would have never bound to it11:12
mupBug #1254766 changed: unit "started" status is unhelpful <canonical-is> <canonical-webops> <cloud-installer> <hooks> <landscape> <papercut> <relations> <status> <ubuntu-engineering> <usability> <juju-core:Fix Released by wallyworld> <https://launchpad.net/bugs/1254766>11:13
mupBug #1452680 was opened: Failed to upgrade from 1.22.1 to 1.22.3 during deployment <cloud-installer> <landscape> <juju-core:New> <https://launchpad.net/bugs/1452680>11:13
voidspacejam: so keeping the first address first would solve that problem, right?11:42
jamvoidspace: keeping the address we are using does seem correct. I think jamespage's point is we shouldn't start recording it as a *possible* address yet. Though I don't know that we can detect when a charm/API would actually be using a given address.11:43
voidspacejam: if an interface with an ip address comes up on the machine how are we to know we're not supposed to be using it11:43
voidspacejam: they'd be annoyed if they *did* want to use it11:44
voidspacejam: the wider network model should solve this11:44
voidspacejam: the concept of "the address" is currently, the first address from the list that have been set by state.Machine.SetAddresses - correct?11:45
wwitzel3jam: ping11:47
jamwwitzel3: /wave, I'm currently in about 4 conversations, but I'll try to include you as well :)11:47
jamvoidspace: so I believe jamespage's point is "if we have called bind() on an address, then we shouldn't report it as a possible API address" which is different from *should* we bind to it11:48
wwitzel3jam: yeah, I noticed and thought that ping was superfluous after I read the buffer11:48
wwitzel3jam: I can wait, I'd like to jump on a hangout if possible11:48
voidspacejam: so if we call bind() (where?) shouldn't we *store* that information as canonical and only report that11:50
voidspacejam: rather than relying on list ordering11:50
voidspaceI presume it's the charm that's binding11:54
anastasiamacmattyw: +1 on focusing team meetings on topic12:21
anastasiamacmattyw: -1000 for haskell discussion12:21
mgzanastasiamac: ...wha?12:22
anastasiamacmgz: i like the idea of proposing topics for core meetings for discussion12:23
mattywanastasiamac, I like putting saying things like that to check people read it ;)12:23
mattywanastasiamac, I remember we sort of discussed it at nuremberg - I've spent the interim time trying to think of something12:24
anastasiamacmgz: i do not like the h-word matty used in  the same sentence as juju :D12:24
anastasiamacmattyw: thnx for putting it in writting :D12:25
mattywanastasiamac, thanks for the support :)12:26
mgzanastasiamac: you don't want us to rewrite juju in haskell? :)12:30
anastasiamacmgz: :))12:30
=== luca__ is now known as lucap_
TheMuemattyw: I would prefer erlang ;)12:40
mattywTheMue, would you settle for elixir?12:41
TheMuemattyw: somehow not, maybe I'm too much erlang old school12:41
mattywTheMue, maybe I can change your mind in a future team meeting ;)12:42
TheMuemattyw: I'm currently taking a look into pony, kind of best of go, erlang, and rust, but too young right now12:42
TheMuemattyw: towards elixir or haskell?12:42
mattywTheMue, elixir12:43
perrito666hello all12:43
mattywTheMue, but also - I'm very much not serious12:43
TheMueperrito666: heya12:43
mattywTheMue, will have to look at pony12:43
mattywperrito666, morning!12:43
TheMuemattyw: elixir isn't bad, but cannot get warm with the syntax12:44
mattywTheMue, my feeling to erlang12:45
mattywTheMue, althought I've been told you get used to it in no time12:45
TheMuemattyw: hehe, yeah, it's strange too.12:46
TheMuemattyw: yes, it's more compelling than e.g. elixir.12:46
perrito666mattyw: do you get hipster points for a talk about errlang in a channel  about a go project?12:46
TheMuemattyw: but this old prolog based syntax makes many people wonder12:47
TheMueperrito666: madness points for mentioning the reimplementation of juju in language X (fill in any language you like)12:47
mattywperrito666, I find hipster points is a zero sum game12:49
katco+1 for learning any new programming language :)13:15
katcodoes nothing but broaden your horizons!13:16
anastasiamackatco: learning new programming language is not the question :D13:18
anastasiamackatco: personally, haskell is an old friend13:18
katcoit is probably the next one i'll learn13:18
TheMueI just took a look into rust, but only for an article about it. it's ok, but not mine. I like langs with lightweight processes, like erlang, go, and now pony.13:26
wallyworldaxw: a small one https://github.com/juju/juju/pull/225013:28
natefinchwhat's the easiest way to figure out what branches have been cut from master since a specific commit?   I have to figure out what releases have this bug in them13:31
perrito666natefinch: a graphical tool13:31
perrito666but if you know in which commit the bug is present just go to github to that commit13:32
perrito666and in the  top bar it will tell you which branches contain said commit13:32
natefinchperrito666: ahh, cool, thanks13:32
abentleynatefinch: You would actually want branches that *merged* master with that commit too, so perrito666's answer is actually better than you asked for.13:33
natefinchlooks like log rotation for machine logs is broken in all of 1.22 and newer13:33
alexisbnatefinch, lovely13:39
natefinchalexisb: yeah... it's mostly my fault for  not having CI tests for the rotation.   Katco moved around some of the machine agent code, and just happened to move the log rotation stuff earlier in the startup code... and we evidently have two places that twiddle with how we write logs... and the order in which that code runs determines whether we rotate or not.13:42
alexisbwell here is our opportunity to fix it13:43
natefinchalexisb: yep13:43
natefinchalexisb: it's interesting that menn0 just happened to notice we weren't logging right before that big customer problem came up...13:44
alexisbinteresting... yes that is a good word ;)13:44
natefinchalexisb: lucky, really.  Otherwise we would have upgraded to 1.22 and rotation would have *still* been broken13:45
perrito666natefinch: its a clasic movie moment, when the character realizes he cannot deactivate the bomb right bifore the explosion13:45
perrito666camera focus on face, surpised face, big blast, black screen13:45
alexisbperrito666, lol13:46
natefinchrogpeppe2, jam, fwereade: any of you know why we're messing with logging here? https://github.com/juju/cmd/blob/master/logging.go#L9213:51
rogpeppe2natefinch: probably because commands are supposed to use the stderr from the context, not os.Stderr13:54
rogpeppe2natefinch: but that surely shouldn't affect logging in the environment?13:55
natefinchrogpeppe2: loggo's default writer is a global variable. this code replaces the default writer with one that writes to the whatever is in ctx.stderr13:55
rogpeppe2natefinch: why is that a problem?13:56
natefinchrogpeppe2: because we have code elsewhere that changes loggo to write to a lumberjack writer, which does the log rotation.  So this overwrites that and sets it back to stderr13:56
natefinchthus breaking log rotation13:56
rogpeppe2natefinch: i don't understand13:56
rogpeppe2natefinch: oh yes i do13:57
rogpeppe2natefinch: sorry, i thought this was in a cmd/juju file13:57
rogpeppe2natefinch:  but it's in cmd/juju...13:57
rogpeppe2natefinch: where's the lumberjack writer installed?13:58
natefinchrogpeppe2: https://github.com/juju/juju/blob/master/cmd/jujud/agent/machine.go#L224   (that function just calls loggo.ChangeDefaultWriter or whatever it is13:59
alexisbgsamfira ping13:59
rogpeppe2natefinch: that should probably be done in Start13:59
gsamfiraalexisb: pong13:59
alexisbfor bug https://bugs.launchpad.net/juju-core/+bug/145162613:59
mupBug #1451626: Erroneous Juju user data on Windows for Juju version 1.23 <1.23> <juju> <windows> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1451626>13:59
alexisbcan you please add the pull request under review in a comment14:00
alexisbjust so we can track them14:00
natefinchrogpeppe2: I was wondering if it might be a good idea to check in the cmd code if loggo is currently writing to stderr before replacing it14:00
rogpeppe2natefinch: alternatively it could be be done in logging.go14:01
natefinchrogpeppe2: the code says "write to ctx.Stderr instead of os.Stderr" which sounds fine.... unless we aren't actually writing to os.Stderr anymore.14:01
rogpeppe2natefinch: istm that logging.go and machine.go are in conflict with one another14:01
rogpeppe2natefinch: exactly14:01
gsamfiraalexisb: done14:01
rogpeppe2natefinch: ISTM that the Log struct is where logging-related stuff is centralised14:02
katconatefinch: standup14:02
rogpeppe2natefinch: i see two immediate possibilities:14:02
rogpeppe2natefinch: 1) put a NoStderrLogging bool inside the Log struct14:02
rogpeppe2natefinch: 2) put a lumberjack config inside the Log struct14:03
natefinchrogpeppe2: yeah, I think the main problem is that we 're trying to modify logging config without doing it through the cmd Log structure.14:10
rogpeppe2natefinch: yeah14:10
rogpeppe2natefinch: you can either modify the Log structure to make it possible to avoid that (but not introduce a lumberjack dependency there), or just make it know about lumberjack14:11
rogpeppe2natefinch: i *think* my inclination is towards the former14:11
natefinchrogpeppe2: yeah, I don't want to add a hard dependency on lumberjack... it should be something you can easily plug in if you want, but not something we demand you use.14:12
rogpeppe2natefinch: are you sure we're passing the --show-log flag to agents?14:13
natefinchrogpeppe2: not sure.  In standup, will check after.14:14
rogpeppe2natefinch: it doesn't appear so (not in 1.20.11 anyway...)14:14
rogpeppe2natefinch: oh yes, it is:14:15
rogpeppe2f.BoolVar(&l.Debug, "debug", false, "equivalent to --show-log --log-config=<root>=DEBUG")14:15
rogpeppe2natefinch: i don't think that --debug should imply --show-log14:16
rogpeppe2natefinch: hmm, actually i take that back14:16
rogpeppe2natefinch: i don't think that agents should be started with the --debug flag, but just --log-config=DEBUG14:17
mupBug #1452745 was opened: 386 constant 250059350016 overflows int <386> <blocker> <ci> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1452745>14:34
xwwtsinzui - are you on cross-team?14:36
* natefinch wonders if anyone else thinks it's funny that "250059350016 overflows int" is marked as a regression.... as if it didn't used to overflow ;)14:49
mgznatefinch: it is a regression, storage work landed some bad json examples in tests :)14:50
natefinchmgz: no no, I understand the fact that we're using that constant is a regression... but the way it's worded it sounds like we're saying that 250059350016 used to be a valid int32 :)14:51
perrito666natefinch: ints aren t what they used to be14:51
natefinchperrito666: gets it14:51
mgzin my day, I could count an int on one two hands?14:51
perrito666in my times, int32s where 64s, everything comes in smaller cans nowadays14:51
natefinchhaha, new listing in my town:  1 bedroom, 1 bathroom, 856 sq ft (79.5 sq m): $360,00014:55
Spadsseems legit14:55
natefinchit's even a tiny lot (for this town).  Weird.14:56
natefinchto be fair, it's probably the cheapest house in town14:56
katcowwitzel3: are you back on yet?14:58
mupBug #1452785 was opened: os-enable-refresh-update is false and some security packages are not available <juju-core:New> <https://launchpad.net/bugs/1452785>16:05
mupBug #1452808 was opened: no API addresses to connect to after juju upgrade <juju-core:New> <https://launchpad.net/bugs/1452808>16:35
perrito666natefinch: that is dollars?16:41
perrito666katco: is the bug you mentioned earlier still orphaned?16:42
katcoperrito666: no, cherylj is looking into it16:42
katcoperrito666: ty for responding16:42
cheryljperrito666: I could use some input, if you're familiar with upgrading :)16:50
cheryljThis bug is confusing since they're saying that things are hung and nothing else was written to all-machines.log.  Yet, if you look at the juju status that they included, all the agents are at 1.22.316:51
cheryljand the only thing that looks weird to me in the log is this error: ERROR juju.worker runner.go:219 exited "firewaller": machine 3 not provisioned16:52
cherylj(but there is a machine-3 in their status, which also has an agent-version of 1.22.3)16:53
perrito666cherylj: sorry I was eating one of my daily rations of white rice... (gotta love stomach bugs)17:09
cheryljyuck :(17:10
perrito666cherylj: the number is?17:10
perrito666of the bug I mean17:10
cheryljbug 145268017:10
mupBug #1452680: Failed to upgrade from 1.22.1 to 1.22.3 during deployment <cloud-installer> <landscape> <upgrade-juju> <juju-core:Incomplete> <juju-core 1.22:Triaged by cherylj> <juju-core 1.23:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1452680>17:10
perrito666cherylj: i am not at all familiar with autopilot, but if I had to guess, I would say compatibility was broken? the juju status output seems to indicate everything went fine17:16
wwitzel3katco: back now17:16
katcowwitzel3: hope you're feeling better17:16
perrito666all services started, all agents upgraded17:17
katcoericsnow: feel free to pair up with wwitzel3 on those user stories17:17
ericsnowkatco: k17:17
wwitzel3katco: k, will do17:17
perrito666katco: did you see the trello for emacs thing someone mentioned on telegram the other day?17:18
katcoperrito666: yeah, it's the primary reason i wish we were using trello17:18
wwitzel3katco: thanks, I'll be ok, just little queasy still17:18
katcoperrito666: because my *life* is in org-mode, and it would unify two big inboxes for me17:18
katcowwitzel3: food poisoning? :(17:18
perrito666wwitzel3: welcome to the white rice club17:19
wwitzel3katco: yeah :( .. but already feeling way better17:19
katcowwitzel3: good to hear. that sucks... i think you can report it to the cdc17:20
wwitzel3katco: yeah, hindsight .. probably don't get a shrimp omelette at a hole in the wall diner17:21
wwitzel3but it soo good17:21
perrito666wwitzel3: katco be fair, I say that, if the food is good, the place only needs to be reported if you get sick 2 out of 3 times17:23
wwitzel3perrito666: I've eaten at this place a lot and never got sick, it is the only place we go for breakfast17:24
wwitzel3perrito666: I did call them to let them know and they said they were going to stop serving that17:24
perrito666that is a bit extremist, they could just serve that not rotten17:25
wwitzel3perrito666: well, he said "we will pull that batch"17:26
perrito666ah, that is better17:26
natefinchperrito666: btw, yes, dollars.17:52
katconatefinch: how's the log rotation fix coming?17:56
natefinchkatco: mostly done... doing testing now.17:56
katconatefinch: sweet17:57
katconatefinch: let's plan on deferring our 1:1 until the bug is fixed17:58
natefinchkatco: makes sense17:58
perrito666natefinch: that is an interesting number for a 75m^2 loft17:58
natefinchkatco: the implementation is less fragile now, though I kinda hate that it involves some code needing to know about the implementation in otherwise very remote code  ... but at least it's not relying on the order of execution of two unrelated pieces of code.17:59
natefinchperrito666: it's a standalone house with 3358m^2 of land17:59
natefinch(.83 acres for the US people)17:59
natefinchthat's a small lot for my town18:00
perrito666natefinch: you might have omitted that point18:00
natefinchperrito666: 360k for that small a living space is pretty bad unless you're in the middle of the city.  ANd we are decidedly not in the middle of a city18:00
perrito6663358m2 of land makes for the small house18:01
natefinchperrito666: not here.... most plots are ~7000+18:02
natefinch(at least in this town)18:02
natefinchthere used to be a law that all plots had to be 8000+  (2 acres+)18:02
natefinchbut that got struck down as being illegal for discriminating against poor people or something along those lines18:03
* perrito666 watches reviewboard waiting for it to take his backport18:04
perrito666lol, the house I currently live in is in a 45, 50 m2 piece of land :p18:05
natefinchperrito666: my house is on 51,000m2 ;)18:06
natefinchto be fair, that's large for this town, but there are larger plots.18:07
perrito66610% of your land is about 4 times the plot I bought for my new house :p18:07
natefinchthe benefits of living in the middle of nowhere :)18:08
perrito666I cant imagine how much time it takes to mow the lawn there :p18:08
natefinchmost of it is woods on a hill.  So no really usable for much except keeping the neighbors away18:08
natefinchI only have about 4000m2 of lawn to mow18:08
natefinchwhich is not tiny, but a lot more manageable :)18:08
perrito666you clearly as not as lazy as I am, I have 10m2 of lawn and I pay someone to mow it (and to cover all the holes my dog does and remove the branches from my neigbour's palm tree)18:09
natefinchperrito666: I'm lazy, I'm just even more cheap than lazy18:10
natefinchperrito666: I'm lazy, I'm just even more cheap than lazy18:11
perrito666in my defense, I should pay this guy for years before actually covering the cost of the machine for the job18:11
natefinchperrito666: yeah, it's different here.  Labor is actually expensive.  To be fair, I could probably pay someone for a few years to cover the cost of my riding lawnmower, but... it *feels* like I'm saving money ;)18:11
perrito666before moving into a larger plot I should have children, so I can get them to do it eventually18:12
perrito666natefinch: labour is somehow expensive for local standards, but machinery is more expensive18:12
* perrito666 discovers that his terminal emulator actually handles lp: uris18:32
natefinchahh crap, I think I just pushed to 1.23 directly18:37
perrito666how do you do that?18:38
natefinchperrito666: I was deleting a branch to recreate it off of 1.23, and so deleted it, checked out 1.23, and then foolishly did a git push -f thinking that would push up the branch delete to my own github18:39
perrito666uh git push -f?18:40
natefinchperhaps crap was too tame a word18:40
natefinchhere's what git said after I did push -f:18:40
natefinchCounting objects: 86, done.18:40
natefinchDelta compression using up to 8 threads.18:40
natefinchCompressing objects: 100% (65/65), done.18:40
natefinchWriting objects: 100% (86/86), 16.86 KiB | 0 bytes/s, done.18:40
natefinchTotal 86 (delta 58), reused 40 (delta 17)18:40
perrito666natefinch: you might have deleted history there18:40
natefinchTo https://github.com/juju/juju18:40
natefinch + 62cc2e3...7a6a90a 1.23 -> 1.23 (forced update)18:40
natefinchperrito666: I know.18:41
perrito666natefinch: luckily for you, I pulled 1.23 less than an hour ago :)18:41
natefinchI'm kind of surprised that git checkout foo && git push -f  actually does *anything*18:41
natefinchI shouldn't have any changes to 1.23 on my local branch18:42
natefinchI don't even know how to tell what changed18:44
natefinchperrito666: if you recently pulled 1.23, can you then push -f your branch and just fix it?  I doubt anyone checked anything into 1.23 in the last hour18:59
perrito666natefinch: going to now19:08
natefinchperrito666: thanks, owe you like 1000 beers19:08
perrito666sorry the architect interrupted with the official plans for my house to be presented to the city inspection :D19:09
katconatefinch: lmk when/if you're ready for our 1:119:09
katcowwitzel3: i'm free now if you're up for our 1:1. fine if you're not.19:09
perrito666natefinch: you just lost one commit from wayne19:11
perrito666natefinch: I have no permission to do that :p19:14
natefinchperrito666: lol19:14
wwitzel3katco: yep, we can do that, one sec19:14
natefinchperrito666: I can give you the power19:14
perrito666natefinch: github.com/perrito666/juju/1.23 you will have to do it19:14
perrito666natefinch: I am perfectly fine not having the power19:14
perrito666the less  have the power the better19:14
natefinchperrito666: heh... I obviously shouldn't have the power either :)19:14
perrito666natefinch: just make sure your upstream remote for juju uses an anonymous checkout instead of a ssh one19:15
natefinchperrito666: it does... setting up ssh was too much of a hassle19:16
perrito666it doesn't if your upstream was anonymous you wouldn't be able to push like that without at least providing creds19:17
perrito666anyway, do you do the push or give me the power?19:17
natefinchperrito666: I don't actually know how to get your 1.23 branch pushed up to the juju 1.23 branch.  I mean, I could cherry-pick the commit, but I'm not sure if that's the right thing to do19:18
=== anthonyf is now known as Guest80518
natefinchkatco: yes, doing wwitzel3's 1:1 now is probably better.19:20
katconatefinch: kk19:20
perrito666natefinch: cd /tmp; git clone myrepo; cd myrepo; git co 1.23; git remote add upstream jujurepo; git push -f upstream 1.2319:20
perrito666natefinch: If I wherent that lazy I would have written a working line, but that one is not that far19:21
perrito666but lets face it, I am lazy19:21
natefinchperrito666: thanks, fixed19:24
katcowwitzel3: did i lose connection? you or me?19:26
perrito666natefinch: np19:26
* natefinch wipes a bead of sweat off his brow.19:26
* perrito666 thinks what is the item natefinch will have to transport for him in payment :p19:29
perrito666mm, IsValidMachine will say yes to a container, is that correct?19:38
perrito666I mean,is that supposed to be the behaviour?19:38
natefinchkatco, perrito666, wwitzel3, anyone else:  review me?  critical fix for 1.22  (to be merged into 1.23 and 1.24 and master) - http://reviews.vapour.ws/r/1619/diff/#19:52
natefincher rather, "to be merged later into..."19:53
perrito666natefinch: I am a little concerned that there is not _test touched in that patch19:57
natefinchperrito666: yeah.... testing whether we're rotating logs is... tricky.  I guess I could try to make a test that at least checks loggo is writing to a lumberjack.Logger with the correct configuration19:58
natefinchwe could then just rely on lumberjack's tests to ensure it rotates correctly with the given configuration, which I think is safe19:58
perrito666natefinch: I would for for a   test no one is changing my writer test19:59
perrito666I am not sure if there is a sane infrastructure to test that though19:59
wwitzel3natefinch: I think that is a good idea (test that it is writing to the LJ logger)19:59
natefinchironically, most tests intentionally disable writing to lumberjack so we can read from stderr20:01
=== anthonyf is now known as Guest51489
perrito666ericsnow: are you working in https://bugs.launchpad.net/juju-core/+bug/1452511 ?20:07
mupBug #1452511: jujud does not restart after upgrade-juju on systemd hosts <regression> <systemd> <vivid> <juju-core:In Progress by ericsnowcurrently> <juju-core 1.23:In Progress by ericsnowcurrently> <juju-core 1.24:In Progress by ericsnowcurrently> <https://launchpad.net/bugs/1452511>20:07
ericsnowperrito666: yep20:11
* perrito666 scratches from his list20:11
natefinchgah, I have no friggin' clue how to make the tests that test this.  The tests for the Machine agent are like 20 layers of abstraction and mocking, and one of the lowest layers changes the default logger :/20:47
mupBug #1452891 was opened: juju determines the unit IP addresss based on the last interface attached in openstack <juju-core:New> <https://launchpad.net/bugs/1452891>20:47
katcoericsnow: did i freeze again?20:50
rick_h_natefinch: no way to toss it at a functional layer in CI? hammer the logs and verify they rotate during a deployment test?20:52
natefinchrick_h_: yeah, it just would be nice if we had a unit test that would catch it at development time, rather than asynchronously breaking trunk due to a CI test a day later20:53
rick_h_natefinch: +1 just sympathizing with this type of thing that really is a function of things 'working'20:54
natefinchrick_h_: it would be a lot easier to test that we haven't screwed it up if it wasn't a global variable that any code anywhere could screw up21:00
bdxWould someone be willing to provide an example of setting data-port and bridge-mappings for quantum-gateway and for neutron-openvswitch21:37
alexisbbdx, all of our juju networking folks are based in europe22:11
alexisbso an email would be good22:12
bdxalexisb: Thanks, will do!@22:31
perrito666wallyworld: axw anastasiamac suddenly I cannot reach anything google related23:35
wallyworldperrito666: no worries, anastasiamac  was talking about you23:39
anastasiamacperrito666: all good tho :D23:39
anastasiamacwallyworld: 1:1 or tanzanite?23:40
perrito666oh I hope it was nice things23:48
perrito666aghh my client cannot even get the backlog for irc, this is ludicrous23:48
* perrito666 suddenly realizes that half of the negborhood has a power outage and it might be related23:48

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!