blrthe MenuAPI is making my head hurt.08:39
blrwgrant: have you ever considered moving the permission checks on views to decorators?08:41
blrmight be nice08:41
wgrantblr: MenuAPI is indeed a little weird, and parts of it are not used in the current UI design.08:56
wgrantThe way views are defined in ZCML is inherited from Zope 3/ZTK. Grok has an alternate syntax that uses the same infrastructure, but doesn't use class decorators: http://grok.zope.org/documentation/tutorial/permissions/tutorial-all-pages08:56
blrhuh, this is the first I've heard about Grok.08:58
wgrantIt was really Zope 3's dying breath.08:58
wgrantWe use parts of its underlying libraries (martian) in lazr.restful to generate the API from decorators.08:58
wgrantBut it does away with ZCML almost entirely.08:59
wgrantrepoze.bfg (the original name for pyramid) used to use martian, but I think it's moved to internal stuff.09:00
blrhuh, interesting.09:00
cjwatsonwgrant: What do you mean by your comment on https://code.launchpad.net/~cjwatson/launchpad/git-target-inline-default-repo/+merge/258033 ?  Just break up the elif into two parts so that future changes can handle the imported case, or do I need to introduce a repository_type enum?11:33
wgrantcjwatson: My comment is missing an "eventually", I think.11:34
wgrantI'd just XXX it for now.11:34
wgrantAny default git repo now causes the project to state it's using LP officially for code, even when that's a lie.11:35
cjwatsonOK.  We probably do want to do a repository type thing quite soon, because it'll be needed for recipes.11:35
cjwatsonAnd better to do it when it's easy to widen the table.11:35
wgrantWhy's it needed for recipes?11:36
cjwatsonWell, not strictly needed, but in practice a lot of them are going to want to be imports from elsewhere.11:37
wgrantAh, sure, we'll want mirrors for recipes.11:38
wgrantBut that's a bit more than a simple repository_type :)11:38
cjwatsonWell, sure, but it's the start.11:38
cjwatsonAlso probably not that much more :-)11:38
cjwatsonAt least for git->git11:38
wgrantIndeed, it's not hugely difficult.11:39
cjwatsonDid we agree to just deal with log extraction by opening up rsync from carob, BTW?  I think we did and can deal with that but wanted to check.11:46
wgrantI think so, since ELK isn't ready yet.11:46
wgrantI wonder if there's an existing rsyncd subordinate.11:46
cjwatsonbasenode does it11:46
wgrantOh, handy.11:47
cjwatsonAnd we only need this in prod (and qas for symmetry) anyway11:47
cjwatsonwgrant,blr: I self-reviewed https://code.launchpad.net/~cjwatson/launchpad/testfix-git-target-inline-default-repo/+merge/258528 to fix buildbot, but it could do with a post-hoc review.16:55
=== anthonyf is now known as Guest80518
=== anthonyf is now known as Guest51489

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!