[08:39] the MenuAPI is making my head hurt. [08:41] wgrant: have you ever considered moving the permission checks on views to decorators? [08:41] might be nice [08:56] blr: MenuAPI is indeed a little weird, and parts of it are not used in the current UI design. [08:56] The way views are defined in ZCML is inherited from Zope 3/ZTK. Grok has an alternate syntax that uses the same infrastructure, but doesn't use class decorators: http://grok.zope.org/documentation/tutorial/permissions/tutorial-all-pages [08:58] huh, this is the first I've heard about Grok. [08:58] It was really Zope 3's dying breath. [08:58] We use parts of its underlying libraries (martian) in lazr.restful to generate the API from decorators. [08:59] But it does away with ZCML almost entirely. [09:00] repoze.bfg (the original name for pyramid) used to use martian, but I think it's moved to internal stuff. [09:00] huh, interesting. [11:33] wgrant: What do you mean by your comment on https://code.launchpad.net/~cjwatson/launchpad/git-target-inline-default-repo/+merge/258033 ? Just break up the elif into two parts so that future changes can handle the imported case, or do I need to introduce a repository_type enum? [11:34] cjwatson: My comment is missing an "eventually", I think. [11:34] I'd just XXX it for now. [11:35] Any default git repo now causes the project to state it's using LP officially for code, even when that's a lie. [11:35] OK. We probably do want to do a repository type thing quite soon, because it'll be needed for recipes. [11:35] And better to do it when it's easy to widen the table. [11:36] Why's it needed for recipes? [11:37] Well, not strictly needed, but in practice a lot of them are going to want to be imports from elsewhere. [11:38] Ah, sure, we'll want mirrors for recipes. [11:38] But that's a bit more than a simple repository_type :) [11:38] Well, sure, but it's the start. [11:38] Also probably not that much more :-) [11:38] At least for git->git [11:39] Indeed, it's not hugely difficult. [11:46] Did we agree to just deal with log extraction by opening up rsync from carob, BTW? I think we did and can deal with that but wanted to check. [11:46] I think so, since ELK isn't ready yet. [11:46] I wonder if there's an existing rsyncd subordinate. [11:46] basenode does it [11:47] Oh, handy. [11:47] And we only need this in prod (and qas for symmetry) anyway [16:55] wgrant,blr: I self-reviewed https://code.launchpad.net/~cjwatson/launchpad/testfix-git-target-inline-default-repo/+merge/258528 to fix buildbot, but it could do with a post-hoc review. === anthonyf is now known as Guest80518 === anthonyf is now known as Guest51489