=== erkules_ is now known as erkules [08:19] morning [08:48] mo'in [08:52] Good morning all; happy Roast Leg Of Lamb Day! 😃 [08:55] why would you call something “xubuntu core”? [09:00] gosh i'm grumpy today [09:00] i think i'll have second breakfast [09:00] not sure whether it'll help, but i'll have had second breakfast [09:00] hehe, enjoy! [09:00] * mvo_ will have more tea that always works for me [09:17] Chipaca: hey, would you mind casting an eye over https://code.launchpad.net/~stephen-stewart/webdm/nobody-puts-baby-in-the-corner/+merge/258466 [09:18] Chipaca: as you will see, i fail at bzr, it should be based on your branch but… i fail at bzring [09:23] beowulf: no worries, it will be git soon once we solve the tarmac problem [09:23] :) [09:28] Chipaca: oops, forgot to remove xvfb, change pushed [09:44] * Chipaca looks [09:45] hmmm [09:46] ah, it ignores node_moudles anywhere, not just in www, ok :) [09:51] mvo_: https://code.launchpad.net/~mvo/snappy/meta-cleanup/+merge/258467 ...? [09:51] mvo_: forgot anything? [09:53] Chipaca: ups, sorry, indeed [09:54] beowulf: getting several of these, are they expected? [09:54] npm WARN unmet dependency undefined, [09:54] npm WARN unmet dependency which is version undefined [09:54] npm WARN unmet dependency /home/john/canonical/webdm/src/launchpad.net/webdm/node_modules/gulp-imagemin/node_modules/imagemin/node_modules/imagemin-pngquant/node_modules/pngquant-bin/node_modules/bin-build/node_modules/decompress/node_modules/decompress-unzip/node_modules/strip-dirs/node_modules/sum-up requires chalk@'^1.0.0' but will load [09:55] beowulf: that's a lot of node_modules [09:55] lool, isnt your ramdisk_size= cmdline option a bit small ? that defines the size of the unpacked ramdisk IIRC ... [09:56] Chipaca: I think there is a umask issue in CopyFile, i.e. snappy build with a 777 dir will not create a 777 dir in the snap, I look at this after lunch, just fyi that I stumbled over this [09:56] ogra_: that might be [09:56] Chipaca: you can ignore the warnings [09:56] Chipaca: had fun this morning with preparing for the OS snap stuff :) [09:56] mvo_: :) [09:57] mvo_: CopyFile doesn't create dirs tho [09:57] ogra_: I also didn't really know how to chose it's location [09:57] I tried closer to the end of the RAM, but that failed for some reason [09:57] and before linux or just after it and that gets clobbered [09:58] well, it finds it obviously [09:58] oh [09:58] I can try with a larger size [09:58] well ... [09:58] morning [09:58] it seems to override your setting actually [09:58] Kernel command line: "earlyprintk=ttyMFD2 root=/dev/disk/by-label/system-a console=ttyMFD2 init=/lib/systemd/systemd ro ramdisk_size=50000" [09:58] vs [09:59] [ 0.000000] Kernel command line: earlyprintk=ttyMFD2 root=/dev/disk/by-label/ [09:59] system-a console=ttyMFD2 init=/lib/systemd/systemd ro ramdisk_size=19333091 [09:59] thats weird [09:59] ogra_: actually this is me failing to update the first copy-paste [09:59] ah, k [10:00] but 19333091 is still wront (compressed instead of uncompressed) [10:00] it is kB ... [10:00] so that's more than enough then [10:00] right [10:00] red herring [10:00] that's too much in fact [10:01] it is a bit much, but i would expect the kernel to catch that ... should still unpack [10:02] sergiusens: mo'i [10:02] sergiusens: n [10:07] Chipaca: er, yeah, tarmac has no npm/node [10:09] beowulf: one second [10:14] beowulf: try again [10:14] Chipaca: did you get to see my MPs [10:14] ? [10:15] sergiusens: no [10:16] Chipaca: heh, indeed [10:16] @reviewlist [10:16] https://code.launchpad.net/~chipaca/ubuntu-core-launcher/unshare/+merge/258367 | No reviews (less than a day old) [10:16] https://code.launchpad.net/~sergiusens/webdm/filterInstalled/+merge/258440 | No reviews (less than a day old) [10:16] https://code.launchpad.net/~sergiusens/webdm/originNamespacesInconsistencies/+merge/258438 | No reviews (less than a day old) [10:16] https://code.launchpad.net/~stephen-stewart/webdm/install-as-behaviour/+merge/258424 | No reviews (less than a day old) [10:16] https://code.launchpad.net/~chipaca/webdm/filter-by-type/+merge/258408 | Needs Fixing: 1 (less than a day old) [10:18] sergiusens: helping rvba right now, will look at them in a few [10:22] sergiusens: top-approve https://code.launchpad.net/~sergiusens/snappy/storeSnapType/+merge/258437 ? [10:23] Chipaca: I would, but it's my own MP :-) [10:42] @reviewlist [10:42] https://code.launchpad.net/~chipaca/ubuntu-core-launcher/unshare/+merge/258367 | No reviews (less than a day old) [10:42] https://code.launchpad.net/~stephen-stewart/webdm/nobody-puts-baby-in-the-corner/+merge/258466 | Approve: 1 (less than a day old) [10:42] https://code.launchpad.net/~sergiusens/webdm/originNamespacesInconsistencies/+merge/258438 | Approve: 1 (less than a day old) [10:42] https://code.launchpad.net/~stephen-stewart/webdm/install-as-behaviour/+merge/258424 | No reviews (less than a day old) [10:42] https://code.launchpad.net/~chipaca/webdm/filter-by-type/+merge/258408 | Needs Fixing: 1 (less than a day old) [10:46] * beowulf checks out lp:~chipaca/webdm/filter-by-type [10:46] beowulf: that's missing a thing [10:46] * Chipaca waits for sergiusens' branches to land so he can merge, and will then add the thing [10:46] Chipaca: what thing? the curl in the comments isn't correct, i believe [10:47] beowulf: dunno, but the comment of what is missing is correct; there's one path i'm not filtering on [10:47] Chipaca: ack [10:47] Chipaca: would you look again at https://code.launchpad.net/~stephen-stewart/webdm/nobody-puts-baby-in-the-corner/+merge/258466 [10:47] i missed the paths in gulpfile.js [10:48] and then i need to use all the nice new filters and data [11:06] beowulf: that also might not work. but let's give it a go. [11:09] exciting [11:24] beowulf: when you said the GET in https://code.launchpad.net/~chipaca/webdm/filter-by-type/+merge/258408 wasn't right, do you have a 'right' one? [11:40] Chipaca: it would be something like /api/v2/packages?types[]=app&types[]=core [11:40] /api/v2/packages/?types[]=app&types[]=core [11:41] Chipaca: as a query rather than in the body [11:44] beowulf: h,, that's not what the docs say tho [11:44] Chipaca: which docs? [11:44] mvo_: sergiusens: can seccomp be disabled? [11:45] beowulf: sergiusens has a gist somewhere, give me a sec [11:45] beowulf: https://gist.github.com/sergiusens/15949095c52a83a46c6b [11:45] Chipaca: right, so i don't think sergiusens meant for it to be in the body, it should be a query [11:46] Chipaca: see https://code.launchpad.net/~sergiusens/webdm/filterInstalled [11:47] Chipaca: see also https://groups.yahoo.com/neo/groups/rest-discuss/conversations/messages/9962 [11:47] beowulf: ah, fair enough. I'm planning on waiting for that to land and then merging with it, so i'll do the right thing anyway [11:48] beowulf: if that is “sending a body with a GET is a horribly idea that should die in hell”, i don't need to read it [11:48] * Chipaca looks [11:48] Chipaca: then you don't need to read it [11:48] :) [11:49] body on GETs are the “oh and here are some pictures of my kids, aren't they cute” of REST [11:50] the only people that care are the owners [11:52] Chipaca: yes, just put @unrestritcted in the custom seccomp file [11:52] sergiusens, Chipaca: btw, can I/should I help with webdm too? [11:57] mvo_: looking at this package's yaml, it's http://pastebin.ubuntu.com/11008516/ [11:57] mvo_: AIUI the 'integration' thing is the older way, and a better way would be to have the apparmor under the service, is that right? [11:57] Chipaca: is there a bzr branch that I could use to tweak it? [11:57] mvo_: and the seccomp goes next to it when under the service, but is not supported under integration [11:59] Chipaca: yeah, we should not integration for apparmor anymore though, should be fine to put that under service [11:59] * Chipaca nods [11:59] Chipaca: what does the apparmor look like? json or a hand-craftet profile? [12:00] Chipaca: would you mind bouncing https://code.launchpad.net/~stephen-stewart/webdm/install-as-behaviour/+merge/258424 [12:00] mvo_: json [12:00] beowulf: bounce [12:00] Chipaca: ok, security-override:\n apparmor: ...\nseccomp should do it [12:01] mvo_: and the seccomp file would just be “@unrestricted”? [12:02] Chipaca: yes, let me quickly double check, its not documented in meta/security.md (yet) - needs fixing :P [12:02] Chipaca: yes, @unrestricted shoudld work [12:16] sergiusens: was there anything pending in the install.yaml MP btw? I guess we just need to decide if its 15.04 material but I guess it is(?) [12:26] * beowulf goes for lunch, then to pick a horse [12:30] mvo_: so, the seccomp file should be yaml. do you have an example of how to put that @unrestricted in there? [12:31] Chipaca: uhhh, I hope jdstrand has a answer if he is up, if not I check the source now [12:32] mvo_: maybe that's the template? [12:33] Chipaca: yeah, I think so [12:33] Chipaca: "template: unrestricted" [12:33] Chipaca: does that work? [12:34] i'll try :) [12:34] it's slow tho [14:06] Chipaca: I fixed the MP but not the docs last night [14:48] sergiusens: which em pee? [14:51] sergiusens: assuming you mean the one about the id [14:52] hmm, why isn't https://code.launchpad.net/~mvo/snappy/snappy-tar-unpack-mknod/+merge/258407 landing? [14:54] Chipaca: dep? [14:54] Chipaca: the MP I fixed is the types, installed_only one [14:54] Chipaca: I think deps, I fixed the dep I think [14:54] mvo__: dep is merged [14:55] mvo__: unless that's happened *just* now :) [14:55] ha! you are right (of course) [14:55] * mvo__ throws his hands up helplessly [14:56] * Chipaca makes a note to not be right, because it makes mvo quit [14:56] Chipaca:lol [14:57] Chipaca: looks like its time to inspect what tarmac is doing [14:58] what's the current status of webdm? [15:00] beowulf: http://i.imgur.com/F6mBAWi.gif [15:01] good good [15:06] mvo: you had access to tarmac, so feel free to login and mess around [15:06] unless you want me to [15:52] beowulf: maybe for this https://code.launchpad.net/~stephen-stewart/webdm/handle-missing-response-in-parse/+merge/258518 [15:52] beowulf: can you tell me what it's expecting in order to fix? [16:00] sergiusens: i'm getting errors on install or uninstall, 400s, the response is always of the form {"package":"8nzc1x4iim2xj1g2ul64","message":"Operation in progress"} [16:01] beowulf: are you sending a PUT twice? [16:01] beowulf: maybe you need my branch which is taking too long to land [16:02] beowulf: your fix is fine for the just to be safe case [16:02] sergiusens: no, don't think so... yes i think i need your branch [16:21] -uos-core or -uos-showandtell or some other for questions? They are reading off questions that I do not see in uos-core for instance [16:22] genii: -uos-core [16:22] I see all questions there [16:22] Hm [16:22] OK, thanks [16:24] beowulf: hey, I see you moved the npm/gulp stuff, does the readme need updating though? [16:35] beowulf: I tripple checked and the only way to get that answer you got is if you do a PUT and a DELETE while the PUT is taking place [16:36] sergiusens: can haz re-review of https://code.launchpad.net/~chipaca/webdm/filter-by-type/+merge/258408 ? now that your thing landed an' all :) [16:37] Chipaca: /me tries [16:38] Chipaca: heh, the diff only goes all the way to r120 but there's r122... oh well :-) [16:38] hm? [16:38] sergiusens: i'm seein 122 here [16:39] Chipaca: refresh again ftw :-) [16:39] :) [16:54] sergiusens: i think i did update the readme [16:54] sergiusens: i'm going to rebuild latest and try again [16:54] beowulf: good [16:54] beowulf: if you wait a bit you will get filtering by types btw [16:55] sergiusens: then i will break for dinner and try later [16:55] beowulf: maybe don't ask for the oem ones [16:55] beowulf: so in the installed list, list it, in the store listing keep it out [16:56] sergiusens: i can also hide install buttons for any types you want to show but not allow install [16:56] and i notice that uninstall removes the item in the store listing, i need to fix that [16:57] asac: It's a gcc switch will will embed into the binary all the compiler options that were used when it was built [16:57] beowulf: make that the oem packages then ;) [16:58] genii: ic. don think we recommend anything like that. the app author is in charge and can make such decisions as it suites him best [16:58] dont [16:58] asac: So it then becomes possible for instance to compare those between two binaries [16:58] genii: who would that help? [16:58] OK, thanks [16:58] if its a thing that app author likes then he can use it... for sure :) [16:59] asac: It would help if a particular option for instance is problemmatic [16:59] but as i said in the q+a we try to be as rigorous in empowering the app author to be in charge to make the decisions for his apps that he needs to do [17:00] genii: yeah. could be that at some point we will have like tools available that make live of developers easier [17:00] if they have such option [17:00] but so far nothing like that is planned. we are just getting started to really think how to support app authors more :) [18:42] sergiusens: a quick one: https://code.launchpad.net/~chipaca/snappy/snappy-tar-pack-mknod/+merge/258536 [18:46] Chipaca: ok [18:53] Chipaca: here's one for you https://code.launchpad.net/~sergiusens/webdm/avahi/+merge/258539 [18:55] sergiusens: this is a long-lived thing, yes? [18:55] as per the "loop forever" [18:55] sergiusens: in which case, better make a timer and reuse it in the loop, instead of creating one over and over [18:55] Chipaca: yes, loopForever is a better func name I guess [18:56] Chipaca: it's my layman approach to change the hostname if changed somewhere [18:58] sergiusens: that's fine [18:58] sergiusens: what i'm saying is [18:59] don't do time.After(blah) [18:59] in a loop [18:59] rather, create a timer outside the for [18:59] and set it in the loop [18:59] a silly change [18:59] Chipaca: ok [19:05] Chipaca: added one comment, not sure how to phrase it better though [19:08] where does uEnv.txt come from? i'm trying to create a beaglebone black image and it's failing to boot because that file is missing [19:09] bjf: the oem snap [19:10] during provisioning [19:10] sergiusens, i'm using: sudo ubuntu-device-flash core 15.04 -o bbb.img --size 4 --channel edge --oem beagleblack --enable-ssh --device-part=device.tar.xz [19:11] bjf: strange, it should be in your system-boot partition then [19:11] bjf: can you check? [19:12] sergiusens, system-a/boot/uboot ? [19:13] bjf: oh, you have a running system? [19:14] system-boot is the label you need to look for [19:14] sergiusens, no i'm looking at the sd card [19:14] bjf: partition 1, called snappy-boot or something boot [19:15] sergiusens, indeed, that is there but when my bbb boots i get "** Unable to read file uEnv.txt **" [19:15] bjf: is the file corrupted? [19:16] Chipaca: updated MP for avahi [19:17] sergiusens, no, it looks correct [19:17] sergiusens: um [19:17] sergiusens: that won't work [19:17] i don't think [19:18] sergiusens: yeah, that's not what you want [19:19] Chipaca: it does work fwiw [19:20] sergiusens: https://play.golang.org/p/gUA2uOEehv [19:21] Chipaca: interesing, so what did I want? [19:21] Chipaca: as in, what were you asking for? It felt strange, but I just went with it; is it for _ := range time.After... { or something like that? [19:22] sergiusens: https://play.golang.org/p/b62amWnQu8 [19:22] Chipaca: oh, more words is what you want :-P [19:23] sergiusens: or, do the reset before the <-t.C if you want the wait to be at least the timeout [19:23] otherwise the wait will be the timeout - however much the func took [19:24] Chipaca: the playground doesn't like your code though :-P [19:24] heh [19:24] try it locally [19:25] Chipaca: I am, I was joking [19:25] as in there are trolls on the playground :-P [19:28] Chipaca: there [19:28] hmm [19:28] now [19:29] beowulf: are we waiting for any tasty MPs today still? [19:31] sergiusens: i added install/uninstall to the store listing in haste, and it's slightly broken in that it removes the item from the list currently, so i'm trying to fix that now [19:31] sergiusens: other than that i have a couple of mps to tidy little things but they're more likely tomorrow now [19:31] beowulf: darn; I didn't notice that [19:32] it's annoying [19:32] it is, just saw [19:38] sergiusens: pushed https://code.launchpad.net/~chipaca/snappy/snappy-tar-pack-mknod/+merge/258536 [19:38] sergiusens: let me know if context switching is driving you (more) bonkers [19:44] sergiusens: https://code.launchpad.net/~stephen-stewart/webdm/destroy-without-removal/+merge/258547 [19:48] Chipaca: heh, it does at times, but I feel more relaxed now than earlier today [19:58] sergiusens, i just built a new image on Trusty and it boots just fine. images build using vivid fail. i've done an intial comparison of the two images and don't see any difference [20:00] Chipaca: ping my avahi :-) [20:01] bjf: I'm not sure how that is, lots of people use vivid here and the code is pretty much generic [20:01] bjf: maybe a dd fail? [20:01] sergiusens, this _is_ a different system Trusty is desktop and Vivid is macbook air [20:02] sergiusens: trade you my https://code.launchpad.net/~chipaca/snappy/snappy-tar-pack-mknod/+merge/258536 [20:02] beowulf: it still dissappears here with your branch [20:02] Chipaca: ok [20:02] Chipaca: there's also the backporting one to calm down asac ;-) [20:04] sergiusens: sure? [20:04] * beowulf needs to write tests [20:04] beowulf: mostly [20:04] * beowulf laments that isn't likely tonight [20:04] beowulf: does it work for you? [20:04] sergiusens: switching back to checjk :) [20:05] sergiusens: works for me [20:06] i kinda love installing and uninstalling :) [20:06] beowulf: hmmm, let me do something here [20:06] beowulf: for some reason it needed a browser refresh, it's fine [20:07] also, errors trigger an error view but if you were to get >1 error the first would be clobbered, so that's something to fix later [20:07] possible on the store view, as it allows multiple install/uninstalls [20:07] beowulf: you shouldn't be able to get more errors in theory [20:07] beowulf: right, I need to lock that down deep inside [20:07] sergiusens: well, you could install 3 things and they could all error [20:08] it would be correct for them to report an error each [20:08] no? [20:08] beowulf: right, but we should only support installing in sequence, so I need to queue your requests [20:08] sergiusens: i see [20:08] sergiusens: that makes it less likely [20:08] beowulf: we had this talk returning from downtown Austin with Chipaca if you can recall :-) [20:08] oh yeah [20:08] good times [20:09] beowulf: I don't recall it being an easy sprint though once Monday hit the door :-P [20:10] sergiusens: https://code.launchpad.net/~stephen-stewart/webdm/fix-snap-routing/+merge/258554 [20:10] https://code.launchpad.net/~stephen-stewart/webdm/hide-installer-for-oem [20:10] beowulf: yeah look at those now [20:11] beowulf: you can type @reviewlist now at any given moment and save yourself from copy paste ;-) [20:11] @reviewlist [20:11] https://code.launchpad.net/~chipaca/ubuntu-core-launcher/unshare/+merge/258367 | No reviews (less than a day old) [20:11] https://code.launchpad.net/~stephen-stewart/webdm/fix-snap-routing/+merge/258554 | No reviews (less than a day old) [20:11] https://code.launchpad.net/~stephen-stewart/webdm/hide-installer-for-oem/+merge/258553 | No reviews (less than a day old) [20:11] https://code.launchpad.net/~sergiusens/snappy/backportReviewNOT/+merge/258549 | No reviews (less than a day old) [20:11] https://code.launchpad.net/~chipaca/snappy/snappy-tar-pack-mknod/+merge/258536 | Approve: 1 (less than a day old) [20:11] like i'd give Chipaca the limelight [20:12] * sergiusens needs coffee [20:12] * genii delivers one to sergiusens [20:13] man, we need nothal to do that [20:13] * Chipaca makes a note to add a plugin [20:13] Heh :) [20:20] thanks [20:20] meh, tarmac slow again [20:27] beowulf: what does fix routing do? does it fix the pressing back thing being broken? [20:29] sergiusens: hard reload of snap page was broken [20:29] beowulf: right, that too [20:30] sergiusens: back button broken? [20:30] beowulf: maybe we need to change that 'name' to something else to not confuse it with name [20:30] sergiusens: yeah [20:31] sergiusens: so name there is /snap/$name [20:31] id would be better [20:31] * beowulf changes [20:32] beowulf: that should be the new 'id' [20:35] sergiusens: pushed [20:38] great [20:38] sergiusens: should i top-approve after ading the cosmic space? [20:38] spaaaace [20:39] Chipaca: yeah [20:39] of course [20:40] made sense to me, but not sure if you or mvo had a similar mp sitting there for ages because you wouldn't top-approve your own thing [20:43] beowulf: last cool one would be for installed_only to work on the main page [20:44] sergiusens: one sec [20:47] sergiusens: https://code.launchpad.net/~stephen-stewart/webdm/installed-only/+merge/258559 [20:48] beowulf: looks legit, darn trailing '/' ... [20:48] beowulf: set for review maybe? [20:49] sergiusens: done [20:50] hmm, webdm has a different sized icon... [20:50] beowulf: heh, do you feel like finding a better icon? [20:51] beowulf: can we make the webdm uninstallable too? meybe it needs some thought; but accidentally uninstalling may be a problem [20:52] sergiusens: sure [20:55] sergiusens: ubuntu-core too? [21:00] beowulf: it is uninstallable in itself at the core of everything so it's fine to leave it [21:01] sergiusens: well, i think it's a bit confusing to have the button there so i added it to the list [21:01] you can reject the mp :) [21:01] beowulf: whatever makes it easier on the user [21:01] beowulf: you should ask clurr, not me :-P [21:02] * beowulf invokes clurr [21:02] https://code.launchpad.net/~stephen-stewart/webdm/webdm-uninstallable/+merge/258560 [21:04] \o/ [21:06] sergiusens: i guess you're aiming to publish webdm tonight? [21:07] sergiusens: will you be publising again before iot? [21:08] beowulf: I aim for tonight [21:08] maybe tomorrow [21:08] a new version [21:08] beowulf: I'm off next week [21:26] beowulf: any dandy icon for webdm we want to use? [21:27] sergiusens: umm [21:27] beowulf: you complained :-) [21:27] give me 1 min [21:28] beowulf: do you know of a way to fix all our broken SVGs? as in just get proper svgs for the broken things we have? [21:30] sergiusens: if you give me the svgs i can convert them [21:32] beowulf: one sec [21:32] beowulf: http://bazaar.launchpad.net/~snappy-dev/snappy-hub/snappy-examples/files [21:33] beowulf: you can get an MP as well :-) [21:33] sergiusens: i don't see any ubuntu logos i can repurpose for webdm, and i don't really want to spend time inventing something that won't be acceptable, so what we have will do :) [21:33] beowulf: also, ignore the element14 one [21:33] beowulf: the high five one? [21:34] https://design.ubuntu.com/wp-content/uploads/pictogram-developer-orange-hex.svg [21:34] maybe that one? [21:34] for webdm [21:35] beowulf: sure, looks good, will that render fine without conversion? [21:36] heh [21:36] because i don't yet understand that problem, i can't answer [21:36] let me give you a png of that [21:37] beowulf: with store dimmension requirements? [21:39] yes [21:41] beowulf: https://code.launchpad.net/~stephen-stewart/webdm/webdm-uninstallable/+merge/258560 [21:41] sergiusens: https://drive.google.com/open?id=0B_entiKC77dtUWlzZFdkLWFRRVU&authuser=1 [21:41] beowulf: merge conflicts on that one [21:42] criss cross merge [21:43] sergiusens: should i just change these to png, in snappy examples? [21:44] beowulf: yeah, just make sure package yaml points to the right file name [22:01] Chipaca: not sure adding npm/node test stuff was such a good idea without doing some load analysis [22:05] serTABTABTAB [22:05] https://code.launchpad.net/~stephen-stewart/+junk/snappy-examples [22:07] beowulf: why not an mp? [22:07] Chipaca: i am not one of you [22:07] beowulf: fair enough [22:07] beowulf: you'd be good at it hto [22:07] tho* [22:08] Chipaca: i'd only make you all learn css [22:08] i'd put you in charge of idiot population control [22:08] * Chipaca 's government might stretch the definition of "democracy" [22:08] hehe [22:22] sergiusens: when tarmac says “There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.”, it's talking about top approval. Even when the times are off. [22:23] Chipaca: I just turned off and upgraded the do droplet for 10 more dollars :-) [22:23] Chipaca: let's try again [22:24] we're using a droplet? [22:25] Chipaca: yes [22:25] Chipaca: https://code.launchpad.net/~sergiusens/webdm/newIcon/+merge/258571 [22:25] sergiusens: serTABTABTAB [22:25] https://code.launchpad.net/~stephen-stewart/+junk/snappy-examples [22:25] uhh [22:25] lol [22:26] beowulf: hey! [22:26] beowulf: how about an MP and not junk but push to lp:~ss/snappy-hub/newIcons? [22:31] sergiusens: https://code.launchpad.net/~stephen-stewart/snappy-hub/newIcons [22:34] beowulf: thanks [22:34] sergiusens: while all of the icons were svgs, they were svgs with the payload being a png, so kinda pointless [22:35] beowulf: huh? [22:35] beowulf: oh, only when fetching from the store [22:35] beowulf: once installed we use the icon that's there [22:35] beowulf: the store does a server side conversion which I disagree with [22:36] sergiusens: i mean the old svgs, they were svgs wrapping pngs, you can see in the diff [22:36] i don't think the store converts pngs to svgs [22:36] beowulf: no, the other way around svg->png [22:37] well, that's actually a good thing [22:38] beowulf: not really as the information gets split in to locations to search for [22:38]