=== tmpRAOF is now known as RAOF
tsdgeoslanding \o/07:13
dholbachcan sombody please take a look at https://code.launchpad.net/~ubuntu-mate-dev/compiz/mate-consistent-keybindings/+merge/258251?07:50
dholbachit's in the sponsoring queue, so I thought I'd prod you guys about it :)07:51
tsdgeosmzanetti: so should we start another landing?08:07
tsdgeospstolowski: it seems that at the end my landing took predence over the concierge one?08:22
pstolowskitsdgeos, hmm, indeed08:26
pstolowskitsdgeos, i'll rebuild08:26
=== davidcalle_ is now known as davidcalle
dholbachhey bregma, do you know somebody who could take a look at https://code.launchpad.net/~ubuntu-mate-dev/compiz/mate-consistent-keybindings/+merge/258251?09:42
tsdgeosdandrader: something is borked at https://code.launchpad.net/~dandrader/unity8/app-state-handling/+merge/25865309:42
tsdgeosthere's a few ================09:42
dandradertsdgeos, ok, will check it more closely. maybe I didn't catch all conflicts09:43
dandradertsdgeos, I think it's a bug in launchpad's web diff view09:45
dandradertsdgeos, ah, it must be because its prerequisite has conflicts with trunk09:46
tsdgeosah, can be09:46
tsdgeosi also marked those09:47
bregmadholbach, I'll be working my way through all the outstanding Compiz MPs over the next couple of days:  I just got back from a couple weeks of vacation and things piled up10:11
dholbachthanks a lot bregma10:11
mzanettitsdgeos, hey, can you please install the nichtlustig scope and tell me if that's a bug in unity8 or in the scope?10:16
tsdgeosmzanetti: E_NO_CONTEXT10:17
mzanettierm... huh?10:17
mzanettitsdgeos, it doesn't show anything?10:18
tsdgeosmzanetti: what's the nichtlusting scope?10:18
dandradertsdgeos, no the diff looks correct. had to redo the stack of commits.10:18
tsdgeosis it on the shop?10:18
dandradertsdgeos, s/no/now10:18
mzanettitsdgeos, yes10:19
mzanettitsdgeos, this is the card definition it uses: https://developer.ubuntu.com/en/scopes/guides/scopes-customization-branding/10:19
mzanettiwrong link10:19
mzanettithis one: http://bazaar.launchpad.net/~mzanetti/+junk/nichtlustig-scope/view/head:/src/scope/query.cpp#L2610:19
mzanettinow the question is why the spacings between the tiles are broken10:20
tsdgeosmzanetti: ok, give me a sec10:26
tsdgeosmzanetti: so what's wrong exactly?10:29
tsdgeosthe empty spacing?10:29
mzanettitsdgeos, yeah10:34
mzanettitsdgeos, it's more... first I'd say the spacing is too big.10:34
mzanettitsdgeos, sometimes though, it's missing completely10:34
mzanettirefresh the scope and it'll change10:35
tsdgeosnot here, it's always the same10:35
mzanettitsdgeos, scroll down the scope10:36
mzanettitsdgeos, also, you'll see cachebuffer operating too early and tiles disappear before the are leaving the scene10:36
tsdgeosnot here10:36
tsdgeosmzanetti: are you on rtm or vivid?10:36
tsdgeosok, going back to scopes and using the manage scopes got me the bad spacing10:37
tsdgeoscan't get the tiles to disappear10:37
tsdgeosbut that may happen at some point if they're wrongly layouted10:37
mzanettithis is when I scroll to the bottom10:38
mzanetti100% reproduceable by doing:10:38
mzanetti* favorite the scope10:38
mzanetti* go to it using horizontal swipes10:38
mzanetti* pull down to refresh it10:38
mzanettithen slowly scroll to the bottom, watch topmost ones disappear too early, see spacing broken for bottom cards10:39
tsdgeosmzanetti: can i get the scope for the desktop please?10:41
tsdgeos<tsdgeos> mzanetti: can i get the scope for the desktop please?10:44
tsdgeos<tsdgeos> i guess we're at the point already that some stuff is much easier to get on the phone than on the desktop10:44
tsdgeosok compiled manually10:53
tsdgeosi'll have a look at least as to why there's the empty space10:53
=== MacSlow is now known as MacSlow|lunch
mzanettinot sure why my IRC highlight has gone today11:05
mzanettitsdgeos, you still need something?11:05
mzanettitsdgeos, also I'd have another one of those questions. If you install the "südwestpresse" scope (search for "swp" in the store). then open a preview, you'll see that the image in the header is too large11:10
mzanettiagain I think even if the scope developer provides an image that doesn't fit properly, we should probably set the size ourselves somehow11:10
tsdgeosmzanetti: no, it's ok11:14
tsdgeosi've a fix at least for the empty space11:15
mzanettitsdgeos, cool :)11:15
tsdgeosnot sure if that'll fix the clipping11:16
tsdgeosi'm hoping it will11:16
=== dandrader is now known as dandrader|afk
tsdgeosmzanetti: https://code.launchpad.net/~aacid/unity8/card_height_overlay_header/+merge/25875611:24
mzanettitsdgeos, will this still work for cards that have a headeroverlay AND and a summary?11:25
mzanettigiven that the summary is still outside the art in that case11:25
tsdgeosmzanetti: the if for the summary is higher in the chain11:26
=== dandrader|afk is now known as dandrader
=== alan_g is now known as alan_g|lunch
=== MacSlow|lunch is now known as MacSlow
tsdgeosmzanetti: have you tried the patch?12:52
=== alan_g|lunch is now known as alan_g
tsdgeosmzanetti: also answered https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/145354613:03
ubot5Ubuntu bug 1453546 in unity8 (Ubuntu) "cannot use color:/// uri for scope header foreground and divider color" [Undecided,New]13:03
mzanettitsdgeos, well, regardless if it's intentional or not... it's bad13:46
mzanettiIMHO, that is13:46
tsdgeoswhy ?13:46
tsdgeoshow would you use a gradient in the foreground color or in the divider line?13:47
mzanettibecause for example the swp scope. the blue in the logo can't be the same blue as the one of the back arrow13:47
mzanettitsdgeos, not necessarily a gradient... but a color:///#aarrggbb13:47
tsdgeoswell that works of course13:47
tsdgeosjust don't use color:///13:47
mzanettitsdgeos, not for me13:47
mzanettiah... ok... then it's the doc that sucks13:48
mzanettimhall119, think we can improve that? ^^13:48
tsdgeosmzanetti: i don't know why it sucks13:49
mzanettithe docs say one should use color:///#aarrggbb, but apparently only "#aarrggbb" works13:49
tsdgeosmzanetti: no, one should use color://// in the fields that support background uris13:50
tsdgeosread the part i quoted on the bug13:50
mzanettiand which fields are that?13:50
mzanetti"some" is really not precise enough imo13:50
mhall119mzanetti: where is that?13:50
mzanettimhall119, https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/145354613:51
ubot5Ubuntu bug 1453546 in unity8 (Ubuntu) "cannot use color:/// uri for scope header foreground and divider color" [Undecided,New]13:51
tsdgeosmzanetti: actually it's pretty defined i think13:51
tsdgeosthe ones that say "background scheme" it's a "background scheme" (i.e. the color:///) stuff13:51
tsdgeosthe rest just say "color"13:51
tsdgeosand color is "red" or "#aarrggbb"13:51
tsdgeosbut i guess it could be improved13:52
tsdgeosit took me a while to understand it and i kind of know what it says13:52
=== elopio_ is now known as elopio
mzanettialso it should say that for !some one should use either an svg color name or a "#aarrggbb" value13:52
mzanettibut I'm so sure I tried that... it only painted black all the time for me13:52
mzanettilet me try again13:52
tsdgeoswell then that's a bug13:53
mzanettiit works... seems I didn't try that13:55
tsdgeosso i guess it needs a rewording13:57
tsdgeossaying "in the above list color means bla and background scheme means blo"13:57
=== marcusto_ is now known as marcustomlinson
mzanettitsdgeos, why making it different though...13:59
mzanettiit should always be the same, except background one additionally supporting gradient:///13:59
tsdgeosmzanetti: and images in urls14:00
tsdgeosi don't know i didn't do that spec14:01
tsdgeosi'm just telling you what it says and how we implemented it14:01
tsdgeoshonestly i have no opinion14:01
dandradergreyback, what optimization does a const int parameter bring?14:07
greybackdandrader: it's more for humans here tbh. Without the compiler will usually have to copy the parameter, so for objects that can be a cost. For int, it's pretty cheap, so not much of a gain. But I like using const whenever possible14:14
greybackhttp://www.gotw.ca/gotw/081.htm is nice summary14:14
pstolowskitsdgeos, hey, i guess you want somebody from unity8 team to top-approve https://code.launchpad.net/~aacid/unity8/edit_reviews/+merge/258623 ?14:18
tsdgeospstolowski: i'd like to yeah14:18
tsdgeosgreyback: const won't stop the compiler doing a copy of the object, const & will14:18
pstolowskitsdgeos, i will prepare a silo with our stuff14:19
tsdgeosalso it's actaully slower to pass POD as const & than just by copy14:19
dandradergreyback, I don't see the point of a "const int". But I do see it for "const FooStruct&". In the latter you avoid copying over a struct. but and int? nothing is smaller than an int14:19
greybacktsdgeos: you're right14:20
tsdgeosgreyback: http://www.macieira.org/blog/2012/02/the-value-of-passing-by-value/ is a very nice article about it14:20
tsdgeoswhen you have days to digest it all14:20
greybacktsdgeos: what say you? "const int" vs "int"14:20
tsdgeosi went straight into the conclusions :D14:20
tsdgeosgreyback: no i mean const int & vs int14:21
tsdgeosconst int vs int i'd say it's the same14:21
greybackdandrader: then it's merely a hint for humans14:22
greybackbut one I like14:22
tsdgeosand the compiler in case you try to change it :D14:22
tsdgeoscimi: can you do https://code.launchpad.net/~aacid/unity8/edit_reviews/+merge/258623  ?14:23
dandraderI would say that "const int" param is a copy of an int that the function code can't modify. no optimization14:23
cimitsdgeos, sure14:23
tsdgeoscimi: cheers14:23
dandradergreyback, I don't know. I've never seen a function taking a "const int".....14:24
greybackdandrader: yep, we've already established it's not a performance optimization, it's a hint for human & compiler14:24
dandradergreyback, I think this hint does more harm than good, as it bloats the signature for no real benefit14:25
dandraderI mean, who care is the function implementation changes the int it gets as a parameter?14:26
greybackdandrader: 6 chars != bloat in my book14:26
dandrader*cares if14:26
pstolowskimzanetti, hey, ok if i request a silo with unity8 branch and related stuff for review editing functionality?14:26
mzanettipstolowski, sure. can we add some little more stuff into that?14:27
mzanettipstolowski, I would help with the testing abviously14:27
* mterry upgrades to wily14:29
pstolowskimzanetti, sure14:29
mzanettitsdgeos, approved your branch. fixes the nichtlustig scope spacings14:32
mzanettitsdgeos, however, I can still see cards disaappear too early14:32
tsdgeosok, i'll try to reproduce harder14:32
mzanettitsdgeos, I can only repro it with the nichtlustig scope... not for example with the xkcd one that also uses header-overlay with no summary14:35
pstolowskitsdgeos, can you bump the version with your edit_reviews branch? i need to make click scope depend on that, otherwise the scope will break14:39
=== dandrader is now known as dandrader|lunch
tsdgeosmzanetti: it's probably not a journal?14:49
tsdgeospstolowski: bump the version of what?14:49
pstolowskitsdgeos, unity814:49
tsdgeosdoesn't every release do that?14:50
tsdgeosor you mean bump to 8.03 ?14:50
pstolowskitsdgeos, sure, but i need the number upfront to update my control file :)14:50
mzanettitsdgeos, right...14:51
tsdgeospstolowski: not sure what i have to do then :D14:51
tsdgeosmzanetti: ↑↑↑ ?14:51
pstolowskitsdgeos, actually.. i wonder if it's a good idea to introduce such dependency14:52
pstolowskitsdgeos, i've never done that before14:52
pstolowskitsdgeos, meh, scratch that14:52
tsdgeospstolowski: ok :D14:52
pstolowskimzanetti, feel free to add more stuff to line #7014:53
mzanettipstolowski, ack14:53
mzanettipstolowski, I see this targetting wily. how are you handling that?14:54
mzanettidoes that mean editing reviews will only work in november?14:54
mzanettiMacSlow, hey... so, about that shellrotation AP tests. what's the status?14:55
tsdgeoswhich raises the question of14:55
tsdgeosshall we jump to wily or what?14:56
mzanettiyeah... current situation is not really clear at all14:56
MacSlowmzanetti, ready for more review eyes14:56
mzanettiMacSlow, has that long standing issue been fixed now?14:57
MacSlowmzanetti, qml-cache issue can be avoided by unsetting QV4_ENABLE_JIT_CACHE... this isn't really an issue that branch is meant to solve.14:58
mzanettiah ok14:58
MacSlowmzanetti, apart from that I've 100% success-rate14:58
mzanettiok. sounds good14:58
MacSlowmzanetti, I'll just hope to dig myself 100% into unity8-launcher work now... as that _much_ more fun than the ap-test and related parts :)14:59
MacSlowmzanetti, btw... QV4_ENABLE_JIT_CACHE really has to be unset... just assigning 0 can still keep the QML-cache bug happen again15:01
MacSlowmzanetti, just wiping ~/.cache/QML before the ap-test-run isn't enough, because the shell-rotation AP-test is using scenarios now - upon QA-team request - thus on ap-test-run causes multiple unity8 start/stop cycles which in turn recreate the qml-cache if $QV4_ENABLE_JIT_CACHE is defined15:03
mzanettiMacSlow, so does that mean if we land it, our jenkins runs will fail?15:04
MacSlowmzanetti, no... it can15:04
MacSlowmzanetti, the failure-rate due to the qml-cache bug is... about 20%15:05
mzanettiso yes, our jenkins runs will fail then15:05
MacSlowmzanetti, iirc we have a bug files for this too...15:05
pstolowskimzanetti, i'm not sure about willy; i'm definately planning to land in vivid as wel15:05
pstolowskimzanetti, i assume willy is kind of required, then we need another silo for vivid overlay15:06
mzanettiwilly :D15:06
pstolowskigosh ;)15:07
mzanettipstolowski, if that's supposed to to go into vivid, then I think you should just target vivid in the spreadsheet15:07
pstolowskimzanetti, sure, but we need to target both, no?15:07
MacSlowpstolowski, mzanetti: what a difference a 'l' can make :)15:08
mzanettipstolowski, and that's where I'm a bit lost too tbh15:08
mzanettipstolowski, so I guess the only way out would be to branch vivd+overlay in the repos, land to wily and backport to the other...15:09
mzanettiwhich is a pain15:09
mzanettibut anything else is just pointless in one way or the other15:09
=== dholbach_ is now known as dholbach
tsdgeosmzanetti: ok, i can actually reproduce it, it's just more subtle that i expected15:10
mzanettitsdgeos, I have a feeling after your first fix it's less visible, yes15:10
pstolowskimzanetti, ok, i got some clarity about click scope part of it at least; it has 15.04 branch which I need to target for "vivid"; trunk is for W15:12
mzanettiyeah, that's what I meant with the backporting thing15:12
mzanettiit's really the only thing that works15:12
mzanettiwe don't have a 15.04 branch in unity though... I suppose I should just create it then15:13
pstolowskimzanetti, yes... i can small a lot of fun15:14
greybackpstolowski: "small" "willy" - what fun typos are you making ;)15:14
pstolowskimzanetti, i've changed the spreadhseet to target vivid15:14
mzanettiok, cool15:14
pstolowskigreyback, :)15:14
=== dandrader|lunch is now known as dandrader
tsdgeosmzanetti: ok, found out the problem15:58
tsdgeosi'm not taking into account the various margins around the journal when calculating what is really seen15:58
tsdgeosso if we were clipping it'd be right, btu since we're not need to take them into account15:58
tsdgeoswill fix tomorrow15:59
* tsdgeos waves16:00
mzanettimy laptop battery only charges up to 76% any more :'(16:40
=== alan_g is now known as alan_g|EOD
=== greyback__ is now known as greyback

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!