| dholbach | good morning | 06:11 |
|---|---|---|
| === erkules_ is now known as erkules | ||
| JamesTait | Good morning all; happy Friday, and happy Nylon Stockings Day! 😝 | 08:35 |
| === vrruiz_ is now known as rvr | ||
| === leandrosansilva2 is now known as leandrosansilva | ||
| Chipaca | @reviewlist | 10:02 |
| nothal | https://code.launchpad.net/~chipaca/ubuntu-core-launcher/unshare/+merge/258367 | Approve: 1, Needs Fixing: 1 (8 days old) | 10:02 |
| nothal | https://code.launchpad.net/~sergiusens/webdm/queryPackageNames/+merge/258640 | No reviews (6 days old) | 10:02 |
| nothal | https://code.launchpad.net/~mterry/snappy/allow-more-dots/+merge/259181 | Approve: 1 (less than a day old) | 10:02 |
| nothal | https://code.launchpad.net/~chipaca/snappy/log-command-failure/+merge/258669 | Approve: 1 (6 days old) | 10:02 |
| nothal | https://code.launchpad.net/~chipaca/snappy/no-more-log/+merge/258667 | No reviews (6 days old) | 10:02 |
| vmayoral|pc | rsalveti: thanks for yesterday's changes. It seems the we are still missing some dependencies https://gist.github.com/vmayoral/3be25ea9026a8d73568e. Mind taking another look please? | 12:32 |
| ogra_ | vmayoral|pc, ouch ... thats a bit trickier to solve | 13:02 |
| rsalveti | yeah, the problem is see is mixing up vivid with trusty | 13:02 |
| ogra_ | well, the problem is as well that we dont have android-tools for armhf | 13:02 |
| rsalveti | I think we do | 13:02 |
| ogra_ | and u-d-f depends on that ... | 13:03 |
| rsalveti | at least I was able to install snappy-tools on my meizu yesterday | 13:03 |
| rsalveti | but using vivid | 13:03 |
| ogra_ | ah | 13:03 |
| vmayoral|pc | let me retry bootstrapping a vivid file system and i'll provide feedback | 13:03 |
| rsalveti | after rebuild the packages | 13:03 |
| rsalveti | *rebuilding | 13:03 |
| ogra_ | ah, right, i see them on the phone | 13:04 |
| rsalveti | let me reflash vivid, got wily while trying to get vivid | 13:04 |
| ogra_ | heh, yeah | 13:04 |
| rsalveti | this channel mess we had yesterday | 13:04 |
| ogra_ | i'm currently re.working all my bot scripts ... | 13:04 |
| davmor2 | rsalveti: no really | 13:04 |
| ogra_ | not only the channels changed ... buit versions were re-set too | 13:04 |
| davmor2 | rsalveti: you'll need a new channel but I'm not telling you what :) | 13:05 |
| rsalveti | davmor2: rc/ubuntu-developer right? | 13:05 |
| rsalveti | or yet another channel | 13:05 |
| ogra_ | no, thats wily | 13:05 |
| rsalveti | trying with mako | 13:05 |
| ogra_ | ubuntu-touch/rc-proposed/bq-aquaris.en | 13:05 |
| rsalveti | even for mako? | 13:05 |
| ogra_ | that seems the only vivid channel left | 13:06 |
| ogra_ | there is a mako subdir | 13:06 |
| rsalveti | haha, interesting | 13:06 |
| ogra_ | ogra@anubis:~/irc-json-daemon$ ubuntu-device-flash query --channel=ubuntu-touch/rc-proposed/bq-aquaris.en --device mako --list-images|tail -1 | 13:06 |
| ogra_ | 5: description='ubuntu=20150515,device=20150210,custom=mako-1.1,version=5' | 13:06 |
| ogra_ | wow, we havent re-built android since feb. | 13:07 |
| rsalveti | yeah, need to rebuild that, was waiting a few patches to land in code-phablet first | 13:09 |
| rsalveti | like the aosp apns update | 13:09 |
| rsalveti | ogra_: seems to be working: http://paste.ubuntu.com/11147470/ | 13:26 |
| ogra_ | yeah | 13:27 |
| === rickspencer3_ is now known as rickspencer3 | ||
| === utlemming_away is now known as utlemming | ||
| mterry | Chipaca, what is the snappy project's code review flow? For example, on lp:~mterry/snappy/allow-more-dots, you did an approve comment with a small comment request. (I made that change) Should I top-approve? Do I need more than one approval? Do we manually push to trunk or does tarmac do that for us? We don't seem to have a CI instance I note | 14:34 |
| Chipaca | mterry: usually, if a branch is fine i'd +1 and top-approve; when it has comments i'd +1 and let you top-approve once you'd considered the comments (or come back to me and ask to re-review if it ended up being less-than-cosmetic) | 15:10 |
| mterry | ChickenCutlass, makes sense. If top-approved, does it automatically land in trunk or do we use silos etc? | 15:11 |
| * Chipaca hugs ChickenCutlass | 15:11 | |
| mterry | whoops | 15:11 |
| mterry | :) | 15:11 |
| Chipaca | mterry: it lands in trunk | 15:11 |
| mterry | Chipaca, OK. So only one approve needed, auto-lands in trunk. But no CI hooked up yet? Reviewers manually run tests? | 15:12 |
| Chipaca | mterry: it runs run-checks before landing to trunk | 15:12 |
| Chipaca | mterry: no CI yet; selftest needs work for that (not much though) | 15:12 |
| mterry | Chipaca, neat, great. I'm out of questions :) | 15:13 |
| Chipaca | mterry: you could also run go fmt as a precommit hook | 15:18 |
| Chipaca | mterry: congrats on your first landing :) | 15:28 |
| mterry | Chipaca, I'm breaking out the beer now ;) | 15:28 |
| Chipaca | mterry: and now you've got (another) excuse! | 15:28 |
| Chipaca | mterry: and, jsut so you don't get *too* high and mighty, need-fixing'ed your second mp | 15:36 |
| mterry | :) | 15:42 |
| === retrack is now known as Guest16574 | ||
| * Chipaca ~> EOD \o/ | 17:12 | |
| Chipaca | EOW, also | 17:12 |
| ogra_ | enjoy ! | 17:12 |
| * Chipaca might be lying | 17:12 | |
| Chipaca | no, not lying, promise | 17:13 |
| * Chipaca definitely lying then | 17:13 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!