=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
=== vrruiz_ is now known as rvr
=== oSoMoN_ is now known as oSoMoN
=== pgraner-afk is now known as pgraner
=== chihchun_afk is now known as chihchun
nuclearbobubuntu-qa: I'm fixing some DNS issues for the automated jobs, so I may be in and out of channels for a bit14:43
=== chihchun is now known as chihchun_afk
balloonsubuntu-qa, can I get a review of https://code.launchpad.net/~nskaggs/qtcreator-plugin-ubuntu/update-qml-autopilot/+merge/259164?17:04
elopionuclearbob: you are vanguard. ^17:05
elopioballoons: I want to look at it, but I won't be able today. Sorry.17:06
balloonselopio, no worries at all.17:06
=== pgraner is now known as pgraner-afk
nuclearbobballoons: I'm taking a look17:32
nuclearbobballoons: it looks like r394 is mostly spacing changes, but I see at least one that's lining up in an odd way in the viewer: http://bazaar.launchpad.net/~nskaggs/qtcreator-plugin-ubuntu/update-qml-autopilot/revision/39417:39
nuclearbobit's line 27 there, not sure if that's something to worry about17:39
balloonsnuclearbob, the spacing in the wizard files? Yea, I spaced it all nicely in one but didn't carry that to all of them17:42
balloonsnot sure if people like the spaced out style or not17:42
nuclearbobballoons: okay, I won't worry about that, I'll keep reviewing17:42
nuclearbobballoons: I'm guessing this project isn't enforcing flake8 by the number of things that come up. Do you me to check the files you've modified or just leave that alone?17:45
balloonsnuclearbob, ahh right, it doesn't enforce flake8. But I did check my stuff to make sure it was a-ok. What are you seeing?17:50
balloonsthe python we're writing in here should be flake8, and if it's not let's fix it17:50
nuclearbobballoons: mostly missing whitespace around operators, but the list is a little long. If you've checked yours, I'm sure it's fine. I'll keep looking at the other changes, I'm trying to grok things but I'm not really familiar with this project17:50
nuclearbobballoons: do you want me to send you the list of things it came up with?17:51
balloonsnuclearbob, wow.. quite a bit there. Yea, I would stay focused on the stuff I changed. Making all that python flake8 compatible is worthy of a seperate bug and mp I'd guess17:55
nuclearbobballoons: yeah17:55
balloonsnuclearbob, ohh interestingly, I wonder if the flake8 issues on my stuff are simply because of the 'before version' of the code17:56
balloonsonce it's been templated, it all passes17:57
nuclearbobballoons: oh, that's very interesting and quite possible17:57
balloonsI would be hesitant to make changes.. I know some of those things I had to change (like the no newlines at end of file, sdk adds one)17:57
nuclearbobI see stuff in share/qtcreator/ubuntu/scripts17:58
nuclearbobnot sure if that's templately or not17:58
balloonstemplates should all be under /share/qtcreator/templates/wizards/ubuntu/.. so outside that is probably valid17:58
balloonsvalid to fix that i s:-)17:59
nuclearbobballoons: the changes that I understand seem reasonable, but I must confess the shocking secret that my knowledge of QML is pretty rudimentary. If the new tests are passing, I imagine it should work18:27
balloonsnuclearbob, :-) thanks for having a look and reviewing!18:27
balloonsyou can copy the templates and try them out in qt creator18:28
balloonscp -r share/qtcreator/templates/wizards/ubuntu/ /usr/share/qtcreator/templates/wizards18:28
balloonsmind you, that will overlay what's there without backup, so ;-)18:28
elopioubuntu-qa: the ubuntu-keyboard doesn't seem to work on arale devel-proposed. Is that a known thing? Any workarounds come to mind?18:40
davmor2elopio: on devel-proposed that is wily based it could be anything18:41

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!