=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
=== vrruiz_ is now known as rvr
=== oSoMoN_ is now known as oSoMoN
=== pgraner-afk is now known as pgraner
=== chihchun_afk is now known as chihchun
[14:43] <nuclearbob> ubuntu-qa: I'm fixing some DNS issues for the automated jobs, so I may be in and out of channels for a bit
=== chihchun is now known as chihchun_afk
[17:04] <balloons> ubuntu-qa, can I get a review of https://code.launchpad.net/~nskaggs/qtcreator-plugin-ubuntu/update-qml-autopilot/+merge/259164?
[17:05] <elopio> nuclearbob: you are vanguard. ^
[17:06] <elopio> balloons: I want to look at it, but I won't be able today. Sorry.
[17:06] <balloons> elopio, no worries at all.
=== pgraner is now known as pgraner-afk
[17:32] <nuclearbob> balloons: I'm taking a look
[17:39] <nuclearbob> balloons: it looks like r394 is mostly spacing changes, but I see at least one that's lining up in an odd way in the viewer: http://bazaar.launchpad.net/~nskaggs/qtcreator-plugin-ubuntu/update-qml-autopilot/revision/394
[17:39] <nuclearbob> it's line 27 there, not sure if that's something to worry about
[17:42] <balloons> nuclearbob, the spacing in the wizard files? Yea, I spaced it all nicely in one but didn't carry that to all of them
[17:42] <balloons> not sure if people like the spaced out style or not
[17:42] <nuclearbob> balloons: okay, I won't worry about that, I'll keep reviewing
[17:45] <nuclearbob> balloons: I'm guessing this project isn't enforcing flake8 by the number of things that come up. Do you me to check the files you've modified or just leave that alone?
[17:50] <balloons> nuclearbob, ahh right, it doesn't enforce flake8. But I did check my stuff to make sure it was a-ok. What are you seeing?
[17:50] <balloons> the python we're writing in here should be flake8, and if it's not let's fix it
[17:50] <nuclearbob> balloons: mostly missing whitespace around operators, but the list is a little long. If you've checked yours, I'm sure it's fine. I'll keep looking at the other changes, I'm trying to grok things but I'm not really familiar with this project
[17:51] <nuclearbob> balloons: do you want me to send you the list of things it came up with?
[17:51] <nuclearbob> http://paste.ubuntu.com/11151176/
[17:55] <balloons> nuclearbob, wow.. quite a bit there. Yea, I would stay focused on the stuff I changed. Making all that python flake8 compatible is worthy of a seperate bug and mp I'd guess
[17:55] <nuclearbob> balloons: yeah
[17:56] <balloons> nuclearbob, ohh interestingly, I wonder if the flake8 issues on my stuff are simply because of the 'before version' of the code
[17:57] <balloons> once it's been templated, it all passes
[17:57] <nuclearbob> balloons: oh, that's very interesting and quite possible
[17:57] <balloons> I would be hesitant to make changes.. I know some of those things I had to change (like the no newlines at end of file, sdk adds one)
[17:57] <nuclearbob> yeah
[17:58] <nuclearbob> I see stuff in share/qtcreator/ubuntu/scripts
[17:58] <nuclearbob> not sure if that's templately or not
[17:58] <balloons> templates should all be under /share/qtcreator/templates/wizards/ubuntu/.. so outside that is probably valid
[17:59] <balloons> valid to fix that i s:-)
[18:27] <nuclearbob> balloons: the changes that I understand seem reasonable, but I must confess the shocking secret that my knowledge of QML is pretty rudimentary. If the new tests are passing, I imagine it should work
[18:27] <balloons> nuclearbob, :-) thanks for having a look and reviewing!
[18:28] <balloons> you can copy the templates and try them out in qt creator
[18:28] <balloons> cp -r share/qtcreator/templates/wizards/ubuntu/ /usr/share/qtcreator/templates/wizards
[18:28] <balloons> mind you, that will overlay what's there without backup, so ;-)
[18:28] <nuclearbob> ah
[18:40] <elopio> ubuntu-qa: the ubuntu-keyboard doesn't seem to work on arale devel-proposed. Is that a known thing? Any workarounds come to mind?
[18:41] <davmor2> elopio: on devel-proposed that is wily based it could be anything