| blr_ | wgrant: using zope interfaces, is it possible to express that a concerete class should implement one _or_ another method but not both? | 02:22 |
|---|---|---|
| wgrant | blr_: No. | 02:30 |
| wgrant | blr_: What are you trying to do? | 02:30 |
| blr_ | wgrant: oh, not trying to do that, was discussing zope interfaces with someone and that came up. | 02:32 |
| blr | wgrant: have added a new doctest for product +setbranch, however I'm matching elements against browser.contents | 07:54 |
| blr | assuming it would be better to have a helper? | 07:54 |
| wgrant | blr: There are a few helpers around already. None did what you need? | 07:54 |
| blr | well, I want it to match a specific element for vcs | 07:55 |
| blr | e.g. I currently have ">>> '<dl id="product-vcs">' in browser.contents" | 07:56 |
| wgrant | blr: A number of tests use BeautifulSoup for that. | 07:56 |
| blr | I'll dig around and look at more of the doctests. | 07:57 |
| blr | hmm, lots of gpg-coc stories blowing up, would be surprised if they're regressions | 08:21 |
| blr | wgrant: does bin/retest work reliably for you? it seems to hang with no output. | 08:32 |
| wgrant | blr: You need to give it the list of failures from bin/test in one of two ways: a file specified at the commandline, or the raw text given to stdin. | 08:33 |
| wgrant | If you don't specify a filename it will await input. | 08:34 |
| blr | hah ok, not as magical as I had hoped :) | 08:36 |
| wgrant | If you want properly magical, consider testrepository. | 08:37 |
| cjwatson | blr: Does it have to be a doctest, notwithstanding the existing stuff that does that? You can often do this pretty well in unit tests. | 09:17 |
| cjwatson | wgrant: webhooks proxy> good idea. I'd be inclined to just use squid as then we don't have to write a new charm at all. | 10:58 |
| cjwatson | I'm sure we can control requests' proxy settings accurately enough. | 10:59 |
| wgrant | Yep, as long as we're careful that should be fine. | 11:00 |
| cjwatson | I'll get an RT in for an initial sanity check and a stagingstack tenant. | 11:00 |
| wgrant | Need to check the PS4 egress firewalls thoroughly, but it should be fine. | 11:00 |
| wgrant | block 10.0.0.0/8 and all our IP ranges except archive and blah blah blah | 11:01 |
| cjwatson | Yeah | 11:01 |
| wgrant | (except when people want to webhook internal hosts. but then we can open those up.) | 11:01 |
| wgrant | I'll raise it on the IS call in 9 hours. | 11:02 |
| cjwatson | Thanks. | 11:02 |
| cjwatson | wgrant: https://rt.admin.canonical.com/Ticket/Display.html?id=81258 | 11:37 |
| cjwatson | (I forgot to specifically mention the needed access from ackee, but we can sort that out as we go.) | 11:41 |
| wgrant | cjwatson: The instances probably want floating IPs if only so they have sane reverse DNS, but otherwise that looks good. Thanks. | 11:55 |
| cjwatson | wgrant: Indeed, just didn't mention that because that can't be done until we have a spec deployed. | 12:50 |
| cjwatson | bigjools: William made the change you asked for to default new private archives to 20GiB rather than 2GiB; that's live now. | 15:39 |
| blr | cjwatson: I added doctests to mirror the existing ones for series setbranch. Do we want to consider them generally deprecated at his point? | 20:32 |
| wgrant | blr: Yes, doctests are quite deprecated. | 20:32 |
| blr | I'm not that fond of them tbh | 20:32 |
| wgrant | It's okay to add to them when that's substantially lower friction than adding a unit test, but it is discouraged. | 20:32 |
| blr | I'll get the unit tests in place this morning, and perhaps you can judge if we should just drop the new doctests entirely when you review the branch | 20:33 |
| blr | wgrant: oh, regarding push instructions, was thinking the nicest thing to do perhaps is display them based on the toggle state of default vcs on project setbranch | 20:35 |
| blr | wgrant, cjwatson: one other wee thing, in the case where we infer vcs default from BranchCollection, git will be set as the default in the case where there are both bzr and git branches - is that acceptable? I figured that was the right approach given we want to generally consider bzr deprecated. | 20:42 |
| wgrant | That sounds reasonable to me. | 20:43 |
| wgrant | blr: Which push instructions? | 20:43 |
| cjwatson | Agreed, also we can mostly assume that people will be migrating from bzr to git rather than the other way round. | 20:44 |
| blr | push intructions at the top of +setbranch | 20:44 |
| blr | currently only for bzr | 20:44 |
| cjwatson | Similar for Product:+branches and probably various other places | 20:45 |
| wgrant | Product:+branches isn't really affected; it'll show whatever the current view is. | 20:46 |
| cjwatson | True, +setbranch has a more awkward choice to make | 20:46 |
| blr | I just thought that might be nice, to toggle between git and bzr intructions on the right hand side based on the vcs default selected | 20:46 |
| blr | possibly it isn't even useful there, the code index view is really where you expect to see it. | 20:48 |
| wgrant | +setbranch should have it, as that's probably the place you go when you create a new project. | 20:56 |
| bigjools | cjwatson: wgrant: thanks a million, that's awesome | 21:38 |
| wgrant | bigjools: np | 21:40 |
| blr | wgrant: added a view test for default vcs to TestProductView - is there an equivalent set of tests for setbranch somewhere, or only doctests? | 23:23 |
| wgrant | blr: I can't see any non-doctests. | 23:25 |
| blr | ok, thanks for confirming, that's what I thought. | 23:25 |
| blr | wgrant: `bin/test -cvvt xx-` should be catching all doctests yes? | 23:54 |
| wgrant | blr: That should catch most of the browser doctests. | 23:56 |
| wgrant | But that's not usually an interesting pattern. | 23:57 |
| wgrant | -t registry.*product or something might be more interesting. | 23:57 |
| wgrant | Or -t code.*product | 23:57 |
| blr | wgrant: I found some regressions in translations, which I probably would not have noticed. I should probably just run the entire suite. | 23:58 |
| wgrant | blr: That's buildbot's job. | 23:58 |
| wgrant | Running the entire test suite takes more than three hours on my overclocked Haswell desktop. | 23:58 |
| wgrant | But you could grep for tests that reference setbranch, for example. | 23:58 |
| blr | okay, thanks | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!