| blr | wgrant: think that's ready for review - sorry for the cjwatson sized diff. | 02:52 |
|---|---|---|
| wgrant | blr: Do you want to perhaps split the reindenting into another branch? | 02:52 |
| wgrant | Just create a fresh branch of devel, fix the indentation, and land that so the diff in this branch is reviewable. | 02:53 |
| blr | sorry, reindenting? | 02:53 |
| wgrant | productseries-setbranch.js at least | 02:53 |
| wgrant | Half the file is correctly reindented from three to four spaces. | 02:54 |
| blr | ah, sure. | 02:55 |
| blr | I'm going to blame emacs. | 02:55 |
| wgrant | Heh | 02:58 |
| blr | might as well lint it while I'm at it, this file would make douglas crockford sad. | 02:59 |
| wgrant | It certainly would. | 03:00 |
| blr | wgrant: ~blr/launchpad/trivial-fix-productseries-js-indentation | 03:11 |
| wgrant | blr: Too late :) | 03:11 |
| blr | refreshing is hard. | 03:11 |
| blr | wgrant: shall I resub that mp with a dependant branch, or wait for the merge. | 03:14 |
| wgrant | blr: Land the reindentation, then merge it into your main branch, resolve the conflicts, commit and push. | 03:15 |
| wgrant | (there isn't really a "wait for the merge" step, since buildbot runs *after* the merge) | 03:16 |
| wgrant | cjwatson: Ah, hm. Git MPs live under their target ref, but their target ref may no longer exist. | 03:21 |
| wgrant | eg. the launchpad:test MP on https://code.launchpad.net/launchpad/+activereviews | 03:21 |
| cjwatson | wgrant: Mm, it might make sense to move those directly under GitRepository, indeed. | 10:21 |
| cjwatson | And it would make the URLs a little less obnoxious ... | 10:22 |
| cjwatson | wgrant: Will be much easier after git-repository-delete lands, since that incidentally needed to add some MP-related properties to GitRepository. | 11:40 |
| wgrant | cjwatson: Ah good. | 11:41 |
| wgrant | cjwatson: I'd not really be concerned about leaving redirects. | 11:55 |
| cjwatson | wgrant: Perhaps not. | 12:41 |
| blr | wgrant: thank you for the thorough review! | 21:08 |
| blr | wgrant: cjwatson: this looks potentially useful https://github.com/DesertBus/sockjs-twisted/ | 22:54 |
| blr | sockjs seems to have a sensible approach to degrading transports - haven't used it in earnest however. | 22:55 |
| cjwatson | entirely new to me :) | 22:56 |
| blr | cjwatson: anecdotally better maintained and more robust than socket.io | 22:58 |
| wgrant | blr: Do my issues/suggestions on the MP make sense? | 23:54 |
| cjwatson | https://code.launchpad.net/~cjwatson/canonical-is-puppet/webhooks-proxy-tweaks/+merge/259558 | 23:56 |
| cjwatson | And now to bed. | 23:56 |
| wgrant | cjwatson: Thanks, and night. | 23:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!