blrwgrant: think that's ready for review - sorry for the cjwatson sized diff.02:52
wgrantblr: Do you want to perhaps split the reindenting into another branch?02:52
wgrantJust create a fresh branch of devel, fix the indentation, and land that so the diff in this branch is reviewable.02:53
blrsorry, reindenting?02:53
wgrantproductseries-setbranch.js at least02:53
wgrantHalf the file is correctly reindented from three to four spaces.02:54
blrah, sure.02:55
blrI'm going to blame emacs.02:55
blrmight as well lint it while I'm at it, this file would make douglas crockford sad.02:59
wgrantIt certainly would.03:00
blrwgrant: ~blr/launchpad/trivial-fix-productseries-js-indentation03:11
wgrantblr: Too late :)03:11
blrrefreshing is hard.03:11
blrwgrant: shall I resub that mp with a dependant branch, or wait for the merge.03:14
wgrantblr: Land the reindentation, then merge it into your main branch, resolve the conflicts, commit and push.03:15
wgrant(there isn't really a "wait for the merge" step, since buildbot runs *after* the merge)03:16
wgrantcjwatson: Ah, hm. Git MPs live under their target ref, but their target ref may no longer exist.03:21
wgranteg. the launchpad:test MP on https://code.launchpad.net/launchpad/+activereviews03:21
cjwatsonwgrant: Mm, it might make sense to move those directly under GitRepository, indeed.10:21
cjwatsonAnd it would make the URLs a little less obnoxious ...10:22
cjwatsonwgrant: Will be much easier after git-repository-delete lands, since that incidentally needed to add some MP-related properties to GitRepository.11:40
wgrantcjwatson: Ah good.11:41
wgrantcjwatson: I'd not really be concerned about leaving redirects.11:55
cjwatsonwgrant: Perhaps not.12:41
blrwgrant: thank you for the thorough review!21:08
blrwgrant: cjwatson: this looks potentially useful https://github.com/DesertBus/sockjs-twisted/22:54
blrsockjs seems to have a sensible approach to degrading transports - haven't used it in earnest however.22:55
cjwatsonentirely new to me :)22:56
blrcjwatson: anecdotally better maintained and more robust than socket.io22:58
wgrantblr: Do my issues/suggestions on the MP make sense?23:54
cjwatsonAnd now to bed.23:56
wgrantcjwatson: Thanks, and night.23:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!