[02:52] <blr> wgrant: think that's ready for review - sorry for the cjwatson sized diff.
[02:52] <wgrant> blr: Do you want to perhaps split the reindenting into another branch?
[02:53] <wgrant> Just create a fresh branch of devel, fix the indentation, and land that so the diff in this branch is reviewable.
[02:53] <blr> sorry, reindenting?
[02:53] <wgrant> productseries-setbranch.js at least
[02:54] <wgrant> Half the file is correctly reindented from three to four spaces.
[02:55] <blr> ah, sure.
[02:55] <blr> I'm going to blame emacs.
[02:58] <wgrant> Heh
[02:59] <blr> might as well lint it while I'm at it, this file would make douglas crockford sad.
[03:00] <wgrant> It certainly would.
[03:11] <blr> wgrant: ~blr/launchpad/trivial-fix-productseries-js-indentation
[03:11] <wgrant> blr: Too late :)
[03:11] <blr> refreshing is hard.
[03:14] <blr> wgrant: shall I resub that mp with a dependant branch, or wait for the merge.
[03:15] <wgrant> blr: Land the reindentation, then merge it into your main branch, resolve the conflicts, commit and push.
[03:16] <wgrant> (there isn't really a "wait for the merge" step, since buildbot runs *after* the merge)
[03:21] <wgrant> cjwatson: Ah, hm. Git MPs live under their target ref, but their target ref may no longer exist.
[03:21] <wgrant> eg. the launchpad:test MP on https://code.launchpad.net/launchpad/+activereviews
[10:21] <cjwatson> wgrant: Mm, it might make sense to move those directly under GitRepository, indeed.
[10:22] <cjwatson> And it would make the URLs a little less obnoxious ...
[11:40] <cjwatson> wgrant: Will be much easier after git-repository-delete lands, since that incidentally needed to add some MP-related properties to GitRepository.
[11:41] <wgrant> cjwatson: Ah good.
[11:55] <wgrant> cjwatson: I'd not really be concerned about leaving redirects.
[12:41] <cjwatson> wgrant: Perhaps not.
[21:08] <blr> wgrant: thank you for the thorough review!
[22:54] <blr> wgrant: cjwatson: this looks potentially useful https://github.com/DesertBus/sockjs-twisted/
[22:55] <blr> sockjs seems to have a sensible approach to degrading transports - haven't used it in earnest however.
[22:56] <cjwatson> entirely new to me :)
[22:58] <blr> cjwatson: anecdotally better maintained and more robust than socket.io
[23:54] <wgrant> blr: Do my issues/suggestions on the MP make sense?
[23:56] <cjwatson> https://code.launchpad.net/~cjwatson/canonical-is-puppet/webhooks-proxy-tweaks/+merge/259558
[23:56] <cjwatson> And now to bed.
[23:56] <wgrant> cjwatson: Thanks, and night.