=== zz_natorious is now known as natorious === natorious is now known as zz_natorious [12:45] smoser: Thanks for merging the Azure walinuxagent replacement stuff. :) === Odd_Blok1 is now known as Odd_Bloke [12:49] smoser: We've realised that we're lacking a way of turning this on without using user-data; do you have any recommendations about how to make it configurable using something we can include in the image build? === rangerpbzzzz is now known as rangerpb === zz_natorious is now known as natorious === natorious is now known as zz_natorious [13:48] Odd_Bloke, the datasource config shoudl suffice [13:49] smoser: How would we change that config at image build time? [13:49] /etc/cloud/cloud.cfg.d/azure.cfg === zz_natorious is now known as natorious [16:00] Odd_Bloke, around ? [16:01] wonder if you have some time to look at https://code.launchpad.net/~bbaude/cloud-init/rh_subscription/+merge/259159 with rangerpb . he's just getting head around unit tests and mock and the things there used checking of log, which seems less than ideal. wondered if you had some other suggestions. [16:02] thanks smoser Odd_Bloke happy to hear what you would prefer, etc === natorious is now known as zz_natorious === zz_natorious is now known as natorious [18:50] Hi All, I have two remaining issues with a CentOS 7 image running cloud-init 0.7.7. [18:51] First, pre-networking fails with a python error "No Such File or Directory, but I can't figure out which file it's looking for. [18:51] Second, cc-locale fails, but doesn't provide any more detail. [18:53] Err, my bad - cc_locale. As I doubt I'll ever use a VM that isn't in English, I'm not sure that one matters a whole lot, but while I'm here asking questions, I might as well ask about it. [19:10] Sorry. I had to take a phone call. Here's a pastebin of the python error in pre-networking: http://pastebin.com/sKBevg5k [19:14] smoser: Rebuilding the CentOS 7 image without LVM worked like a charm. The xfsprogs was, in fact, installed by default, even on a Minimal System configuration. I appreciate your insights on the matter. [19:16] dbuechler, not sure on the selinux... [19:16] would have to poke more. [19:16] Rather, the xfsprogs *package* was installed by default... I'm a native English speaker. I promise. [19:16] can you pate the whole cloud-init.log ? [19:16] and cloud-init-output.log ? [19:17] unless you're concerned about sensitive info there. [19:18] Sure. Curiously, cloud-init.log was empty. Cloud-init-output, I'll paste. I'll just redact anything critical. [19:20] cloud-init.log being empty is not good. its probably related to you needing to configure logging. [19:27] smoser: Uh-oh. Looks like I have a problem with my cloud. It appears one of my controller nodes may be down. I'll get that information for you as soon as I can. It may be a couple of hours. I'll paste cloud-init-output, verify cloud-init.log is still empty and then probably paste my cloud.cfg file. [19:28] k. === natorious is now known as zz_natorious === zz_natorious is now known as natorious [20:35] smoser: rangerpb: Around for a little while now, will take a quick look. [20:35] thanks Odd_Bloke [20:42] rangerpb: I assume GoodTests and BadTests are happy-path/bad-path? [20:43] correct === natorious is now known as zz_natorious === zz_natorious is now known as natorious === natorious is now known as zz_natorious === zz_natorious is now known as natorious [21:18] smoser: rangerpb: I can't decide how I feel about the checking of log; it is a kind of contract that the unit under test has with the end user. [21:18] But it's also the sort of test that can end up being very brittle. [21:18] yeah it is brittle due to changing of error messages == failed tests [21:19] rangerpb: I wonder if perhaps relaxing the checks to just "did we log something at info level" and "did we log something at warn level" might be a good compromise? [21:21] the log is definitive which is why I put it in there. im thinking either your suggestion or remove it completely and depend on counting calls to functions, etc [21:21] i suppose i could set some test vars in the code which are bool and I could check those [21:22] like finishing sucessfully or not, prefer that? [21:22] rangerpb: That doesn't sound quite as good; you could move the logging out to log_success() and log_failure() functions, and check that those are called? [21:23] you mean the actual calls to the logger? [21:23] I mean something like: [21:23] def log_success(): [21:23] LOGGER.info('rh_subscription plugin completed successfully') [21:23] yeah [21:23] i could do that [21:24] And then we aren't testing the messages, just that the high-level communication to the user is happening. [21:24] sure [21:24] if you are comfy with that, i will do that [21:25] rangerpb: Thanks. :) [21:46] rangerpb: Just added a few more comments. :) === natorious is now known as zz_natorious [21:48] cool thanks man === zz_natorious is now known as natorious === natorious is now known as zz_natorious === zz_natorious is now known as natorious === natorious is now known as zz_natorious === zz_natorious is now known as natorious === natorious is now known as zz_natorious === rangerpb is now known as rangerpbzzzz