[00:14] axw_: #1441478 when you say it "bails if any of the instances cannot be found", are you talking about the txn.DocExists assert in the upgrade step? [00:14] Bug #1441478: state: availability zone upgrade fails if containers are present [00:14] thumper: can you recall what happens in jujud panics in it's Run() method - will the upstart service restart the agent? [00:15] ah yes i think it does [00:19] wallyworld: can we chat earlier today? [00:19] wallyworld: and yes, upstart restarts [00:19] sure, free whenever [00:19] kk, just making some toast, with you shortly [00:25] wallyworld: in our hangout now [01:15] waigani: was taking my daughter to school, looking now [01:19] waigani: I mean the azFunc function may return environs.ErrNoInstances [01:19] axw_: ah right, okay thanks [01:21] I've setup maas with a few nodes on my laptop to test, got juju bootstrapped, but after a destroy env and rebootstrap I've run afoul of #1412621 [01:21] Bug #1412621: replica set EMPTYCONFIG MAAS bootstrap [01:22] so looking at the original bug, but ironing out maas issues along the way [02:02] Bug #1459885 was opened: harvest mode setting not used by container provisioner [02:02] wallyworld: 1:1? [02:02] oh yeah [02:12] https://github.com/juju/juju/pull/2447 [02:12] can I get a review on this [02:12] it shits me to tears every time I got to fix a bug in one of our libraries [02:13] i find that juju is lagging behind using fixes that have landed in it by months [02:16] thumper: waigani http://reviews.vapour.ws/r/1810/ [02:16] all the on call reviewers are in the EU timezoen today [02:16] do you have a second to take a look [02:17] davecheney: it's just an dependencies update? [02:17] s/an/a [02:17] yup [02:17] LGTM [02:17] danka [02:28] if only there were some way to automatically pull from the head revision, so we'd always get all the new fixes.... [02:29] nah, that leads to madness [02:29] and irreproducible builds [02:29] what i don't understand is [02:29] you can freeze release branches [02:29] when I land a fix on juju/tesing [02:29] it's because I need it to fix a bug in juju [02:29] ]I don't understand why we freeze a development branch, though [02:29] who is landing fixes on juju/testing that doesn't need them ? [02:30] davecheney: probably people working on the charm store etc [02:30] also, shouldn't it be obvious in the commit log? L) [02:30] :) [02:33] natefinch: it's generally accepted pulling tip of your dependencies is bad - but Go does a lot of things I disagree with :-) [02:37] wallyworld: I guess the problem is that we don't have CI running across all tests that use our own dependencies, so in theory, changing github.com/juju/testing could break charm store if we only test the change in juju-core [02:38] wallyworld: otherwise, really, it's not a dependency.... it's just our code. Anymore than github.com/juju/juju/agent is a "dependency" of github.com/juju/juju/state ... [02:38] natefinch: yeah, the Go approach works ok if you consider all the source code in the entire repo part of your project, which is what googles does [02:38] but for shared libraries not so well [02:39] wallyworld: we probably should, since otherwise we can get into a state where the charm store makes a change to testing for its needs, and then when juju-core updates, that change is incompatible with our own code [02:40] the overriding facror though needs to be reproducable builds [02:40] ....for release branches [02:40] and proper dependency management [02:40] not master [02:40] nobody is reproducing builds off master [02:40] hmmm [02:41] let's add this to the "discuss over several red wines" list [02:41] haha === kadams54 is now known as kadams54-away [02:41] the more the better :-) [02:41] someday, someone will actually be able to explain to me what "proper dependency management" means. Because everyone seems to have different - usually fairly fuzzy and not actionable - ideas about it. [02:44] repeatable builds, explicitly choosing the version/revno of the lib you want to link to/ build against, and a way to manage and track that === kadams54-away is now known as kadams54 [02:45] so, like godeps [02:52] natefinch: well, they are going to have very bad day when I land my refactor [02:54] davecheney: what are you refactoring? [02:54] https://launchpad.net/bugs/1459064 [02:54] Bug #1459064: worker/leadership: data races in test and code [02:55] ahh awesome [02:55] davecheney: not sure who they is, and why that would make them have a bad day [02:57] imma in your package, breakin your api [02:58] see, you're not supposed to do that :) [02:59] what if your api is not thread safe [02:59] time for v2 [02:59] and the package is supposed to be used in a multithreaded manner ? [03:00] heh ouch [03:00] then you screwed up. I guess in that case, you break the API and then because everyone's pulling tip, they are helpfully given compile errors that tell them they need to update their code because the old code is totally borked. [03:01] as opposed to when you're pinning revisions and you go on forever using that old racy P.O.S. code [03:01] sounds like youre scrrewed either way [03:01] have fun [03:01] Yes. but I'd rather know than go on thinking I'm ok [03:32] Bug #1459288 changed: TestWriteTokenReplaceExisting fails [03:32] Bug #1459616 changed: 'juju status' timestamps should use rfc3339 or ISO8601 === kadams54 is now known as kadams54-away [04:08] Bug #1459912 was opened: juju agent opens api when upgrade is pending === kadams54-away is now known as kadams54 [04:12] http://reviews.vapour.ws/r/1813/ === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === mup_ is now known as mup [05:12] axw_: can i please get a trivial review? http://reviews.vapour.ws/r/1817/ [05:12] looking [05:16] axw_, wallyworld: Here is the PR for #1441478 http://reviews.vapour.ws/r/1818/ I've hit EOD trying to manually test this on maas (hit other maas bugs). So I can follow up with manual testing [05:16] Bug #1441478: state: availability zone upgrade fails if containers are present [05:16] waigani: ty [05:17] waigani: are these maas bugs known? do you need to report them? [05:17] wallyworld: actually yes they are [05:18] oh joy, makes it hard for us [05:18] axw_: ty for review, i need to head to doctor to get more cholesterol medicine, will review your tags one when i get back [05:18] thanks [05:19] wallyworld: thumper has given me some other maas bugs to look at while I'm in maas land - so I'll have a maas(ive) bug list to keep going on next week :) [05:19] waigani: yeah, i told him to give you that one :-P [05:19] thanks :/ [05:19] anytime :-) [05:19] figured you were on a roll [05:19] heh [05:19] the right man for the job [05:20] more like a tumble .... [05:21] but good to get the MAAS knowledge [05:22] waigani: LGTM, thanks [05:23] axw_: wow, quick thanks :) [05:49] wallyworld: please see my reply on the lease change, when you're back [07:15] axw_: thanks for reply, ship it i reckon [09:00] Fledgling MAAS cluster: PDU, switch, plus two proliant servers [09:00] https://www.dropbox.com/s/fvmz7aj5lsvk0pb/2015-05-29%2009.55.44%20HDR.jpg?dl=0 [09:00] dooferlad: ^^ [09:06] dimitern: https://www.dropbox.com/s/fvmz7aj5lsvk0pb/2015-05-29%2009.55.44%20HDR.jpg?dl=0 [09:24] good morning [09:25] voidspace: do the proliants have bmcs, or is that what the pdu is for? [09:33] mwhudson: the proliants have an API that you can poke over one of their network interfaces, but voidspace judged that engineer time to get that doing what we wanted vs cost of a PDU favoured shopping over typing [09:34] mwhudson: it would be interesting to play with one at some point - apart from being larger than a NUC, if we can get the RESTful API doing what we need, they will be great for a home MAAS [09:34] ah not ilo or ipmi or anything like that? [09:36] mwhudson: I belive it is iLO [09:38] huh apparently maas only supports the kind of ilo you get in moonshots? [09:39] I'm sure it's possible to get it working [09:39] a [09:39] a PDU seemed the path of least resistance though [09:39] and means I can plug other things in - like my older N36 proliant [11:22] wallyworld: ping [11:30] waigani: HI [11:30] wallyworld: hey, just saw your email - pushing up a targeted PR to 1.24 [11:31] waigani: you rock, thank you [11:32] wallyworld: the bug was in a 1.22 upgrade step - hence the 1.22 target. I intended to forward port up each version. Should I also target 1.23? [11:37] wallyworld: landing on 1.24: https://github.com/juju/juju/pull/2456 [11:50] waigani: sorry, was afk, bit of an emergency here. but if you've proposed for 1.22, mat was well do 1.23 as well [11:50] thanks for 1.24, that's great === psivaa is now known as psivaa-lunch [13:52] Bug #1460071 was opened: relation-set --file ignores --format [14:24] dooferlad: ping [14:24] voidspace: pong [14:25] dooferlad: I'd like to setup a network for my maas - and I'd like you to help if you can :-) [14:25] sure, give me 5 minutes to finish this review [14:25] I have a switch plus cables and spare ethernet port on my desktop [14:25] sure [14:25] and maas running on my desktop [14:31] Bug #1460087 was opened: quickstart deployment fails to add relations when bootstrap goes "down" [14:36] voidspace: right, what do you want to know? Should we jump in a hangout? [14:37] dooferlad: hangout is good [14:37] dooferlad: sapphire? [14:38] voidspace: yep [14:38] I'm there [14:39] voidspace: so am I... did you hit join? That is my usual problem. [14:39] dooferlad: juju-sapphire? [14:39] dooferlad: I'm in [14:40] "waiting for people to join this video call..." [14:40] I'll leave and re-join === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [15:56] It's a good thing we use *_test packages to only test the exported interface of an API: https://github.com/juju/juju/blob/master/upgrades/export_test.go [15:56] s/API/package/ [16:19] Bug #1460071 changed: relation-set --file ignores --format [16:31] dimitern: struggling to join the conference [16:31] dimitern: the number on the event for London is wrong [16:40] voidspace, hey, I won't manage [16:40] voidspace, but if you can, please do and we'll chat later [16:41] dimitern: it's been cancelled - to be reconvened [16:41] dimitern: was a terrible connection :-/ [16:57] voidspace, ok, thanks for the heads up === kadams54 is now known as kadams54-away === redelmann is now known as rudi|LuNcH [17:35] ericsnow: ping? === rudi|LuNcH is now known as redelmann === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [18:34] Bug #1460171 was opened: Deployer fails because juju thinks it is upgrading [18:40] Bug #1460175 was opened: apiserver_test authhttp_test SetUpTest.debugLogSuite failed === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [19:13] man I love unit tests. I don't know how I ever wrote code that worked without them. === kadams54 is now known as kadams54-away [19:28] any reviewers around to have a look at http://reviews.vapour.ws/r/1821/ ? this (hopefully) fixes the critical bugs#1449054 and #1452221 [19:28] fwereade, fyi ^^ [19:28] * dimitern @eod [19:32] cherylj: sorry, I totally missed your ping [19:39] mm, chaining hooks seems to be something less trivial than expected [19:40] ericsnow: np, I answered my own question :) [19:40] :) [19:41] Bug #1460184 was opened: Bootstrapping fails with Maas on Ubuntu Vivid [19:50] once again my isp did not show to install the upgrade, if I did not work at home I would already have lost 2 work days waiting for them [20:38] people who write functions that take 5 strings should be flogged === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away [22:35] Bug #1459616 was opened: 'juju status' timestamps should use rfc3339 or ISO8601 [22:41] cherylj: thanks for revising that === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away