[00:22] <wgrant> blr: Does it have a diff yet?
[00:22] <blr> wgrant: ooh, yes.
[00:22] <blr> I had given up
[01:04] <wgrant> blr: Why isn't a nav cursor added on comment navigation?
[01:06] <blr> wgrant: if the comment is in the edit state, it looks rather ugly.
[01:07] <blr> decided it was better left out, it really makes more sense when you have a specific lineno at any rate I think
[01:08] <blr> hmm actually the same would apply for a saved comment - given it intrudes into the left hand margin
[01:08] <wgrant> Ah, hm.
[01:09] <blr> factory.makePreviewDiff(size='large') and add a few comments perhaps
[01:10] <blr> see what you think. I think it is probably okay just there for the code navigation.
[01:11] <blr> wgrant: not related to this branch, but do you think we need a different branch location widget for git repos?
[01:11] <blr> or should the existing branch location widget support both
[01:15] <blr> context, linking to existing git repo
[01:17] <wgrant> blr: I know the widget you're talking about, but I don't quite understand the question.
[02:43] <blr> wgrant: hmm, I'll try to clarify, in the search modal, should we list both results for bzr and git, or should we handle the bzr/git cases separately with different widgets
[02:44] <wgrant> blr: They need to be different widgets.
[02:44] <wgrant> For one thing it'd be an awkward widget to achieve.
[02:44] <wgrant> For another it'd be quite confusing, and the UI should be separated anyway.
[02:44] <blr> wgrant: yep, agreed - was just wondering if there were cases where it would be convenient to see both (fairly certain that widget is used elsehwere)
[02:45] <wgrant> It's unlikely you'd ever want to search both.
[02:45] <wgrant> It should only be used in one or two places atm.
[02:45] <wgrant> And they all need to be fixed for the git/bzr split anyway
[02:45] <blr> yep
[05:29] <blr> wgrant: hmm weird, working in chrome.
[05:30] <wgrant> blr: Firefox here, maybe it's special.
[05:30] <blr> I'll have a look
[05:32] <blr> wgrant: working for me in FF O.o
[05:32] <blr> anything in the console?
[05:32] <wgrant> blr: Ah, it was because the comments were unsaved.
[05:33] <wgrant> Hmm.
[05:33] <blr> if an input has focus none of the keybindings work
[05:34] <wgrant> blr: The comment navigation doesn't consider drafts to be comments, but the top hunk header is considered to be one.
[05:38] <blr> wgrant: is navigation between drafts useful?
[05:38] <wgrant> blr: I think it's weird that they appear the same but don't navigate the same.
[05:39] <blr> wgrant: the problem is the dom node collection isn't refreshed, otherwise the nav code would work for them I think.
[05:39] <blr> I'll find the callback, should be easy to fix
[05:40] <wgrant> Ahh
[05:48] <blr> wgrant: fixed
[05:48] <wgrant> blr: Yay
[05:48] <blr> well, still including the first hunk, not sure wtf is going on there.
[05:49] <wgrant> Yeah, that's an odd one.
[05:49] <blr> but the drafts are included now
[05:49] <wgrant> I'd expect the first *file* header.
[05:49] <blr> will debug
[05:49] <wgrant> Neither should happen, but I don't see how first hunk could :)
[05:49] <blr> yeah, very weird.