gsamfira | so for anyone that cares: http://blogs.msdn.com/b/looking_forward_microsoft__support_for_secure_shell_ssh1/archive/2015/06/02/managing-looking-forward-microsoft-support-for-secure-shell-ssh.aspx | 00:00 |
---|---|---|
gsamfira | still waiting for the announcement saying that windows is adopting the linux kernel | 00:00 |
wallyworld | waigani: thanks for fixing maas bug, auto pilot guys will be happy | 00:09 |
menn0 | wallyworld: are you sure that not fixing bug 1457225 for 1.24 is a good idea? | 00:10 |
mup | Bug #1457225: Upgrading from 1.20.9 to 1.23.3 works, but error: runner.go:219 exited "machiner": machine-0 failed to set status started: cannot set status of machine "0": not found or not alive <cts> <sts-stack> <upgrade-juju> <juju-core:Triaged> <https://launchpad.net/bugs/1457225> | 00:10 |
menn0 | wallyworld: seems pretty serious | 00:10 |
wallyworld | menn0: from what i'm told, not really reproducable so the plan is to include in a point release if needed | 00:11 |
menn0 | wallyworld: let me have a quick poke at it | 00:12 |
wallyworld | ok, ty | 00:12 |
menn0 | wallyworld: i can guess what it is | 00:12 |
waigani | wallyworld: welcome. I've put my notes on the wiki, so next time will be a bit quicker: https://github.com/juju/juju/wiki/Update-Launchpad-Dependency | 00:12 |
wallyworld | waigani: ty | 00:12 |
wallyworld | menn0: i haven't looked into the bug in detail, just going on conversations, so if you can guess, that would be good | 00:12 |
menn0 | wallyworld: ok | 00:13 |
wallyworld | natefinch-afk: when you are around, can you look at this bug which arose with the move conf files from logs work? https://bugs.launchpad.net/juju-core/+bug/1461246 | 00:50 |
mup | Bug #1461246: UpgradeSuite.TestUpgradeStepsHostMachine consistently fails on utopic <blocker> <ci> <regression> <unit-tests> <utopic> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1461246> | 00:50 |
mup | Bug #1461339 was opened: rsyslog on bootstrap node causing instability <juju-core:New> <https://launchpad.net/bugs/1461339> | 01:01 |
=== natefinch-afk is now known as natefinch | ||
natefinch | wallyworld: I'll TAL | 01:18 |
wallyworld | ty | 01:18 |
menn0 | wallyworld: I have been unable to reproduce bug 1457225 and i've requested more information | 01:19 |
mup | Bug #1457225: Upgrading from 1.20.9 to 1.23.3 works, but error: runner.go:219 exited "machiner": machine-0 failed to set status started: cannot set status | 01:19 |
mup | of machine "0": not found or not alive <cts> <sts-stack> <upgrade-juju> <juju-core:Incomplete by menno.smits> <https://launchpad.net/bugs/1457225> | 01:19 |
menn0 | wallyworld: dropping it from 1.24 is probably ok | 01:19 |
wallyworld | thanks menn0, that matches my understanding also | 01:19 |
menn0 | wallyworld: it's not what I thought it was at least. it looks like the upgrade started but never completed for some reason. | 01:19 |
wallyworld | yeah | 01:19 |
wallyworld | good to check though | 01:19 |
anastasiamac | axw_: allowing only count for storage constraints is only applicable to storage-add hook tool, rite? | 01:20 |
axw_ | anastasiamac: correct. "juju storage add" should be able to do whatever | 01:20 |
anastasiamac | axw_: tyvm :D | 01:20 |
axw_ | anastasiamac: "storage-add" should just take a name and optional count, and take the rest from constraints | 01:20 |
menn0 | natefinch: I believe that the failing upgrade test runs all the upgrade steps | 01:21 |
menn0 | natefinch: it probably doesn't need to | 01:21 |
menn0 | natefinch: it's an old one | 01:21 |
natefinch | menn0: ahh interesting | 01:21 |
menn0 | natefinch: mocking out the actual running of the upgrade steps and just confirming that they would be run is probably enopugh | 01:21 |
menn0 | natefinch: the steps and upgrade running infrastructure is all tested comprehensively elsewhere | 01:22 |
* menn0 has to go for a bit | 01:22 | |
wallyworld | sinzui: tell me i'm crazy - i run "juju get-env" and the output includes secrets. why shouldn't we be masking those out by default? | 01:39 |
anastasiamac | wallyworld: :( | 01:49 |
mup | Bug #1461342 was opened: unit storage add should only accept count as constraint <juju-core:New for anastasia-macmood> <juju-core 1.24:In Progress by anastasia-macmood> <https://launchpad.net/bugs/1461342> | 01:49 |
natefinch | wallyworld: the two tests that are marked as failing pass just fine on my machine (and I'm on utopic). That specific test, when I run it, just says it's skipping all the copying of files, because they don't exist. But on the CI machine, it says there's one there that it doesn't have permission to remove. Seems like an environmental problem - there's a file in /var/log/juju/ that shouldn't exist. | 02:07 |
natefinch | wallyworld: given that it's only failing on utopic makes me suspicious that it's just that CI machine that has the errant file lying around, since the code isn't any different for different series. | 02:07 |
wallyworld | natefinch: that makes sense i think | 02:08 |
wallyworld | maybe mark the bug with a comment | 02:08 |
wallyworld | natefinch: also, i recall a change with "-" in the branch? | 02:08 |
wallyworld | with rsyslog config? | 02:09 |
wallyworld | i just saw this, could be related? http://pastebin.ubuntu.com/11533025/ | 02:09 |
wallyworld | seems there's an extra "-" in front of machine-1 | 02:09 |
natefinch | weird... might have been an errant typo | 02:09 |
wallyworld | natefinch: also. maybe the upgrade step should just skip files it can't move? witha warning? | 02:10 |
wallyworld | more robust that way | 02:10 |
menn0 | wallyworld, natefinch: i was going to say what wallyworld just said | 02:10 |
menn0 | you don't want an upgrade completely failing b/c of this | 02:11 |
natefinch | wallyworld: yeah, that makes sense. No need to kill the upgrade step.. the whole reason we're moving the files is so that if you blow away the folder, you don't mess up our config... but we don't really care if the old files are there anymore or not. | 02:11 |
wallyworld | yep | 02:11 |
natefinch | I'll make a PR | 02:13 |
wallyworld | natefinch: https://bugs.launchpad.net/juju-core/+bug/1461354 - i'm working another bug atm, but for your day tomorrow, if i don't get to this - could you look at it from the perspective it could be caused by the "-" change? | 02:15 |
mup | Bug #1461354: invalid tag and panic seen in state server logs <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1461354> | 02:15 |
natefinch | wallyworld: absolutely... though I don't know what the "-" change is, but I can look for it. | 02:16 |
natefinch | oh, actually, I know what you're talking about | 02:16 |
wallyworld | natefinch: in the log move work - you change rsyslog config | 02:16 |
wallyworld | sorry, didn't know how to explain :-) | 02:16 |
natefinch | yeah yeah... I made the Namespace not include the - in the field, but added it to the logic of writing out instead | 02:17 |
wallyworld | i may be jumping to conclusions | 02:17 |
wallyworld | but seems like a reasonable place to start looking | 02:17 |
natefinch | it does seem suspicious | 02:17 |
mup | Bug #1461354 was opened: invalid tag and panic seen in state server logs <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1461354> | 02:19 |
natefinch | OMG export_test is the worst | 02:27 |
natefinch | is the bot broken? | 02:41 |
natefinch | ahh maybe just slow | 02:45 |
natefinch | maybe it's just the reviewboard integration that's broken | 02:48 |
natefinch | wallyworld, menn0: care to do a very quick review on github? https://github.com/juju/juju/pull/2476 | 02:49 |
wallyworld | ok | 02:49 |
mup | Bug #1461358 was opened: Resource tags should be periodically updated to reflect reality <storage> <juju-core:Triaged> <https://launchpad.net/bugs/1461358> | 02:49 |
wallyworld | menn0: you and i obviously think simiarly | 02:54 |
menn0 | wallyworld: well in one case. | 02:55 |
menn0 | then I found all the trivial stuff and you found what could be actual problems :) | 02:55 |
wallyworld | well, you saved me from the gc.IsNil things :-) | 02:55 |
natefinch | So, I almost put a comment in the actual code about not using PatchValue. I'm not embedding whatever base suite has that... adding it would run a ton more code for the tests for no reason, and would actually add more lines of code to the file.... all to avoid doing my own defer. | 02:56 |
natefinch | As for warning.... I don't know? I guess I assumed that if we don't care if the old file is there.... we don't care. No need to warn. Warn is something I feel is like "this may indicate there's a problem you should look at" .... but a file we can't delete that we don't read or care about is not really a problem for Juju. | 02:58 |
natefinch | I started to write it as Warning and then changed to Info. I'm only like 40% committed to it though, so if you guys think warning is more appropriate, that's fine. | 02:58 |
menn0 | natefinch: that BaseSuite embeds CleanupSuite which has PatchValue | 02:59 |
natefinch | menn0: weird, I swear I tried to type it in and it complained at me. Maybe I typoed it,. | 02:59 |
natefinch | menn0: so it does... my autocomplete was not finding it for some reason. | 03:03 |
natefinch | menn0, wallyworld: Fixes ready, do you want me to make the log message Warning? | 03:05 |
wallyworld | yes please | 03:06 |
natefinch | ok | 03:06 |
natefinch | updated: https://github.com/juju/juju/pull/2476 | 03:10 |
* thumper is getting pretty grumpy at all the intermittent failures with the bot | 03:13 | |
wallyworld | waigani: ocr? trivial one please for ci blocker http://reviews.vapour.ws/r/1843/ | 03:19 |
waigani | wallyworld: shipit | 03:21 |
wallyworld | tyvm | 03:21 |
thumper | YAY (NOT) new intermittent test failure: filter_test.go:146: s.assertAgentTerminates(c, f) | 03:25 |
thumper | uniter/filter | 03:25 |
wallyworld | thumper: you running vivid? | 03:27 |
wallyworld | our tests on vivid are worse | 03:28 |
mup | Bug #1461150 changed: lxc provisioning fails on joyent <blocker> <ci> <joyent-provider> <lxc> <regression> <juju-core 1.24:In Progress by wallyworld> <https://launchpad.net/bugs/1461150> | 03:37 |
mup | Bug #1461246 changed: UpgradeSuite.TestUpgradeStepsHostMachine consistently fails on utopic <blocker> <ci> <regression> <unit-tests> <utopic> <juju-core 1.24:In Progress by natefinch> <https://launchpad.net/bugs/1461246> | 03:37 |
natefinch | wallyworld, menn0: care to check my update? https://github.com/juju/juju/pull/2476/files | 03:44 |
wallyworld | ok | 03:44 |
wallyworld | natefinch: +1 | 03:45 |
natefinch | awesome | 03:45 |
wallyworld | axw_: you resources pr - the provisioner version bump - it should be ok with an older env, and upgrades should work too, from what i can tell. i think? | 03:51 |
axw_ | wallyworld: the provisioner has a bit of code that loops while it gets a NotImplemented error | 03:53 |
axw_ | so I think it should be fine | 03:53 |
wallyworld | ok | 03:53 |
thumper | wallyworld: no | 03:54 |
thumper | wallyworld: and that failure is from the bot | 03:54 |
wallyworld | ah ok | 03:54 |
wallyworld | axw_: lgtm, love the deleted code, much cleaner | 03:57 |
axw_ | wallyworld: cool, thanks | 03:57 |
mup | Bug #1461385 was opened: apiserver/instancepoller: data race in test <juju-core:Confirmed for dave-cheney> <https://launchpad.net/bugs/1461385> | 05:25 |
mup | Bug #1461393 was opened: worker/deployer: multiple data races <juju-core:Confirmed for dave-cheney> <https://launchpad.net/bugs/1461393> | 05:55 |
axw | wallyworld: https://github.com/axw/juju/blob/resource-tags-units-storagename-etc/environs/tags/tags.go | 07:38 |
axw | wallyworld: quick look over please, it was missing in the diff before | 07:38 |
wallyworld | ok | 07:39 |
axw | overzealous .gitignore | 07:39 |
wallyworld | axw: actually i did wonder about not seeing that file in the PR | 07:39 |
wallyworld | axw: LGTM | 07:40 |
axw | ta | 07:40 |
fwereade | anyone here got a graph theory background? | 08:43 |
anastasiamac | fwereade: the answer depends on why u r asking :D | 08:49 |
fwereade | anastasiamac, I'm wondering if there's any literature I should look at regarding *potential* cycles | 08:49 |
fwereade | anastasiamac, i.e. I have a graph built up from a bunnch of successor lists which do not always agree, and may thus imply cycles | 08:50 |
fwereade | anastasiamac, I know that each node appears at most once in each successor list | 08:50 |
Spads | fwereade: so you're looking to run Tarjan's algorithm on your data set? | 08:50 |
fwereade | Spads, not quite | 08:51 |
fwereade | Spads, I'm lookinng to determin whether a data set will produce the same tarjan sort for all possible extensions of the original data | 08:51 |
Spads | ahhhh | 08:51 |
fwereade | Spads, given that the inputs can change in somewhat restricted ways | 08:51 |
fwereade | Spads, I thought I had something and, well, the failure rate on a workload designed to trigger the problem is down from 1 in 10k to 1 in 2m | 08:52 |
fwereade | Spads, which is sort of good | 08:52 |
fwereade | Spads, but sorta implies that I've missed something subtle, hence wondering if anyone remembers any related literature or anything :) | 08:53 |
Spads | fwereade: this is outside my two-decade-old memory of my discrete methods/graph theory classes. Let me poke someone who may know | 08:54 |
fwereade | Spads, tyvm | 08:54 |
fwereade | Spads, no rush, I have a meeting in a moment anyway | 08:55 |
Spads | fwereade: yeah, she may need to go dig a bit anyway | 08:55 |
fwereade | Spads, cheers | 08:55 |
Spads | fwereade: are your rules aware of the tarjan weights of the nodes they're connecting to? | 08:57 |
dimitern | voidspace, it's just you and me today :) | 09:02 |
fwereade | Spads, I'm not aware of any weighting here | 09:03 |
dimitern | voidspace, ping | 09:09 |
voidspace | dimitern: sorry | 09:10 |
voidspace | dimitern: was helping wife with car!! | 09:10 |
voidspace | dimitern: omw | 09:10 |
dimitern | voidspace, np | 09:11 |
rogpeppe | anyone know what the Settings.NoProxy value means in github.com/juju/utils/proxy ? | 10:47 |
rogpeppe | evilnickveitch: here's as far as i've got so far: http://paste.ubuntu.com/11541062/ | 11:38 |
rogpeppe | evilnickveitch: i've got descriptions for everything now, at least | 11:38 |
evilnickveitch | rogpeppe, that looks good - I will update the table in docs accordingly | 11:45 |
rogpeppe | evilnickveitch: i could probably generate the table automatically from that table if you'd like - might save a bit of time | 11:45 |
rogpeppe | s/from that table/from that data/ | 11:45 |
evilnickveitch | rogpeppe, if you want to give that a go, i'm not stopping you :) the markdown syntax for tables is pretty straightforward | 11:47 |
rogpeppe | evilnickveitch: should only take a minute or two | 11:47 |
rogpeppe | evilnickveitch: i'm just formalising the defaults | 11:47 |
evilnickveitch | cool | 11:48 |
wallyworld | jam: got time for a brief chat about spec? | 12:13 |
rogpeppe | evilnickveitch: http://paste.ubuntu.com/11541625/ | 12:14 |
rogpeppe | evilnickveitch: gist.github.com doesn't like it though, so it may well be invalid md syntax | 12:14 |
rogpeppe | evilnickveitch: i left deprecated entries in there - you'll probably want to separate them out | 12:15 |
rogpeppe | evilnickveitch: this is better: https://gist.github.com/rogpeppe/c7ce1f02258a39898d37 | 12:16 |
jam | wallyworld: I'm meeting with alexis now, can I chat with you after 30min or so? | 12:16 |
wallyworld | sure | 12:16 |
rogpeppe | voidspace: i'm led to believe you might know something about github.com/juju/utils/proxy ... is that true? | 12:18 |
evilnickveitch | rogpeppe, yup, that will certainly do the job. thanks! | 12:18 |
rogpeppe | evilnickveitch: np | 12:18 |
rogpeppe | evilnickveitch: let me fix those multi-line descriptions first | 12:19 |
evilnickveitch | ok | 12:20 |
rogpeppe | evilnickveitch: this is better: https://gist.github.com/rogpeppe/8015a6c7122c85878b43 | 12:25 |
evilnickveitch | rogpeppe, it is. I will get this added shortly | 12:27 |
rogpeppe | evilnickveitch: it really needs default values for all the other rows too | 12:27 |
evilnickveitch | yes. I am not sure they all have them | 12:27 |
evilnickveitch | rogpeppe, AFAIR, some keys simply don't exist if they aren't specified | 12:27 |
rogpeppe | evilnickveitch: yeah, but at least all bool vals should document what the default bool is | 12:28 |
evilnickveitch | perhaps they should definitively say 'none' in that case | 12:28 |
evilnickveitch | agreed | 12:29 |
rogpeppe | evilnickveitch: FWIW this is the code i used to generate the table (and check consistency with the real code): http://play.golang.org/p/6ci9O6GOz3 | 12:29 |
evilnickveitch | rogpeppe, ok, thanks, i am sure that will be useful in the future too | 12:29 |
rogpeppe | evilnickveitch: the stuff after the ///// comment was pasted directly from the juju-core config code | 12:30 |
mup | Bug #1461529 was opened: juju upgrade-charm has no effect for subordinate charms <juju-core:New> <https://launchpad.net/bugs/1461529> | 12:41 |
wwitzel3 | ericsnow: ping | 12:45 |
Syed_A | Hello Folks, | 12:48 |
Syed_A | I am trying to deploy HA openstack keystone in 3 lxc nodes. | 12:49 |
Syed_A | I am getting this error: ERROR: grp_ks_vips: id is already in use | 12:49 |
voidspace | rogpeppe: I don't believe so, no | 12:56 |
rogpeppe | voidspace: ok, thanks | 12:56 |
voidspace | :-) | 12:58 |
voidspace | sorry | 12:58 |
mup | Bug #1461534 was opened: presence.$cmd {getLastError} taking 100ms <mongodb> <juju-core:Triaged> <https://launchpad.net/bugs/1461534> | 13:09 |
sinzui | mgz: I was about to try a reboot from the horzon console | 13:17 |
rogpeppe | evilnickveitch: this also adds information on which attributes are immutable: https://gist.github.com/rogpeppe/cff7976fbf56f135af4b | 13:17 |
* sinzui can move two jobs to another slave | 13:18 | |
evilnickveitch | rogpeppe, ah, useful! We may need to coordinate with web design again before making the table any bigger - there is precious little width to display the current info! | 13:19 |
rogpeppe | evilnickveitch: that's your domain :) | 13:19 |
evilnickveitch | I wish it were! But it is my domain to ask the people who can fix it, at least | 13:20 |
ericsnow | wwitzel3: pong | 13:35 |
natefinch | Syed_A: not a lot of open stack experts on here... try #juju | 13:35 |
wwitzel3 | ericsnow: hey, want to pair up? | 13:36 |
ericsnow | wwitzel3: yep | 13:36 |
wwitzel3 | ericsnow: going to moonstone now | 13:41 |
wwitzel3 | jam: ping, you still around? | 13:45 |
jam | wwitzel3: I'm 45 minutes past needing to help my son with homework, so I have to pretend I'm not here, sorry | 13:47 |
wwitzel3 | jam: understand completely :) | 13:47 |
perrito666 | we could do cooperative help with the homework and get you back faster? :p | 13:48 |
sinzui | natefinch: can you triage bug 1461339? I see several related bugs tagged “rsyslog”. This is also an older juju; the issue might be fixed in newer juju | 13:54 |
mup | Bug #1461339: rsyslog on bootstrap node causing instability <logging> <rsyslog> <juju-core:New> <https://launchpad.net/bugs/1461339> | 13:54 |
natefinch | sinzui: that sounds a lot like what happened a couple weeks ago with that big customer problem. I definitely think it's something we should be looking into addressing. This is really katco's dept though :) I'm just a code monkey now ;) | 13:57 |
sinzui | natefinch: If you feel it is still a real issue, then we now the issue medium, and if we want to fix it in 1.25, it is high | 13:58 |
sinzui | thank you natefinch | 13:58 |
katco | sinzui: tal | 13:58 |
wallyworld | natefinch: you going to look at bug 1461354? | 13:58 |
mup | Bug #1461354: debug-log EOF: invalid tag and panic seen in state server logs <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1461354> | 13:59 |
wallyworld | katco: you saw the credentials one in our fix - it's a one liner | 13:59 |
katco | wallyworld: eh? context pls! :) | 13:59 |
wallyworld | the cloudsigma crednetials leak bug we talked about this m orning | 14:00 |
wallyworld | it's a private bug on beta6 - a few hours ago they added a note to the bug | 14:00 |
katco | wallyworld: ah no i haven't looked at that | 14:00 |
wallyworld | we need to change one line of code to fix | 14:00 |
katco | wallyworld: ok, it sounds like it's proposed? | 14:01 |
wallyworld | proposed? | 14:01 |
wallyworld | oh on rb? | 14:01 |
katco | yeah | 14:01 |
wallyworld | not that i can see | 14:02 |
wallyworld | but i've been busy on other bugs and things sadly and it was past my official eod when i saw the comment and then i had soccer | 14:02 |
katco | wallyworld: ah ok. we'll try and get it fixed | 14:02 |
wallyworld | ty :-) | 14:02 |
wallyworld | past midnight here | 14:02 |
katco | wallyworld: yipes, gtb! | 14:03 |
wallyworld | will do, sorry for not fixing, thought it best to nag you at this stage of the evening :-) | 14:03 |
katco | wallyworld: definitely :) | 14:03 |
katco | wallyworld: share the load | 14:04 |
wallyworld | and the only other one is the critical debug log issue i discovered today | 14:04 |
wallyworld | debug log entries from machines != 0 are busted | 14:04 |
wallyworld | the logged tag seems to have an extra "-" prepended | 14:04 |
wallyworld | might? be syslog related, not sure | 14:05 |
natefinch | wallyworld: I think I know the exact problem | 14:05 |
wallyworld | awesome :-) so a fix is on the way? | 14:05 |
natefinch | wallyworld: yep | 14:05 |
wallyworld | tyvm :-) | 14:05 |
wallyworld | so we can get beta6 out today, yay | 14:06 |
wwitzel3 | cherylj: ping, need a review when you have a moment, http://reviews.vapour.ws/r/1798/ | 14:09 |
cherylj | wwitzel3: looking now, but I am not a graduated reviewer yet. | 14:18 |
mup | Bug #1461561 was opened: juju run fails with "Permission denied (publickey)" on manual provider <intermittent-failure> <manual-provider> <run> <juju-core:Triaged> <https://launchpad.net/bugs/1461561> | 14:24 |
wwitzel3 | cherylj: thats ok, it will help get the ball rolling, thank you | 14:32 |
natefinch | jw4: you around? | 14:51 |
jw4 | natefinch: indeed | 14:51 |
natefinch | jw4: what's up with juju action not taking the -e <env> flag until after the subcommand? It's different from every other command we have, where you can do "juju deploy -e <env> [charm]" for example, but for action it's juju action do -e <env> [action | 14:53 |
jw4 | natefinch: that's weird | 14:53 |
jw4 | natefinch: I suspect it's because all of our commands are subcommands, and we don't have any top level command code | 14:54 |
jw4 | natefinch: "bug" | 14:54 |
perrito666 | omg, how is it possible that the chrome hangouts plugin still does not accept multi account | 14:59 |
natefinch | abentley: addressed your concerns. Should be a pretty quick review. https://code.launchpad.net/~natefinch/juju-ci-tools/logrot/+merge/259750/+index | 15:42 |
abentley | natefinch: Thanks. On the phone. | 15:42 |
natefinch | abentley: np | 15:42 |
rogpeppe | anyone know which commit fixed the second issue mentioned in this comment? https://bugs.launchpad.net/juju-core/+bug/1339770/comments/2 | 15:42 |
mup | Bug #1339770: Machines are killed if mongo fails <canonical-is> <landscape> <maas-provider> <juju-core:Fix Released by wallyworld> <juju-core 1.18:Won't Fix> <https://launchpad.net/bugs/1339770> | 15:42 |
natefinch | man what I wouldn't give to have issues on github so when I fix a bug I don't have to go through and copy and paste all the bug data into the comments. | 15:56 |
natefinch | ericsnow: reviewboard doesn't seem to be picking up commits to 1.24... can you investigate? | 16:01 |
ericsnow | sure | 16:01 |
natefinch | wallyworld: fix for your issue: https://github.com/juju/juju/pull/2483 | 16:01 |
ericsnow | natefinch: is your 1.24 up-to-date? | 16:01 |
natefinch | ericsnow: ish? | 16:02 |
natefinch | ericsnow: I think I updated yesterday | 16:03 |
natefinch | cherylj: can you review this? https://github.com/juju/juju/pull/2483 fixes a bug I introduced here: https://github.com/juju/juju/pull/2458/files#diff-29cf702f1f3ee55354dc999b19a2e391R208 | 16:07 |
natefinch | (very quick review) | 16:07 |
cherylj | natefinch: yeah, I'm finishing up a review for wwitzel3, give me a couple minutes. | 16:08 |
natefinch | cherylj: np, thanks | 16:14 |
ericsnow | natefinch: re: reviewboard, I'm not seeing a problem | 16:15 |
ericsnow | natefinch: was it a particular PR? | 16:15 |
natefinch | ericsnow: oh, no, maybe something is just really slow... the review is posted now | 16:16 |
ericsnow | natefinch: k | 16:17 |
ericsnow | natefinch: yeah, looks like RB is a little slow right now | 16:17 |
natefinch | (where really slow might be anything greater than my patience level of ~20 seconds ;) | 16:17 |
abentley | natefinch: r=me. Shall I merge it for you? | 16:23 |
natefinch | abentley: yes please | 16:25 |
natefinch | abentley: thanks for all the time you spent reviewing the code. | 16:25 |
abentley | natefinch: You're welcome. Thanks for your follow-through. | 16:26 |
mup | Bug #1461605 was opened: juju action commands require -e in the "wrong" place <actions> <juju-core:New> <https://launchpad.net/bugs/1461605> | 16:45 |
mgz_ | gsamfira: bug 1455627 | 16:57 |
mup | Bug #1455627: TestAgentConnectionDelaysShutdownWithPing fails <ci> <intermittent-failure> <lxc> <test-failure> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1455627> | 16:57 |
gsamfira | mgz_: ahh. Cool. This was the only test that sometimes failed against Go 1.4.2 | 16:58 |
gsamfira | mgz_: tested on windows and Ubuntu. The rest all passed | 16:59 |
gsamfira | mgz_: also did a live test. Bootstrapped new env and deployed a noop charm | 17:00 |
gsamfira | on windows and ubuntu | 17:01 |
gsamfira | all worked fine | 17:01 |
mgz_ | cool | 17:01 |
gsamfira | mgz_: it should probably be tested for a couple of weeks in the CI before trusting that all is well, but initial tests looked okay :) | 17:02 |
=== kadams54_ is now known as kadams54-away | ||
=== kadams54-away is now known as kadams54_ | ||
rogpeppe | if anyone fancies a review, here's a change to environs/config that starts us down the road that will let us create sensible UI forms for environment config attributes: https://github.com/juju/juju/pull/2487 | 17:38 |
natefinch_ | gah... dammit ubuntu... first my screen freezes, now I reboot and my mouse cursor is invisible | 18:38 |
natefinch | at least reviewboard didn't drop all my comments on the floor... that's ncie | 18:41 |
perrito666 | natefinch: well if it makes you feel better, each time I use my kb after taking a bath 2 finger scroll goes crazy | 18:43 |
natefinch | That sounds like a euphemism for something | 18:43 |
natefinch | gsamfira: I'd like to see tests with multi-byte characters... I wonder if those "interleaved nulls" are really just UTF16 padding for ASCII characters. | 18:46 |
perrito666 | natefinch: that does not sound right at all | 18:48 |
natefinch | btw, evidently this was just released: https://github.com/aws/aws-sdk-go | 19:03 |
natefinch | "aws-sdk-go is the official AWS SDK for the Go programming language" | 19:04 |
natefinch | currently at "developer preview release" | 19:04 |
natefinch | https://aws.amazon.com/blogs/aws/developer-preview-of-aws-sdk-for-go-is-now-available/ | 19:05 |
perrito666 | natefinch: that sounds a lot like alpha :p | 19:06 |
natefinch | "we have moved our GitHub repository from the awslabs organization to aws/aws-sdk-go. This signifies that this SDK is no longer in an experimental state." | 19:06 |
natefinch | *shrug* | 19:06 |
natefinch | dammit git | 19:46 |
perrito666 | natefinch: dont complain or we will make youuse bzr | 19:48 |
natefinch | somehow it thought my branch was missing a whole buttload of commits... so it wouldn't let me repush | 19:50 |
perrito666 | did you rebase? | 19:55 |
natefinch | perrito666: yes, and this is what I got: https://github.com/juju/juju/pull/2483 | 19:56 |
natefinch | only the first and last commit are supposed to be there | 19:56 |
perrito666 | ah because rebasing usually results on you not being able to push your branch if you had before | 19:57 |
natefinch | that's ok, I just made a new branch and cherry-picked the right commits: https://github.com/juju/juju/pull/2489 | 19:57 |
perrito666 | taht makes no sense | 19:57 |
perrito666 | all the commits there (which are mine) are merged into 1.24 | 19:57 |
natefinch | cherylj: if you have a second, this is the same as the last one you reviewed, but with an added test. http://reviews.vapour.ws/r/1855/diff/# (the key to the test is the "" in NewRsyslogConfigWorker.... we have another test that does the same thing, but with a non-empty namespace, but no test with an empty one. | 19:58 |
perrito666 | natefinch: there, it is fine now | 19:58 |
perrito666 | seems like github was having a bad day | 19:59 |
cherylj | natefinch: looking now. | 19:59 |
natefinch | perrito666: not sure what "there" means... still looks wrong to me | 20:06 |
perrito666 | natefinch: odd, it looks ook to me | 20:07 |
perrito666 | hard refresh? | 20:07 |
natefinch | been trying that | 20:08 |
natefinch | even incognito says it's still wrong. It's ok. | 20:08 |
natefinch | that;s what the other PR is for. | 20:08 |
natefinch | only took a second, it's just annoying. | 20:08 |
perrito666 | natefinch: ah I am an idiot, I was seeing the new one | 20:09 |
natefinch | lol | 20:09 |
perrito666 | natefinch: also, there is an error in your rebase, perhaps a merge in the middle, you can see how one of your commits is at the beginning of the list and the other at the end | 20:09 |
perrito666 | in a proper rebase all your commits are at the end | 20:10 |
natefinch | I just did git pull --rebase *shrug* | 20:10 |
perrito666 | so do remember that for git there are the nodes and the tree all those commits are there because you are changing the shape of the tree for that branch | 20:10 |
natefinch | I don't know why there were any commits at all, given that I was on my own damn branch | 20:10 |
perrito666 | you need to take it lightly :) come to spend a couple of weeks here where everything works like s**t and you will see git with a different eye | 20:11 |
natefinch | lol | 20:11 |
natefinch | pretty sure the average sound level at my house has increased by about 20 decibels per child | 20:16 |
=== kadams54_ is now known as kadams54-away | ||
thumper | sinzui: ping | 21:22 |
thumper | or abentley ? | 21:22 |
abentley | thumper: pong | 21:23 |
thumper | abentley: hey there | 21:23 |
thumper | abentley: where are we on adding a CI test for race conditions? | 21:24 |
abentley | thumper: It's there. | 21:24 |
thumper | abentley: I don't see it in the emails | 21:24 |
abentley | thumper: http://juju-ci.vapour.ws/job/run-unit-tests-race/ | 21:24 |
abentley | thumper: It is in the emails, under Failed non-voting tests. | 21:25 |
thumper | abentley: ah, I see it now | 21:26 |
thumper | thanks | 21:26 |
thumper | hopefully we can make it voting next week | 21:26 |
abentley | thumper: That would be great. | 21:27 |
thumper | wallyworld: is the container provisioner fix being back ported? | 22:25 |
thumper | wallyworld: it should be | 22:25 |
wallyworld | thumper: sec | 22:26 |
wallyworld | thumper: not backported to 1.22 (CI didn't show an issue like it did for 1.24) and we are about the put 1.22.5 in trusty. But, there will almost certainly be a 1.22. release and as soon as that milestone is created, it will be backported | 22:28 |
* thumper nods | 22:29 | |
wallyworld | it only affects joyent | 22:29 |
thumper | ?! | 22:33 |
thumper | ah... no | 22:33 |
* thumper has read the bug, and I see it has been fixed... | 22:38 | |
* thumper goes to make coffee | 22:38 | |
thumper | WTF? ... | 23:49 |
thumper | ERROR while stopping machine agent: exec ["stop" "--system" "juju-agent-tim-testlocal"]: exit status 1 (stop: Method "Get" with signature "ss" on interface "org.freedesktop.DBus.Properties" doesn't exist) | 23:50 |
thumper | it did destroy the environment, but this is a bit worrying | 23:51 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!