| wgrant | blr: How's it going? | 00:26 |
|---|---|---|
| blr | wgrant: bit of a conundrum actually, zope testbrowser is apparently unable to set the disabled attribute on a control (set by js when the bzr setbranch form is hidden) | 00:30 |
| wgrant | blr: zope.testbrowser doesn't execute JavaScript. | 00:31 |
| blr | yep | 00:31 |
| wgrant | JS stuff should be testing using YUI3 unit tests. | 00:31 |
| wgrant | blr: Can you have a look at the buildbot failures soon to unblock landings? | 00:32 |
| blr | wgrant: sure | 00:33 |
| blr | wgrant: I suppose it doesn't matter, there's not much value in adding a new doctest. | 00:33 |
| wgrant | blr: Right, adjust existing doctests if need be, but avoid adding new bits. | 00:34 |
| wgrant | And don't attempt to test JS; it won't work. | 00:34 |
| blr | would be useful to look at moving new browser tests to phantomjs perhaps. | 00:36 |
| blr | wgrant: fixed the doctest, will grab some lunch and look at the smoketest failures | 00:51 |
| blr | wgrant: would it be better to drop requester from the repr, or ammend the permissions? | 02:13 |
| wgrant | blr: I'd amend the permissions, I think. | 02:13 |
| wgrant | blr: Pretty much everything can see Person anyway, so this is a one-liner in security.cfg | 02:13 |
| blr | wgrant: done, thanks. How do I go about poking buildbot? | 02:22 |
| wgrant | blr: bzr lp-land --testfix | 02:37 |
| wgrant | blr: Have you fixed all three failures? | 02:37 |
| blr | wgrant: yes, one doctest and the others were both resolved with permissions | 02:38 |
| wgrant | Yep | 02:39 |
| blr | wgrant: oh, need a new MP? | 02:40 |
| wgrant | blr: yep | 02:40 |
| blr | wgrant: https://code.launchpad.net/~blr/launchpad/dont-fear-the-repr/+merge/261338 | 02:44 |
| wgrant | blr: lgtm | 02:44 |
| blr | wgrant: cheers (I'll leave you in peace to _actually_ be not here today) | 02:45 |
| wgrant | Feel free to ask questions. I'm around, just not around. | 02:45 |
| blr | wgrant: thanks :) | 02:45 |
| blr | wgrant: buildbot seems rather unhappy, unable to connect to db. | 03:31 |
| wgrant | blr: That's a normal flaky test. | 03:37 |
| blr | wgrant: ah good, had me worried. | 03:39 |
| === 5EXABD84D is now known as infinity | ||
| === danilos` is now known as danilos | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!