=== danilos` is now known as danilos
blrwgrant: that seems to be working better with the expanders (less code too), although I seem to have introduced a validation regression - will get to that tomorrow.09:34
wgrantblr: Great.09:34
wgrantLet me know if you run into any trouble.09:34
blrthanks - I'll be in town for an hour and a bit in the morning to pickup a monitor, but back before lunch.09:34
blrlooking forward to no longer hunching over my laptop :P09:35
wgrantYou've been single-monitor all this time?09:35
wgrantMy condolences.09:35
cjwatsonI'm not *totally* sure that my dual-monitor setup is exactly ergonomic, with the RH one being above and to the right of my laptop09:36
cjwatsonBut it's better than being single-monitor ...09:36
blrmade sure the panel is vesa mountable - will be good to have two eventually.09:36
cjwatsonMy T450s is on the right continent now, so hopefully running 1920x1080 + 1600x1200 won't be too hideously confusing09:38
cjwatsonwgrant: You're right (git-merged-revno), it's much simpler to put merged_revision in the model, thanks.10:25
wgrantcjwatson: I'd call it something displayish if it were expected, but merged_revision is fine internally.10:26
cjwatsonYeah, I didn't export it10:27
wgrantGoddammit, branchrevision10:28
wgrantYou can't have been that cold.10:28
wgrantJust a failed scan despite a few pushes during the day.10:28
wgrantcjwatson: Have you heard anything about git support in mojo?10:29
wgrantTempted to switch something like turnip git-ward now that things are generally functional.10:30
cjwatsonBut mojo is definitely an issue there.10:31
cjwatsonI guess we could run an import.10:31
wgrantYeah, as long as we don't use gpgsig the import will be fine.10:31
wgrantWe should dogfood at least *something* ASAP now it's reasonable.10:31
wgrantAnd the lack of CI on turnip makes it an easy target :)10:32
wgrantAlso it'10:32
cjwatsonI suspect the firewall will need a tweak10:32
wgrants a git server hosted on bzr.10:32
cjwatsonFor self-imports10:32
wgrantNot just a firewall tweak, but yeah.10:32
wgrantAnything under .launchpad.net is blacklisted.10:32
cjwatsonI wanted to finish merge detection before we started dogfooding.10:33
cjwatsonOtherwise it'll just be annoying10:33
wgrantI was thinking that distro MPs didn't do it, so it couldn't be too annoying.10:33
wgrantBut it's distro *branches* that don't.10:33
cjwatsonYeah, there are XXX comments about that10:35
wgrant(also I assumed something based on UDD being reasonable, which is itself unreasonable)10:35
cjwatsonMuch easier to have sensible logic without branch lifecycles.10:35
wgrantDeletable branches are cool.10:36
cjwatsonwgrant: One reason I included target_default on the form for now is that otherwise if you retarget a repository to personal and back then the target defaultness goes away and you don't know why and have no UI way to restore it.11:06
cjwatsonBut I agree that the permission limit there is problematic.11:07
cjwatsonPerhaps it should simply not be possible to retarget a target default.11:08
wgrantcjwatson: The lack of UI way to restore it will go away once the product config page is reworked.11:15
cjwatsonYeah.  Retargeting a target default repository is a slightly weird thing to do anyway, though, and has lots of intersecting permissions.11:16
wgrantIt's inconsistent with the owner-target default checkbox.11:17
wgrantBut the permissions for that are much less intractable.11:17
cjwatsonThat's just edit plus checking that there's no conflict.11:17
cjwatsonI'll work on something to make the target uneditable with an explanatory message in this case.11:19
cjwatsonwgrant: What's the modern equivalent of the onKeyPress thing you called out in https://code.launchpad.net/~cjwatson/launchpad/git-repository-ui-edit-target/+merge/261232 ?16:57
cjwatsonI can't find anything in LP that's using anything different16:57
blrcjwatson: I'm not certain, but perhaps he was suggesting adding an event handler to the JS rather than using the widget event?20:51
cjwatsonblr: I'm still at the cargo-culting level with LP JS :-/21:58
cjwatsonOr JS in general really21:58
cjwatsonAre you thinking of something to do with YUI.Event?21:59
cjwatsonOh, there are some .on('keypress', blah) calls in our JS22:00
cjwatsonOK, that I can work with, looks straightforward enough22:00
blrcjwatson: you might want to clarify with wgrant, but at a guess that's what he meant.22:01
cjwatsonYeah, it makes sense now that I've found it22:02
blrcool :)22:02
cjwatsonIdeally I'd figure out how to make the JS live with the widget, mind22:02
cjwatsonBut I guess it's already separate22:03

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!