[00:42] <davecheney> thumper: thats most of the fix
[00:42] <davecheney> there is still another place they need to put a mutex, in _loopWorker or whatever it's called
[01:17] <cherylj> I think this bootstack bug #1463480 might be a dup of bug #1416928.  Can anyone take a look and sanity check for me?
[01:17] <mup> Bug #1463480: Failed upgrade, mixed up HA addresses <blocker> <canonical-bootstack> <ha> <upgrade-juju> <juju-core:Triaged> <juju-core 1.22:In Progress by cherylj> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1463480>
[01:17] <mup> Bug #1416928: juju agent using lxcbr0 address as apiaddress instead of juju-br0 breaks agents <api> <lxc> <network> <juju-core:Fix Released by dooferlad> <juju-core 1.21:Fix Released by dimitern> <juju-core 1.22:Fix Released by dooferlad> <https://launchpad.net/bugs/1416928>
[01:37] <waigani> wallyworld: PR for #1447899 https://bugs.launchpad.net/juju-core/+bug/1447899 I assume we'll also want to target 1.22?
[01:37] <mup> Bug #1447899: upgrade fails if no explicit version is specified <upgrade-juju> <juju-core:In Progress by waigani> <https://launchpad.net/bugs/1447899>
[01:37] <wallyworld> waigani: um, we do have a window for 1.22.6 fixes. i don't know that this bug is worth backporting though
[01:38] <waigani> wallyworld: okay, that PR targets 1.25 - as specified by the bug report
[01:38] <wallyworld> sounds good ty
[02:53] <axw> waigani: have you tested that tools upgrade fix live?
[02:54] <waigani> axw: yes, sorry forgot to put that in the PR
[02:54] <waigani> axw: tested on aws
[02:54] <waigani> axw: ec2 provider
[02:54] <axw> waigani: nps, thanks. LGTM
[02:54] <waigani> axw: used same versions as in original bug
[02:54] <axw> cool
[02:54] <waigani> axw: awesome, thanks
[02:56] <davecheney> thumper: panic: rescanned document misses transaction in queue
[02:56] <davecheney> goroutine 189 [running]:
[02:56] <davecheney> runtime.panic(0xe6fa60, 0xc210b9e990) /usr/lib/go/src/pkg/runtime/panic.c:266 +0xb6
[02:56] <davecheney> your build just failed with this error
[02:56] <davecheney> menn0: this looks very serious
[02:56] <thumper> ?!
[02:57] <axw> waigani: with forward/back ports, I don't normally wait for LGTM unless there were significant merge differences/conflicts
[02:57] <thumper> davecheney: I think this is what William has been looking at fixing recently
[02:58] <waigani> axw: yep, same. It just automatically pops up in RB. I usually close them straight away.
[02:58] <menn0> davecheney: https://bugs.launchpad.net/juju-core/+bug/1449054
[02:58] <mup> Bug #1449054: Intermittent panic: rescanned document <ci> <test-failure> <juju-core:Triaged by fwereade> <juju-core 1.22:Fix Released by dimitern> <juju-core 1.23:Won't Fix by fwereade> <juju-core 1.24:Fix Released by fwereade> <https://launchpad.net/bugs/1449054>
[02:59] <axw> waigani: okey dokey, just thought I'd mention in case you were waiting around
[02:59] <axw> ship-it'd anyway
[02:59] <menn0> davecheney: looks like it's been fixed in 1.22, 1.23 and 1.24 but not master
[02:59] <menn0> actually, not 1.23
[02:59] <menn0> it's probably just a matter of bumping the mgo version but it hasn't been done for some reason
[03:00] <waigani> axw: sweet, cheers
[03:04] <davecheney> waigani: are there any details for this bug ? https://canonical.leankit.com/Boards/View/115065967/115396849
[03:05] <waigani> davecheney: only happens on my machine. Let me write you an email with details.
[03:06] <davecheney> ok
[03:13] <natefinch> davecheney, wallyworld: this was the talk I was thinking of.  The whole thing is very good, but the link brings you to a 2 minute section where he talks about not using assert libraries for testing.  https://www.youtube.com/watch?v=yi5A3cK1LNA&t=9m40s
[03:23] <natefinch> wallyworld, davecheney:  here's a test file for a package I wrote recently with tests just using the stdlib's testing package.  https://github.com/natefinch/pie/blob/master/pie_test.go    I don't think it's terribly more verbose than using gocheck.
[03:23] <wallyworld> natefinch: it's terrible IMO :-) all those it statements when a sinlge line asset will do
[03:24] <wallyworld> 3 lines of syntax vs 1
[03:24] <wallyworld> and no tooling for things like deep equals, err nil, length checks  etc
[03:25] <natefinch> If statements... yeah, those are rough
[03:26] <natefinch> expecially simple ones like if len(a) != expected {
[03:26] <wallyworld> boilerplate
[03:27] <wallyworld> and you've only done simple checks so far
[03:27] <wallyworld> wait till you need to do deep equas, or same contents etc etc
[03:28] <natefinch> wallyworld: sure, some helper functions can help... but you don't need thousands of lines of code just to avoid writing an if statement.... line returns aren't harder to type than other characters
[03:28] <wallyworld> you're missing the point - frameworks do more than just eliminate lots of boilerplate
[03:28] <natefinch> wallyworld: and honestly, most of my gocheck code looks just like these tests.  I really try hard to make tests simple
[03:28] <wallyworld> they ensure consistency and common patterns across the code base
[03:32] <davecheney> natefinch: wallyworld leave me out of this
[03:33] <natefinch> davecheney: heh will do
[03:33] <davecheney> i don't want to start a land war in asia
[03:33] <davecheney> all I want is gocheck to be maintained
[03:33] <wallyworld> +1
[04:46] <thumper> wallyworld,axw: ping
[04:46] <wallyworld> wot
[04:46] <thumper> looking at fixing the help command
[04:46] <wallyworld> \o/
[04:46] <thumper> so we can go:
[04:46] <thumper> juju help system environmenst
[04:46] <thumper> and not have to put the help in the middle
[04:46] <wallyworld> -e as well?
[04:46] <thumper> however, storage is doing weird shit
[04:47] <thumper> -e is harder and out of scope from this change
[04:47] <wallyworld> storage is 3 levels
[04:47] <thumper> why do you have your own Command struct in storage for the super command
[04:47] <thumper> that doesn't matter
[04:47] <thumper> by wrapping it in another struct
[04:47] <thumper> it means I can't go:
[04:47] <wallyworld> i can't give you a good answer off hand
[04:47] <thumper> juju help storage pool
[04:48] <thumper> I may just throw that piece away and remove a level of indirection
[04:48] <thumper> I think it'll still work as expected
[04:48] <wallyworld> let me go look at the code real quick
[04:49] <wallyworld> thumper: yeah, i have NFI, that doesn't make sense why it was done
[04:49] <wallyworld> remove it i say
[04:49] <thumper> ok, I'll do that in my branch
[04:49] <wallyworld> ty
[04:52] <thumper> yep, still works
[05:44] <wallyworld> axw: would it make sense for resource-get to send its streamed resource data to its stdout and the charm which invoked the get can then suck on stdout to consume? or redirect to file or pipe elsewhere or whatever
[05:44] <axw> wallyworld: yes, that's what I was thinking
[05:45] <axw> wallyworld: so you can "resource-get thingy | my-fancy-stream-processing-program" or whatever
[05:45] <wallyworld> axw: the reason i initially went with an option for consuming the data in the hook was convenience
[05:45] <wallyworld> yep
[05:45] <axw> wallyworld: consuming the data?
[05:45] <axw> wallyworld: you mean unpacking onto disk?
[05:45] <wallyworld> save the charm author from having then to invoke the hook tool
[05:45] <axw> or installing deb or whatever
[05:45] <wallyworld> yeah, consume the data
[05:46] <axw> wallyworld: yes, that's probably the common scenario, so we should have that as an option/probably default
[05:46] <wallyworld> ok, will add it back
[05:46] <wallyworld> i still think we'll need to introduce a usage-type
[05:46] <axw> wallyworld: sorry, I didn't realise you took it out in favour of this
[05:46] <wallyworld> np :-)
[05:47] <axw> wallyworld: I was thinking it'd be a property of the resource type. is that conflating?
[05:48] <wallyworld> axw: yeah, because some charms will want to just get the deb or zip as a file, others would want to unit agent to install or unpack say
[05:48] <wallyworld> IMO
[05:49] <wallyworld> so having a separate usage-type attribute allows the charm to say it wants not just the file, but some type specific post processing
[05:49] <axw> wallyworld: the reason that feels awkward to me, is that what you do with the resource depends on the type of the resource. and the type of the resource may change depending on how you deploy the service, right?
[05:50] <axw> wallyworld: e.g. I might deploy with a deb to install mysql, or with a github repo that's my fork of mysql
[05:50] <axw> wallyworld: so what does the usage type mean in that case?
[05:50] <wallyworld> they would be different types though , right?
[05:51] <wallyworld> this is hard to discuss here, let's defer to tomorrow in 1:1
[05:51] <axw> wallyworld: sure :)
[07:19] <davecheney>     // TODO(rog) Fix this so it doesn't wait for so long.
[07:19] <davecheney>     // https://bugs.launchpad.net/juju-core/+bug/1163983
[07:19] <davecheney>     c.Fatalf("timed out waiting for agent to terminate")
[07:19] <davecheney> ... Error: timed out waiting for agent to terminate
[07:19] <mup> Bug #1163983: some tests take an unnecessarily long time waiting for the poll interval <performance> <tech-debt> <testing> <juju-core:Triaged> <https://launchpad.net/bugs/1163983>
[07:19] <davecheney> .... seriously
[08:31] <TheMue> dimitern: ping
[08:36] <dimitern> TheMue, pong
[08:37] <TheMue> dimitern: one question regarding IPAddress() and the address type
[08:37] <TheMue> dimitern: in state
[08:37] <dimitern> TheMue, yeah?
[08:38] <TheMue> dimitern: the signature is IPAddress(value string) ... and here value is taken as the docID. but the returned address type itself has also a field called Value containing the IP-Address. how they all are related?
[08:39] <TheMue> dimitern: does the docID contain the same value as Value and only exists for database reasons?
[08:40] <TheMue> dimitern: oh, and yes, params.Address contains Value as field (a string) but no ID. ?!?
[08:40] <dimitern> TheMue, the docID should contain the environment UUID as prefix to the address value
[08:43] <TheMue> dimitern: hmm, ok, so when retrieving the IP addresses via the API I only have the value, which doesn't allows me to retrieve the IP addresses again (as state instances) for later removal.
[08:44] <TheMue> dimitern: any troubles with extending the params.Address with the ID?
[08:44] <TheMue> *aaaargh*
[08:44]  * TheMue doesn't cry due to addresses
[08:45] <TheMue> thought I could stay on the veranda, but left hand a lawn mower and right hand craftsmen building on a house
[08:45] <TheMue> too much noise *grmblx*
[08:57] <dimitern> TheMue, the env uuid is automatically prepended to the id you pass
[08:57] <dimitern> TheMue, so you don't need anything else than the value
[08:58] <voidspace> if you use full disk encryption then ubuntu creates an unecrypted /boot partition where the linux image lives
[08:59] <voidspace> it makes it 237Mb - so when an update includes a new image (leaving the current one there too, plus any old ones which aren't auto un-installed)
[08:59] <voidspace> it fills up!
[08:59] <voidspace> every other time an update includes an updated image I have to do surgery on /boot
[09:00] <voidspace> and because the other partition is encrypted resizing partitions is non-trivial (can be done by booting a live-cd which I'll do at some point)
[09:00] <voidspace> *sigh*
[09:00] <TheMue> dimitern: great
[09:00] <voidspace> and due to the bug with plymouth after an upgrade (when you have an encrypted filesystem) I'm still doing a recovery boot every time
[09:01] <dimitern> jam, voidspace, dooferlad, standup?
[09:01] <voidspace> dimitern: omw
[09:01] <jam> dimitern: currently with mark, I'll be late if I'm there
[09:04] <dimitern> jam, np, sure
[09:20] <voidspace> dimitern: we could then filter juju-private from status if necessary
[09:21]  * dimitern steps out for a short while
[09:21] <dimitern> voidspace, if we need to, yes
[09:22] <dimitern> voidspace, TheMue, dooferlad, I'd appreciate a review on http://reviews.vapour.ws/r/1918/
[09:22] <TheMue> dimitern: just seen it
[09:23] <voidspace> dimitern: although this is putting workarounds in place for code that only has imaginery future use cases... *sigh*
[09:25] <jam> fwereade: I have a relation-get question for you when you have time
[09:25] <jam> wallyworld: when you are back, we did spend about 10min on resources, and there was a pretty big thing to consider
[09:29] <voidspace> dimitern: hmmm... a network *also* requires a ProviderId
[09:30] <voidspace> dimitern: ok to allow that to be empty? They're supposed to be unique per provider I guess.
[09:32] <voidspace> dimitern: yeah, there's an index on provider id
[09:32] <voidspace> unique index
[09:36] <voidspace> dimitern: what we *want* here is an interface that isn't associated with a provider network (except maybe the default one)
[09:36] <voidspace> dimitern: we need to be clear about our model though
[09:46] <voidspace> dimitern: so we either need to model the provider network that the nic is associated with *or* we need interfaces not associated with a network
[09:46] <voidspace> dimitern: the latter seems easier at this stage
[09:57] <voidspace> dimitern: or we could make provider id a sparse index I guess...
[09:58] <voidspace> although we'd still have problems with duplicates
[10:03]  * dimitern is back
[10:03] <dimitern> voidspace, ProviderId is supposed to be coming from the maas network name
[10:04] <dimitern> voidspace, but I guess setting it to the same as the network name *for now* should be fine
[10:06] <voidspace> dimitern: this is not just for maas
[10:06] <voidspace> dimitern: this is for ec2 (and then openstack too)
[10:10] <dimitern> voidspace, I know
[10:10] <dimitern> voidspace, but the model (as implemented in state) will change anyway (e.g. subnets instead of networks, while networks are a different concept)
[10:11] <voidspace> dimitern: right, but at the time we're creating the network configuration for the container I'm not sure that we *have* the network name
[10:11] <voidspace> as it's not relevant
[10:12] <voidspace> I'll look through the code a bit more carefully
[10:12] <dimitern> voidspace, we *should* have it, as the container's host is already on it
[10:12] <dimitern> voidspace, but it's not populated I guess
[10:13] <voidspace> I don't think we have it in configureContainerNetwork I mean
[10:13] <voidspace> I'll check
[10:14] <voidspace> the interface info we're working with comes from the PrepareContainerInterfaceInfo call and NetworkName is not populated
[10:14] <voidspace> I can see if it's possible to populate it there
[10:14] <dimitern> voidspace, right
[10:15] <dimitern> voidspace, if the host itself had it populated at provisioning, it should be possible to get it from there and use the same
[10:15] <dimitern> voidspace, but it won't be populated on the host unless you deploy it e.g. with --networks maas-net-name
[10:16] <voidspace> right - we do copy the NetworkName into the result, so we're being given an empty name and ProviderId
[10:16] <dimitern> voidspace, so just hardcoding it to juju-private (with a TODO comment please that we'll need to fix that as the model gets changed) in PCII() should do the trick I guess?
[10:16] <voidspace> dimitern: for provider Id too? that has to be unique
[10:16] <voidspace> it's actually ProviderId that's the problem now
[10:17] <dimitern> voidspace, unique how?
[10:17] <voidspace> dimitern: there's a unique index on provider id in mongo
[10:17] <dimitern> voidspace, it's no
[10:17] <voidspace> dimitern: go look in state/open.go
[10:17] <dimitern> voidspace, hmm
[10:18] <dimitern> voidspace, that's correct - providerid + envuuid has to be unique within the networks collection
[10:18] <voidspace> right, so we need a unique provider id and at the moment it's empty
[10:19] <dimitern> voidspace, but state.AddNetwork works with existing providerId+envuuid docs and just ignores it
[10:19] <voidspace> dimitern: yes, just found that
[10:19] <voidspace> SetInstanceInfo ignores it
[10:19] <voidspace> not AddNetwork
[10:19] <voidspace> but same effect
[10:19] <dimitern> voidspace, so it *should* be fine
[10:19] <voidspace> dimitern: so set ProviderId to juju-private too? that's actually incorrect - network name is internal to us, provider id is meant to be, well, a provider id :-)
[10:20] <voidspace> dimitern: I can call it "invalid" to make it explicit that we've faked it - or "juju-private-default"
[10:20] <voidspace> which is a bit of a less scary name
[10:20] <voidspace> if it ever leaks
[10:20] <dimitern> voidspace, how about "not-available" ?
[10:20] <voidspace> ok
[10:21] <voidspace> so long as that can never clash with a real one
[10:21] <dimitern> cool, but please make it a const somewhere (network/ I guess)
[10:21] <voidspace> which I guess is probably safe...
[10:22] <dimitern> I don't believe it matters, as it's not used anywhere user-visible
[10:22] <voidspace> dimitern: the danger with ProviderId is that we actually attempt to fetch it from the provider at some point
[10:22] <voidspace> and if it accidentally matches a real one then weird things will happen
[10:23] <voidspace> that's why I suggested a juju prefixed name
[10:23] <dimitern> voidspace, "juju-not-available" ?
[10:23] <dimitern> :)
[10:23] <voidspace> heh
[10:25] <dimitern> voidspace, let's go with "juju-unknown" ?
[10:25] <voidspace> ok
[10:26] <voidspace> bootstrapping with this code...
[10:26] <voidspace> and going for coffee whilst it's churning
[10:47] <wwitzel3> hrmm coffee, good idea
[10:55] <voidspace> wwitzel3: o/
[10:56] <voidspace> dimitern: and that seems to work, but the network *is* displayed in "juju status"
[10:58] <dimitern> voidspace, unless tests start failing for status I can live with that for now :)
[10:58] <dimitern> dooferlad, I've discovered another issue with GetContainerInterfaceInfo (or around it)
[10:59] <dimitern> dooferlad, after host reboot, no routes are added for KVM instances' IPs (for LXC works)
[11:21] <dimitern> dooferlad, additionally, ip route add can fail with exit 2 (RTNETLINK: File exists) and that should be handled better (it currently fails the process of the network config on the host altogether)
[11:23] <dimitern> dooferlad, it should ignore exit 2 and only fail for exit 1 (e.g. Error: an inet prefix is expected rather than "10.15.0.". ; when doing ip route add 10.15.0. dev eth0)
[11:34] <dimitern> dooferlad, I've added a card for you with details, please ping me if unclear
[11:38] <dooferlad> dimitern: just back from lunch. Looking.
[11:39] <dooferlad> dimitern: any idea why it has HTML tags in the description text? Rather noisy to read!
[11:40] <TheMue> dimitern: I've seen the constants, and I liked them. I meant those expectScripts in the tests
[11:44] <dimitern> dooferlad, where are these HTML tags?
[11:45] <dooferlad> dimitern: don't worry, I got rid of them. They were in the card description. Perhaps some copy/paste thing?
[11:45] <dimitern> TheMue, ah, I see
[11:45] <dooferlad> dimitern: The leankit UI is horrible anyway - I don't spend much time looking at it, so it isn't a big deal.
[11:45] <dimitern> dooferlad, ah ok
[11:52] <marcoceppi> Can someone with familiarity of the OpenStack provider respond to the email in the Juju mailing list about Rackspace?
[12:00] <mgz_> marcoceppi: we probably just need a bug filed for firewall-group: none still creating groups
[12:02] <mgz_> marcoceppi: that setting was only added for scale testing, not for clouds that don't actually have the firewalling calls
[12:02] <mgz_> but provider could not do the work
[12:03] <marcoceppi> mgz_: could you let them know that? seems like it's the only blocker for rackspace which would be a huge win fwiu
[12:03] <mgz_> I doubt it's the *only* blocker...
[12:03] <mgz_> certainly the first though, and probably wouldn't be hard to make it work
[12:04] <mgz_> I never bothered because it was a pain to get an account and I wanted the instance-level firewalling support
[12:05] <mgz_> marcoceppi: I'll reply to the mail
[12:06] <marcoceppi> mgz_: thank you!
[12:32] <dimitern> voidspace, hey
[12:33] <dimitern> voidspace, just a heads up - I've filed a separate bug 1464237 for the devices api work, leaving bug 1348663 only for the latest fix I did
[12:33] <mup> Bug #1464237: juju should use devices API on MAAS 1.8+ for addressable containers <addressability> <feature> <kvm> <lxc> <maas-provider> <network> <juju-core:In Progress by mfoord> <https://launchpad.net/bugs/1464237>
[12:33] <mup> Bug #1348663: DHCP addresses for containers should be released on teardown <maas-provider> <network> <oil> <juju-core:In Progress by dimitern> <juju-core 1.24:Fix Committed by dimitern> <MAAS:Invalid> <https://launchpad.net/bugs/1348663>
[12:36]  * dimitern steps out
[12:39] <marcoceppi> is ther any way to get the environment details from the api? I'm trying to gather the region a deployment is in from API only
[12:39] <marcoceppi> (if region is set)
[12:40] <marcoceppi> Environment.info doesn't seem to have those details
[12:42] <marcoceppi> ah, found it, get_env_config in the python-jujuclient will retrieve this information
[12:44] <mup> Bug #1464235 opened: failed to create a security group with firewall-mode: none <openstack-provider> <juju-core:Triaged> <https://launchpad.net/bugs/1464235>
[12:45] <mup> Bug #1464237 opened: juju should use devices API on MAAS 1.8+ for addressable containers <addressability> <feature> <kvm> <lxc> <maas-provider> <network> <juju-core:In Progress by mfoord> <https://launchpad.net/bugs/1464237>
[13:39] <dimitern> reviews appreciated - http://reviews.vapour.ws/r/1919/ - port of the fix for bug 1348663 to master
[13:39] <mup> Bug #1348663: DHCP addresses for containers should be released on teardown <maas-provider> <network> <oil> <juju-core:In Progress by dimitern> <juju-core 1.24:Fix Committed by dimitern> <MAAS:Invalid> <https://launchpad.net/bugs/1348663>
[13:45] <mup> Bug #1464254 opened: charmsSuite teardown fails <ci> <intermittent-failure> <unit-tests> <juju-core:Incomplete> <juju-core feature-proc-mgmt:Triaged> <https://launchpad.net/bugs/1464254>
[13:45] <mup> Bug #1464255 opened: statesuite teardown fails <ci> <intermittent-failure> <unit-tests> <juju-core:New> <juju-core feature-proc-mgmt:Triaged> <https://launchpad.net/bugs/1464255>
[14:02] <katco> wwitzel3: standup
[14:16]  * TheMue 's yesterday rant about a pure functional persistency layer and a dumb model would make mocking simpler. model could be used, in-memory persistency mock would be maintained with real persistency layer
[14:29] <katco> TheMue: agreed. Moonstone is making strides towards such a dream.
[14:29] <TheMue> katco: aaaaaaaaaaaah, great enlighting news
[14:29] <TheMue> katco: makes my day
[14:29] <katco> TheMue: mind you, it will take awhile to get to the end-state, but we are chipping away :)
[14:30] <TheMue> katco: sure, nothing to be done in a week. *lol* but it's worth it.
[14:32]  * TheMue with this news definitely feels better while hacking his current mocks
[14:37] <voidspace> dimitern: so, cmd/juju tests time out
[14:37] <voidspace> dimitern: I'm guessing there's something that blocks waiting for status to match...
[14:38] <voidspace> dimitern: I'll find it
[14:38] <voidspace> dimitern: fixed a handful of other tests
[14:39] <dimitern> voidspace, right, I've suspected this much, but hopefully it shouldn't be too hard to fix
[14:41] <voidspace> dimitern: yeah, just a case of finding the right test :-)
[14:48] <mup> Bug #1464280 opened: storeManagerStateSuite teardown fails <ci> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1464280>
[14:48] <voidspace> dimitern: the panic traceback is 30211 lines long
[14:48] <voidspace> dimitern: that's quite a few goroutines...
[14:49] <dimitern> voidspace, wow :) not unusual
[14:50] <dimitern> voidspace, 90% of the cases the first few tracebacks are the most useful
[14:51] <dimitern> voidspace, I'd appreciate a review on http://reviews.vapour.ws/r/1919/ btw - live tests just passed ok on maas and ec2
[14:53] <voidspace> dimitern: ok
[14:53] <voidspace> dimitern: I think I found the test in that panic
[14:53] <voidspace> dimitern: not obvious from reading the test why it should block
[14:53] <voidspace> but about to try it
[14:53] <voidspace> dimitern: anyway, looking
[14:54] <voidspace> dimitern: so you went with reboot doing an "ifdown"
[14:54] <dimitern> voidspace, try also running suspected tests in isolation
[14:54] <voidspace> dimitern: that's what I'm about to do...
[14:54] <dimitern> voidspace, yeah, works well
[14:54] <voidspace> dimitern: ok
[14:57] <voidspace> dimitern: I hate tests that just copy large blocks of text from the code into the test
[14:57] <voidspace> dimitern: just testing that the config is added would be enough, duplicating the script in the test proves nothing
[14:58] <dimitern> voidspace, it proves the shutdown job for systemd is as expected for vivid
[14:59] <voidspace> dimitern: but you got expected by copying and pasting
[14:59] <voidspace> dimitern: so if there's an error in it the error will be in the test too
[14:59] <voidspace> dimitern: an equally good test would just be checking a match for some unique part of it, and it wouldn't bloat the tests so much
[14:59] <voidspace> dimitern: and they wouldn't be so fragile
[15:00] <voidspace> I had tests fail because my editor trimmed whitespace from a script
[15:00] <voidspace> and the whitespace was duplicated in the test :-/
[15:00] <dimitern> voidspace, heh :) good point, but I've also live tested that it works
[15:00] <voidspace> I'm talking about test cleanliness
[15:00] <voidspace> I'm sure it works, it's just horrible tests
[15:00] <voidspace> they're a menace
[15:01] <dimitern> voidspace, since that PR is for master I'm fine with trying to make the tests a bit better if you think it's worth it - I'll check your comments
[15:01] <voidspace> dimitern: ok, I'll put a comment on the test
[15:01] <dimitern> voidspace, cheers
[15:01] <voidspace> dimitern: hmmm, that test passes on its own
[15:01] <voidspace> dimitern: but it takes >5minutes
[15:02] <voidspace> dimitern: I suspect they're timing out because they're awfully slow tests
[15:02] <voidspace> (cmd/juju I mean)
[15:02] <voidspace> I wonder why these changes would make them slower
[15:02] <voidspace> there's some extra logging I can pull out
[15:02] <dimitern> voidspace, try running them with -race - might uncover the issue
[15:03] <voidspace> dimitern: ok, thanks
[15:03] <katco> wwitzel3: starting to think it might be on my end.
[15:03] <katco> wwitzel3: flash doesn't seem to want to work
[15:03] <wwitzel3> katco: I'm back in
[15:06]  * dimitern will be back in 1h
[15:12] <voidspace> dimitern: a ShipIt with an open issue for the worst offender of the tests...
[15:12] <voidspace> test run with "-race" still going
[15:13] <voidspace> and killed
[15:14] <voidspace> trying just the one test
[15:17] <cherylj> dooferlad,  dimitern,   could you guys take a quick peek at bug 1463480?  I suspect that it's a dup of bug 1416928, but I'm not 100%
[15:17] <mup> Bug #1463480: Failed upgrade, mixed up HA addresses <blocker> <canonical-bootstack> <ha> <upgrade-juju> <juju-core:Triaged> <juju-core 1.22:In Progress by cherylj> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1463480>
[15:17] <mup> Bug #1416928: juju agent using lxcbr0 address as apiaddress instead of juju-br0 breaks agents <api> <lxc> <network> <juju-core:Fix Released by dooferlad> <juju-core 1.21:Fix Released by dimitern> <juju-core 1.22:Fix Released by dooferlad> <https://launchpad.net/bugs/1416928>
[15:25] <dooferlad> cherylj: looking
[15:48] <mup> Bug #1464304 opened: Sending a SIGABRT to jujud process causes jujud to uninstall (wiping /var/lib/juju) <cts> <sts> <juju-core:New> <https://launchpad.net/bugs/1464304>
[15:53] <natefinch> ^^ what, thats a feature
[15:54] <mup> Bug #1464304 changed: Sending a SIGABRT to jujud process causes jujud to uninstall (wiping /var/lib/juju) <cts> <sts> <juju-core:New> <https://launchpad.net/bugs/1464304>
[15:55] <natefinch> mup: infer RandomChoice[{'thats a feature', 'thats a bug'}]
[15:55] <mup> natefinch: Cannot infer much out of this. :-(
[15:55] <natefinch> aww
[16:04] <wwitzel3> ericsnow: just finishing up a quick snack so we can work up until you have to take off
[16:05] <ericsnow> wwitzel3: wrapping up a review so we should be good
[16:06] <mup> Bug #1464304 opened: Sending a SIGABRT to jujud process causes jujud to uninstall (wiping /var/lib/juju) <cts> <sts> <juju-core:New> <https://launchpad.net/bugs/1464304>
[16:11] <voidspace> what's the flag to gocheck to not swallow logging output as it's running?
[16:13] <voidspace> -gocheck.vv
[16:20] <wwitzel3> ericsnow: heading to moonstone
[17:36] <mup> Bug # changed: 1403165, 1441478, 1442257, 1453785, 1454697, 1455158, 1456989, 1463117, 1463439
[17:36] <mup> Bug #1464335 opened: debug-log does not work with local provider <debug-log> <local-provider> <regression> <vivid> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1464335>
[18:36] <mup> Bug #1464356 opened: TestCloudInit fails <ci> <intermittent-failure> <test-failure> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1464356>
[18:53] <natefinch> evidently gc.ErrorMatches can't handle error messages with line returns in them
[18:53] <natefinch> because even this assert is failing: c.Assert(err, gc.ErrorMatches, `.*`)
[18:56] <perrito666> well if it uses the regex, it is correct
[18:56] <perrito666> .* does not include newlines
[18:56] <perrito666> iirc
[18:56] <natefinch> and this is why I hate regexes... well, one of a thousand such reasons
[19:36] <mup> Bug #1464369 opened: Sufficiently sized int config values are converted to floats <oil> <juju-core:New> <https://launchpad.net/bugs/1464369>
[19:48] <mup> Bug #1464369 changed: Sufficiently sized int config values are converted to floats <config> <oil> <juju-core:New> <https://launchpad.net/bugs/1464369>
[20:40] <mup> Bug #1464392 opened: mgo iterators not being closed in state/actions.go <juju-core:New> <https://launchpad.net/bugs/1464392>
[20:58] <natefinch> dinner time!
[20:58] <natefinch> mup: infer RandomChoice[{'bye!', 'adios!'}]
[20:58] <mup> natefinch: Cannot infer much out of this. :-(
[20:58] <natefinch> mup: infer RandomChoice[{'bye', 'adios'}]
[20:58] <mup> natefinch: bye.
[20:58] <natefinch> man... picky
[21:27] <thumper> alexisb: oh hai
[21:27] <alexisb> heya thumper
[21:27] <alexisb> I need to chat go with you today before I go
[21:27] <alexisb> :)
[21:28] <alexisb> but I am in meetings for a but
[21:28] <alexisb> bit
[21:28] <alexisb> still
[21:30] <alexisb> thumper, I will ping you when I am done with calls
[21:30] <thumper> kk
[21:30]  * thumper is about to have a meeting too
[21:36] <alexisb> cherylj, what is the next step for https://bugs.launchpad.net/juju-core/+bug/1463480
[21:36] <mup> Bug #1463480: Failed upgrade, mixed up HA addresses <blocker> <canonical-bootstack> <ha> <upgrade-juju> <juju-core:Triaged> <juju-core 1.22:In Progress by cherylj> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1463480>
[21:38] <cherylj> alexisb: I chatted with thumper about it a few minutes ago, and I think there's not much we can do.  It is a known problem that was fixed in 1.22
[21:39] <cherylj> we can give them a workaround to fix the problem if they see it again
[21:43] <alexisb> cherylj, ack, can you please follow-up with pete and make sure they go through the work-around
[21:44] <cherylj> alexisb: will do
[23:05] <alexisb> ok thumper
[23:05] <alexisb> our 1x1 hangout