| ahoneybun | hey all how do you use flickable with columns? | 02:39 |
|---|---|---|
| meles | mhall119: you are the maintainer of ubuntu-calendar-app. right? | 08:00 |
| DanChapman | meles, IIRC kunal and mihir are the main developers working on calendar. | 08:05 |
| nik90 | meles: ping | 09:42 |
| awad | hi | 11:21 |
| meles | hey nik90 i just saw it now | 13:02 |
| meles | nik90 any progress? | 13:03 |
| meles | nik90 GOT IT! | 13:23 |
| nik90 | meles: can you test the click package on your phone and see if it fixes the bug | 13:24 |
| meles | my patch: http://paste.ubuntu.com/11714089 | 13:26 |
| meles | nik90 ^ where is the click package | 13:26 |
| nik90 | meles: I added a comment in the bug report with the click package | 13:27 |
| meles | nik90: ok | 13:28 |
| meles | nik90 the app fails to open | 13:37 |
| nik90 | meles: eh? | 13:40 |
| nik90 | meles: which device image are you running? | 13:40 |
| nik90 | meles: I built it against a vivid 15.04 image. Are you running BQ with 14.10 instead? | 13:40 |
| meles | nik90 splash screen is appearing and than it crashes. I'm running 14.10 indeed | 13:41 |
| nik90 | meles: that's why it doesn't open for you..its compiled to work on 15.04 and not 14.10 considering that OTA-4 will be released tomorrow which is based on vivid :) | 13:42 |
| meles | nik90 i m building it myself | 13:42 |
| nik90 | meles: rest assured, let me build it for 14.10 and send you the click package if you want | 13:42 |
| nik90 | meles: ok..ping me if you hit any issues and I can send it to you if required | 13:42 |
| meles | nik90 ping | 13:52 |
| nik90 | meles: i'm here | 13:52 |
| meles | nik90 no the fix does not work. but I have to say that I have a special issue. Since I changed the date so many times for testing purposes I had some alarms created at a future date. Reactivating this alarms makes them just go off at the day they were originally created. My fix considers this problem. Can you test it? I can push it if you want. | 13:54 |
| nik90 | meles: would the phone issue change their date and go backwards though? | 13:55 |
| nik90 | meles: can you upload your fix into a branch that I can grab and test quickly? | 13:55 |
| meles | nik90 no normally not but who knows :-) | 13:56 |
| meles | ok otw | 13:56 |
| nik90 | meles: fair enough | 13:56 |
| meles | nik90 ok it's up | 14:03 |
| meles | nik90 lp:~themeles/ubuntu-clock-app/bugfix-1442518 | 14:04 |
| * nik90 tests now | 14:06 | |
| nik90 | meles: yup your patch works better | 14:11 |
| nik90 | nice work! | 14:11 |
| meles | :-) | 14:12 |
| nik90 | meles: just requires 2 minor code fixes, 1) Better variable names 2) add an entry to the debian changelog | 14:13 |
| meles | nik90 just might have to rename the variables a bit, since they are pretty bad | 14:13 |
| nik90 | :) | 14:13 |
| nik90 | meles: if you look at https://code.launchpad.net/~nik90/ubuntu-clock-app/fixes-1442518/+merge/261905, you will see the debian changelog entry I used | 14:14 |
| nik90 | ofcourse add your own name to the entry | 14:14 |
| meles | nik90 ok i fix it | 14:14 |
| nik90 | meles: Why do you do var tdate2 = new Date(d.getFullYear(),d.getMonth(),d.getDate()+1,alarmData.date.getHours(),alarmData.date.getMinutes(),0,0) instead of d.setDay(d.getDate()+1) ? | 14:20 |
| nik90 | is it to set the minutes and seconds to 0? | 14:20 |
| meles | now because i coud not get the other variant working | 14:21 |
| meles | nik90 no because i coud not get the other variant working | 14:22 |
| nik90 | other variant? | 14:25 |
| meles | nik90 the one u suggested | 14:25 |
| nik90 | ah ok | 14:26 |
| meles | nik90 i pushed the new code and entered the information suggested. Is there anything more neccessary | 14:30 |
| nik90 | meles: sec, taking a look | 14:31 |
| nik90 | meles: two things...update debian changelog and also specify a commit msg to the merge proposal you created | 14:32 |
| meles | where do i change the debian changelog | 14:35 |
| nik90 | meles: nano debian/changelog | 14:35 |
| nik90 | meles: one other thing..the two variables "currentTime" and "now" are redundant..you just need one of them | 14:40 |
| meles | nik90: you are right. I stick with now, I think its easier, even though the other was used before. ok? | 14:41 |
| nik90 | meles: fine by me | 14:42 |
| meles | nik90: ok i think now its complete | 14:44 |
| * nik90 checks | 14:45 | |
| nik90 | meles: commented in the MP proposal. | 14:50 |
| meles | nik90 MP? | 14:51 |
| meles | I have to go now urgently, i ll be back later | 14:51 |
| nik90 | meles: ok..you should have got an email about the merge proposal | 14:51 |
| nik90 | meles: tty later | 14:51 |
| meles | hey nik90, thanks for your comments. I changed it as you suggested. I hope it's good to merge now. If not let me know. | 17:19 |
| nik90 | meles: they look good now. I am going to test this for a 2-3 days to ensure that we didn't miss out any rare cases where the bug might reappear. I would recommend you do the same. | 17:21 |
| nik90 | meles: and then I will merge it and try to include it in our release after OTA-4 | 17:22 |
| nik90 | popey, balloons: Could either of you trigger jenkins on https://code.launchpad.net/~themeles/ubuntu-clock-app/bugfix-1442518/+merge/261910 pls. thnx | 17:22 |
| nik90 | meles: I approved the merge proposal. Will merge in a few days after I finish testing it. | 17:23 |
| meles | nik90 allright I will. I'm very glad that I had your great support!!! Maybe I can contribute to some other bugfixes now, which might make the planed selling of my phone obsolete. :-) | 17:25 |
| nik90 | meles: you made the bug fix possible..so a huge thanks to you! And yes feel free to contribute to other bug fixes that grab your attention. | 17:26 |
| nik90 | meles: be sure to assign the bug to yourself on launchpad before starting to work on it since otherwise we might have multiple people working on the same thing. | 17:28 |
| meles | nik90 actually there is even one that annoyed me quite a bit at the beginning. It's Bug #1437316. And I would agree to racb's comment, to make the off button red and the snooze green. | 17:32 |
| ubot5 | bug 1437316 in Ubuntu UX "[Clock] Too easy to accidentally turn off the alarm instead of snoozing" [Undecided,Triaged] https://launchpad.net/bugs/1437316 | 17:32 |
| * nik90 looks at the bug report | 17:32 | |
| nik90 | meles: that bug report is a bit off scope at the moment since it is not the clock app that draws the notification on the screen. Indicator-datetime does at while using the unity8 notification framework. | 17:33 |
| nik90 | meles: also it requires feedback from the design team before proceeding to fix it. | 17:34 |
| nik90 | I do agree to the bug report as stated in the first comment there | 17:34 |
| nik90 | meles: the bugs which are listed in https://launchpad.net/ubuntu-clock-app/+milestone/3.x.backlog are usually blocked atm by things like design, platform limitation etc. | 17:35 |
| meles | nik90 ok I understand. I will see what else I could do. | 17:38 |
| popey | nik90: I am not sure I know how to manually trigger, so gave it a go. lets see if it works | 17:55 |
| popey | nik90: http://91.189.93.70:8080/job/ubuntu-clock-app-ci/ | 17:55 |
| nik90 | popey: ack. | 18:00 |
| meles | nik90 my alarms don't trigger any sound or vibration anymore, they just pop up. Does it work on your system | 18:00 |
| popey | thanks for the contribution meles ! | 18:00 |
| nik90 | meles: for me it triggers sound and vibration even after installing your patch. I tested this on my Nexus 4 running 15.04 | 18:02 |
| meles | popey: no prob. I'm happy that I could contribute and that I got great support! | 18:02 |
| nik90 | meles: good news is that jenkins ran the autopilot and qml tests and found no regressions in your patch! It will be merged in 2 days after we both are confident of the bug fix. | 18:04 |
| popey | woah! My random button pressing worked!? | 18:05 |
| popey | sweet | 18:05 |
| nik90 | haha ;) | 18:05 |
| meles | nik90 is there somewhere a proper how to about how to fix and commit a bug, if not I would work on an easy to read summary | 18:30 |
| nik90 | meles: https://wiki.ubuntu.com/Touch/CoreApps/DevelopmentGuide | 18:31 |
| meles | and about Ubuntu SDK, like how to open the project (CMakeList.txt). | 18:32 |
| meles | nik90 ^ | 18:32 |
| nik90 | meles: well stuff like how to run an app, build it for the phone etc are all documented at developer.ubuntu.com | 18:33 |
| nik90 | meles: it is common knowledge that cmake projects are opened via the CMakeList.txt file, qmake via .pro etc | 18:33 |
| meles | nik90 not to everybody and without your help i might have just given up. | 18:35 |
| nik90 | meles: We could make the core apps contribution guide a bit more descriptive by include such info and for further info redirect the to the official documentation pages? | 18:36 |
| meles | nik90: yes would limit the step to join. And I also think that there is to much text, when I want to check something out I want to get quickly through it. E.g http://paste.ubuntu.com/11715854/ | 18:45 |
| nik90 | meles: well yes some pictures would come in handy to explain it in a more intuitive manner | 18:48 |
| popey | I have an item on my to-do to improve the on-ramp for new developers nik90 meles | 19:00 |
| nik90 | popey: did you have any particular idea/mockup on how to improve it? | 19:03 |
| popey | the idea was to have a pretty home page for each app | 19:03 |
| popey | and a general page for all the cross-app info | 19:03 |
| popey | and move the content off the wiki | 19:03 |
| popey | no mock ups yet | 19:04 |
| nik90 | off the wiki? | 19:05 |
| nik90 | dedicated homepages/website for each app? | 19:05 |
| popey | yeah, move it to developer.ubuntu.com | 19:05 |
| popey | yes | 19:05 |
| popey | page per app | 19:05 |
| popey | with links to where the source is, bitsize bugs, planning docs etc | 19:06 |
| nik90 | ah | 19:06 |
| meles | popey nik90 i was on the phone. I think developer.ubuntu.com would be the better place since this was also where I was looking for such info. but couldn't the quick start guide be quicker to read. All the info but less text. | 19:24 |
| popey | thanks for the feedback | 19:24 |
| popey | I agree | 19:24 |
| nik90 | +1 | 19:28 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!