[01:18] <wgrant> Yay GitHub
[01:19] <wgrant> Trying to create a PR for the dulwich changes.
[01:19] <wgrant> The "Compare" link works, but there's no way to create a PR.
[01:19] <wgrant> The "Pull request" link 404s.
[01:26] <lifeless> jelmer: ^
[01:26] <wgrant> Oh
[01:26] <wgrant> 404 on the pull request link means "you're not logged in", apparently.
[01:26] <wgrant> My session must have expired.
[01:26] <wgrant> Why would you show the link and then 404 :(
[02:57] <maozhou> cjwatson, wgrant : Is it spamming you yet?
[03:05] <wgrant> maozhou: I haven't had reports of it in some weeks.
[03:20] <maozhou> ok
[03:49] <blr> hmm that was weird, must have been logged out for some reason, but ended up with base template json errors
[03:49] <blr> wasn't entirely obvious what was going on...
[03:50] <wgrant> blr: Hm, that's not a good sign.
[03:50] <wgrant> What was the error?
[03:52] <blr> wgrant: https://pastebin.canonical.com/133538/
[04:06] <wgrant> jelmer: Thanks.
[04:06] <wgrant> blr: Hm, can you reproduce it now?
[04:11] <blr> wgrant: nope
[04:22] <blr> wgrant: just about have all these changes complete, but would like to merge the templates - can a tal:condition be a route/path, or refer to the view class? Ideally would like to avoid having a property set on the project setbranch view just for this purpose
[04:26] <wgrant> blr: tal:condition can be any TALES expression. But I don't think it'd be bad to have a is_series or similar property on the view to determine the behaviour, if you had to.
[04:26] <blr> wgrant: ok, if that's acceptable that would certainly be easy enough
[04:44] <blr> wgrant: the zcml docs suggest the 'for' directive can take multiple classes, but I don't see any instances where we're doing that (other than *), is there are a reason for that?
[04:46] <wgrant> blr: Hm, that may work, not sure. If it makes things nicer, I have no problem with it.
[04:46] <wgrant> It would be handy if that did work.
[04:46] <blr> wgrant: hmm no it crashes actually heh
[04:48] <blr> may have been misinterpreting Multiadapters http://docs.zope.org/zope.component/zcml.html
[04:48] <blr> effectively I want to share a macro between IProduct and IProductSeries
[04:50] <wgrant> Yeah, unless you have a common interface you need to register it twice.
[04:50] <wgrant> What's the macro?
[04:53] <blr> push instructions and the ssh key reminder. Both could be inlined in the template, but they seem like they could potentially be used elsewhere
[04:53] <wgrant> ah, yes.
[05:14] <blr> right, think that's in reasonable shape now.
[05:15] <blr> might merge this branch into the golang import meta branch and try to get that working tomorrow for mwhudson
[05:18] <blr> ah, I didn't add the repository_location vocabulary... drat. Will look at that as well.
[05:19] <blr> at any rate, ttyl wgrant
[05:23] <wgrant> blr: Thanks, have a good weekend.