| tsdgeos | mzanetti: pstolowski: why do we need https://code.launchpad.net/~mzanetti/unity8/previewcommentinput/+merge/260719 ? doesn't the other input stuff we have work? | 07:37 |
|---|---|---|
| pstolowski | tsdgeos, afair the look is slightly different, but will need to check design doc again | 07:41 |
| tsdgeos | i see | 07:42 |
| tsdgeos | mzanetti: https://code.launchpad.net/~aacid/unity8/qmluitests_to_uitests/+merge/262661 | 07:54 |
| pstolowski | tsdgeos, from quick look i think it needs to be a single line comment? and the button right to it; is it possible with existing widget? | 08:12 |
| pstolowski | tsdgeos, mzanetti i'm going to rebuild the music scope in silo 5, shall i also rebuild unity* | 08:13 |
| pstolowski | 8? | 08:13 |
| mzanetti | pstolowski, yes | 08:26 |
| mzanetti | tsdgeos, yes, they look a bit different, there's also the new comment item to be done still | 08:27 |
| mzanetti | tsdgeos, will review that branch, thanks | 08:27 |
| tsdgeos | ok then if we're sure we can't reuse the other one | 08:31 |
| tsdgeos | just wanted to make sure we had thought about it | 08:31 |
| tsdgeos | doooo | 08:38 |
| tsdgeos | xvfbtestSurfaceContainer doesn't even compile | 08:38 |
| tsdgeos | /home/tsdgeos_work/phablet/unity8/unity8/tests/qmltests/Stages/tst_SurfaceContainer.qml:35,13: Cannot assign to non-existent property "orientation" | 08:38 |
| tsdgeos | mzanetti: we probably should tell fginther too that the name of the target changed | 09:00 |
| mzanetti | tsdgeos, the jenkins job runs the ./runtests script | 09:00 |
| tsdgeos | ah cool | 09:00 |
| * tsdgeos checks if we updated that one or not :D | 09:00 | |
| tsdgeos | we did \o/ | 09:01 |
| === Trevinho|Holiday is now known as Trevinho | ||
| tsdgeos | mzanetti: what's the deal with https://code.launchpad.net/~aacid/unity8/suspend_screenshoting/+merge/257119 are we landing it or waiting for confirmation? | 09:08 |
| mzanetti | tsdgeos, this only stores them to disk, right? does not yet reload them at startup | 09:09 |
| tsdgeos | mzanetti: it does if it crashed or was killed | 09:10 |
| mzanetti | so it changes the crashed case | 09:11 |
| tsdgeos | + shows spinner | 09:11 |
| mzanetti | ah. I've been talking to jouni about this | 09:11 |
| mzanetti | tsdgeos, so we figured that on krillin the sized down screenshots look quite bad, while on arale they don't | 09:11 |
| mzanetti | the reason is that the resolution is already quite low on krillin | 09:12 |
| mzanetti | so jouni asked for a threshold... i.e. use full pixel screenshots on krillin, scale downon arale | 09:12 |
| mzanetti | where does the spinner come from? design-wise | 09:13 |
| tsdgeos | it was there already i think | 09:13 |
| tsdgeos | maybe not, not sure | 09:13 |
| tsdgeos | no it's new | 09:14 |
| tsdgeos | not sure who told me to add it tbh | 09:14 |
| tsdgeos | does anyone know what's the command to enter a schroot in "modify" mode? | 09:17 |
| tsdgeos | ah it may be using source:vivid-amd64 as name | 09:18 |
| * tsdgeos checks | 09:18 | |
| tsdgeos | yep, cool | 09:20 |
| === MacSlow is now known as MacSlow|lunch | ||
| WhatsNew | www.VALBOT.COM provides domain valuations. Reporting globally on Site Traffic, Pagerank, Malware, WHOIS data, SEO & even Social Media presence. | 11:47 |
| === alan_g is now known as alan_g|lunch | ||
| pete-woods | anyone know what I have to do to get rid of these errors when running unity8? | 12:06 |
| pete-woods | Failed to start a new media-hub player session: org.freedesktop.DBus.Error.ServiceUnknown: The name core.ubuntu.media.Service was not provided by any .service files | 12:06 |
| pete-woods | I've installed and started media-hub | 12:06 |
| pete-woods | but it doesn't seem to be claiming that name on the bus | 12:06 |
| pete-woods | mzanetti / tsdgeos ? | 12:09 |
| === MacSlow|lunch is now known as MacSlow | ||
| === alan_g|lunch is now known as alan_g | ||
| tsdgeos | pete-woods: have never seen that to be honest | 12:51 |
| tsdgeos | pete-woods: is it on the desktop or on the phone you get this error? | 12:51 |
| pete-woods | tsdgeos: desktop | 12:52 |
| === marcusto_ is now known as marcustomlinson | ||
| === boiko_ is now known as boiko | ||
| === Olli_ is now known as olli | ||
| tsdgeos | dandrader: hi there maybe you can review https://code.launchpad.net/~aacid/unity8/fix_test_tutorial/+merge/262681 ? | 13:25 |
| dandrader | tsdgeos, sure | 13:41 |
| tsdgeos | dandrader: tx | 13:42 |
| tsdgeos | dandrader: using Shell in thre means copying code from OrientedShell to the test, which is worse than just using OrientedShell, no? | 13:49 |
| dandrader | tsdgeos, will check | 13:55 |
| dandrader | tsdgeos, I would think it would at most require assigning some Shell.qml properties, like "mode: "greeter" | 13:55 |
| tsdgeos | well | 13:56 |
| tsdgeos | yes and no | 13:56 |
| tsdgeos | the test is changing a gsetting and in exchange of that it expects things to behave differently | 13:56 |
| tsdgeos | the gsetting is processed in OrientedShell | 13:56 |
| tsdgeos | of course you can make the test change the property in tutorial directly | 13:56 |
| tsdgeos | but that makes part of the test less reliable since what we want is not that changing the property does something but that changing the gsetting does something | 13:57 |
| dandrader | tsdgeos, there's also the thing of "unit test vs. integration test": you usually want have the minimum amount of code/context/environment necessary to test a given feature/use case | 13:59 |
| tsdgeos | dandrader: yes we can discuss how many angels can dance on the head of a pin or just fix the test with a one liner | 14:00 |
| dandrader | tsdgeos, don't fret. Added the tst_Tutorial fix I suggested to https://code.launchpad.net/~dandrader/unity8/fixOrientedShellTests/+merge/262490 | 14:08 |
| tsdgeos | yeah whatevger | 14:09 |
| tsdgeos | i need to remember an easy review is never easy with you | 14:09 |
| dandrader | tsdgeos, http://bazaar.launchpad.net/~dandrader/unity8/fixOrientedShellTests/revision/1833 it simplifies tst_Tutorial.qml code | 14:09 |
| tsdgeos | it's silly you prefer to change 10 lines of code | 14:10 |
| tsdgeos | test less things | 14:10 |
| tsdgeos | and call it a win | 14:10 |
| tsdgeos | but i'm going on holidays again | 14:10 |
| tsdgeos | so \o/ | 14:10 |
| dandrader | tsdgeos, it's testing what it's supposed to test but it's not involving unrelated components unnecessarily. that's the spirit of unit testing. your arguments sounds like we should rewrite all our qmltests into autopilot tests, so we can test "more" | 14:13 |
| tsdgeos | dandrader: and that's why we don't call our tests unit tests :) | 14:14 |
| tsdgeos | dandrader: but don't worry you've won, no need to keep arguing, just that when the thing that we were testing before and we don't test with your change breaks i hope you remember how much better having pure unittests is | 14:15 |
| dandrader | tsdgeos, namely testing that a GSettings modifications affects Shell.usageScenario. That's a wholly different test from ensuring swipes in the Tutorial do what they should | 14:17 |
| tsdgeos | dandrader: the test checks that you don't get the right edge swipe when gsettings says we are on window mode, it's not "ensuring swipes in the Tutorial do what they should" | 14:19 |
| tsdgeos | now after your change it's only testing that it does so when shell.usageScenario = "desktop"; | 14:21 |
| tsdgeos | we've lost part of the test | 14:21 |
| tsdgeos | you understand that right? | 14:21 |
| tsdgeos | does the test *really belong* in there? i don't know and i don't care, i'm just saying testing less things is not good | 14:22 |
| tsdgeos | dandrader: while you're fixing tests you may want to fix testSurfaceContainer too | 14:46 |
| dandrader | tsdgeos, it checks tutorial behavior when shell is in windowed/desktop mode. the mock gsettings is just a *way* for the test to get shell into this mode. it's not part of the test itself | 14:47 |
| tsdgeos | dandrader: it's the way the real world gets it into this mode | 14:47 |
| tsdgeos | so it's a pretty important way :) | 14:47 |
| dandrader | s/test itself/code under test | 14:47 |
| tsdgeos | dude you're hard to talk to even when i've say you've won | 14:48 |
| tsdgeos | can we all go back to work? | 14:48 |
| tsdgeos | not sure what you're trying to convince me of really | 14:48 |
| MacSlow | ltinkl, mzanetti: I've resubmitted lp:~macslow/unity-api/set-progress-api to make the API-additions (spread across two branches) get merged in an organized/enforced order. | 15:02 |
| === dandrader is now known as dandrader|lunch | ||
| tsdgeos | cimi: how urgent is https://code.launchpad.net/~cimi/unity8/card-shadows-uitk1.1/+merge/261977 ? | 15:29 |
| tsdgeos | i.e. do i have to review it today or can it wait for next tuesday? | 15:29 |
| cimi | tsdgeos, better today if you can | 15:30 |
| cimi | tsdgeos, if you cannot, we can ask someone else | 15:30 |
| cimi | tsdgeos, since cardcreator breaks easily, better if we merge | 15:30 |
| tsdgeos | cimi: ok, i'll start now, but may need someone else to pick it up anyway unless i find it to be flawless | 15:32 |
| tsdgeos | cimi: i'm not going to have time for a proper review, i'll try to find some time tomorrow morning but can't promise i'll be able in shape to do much | 15:46 |
| cimi | tsdgeos, we can find someone else then, enjoy your time off | 15:47 |
| tsdgeos | cimi: in general it looks good i'd say | 15:51 |
| tsdgeos | did a few minor questions | 15:51 |
| tsdgeos | don't feel like you need to "agree/address" them | 15:51 |
| tsdgeos | just give it some extra thought and that's it | 15:51 |
| tsdgeos | then decide if what i ask makes sense or not :d | 15:51 |
| cimi | tsdgeos, replied | 15:55 |
| tsdgeos | replied back | 15:59 |
| cimi | tsdgeos, ok I will comment in genericscopeview | 16:00 |
| cimi | tsdgeos, it is not possible to have that size elsewhere | 16:01 |
| cimi | I'll actually change to 8gu, 7.4gu because that's the size we want | 16:01 |
| tsdgeos | cimi: okidoki | 16:15 |
| * tsdgeos waves | 16:15 | |
| cimi | tsdgeos, by... | 16:16 |
| cimi | ehm :D | 16:16 |
| === dpm is now known as dpm-afk | ||
| ljagielski | Hi, does anyone have idea if Unity global menu has stopped sending AboutToShow method? | 16:53 |
| ljagielski | I cannot find this in dbus-monitor in 15.04 and think it was there in 14.04 | 16:53 |
| === dandrader|lunch is now known as dandrader | ||
| === alan_g is now known as alan_g|EOD | ||
| attente | hi, does u8 still have known issues with multi-surface apps? | 18:41 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| mhall119 | so I'm trying to get the unity8-lxc installed, and during the setup stage I got stuck in a loop of these messages: | 20:41 |
| mhall119 | dpkg: warning: ignoring request to remove ubuntu-standard which isn't installed | 20:41 |
| mhall119 | dpkg: warning: ignoring request to remove systemd-sysv which isn't installed | 20:41 |
| mhall119 | just that, over and over again | 20:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!