=== rangerpb is now known as rangerpbzzzz === natorious is now known as zz_natorious === rangerpbzzzz is now known as rangerpb [13:55] Scott Moser proposed stackforge/cloud-init: tox: disable proxies when running nosetests https://review.openstack.org/195294 [13:55] claudiupopa, are you there ? [13:55] can you tell me if https://review.openstack.org/#/c/195294/1 works on windows ? [14:05] yeah, seems to work. [14:07] can you +1 ? or +2 if you want. [14:07] done. === smoser changed the topic of #cloud-init to: cloud-init || cloud-init 2.0 reviews: http://bit.ly/cloudinit-reviews [14:44] claudiupopa, so why did that not merge ? [14:45] does it need a jenins run, and if so why didnt it run [14:46] http://status.openstack.org/zuul/ seems to be a pretty big merge queue. [14:59] Merged stackforge/cloud-init: HACKING.rst: mention signing the contribors agreement https://review.openstack.org/194340 [15:14] Scott Moser proposed stackforge/cloud-init: tools/tox-venv: support running other than ./tools/tox-venv https://review.openstack.org/195631 [15:19] Merged stackforge/cloud-init: tox: disable proxies when running nosetests https://review.openstack.org/195294 [15:20] Scott Moser proposed stackforge/cloud-init: tools/tox-venv: support running other than ./tools/tox-venv https://review.openstack.org/195631 [15:22] Scott Moser proposed stackforge/cloud-init: Clean up stale auto-generated autodoc files. https://review.openstack.org/191139 [15:47] smoser is on a rampage. [16:47] harlowja, around ? [16:54] Scott Moser proposed stackforge/cloud-init: Bring over the 'safeyaml' from bzr https://review.openstack.org/170252 [16:58] claudiupopa, if you want, you requeseted test there, i added some ^ [17:02] or Odd_Bloke if you want to review that. [17:06] Merged stackforge/cloud-init: Clean up stale auto-generated autodoc files. https://review.openstack.org/191139 [17:24] smoser suppp [17:33] harlowja, i was gonna ask about how to add tests to your existing change id [17:34] its really wierd.. ijust --amend [17:34] and git review [17:34] and my patchset rplaced yours [17:34] hmmm, lol [17:34] which is wierd in my opinion [17:34] :) [17:34] touching my patchesets, how dare u [17:34] lol [17:35] so what u did is one way, the other way is to make a dependent review [17:35] where u make a new patchset (using the initial one as the base) and then do git-review -R [17:35] *which makes that new review have a dependency on the first [17:36] otherwise ya, the patchsets sorta just get added ontop [17:40] yeah. i think the way i did it makes more sense here. [17:40] as the dependent review would then hav both of them in the git log [17:40] but yours wasnt acceptable without the tests [17:42] :-P [17:44] hm.. [17:44] what to do here. [17:44] looking at the templeter [17:44] and tests for it. [17:45] up to u, how much of it u want to keep :-P [17:50] smoser one option, remove the basic_rendering support, leave jinja2 [17:50] that might help reduce the amount of stuff to test (and meh, do we need that other way anymore?) [17:51] otherwise, include a bunch of test-templates.txt, ensure they get expanded to expected-out-test-templates.txt or whatever [17:51] and blow-up if not [17:51] i think just if its not declared, then we use builtin [17:52] its fine for some things. [17:52] k [17:52] * harlowja doesn't have any attachment to it :-P [17:52] my precious! [17:52] lol [17:54] harlowja, i have this right now: [17:54] http://paste.ubuntu.com/11774661/ [17:54] seems fair to me [17:54] the value in it is that we have *some* builtin renderer [17:54] agreed, which probably suits 90% of the cases anyway [17:55] except for weird i need to have for loops in my tempaltes and such [17:55] well. yeah, i think as we start offering $datasource.hostname [17:55] and such, the builtin will probably fall appart [17:56] Why do we need a bultin renderer at all? [17:56] i'm wondering if you were right though, an djinja should be the default [17:56] as long as jinja2 doesn't die like cheetah, lol [17:56] i dont know, Odd_Bloke [17:56] It's more stuff for our users to learn, and more code for us to maintain. [17:56] its only really for backwards compat. [17:56] Backwards compatibility is probably an argument for it though. [17:57] ^_^ [17:57] so lets say things.. [17:57] should we support cheetah to then :-P [17:57] for backwards compat ;) [17:57] the thing it comes down to is selecting a default [17:57] /kick harlowja NO [17:57] lol [17:57] but but but [17:58] ha [17:58] any template can declare what it needs to be rendered with [17:58] but if there is no header ('##template: jinja2') [17:58] then what do we do? [17:58] what i did just right there was fall back to the builtin [17:58] if we say instead "undefined is jinja2" [17:58] then in the far future world of jinja2-is-dead [17:58] jinja3 ftw [17:59] then we are in the position of basically *having* to break someone [17:59] as we wont be be able to render their undeclared thing [17:59] Jinja2 is very unlikely to go anywhere. [18:00] jinja3 ftw [18:00] lol [18:00] And if it does, we just vendor it in and warn people that it's deprecated. [18:00] meh [18:00] i think i like basicaly requiring the declaration [18:01] ya, we can do that to [18:01] you either declare what you want, where we can then definitively render it or not [18:01] or you dont [18:01] and you get harlowja's crappy builtin renderer [18:01] da best ever! [18:01] lol [18:01] i think i'll add a alias for 'basic' from 'harlowja-crap' [18:01] I think it would be good to warn people against using harlowja's crappy builtin renderer. [18:01] u have to rename it 'crappy_built_in_renderer' [18:01] Something in the log or somesuch. [18:01] Odd_Bloke, why? we can maintain that. [18:01] its not hard. [18:02] I guess. [18:03] * harlowja surely will miss cheetah though, lol [18:04] we could also default to https://github.com/Yelp/yelp_cheetah [18:04] lol [18:04] harlowja, we can bring it back. [18:04] just for old times sake [18:04] :-P [18:08] We really recommend that you don't choose cheetah for new projects, and certainly not this hacked fork [18:09] lol [18:09] i think i'm going to add things like that to all my code from now on [18:09] don't listen to them, jeez [18:09] lol [18:09] :) [18:09] "i really recommend you dont use this." [18:09] :) [18:09] instead, maybe go outside and get some exercise! [18:09] isn't that what all those licenses are for, lol [18:10] thought they did the same thing, use at your own risk, its just opensource mannnn [18:10] lol [18:10] *aka u can't sue me ... [18:11] https://github.com/stackforge/cloud-init/blob/master/LICENSE-Apache2.0#L144 (that section, lol) === zz_natorious is now known as natorious [19:32] alright. i almost have tests for templter whoo hoo [19:33] woooo [19:33] u da man [19:43] the key to improving test coverage is reducing lines of code === natorious is now known as zz_natorious [19:44] Scott Moser proposed stackforge/cloud-init: Bring over the 'templater' from bzr https://review.openstack.org/170257 === smoser changed the topic of #cloud-init to: cloud-init || cloud-init 2.0 reviews: http://bit.ly/cloudinit-reviews [19:50] :) [19:50] i still see lines of code there [19:50] its not 0 [19:50] lol [19:56] what i didn't say was one of the things i did was join lines. [19:56] because 2 lines of 30 characters is 2 lines. [19:56] :) [19:56] but one line of 60 chars is only 1 [19:56] :) [19:58] Scott Moser proposed stackforge/cloud-init: Bring over the 'templater' from bzr https://review.openstack.org/170257 [19:59] harlowja, you want to review your code there + my tests ? [19:59] :) [19:59] sureeeee [19:59] oh man, whoever wrote that code is super [19:59] lol === zz_natorious is now known as natorious === natorious is now known as zz_natorious [20:06] smoser ok added a comment [20:06] i think the fixtures test library can replace that custom tempdir [20:07] commonly used in other parts of openstack (since the author works there) [20:14] harlowja, i dont want to just grab dependencies. [20:14] i dont like writing code just because either [20:14] this would only be a test dep [20:14] yeah, thats not so bad. [20:14] :-P [20:20] harlowja, if you want to add fixtures useage thats ok. [20:20] k [20:20] i can after that goes in [20:20] ok with u [20:21] i'm cool with that [20:21] bb [20:21] but can we make sure it works iwth trusty [20:24] sure, [20:24] afaik the package exists there [20:31] its 0.3 in trusty [21:01] ok, thats pretty old, but should be ok for this i think === rangerpb is now known as rangerpbzzzz === zz_natorious is now known as natorious === natorious is now known as zz_natorious