* cjwatson embarks on a bit of refactoring there00:02
cjwatsonwgrant: I think it was actually broken by r17579 and we just didn't notice.  inferred_vcs shows up in the output.00:06
wgrantcjwatson: Quite possibly. Must be test ordering.00:07
wgrantSince that test has passed since then.00:07
cjwatsonYeah, as I say that test doesn't seem as careful as it should be.00:07
cjwatsonI'm up for a while yet, so I'll clean it up00:08
wgrantI'd forgotten about the JSON cache when I approved that branch. I'm tempted to revert the inferred_vcs export.00:08
wgrantblr: What do you think?00:09
wgrantinferred_vcs should be temporarily, anyway, as we can backfill vcs at some point.00:09
wgrantAnd it is causing every Product view to incur Branch and GitRepository queries to render the JSON representation.00:10
cjwatsonI wouldn't be sad about that00:17
blrwgrant: how valuable is it to expose in the api?00:27
wgrantblr: I don't think it's very interesting at the moment.00:28
blrwe really only need it internally for now00:28
blrwgrant: are you happy to revert the export or shall I?00:30
wgrantblr: Could you? Most/all of the query count test fixes can probably go.00:34
blrwgrant: sure00:35
cjwatsonHa, after starting on this refactoring I notice that I have a branch from March with exactly the same thing in progress00:52
wgrantcjwatson: I hate it when that happens.01:25
wgrantLike with the product-aps thing01:26
wgrantI was looking on DF and wondering why the query didn't use the Product.access_policies that clearly already existed.01:26
wgrantSo I tweak the query locally and the tests fail because the column doesn't exist.01:27
wgrantI'd worked through most of the solution on DF in February and completely forgotten all about it.01:27
wgrantblr: All the other test changes are still necessary with that reverteD?04:33
blrwgrant: hmm perhaps I missed some tests, green with regex 'query_count' and 'test_product', plus the doctest04:37
wgrantblr: I'd just look through your two testfix merges to see if you've missed anything.04:39
blrwgrant: yes, the other querycount bumps are necessary (specification, bugtask, gitlisting)04:51
wgrantblr: Weird, OK.\04:52
wgrantI even filed a bug about the thing I forgot about, with details: https://bugs.launchpad.net/launchpad/+bug/142543005:18
mupBug #1425430: Bulk project access checks are slow <privacy> <private-projects> <timeout> <Launchpad itself:Triaged> <https://launchpad.net/bugs/1425430>05:19
cjwatsonblr: I think your latest change will result in duplicated result lines if there is a comment in the dirty header and a comment somewhere else in the same file08:25
cjwatsonblr: You probably want http://paste.ubuntu.com/11797735/ ?08:28
cjwatsonwgrant: Any word on the Soyuz redesign docs you had sketches of?08:32
wgrantcjwatson: No.08:35
wgrantbuildbot is very unhappy with me.08:35
wgrantI have a vague recollection of Storm leaking references with List attributes.08:35
wgrantMany years ago.08:35
cjwatsonIt really is ...08:35
wgrantPackageUpload.searchable_versions is a List, though.08:36
wgrantAnd it doesn't seem to blow up quite so effectively.08:36
blrcjwatson: err quite, thanks.08:50
wgrantI can reproduce it locally, at least, on one test.08:55
blrwgrant: shall I land this in the morning, given you and buildbot are not on good terms atm?09:02
wgrantblr: Yeah, landing it now won't exactly work.09:25
wgrantAhhh, computers, how I love you.09:29
wgrantCan reliably reproduce in product-aps-set09:29
wgrantCannot reproduce in current devel.09:30
wgrantBut buildbot can.09:30
cjwatsonI'm going to see if I can implement my apt-get build-dep / dose-builddebcheck suggestion today, unless anyone has serious objections.09:32
cjwatsonStarting with trying to backport the thing to precise ...09:32
wgrantThe whole pulling ocaml into everywhere thing is sort of unpleasant.09:33
wgrantBut worth a try, I suppose.09:33
cjwatsonOnly into our build-dep chain.09:33
cjwatsonocaml binaries are standalone once you get them built.09:33
wgrantBut is ocaml in the interesting bootstrap set today?09:34
blrocaml? O.o09:34
wgrantOh, it's in main, so it must be.09:34
wgrantblr: Yes, people are weird, sadly.09:34
cjwatsonThis kind of problem often fits functional languages quite well.09:35
cjwatsonWe could reduce bootstrap problems by allowing lp-buildd to degrade to failing versioned build-dep failures if it doesn't have dose.09:36
cjwatsonocaml is in main because of llvm-toolchain-* b-ding on dh-ocaml.  Not sure why that is.09:37
blrwgrant: yes, and then write libraries like this http://sumtypes.readthedocs.org/en/latest/09:40
lifelesswgrant: people are weird w.r.t. ocaml ?09:42
wgrantlifeless: There are only three projects I've ever cared about written in it, and at least one of them (sks) has no reason to be.09:44
blrlifeless: I've never met a quant, but I can imagine they would be very weird.09:44
wgrantI think the leak may be through Storm's MutableValueVariable._event_system, but I'm just avoiding that part of the code entirely for now.12:18
cjwatsonwgrant: Want me to organise a deployment this afternoon if possible, assuming that you defeat it before EOD?12:21
wgrantcjwatson: Yeah, just waiting for tests to complete.12:31
wgrantThen I get get -use landed and deployed tomorrow afternoon.12:32
wgrantSo perhaps the mere act of reading it is sufficient for doom. Bah.12:58
mptWow bug 1853 is in progress \o/13:04
mupBug #1853: Project group "display name" is redundant with "title" <feature> <lp-registry> <projectgroups> <Launchpad itself:Triaged> <https://launchpad.net/bugs/1853>13:04
mptThe 20th-oldest still-open Launchpad bug report13:07
rpadovaniI know you guys are super busy, but do you have 5 minutes to take a look to https://bugs.launchpad.net/loggerhead/+bug/1436483 ? The diff side by side in completely unusable, and I'm sure it's a 5 minutes fix20:16
mupBug #1436483: The diff page side by side has broken layout <loggerhead:New> <https://launchpad.net/bugs/1436483>20:16
blrrpadovani: certainly not looking very side by side there.20:43
rpadovaniblr, :D I think it's due the  radius borders someone added back in march20:47
blrhmm, that's a different issue, I'm not sure that style should be applied there.20:51
blrrpadovani: I think the issue is the padding20:52
blron .code, .linenumber20:52
blrrpadovani: thanks for the report, will get that fixed now. I just need to see if that style is being used elsewhere (probably how this bug was introduced)20:54
rpadovaniblr, thanks for the fast response, I should ping you guys more often :D20:54
blryeah, please do :)20:55
blrrpadovani: wow, how long has this been broken, any idea?21:07
blrbzr blame is suggesting that padding was added in 2011...21:08
rpadovaniblr, so it isn't, because I used to use it until I opened the bug21:08
blrrpadovani: ok, something else going on in that case (although that did fix it...)21:09
rpadovaniblr, the width of .lineNumber21:12
rpadovanithat fixes https://bugs.launchpad.net/loggerhead/+bug/31025521:13
mupBug #310255: 6 digit line numbers get cutoff <loggerhead:Fix Released by cruzjbishop> <https://launchpad.net/bugs/310255>21:13
blrrpadovani: looking for a diff that satisfies both21:15
blrhmm I don't actually know who reviews loggerhead.. I guess we do?21:37
blrrpadovani: thanks, cjwaston will probably want to look at that, but should be landed soon.21:44
rpadovaniblr, thanks to you :-)21:45
blrmaybe we need css regression testing!21:45
rpadovanior a theme ex-novo, maybe responsing (just joking)21:46
blra responsive theme for LP would be great, but a fair bit of work I'd imagine.21:47
rpadovanitbh after the git support the thing I really would like are webhooks (and I see you are working on them)21:49
blryep, webhooks are coming :)21:49

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!