| wgrant | blr: What's the status of the loggerhead and go get branches? | 00:49 |
|---|---|---|
| wgrant | Oh | 00:51 |
| wgrant | The loggerhead branch landed a minute before I asked? | 00:51 |
| wgrant | Between loading +activereviews and the actual MP... | 00:51 |
| wgrant | Nice timing! | 00:51 |
| blr | wgrant: just had a look at BranchRefNavigation, so presumably I want context.development_focus.unique_name? | 01:01 |
| wgrant | blr: Yep, I think that's right. | 01:03 |
| wgrant | The aliases aren't resolved by the codehosting HTTP server, unlike the git case. | 01:03 |
| wgrant | blr: Is the go branch ready now? | 02:07 |
| blr | wgrant: yep, I think so, want to have a look? | 02:22 |
| wgrant | blr: I'd suggest reworking the tests to verify that it actually ends up on the page. | 02:23 |
| wgrant | blr: Create branches and repos with known paths and then check that the meta tag appears in the HTML. | 02:24 |
| blr | wgrant: ok, worth keeping the unit tests as well? | 02:24 |
| blr | will add a soupmatcher | 02:25 |
| wgrant | blr: I'd probably do both. Construct the branch/repo with a known path, create the view, check the property, and then render the view and check the content to verify that the template worked. | 02:25 |
| wgrant | Yep | 02:25 |
| blr | wgrant: do you have a sec to look over those tests again please? | 03:17 |
| blr | hmm perhaps would be good to have a negative test with no vcs default set. | 03:21 |
| wgrant | Indeed, worth checking the tag isn't there at all. | 03:24 |
| wgrant | And default VCS but no default repo or no default branch depending on the VCS. | 03:24 |
| blr | wgrant: added those tests, thanks. | 04:38 |
| blr | mwhudson: would you like to review the branch? | 04:38 |
| mwhudson | blr: er, seems like i'm too late? | 07:32 |
| mwhudson | it looks ok to me | 07:37 |
| mwhudson | i'll have a poke at it when it hits qastaging | 07:38 |
| mwhudson | i forget how often it updates... | 07:38 |
| StevenK | mwhudson: Automatically, and it will try every 15 minutes | 07:41 |
| mwhudson | ah | 07:41 |
| mwhudson | from stable? or db-stable? | 07:41 |
| StevenK | qastaging from stable | 07:42 |
| mwhudson | half an hour or so then | 07:44 |
| blr | mwhudson: great, thanks | 08:16 |
| mwhudson | blr: hrm, shouldn't there be appropriate tags on view-source:https://qastaging.launchpad.net/pydoctor ? | 08:17 |
| mwhudson | or is the "qastaing doesn't really have the branches" thing | 08:17 |
| wgrant | mwhudson: You'll need to set the Product.vcs property until we backfill it. Hit the Code config link in the sidebar and hit save without making any changes. | 08:26 |
| wgrant | That should make it appear. | 08:26 |
| mwhudson | ah, i loaded the page and saw bzr already selected | 08:27 |
| mwhudson | cool | 08:27 |
| mwhudson | hm :( | 08:28 |
| mwhudson | mwhudson@glamdring:linux_arm64_dynlink$ go get -v qastaging.launchpad.net/pydoctor | 08:28 |
| mwhudson | Fetching https://qastaging.launchpad.net/pydoctor?go-get=1 | 08:28 |
| mwhudson | Parsing meta tags from https://qastaging.launchpad.net/pydoctor?go-get=1 (status code 200) | 08:28 |
| mwhudson | import "qastaging.launchpad.net/pydoctor": parse https://qastaging.launchpad.net/pydoctor?go-get=1: no go-import meta tags | 08:28 |
| mwhudson | package qastaging.launchpad.net/pydoctor: unrecognized import path "qastaging.launchpad.net/pydoctor" | 08:28 |
| mwhudson | doesn't look happy | 08:28 |
| wgrant | Oh | 08:30 |
| wgrant | <meta name="go-import" | 08:30 |
| wgrant | content="qastaging.launchpad.net/~mwhudson/pydoctor/github bzr http://bazaar.qastaging.launchpad.net/~mwhudson/pydoctor/github" /> | 08:30 |
| wgrant | there's the problem | 08:30 |
| mwhudson | hm? | 08:31 |
| wgrant | The first bit should be just qastaging.launchpad.net/pydoctor | 08:31 |
| mwhudson | ah | 08:31 |
| mwhudson | yeah | 08:31 |
| wgrant | blr: ^^ | 08:31 |
| mwhudson | oh right | 08:31 |
| mwhudson | confusing message :/ | 08:32 |
| mwhudson | hey, um, the configure code link doesn't appear after you change the default to git | 08:33 |
| mwhudson | is that a known bug? | 08:33 |
| blr | wgrant: hmm, so it should be, will fix. | 08:37 |
| blr | mwhudson: sorry, check again tomorrow morning :0 | 08:38 |
| wgrant | mwhudson: Yep, for now you have to get there from the sidebar on +index | 08:39 |
| blr | wgrant: mwhudson: fix here once the diff renders, https://code.launchpad.net/~blr/launchpad/golang-meta-import-fix/+merge/263625 | 08:52 |
| wgrant | blr: Does it fix the series case too? | 08:53 |
| blr | wgrant: yes | 08:54 |
| blr | wgrant: if there's a bug for the missing link, could you assign it to me (sounds like a regression from my configure-code branch?) | 08:58 |
| blr | mwhudson: will ping you when the fix is on qastaging. | 09:04 |
| mwhudson | blr: thanks | 09:14 |
| wgrant | blr: Nope, I just never added the link to +git. | 09:26 |
| wgrant | (because of the awkwardness around showing portlets for the default git repo too) | 09:26 |
| cjwatson | Ooh, first trimmed-to-context inline comment mail I've seen. Nice. | 09:31 |
| cjwatson | Hm, looks slightly off though | 09:32 |
| cjwatson | blr: Would you like me to have a look at the dodgy quoted patch headers near the top of http://paste.ubuntu.com/11809068/ ? Must be near your EOD | 09:33 |
| cjwatson | There's an extra "=== modified file 'lib/lp/registry/browser/productseries.py'" for some reason | 09:33 |
| cjwatson | Oh dear, that looks like a bzrlib bug | 09:40 |
| cjwatson | http://paste.ubuntu.com/11809104/ | 09:40 |
| wgrant | But it doesn't throw the line numbers off? Weird. | 09:50 |
| cjwatson | Just working on setting up a bzr test case | 09:51 |
| lifeless | wgrant: btw | 10:09 |
| lifeless | wgrant: have you noticed the Canonical internal channel references on the sso recovery help page | 10:09 |
| lifeless | wgrant: https://login.launchpad.net/+device-help | 10:10 |
| wgrant | lifeless: Yes | 10:10 |
| wgrant | We don't maintain SSO, and there is a bug reported AIUI. | 10:10 |
| lifeless | ok cool | 10:10 |
| lifeless | I know you don't | 10:10 |
| lifeless | but you're closer to the issue :) | 10:10 |
| cjwatson | blr,wgrant: https://code.launchpad.net/~cjwatson/bzr/fix-keep-dirty/+merge/263632 | 10:47 |
| cjwatson | If you're OK with that, I can stuff it into 2.6.0.lp.2 for the time being | 10:47 |
| wgrant | cjwatson: lgtm, thanks | 10:53 |
| cjwatson | wgrant: I don't know the bzr landing process. Is it supposed to wait for Richard? | 10:58 |
| cjwatson | (for trunk, that is, I'll go ahead with .lp.2 nowish) | 10:59 |
| wgrant | cjwatson: Anyone with PQM access (eg. vila) can land it. | 11:00 |
| cjwatson | vila: oh hai :-) | 11:01 |
| vila | cjwatson: hey ! /me looks | 11:04 |
| vila | cjwatson: reviewed, minor nit and it's good to land | 11:19 |
| cjwatson | Ah, assertLength, nice. | 11:30 |
| cjwatson | vila: Fixed, thanks | 11:31 |
| vila | cjwatson: thanks, sent to pqm | 11:59 |
| cjwatson | Yay, thanks | 12:00 |
| * cjwatson gets that into LP | 12:00 | |
| cjwatson | Hopefully pqm actually works at the moment | 12:03 |
| === frankban_ is now known as frankban | ||
| vila | cjwatson: err, pqm... lacks hope ? | 15:15 |
| vila | http://pqm.bazaar-vcs.org/ is up though | 15:15 |
| cjwatson | vila: Richard Wilbur reported that it didn't work the other day; we sent him to the public RT | 15:15 |
| vila | cjwatson: I missed that :-/ What's the public RT ? | 15:16 |
| cjwatson | rt.ubuntu.com, but I don't see a ticket from him there | 15:16 |
| cjwatson | oh, https://rt.ubuntu.com/Ticket/Display.html?id=26672 | 15:16 |
| cjwatson | vila: failing that, looks like you'll need to ask webops to have a look, perhaps referencing that ticket | 15:17 |
| vila | cjwatson: thanks ! will do | 15:19 |
| cjwatson | Laney: I'm sure that, absent a heatwave, it would have taken me a considerably shorter time to sort out this dep-wait bug | 16:13 |
| cjwatson | I think I have code that will do the job now, but need to figure out tests | 16:13 |
| Laney | cjwatson: Oh nice, you were working on it? | 16:13 |
| cjwatson | Yeah | 16:13 |
| Laney | I saw some chatter about dose-debcheck so thought you may be going all out straight off | 16:13 |
| cjwatson | I tried using dose but it ended up being more trouble than worth | 16:14 |
| cjwatson | Since we explicitly only want to care about the top level of build-deps, it's just as easy to check them directly using python-debian | 16:14 |
| cjwatson | (I'd love to have something like Debian's dose-builddebcheck setup, but it's hard to do efficiently with lots of archives) | 16:15 |
| Laney | That's an interesting problem | 16:19 |
| Laney | I suppose you should be able to make the overlay archive case more tractable by reusing earlier analysis | 16:20 |
| cjwatson | In principle | 16:36 |
| cjwatson | In practice I fear it's a fair bit of work in dose ... | 16:36 |
| cjwatson | Anyway, not needed for this bug | 16:36 |
| blr | cjwatson: hmm, did you happen to find the bug in bzrlib? Potentially something I introduced with the changes for preserving dirty headers | 20:31 |
| blr | cjwatson: ah I see you did, thank you. | 20:34 |
| blr | wgrant: one last thing with the goimport that I believe I missed, in the series case the content should be "{base}/product/series bzr branch_path"? | 20:39 |
| blr | thanks vila | 20:49 |
| vila | blr: ;) o/ | 20:52 |
| vila | blr: not landed on lp:bzr yet as pqm is broken :-} | 20:52 |
| vila | err, broken as in someone is fixing it, not broken and nobody can land in lp:bzr anymore, it's an LTS package after all :o) | 20:53 |
| blr | hah right | 20:54 |
| cjwatson | blr: Yeah, all sorted modulo the PQM problem, landed on qastaging | 22:39 |
| wgrant | blr: Right, the first segment needs to match the request, and the third segment needs to be the full branch path. | 22:55 |
| blr | wgrant: yep. that should be looking better now. | 22:59 |
| blr | wgrant: cjwatson approved earlier, but before that fix, want to have another look? | 23:01 |
| wgrant | blr: lgtm, thanks. | 23:08 |
| mwhudson | woot | 23:08 |
| mwhudson | oh yeah, i was trying to test the git support last night | 23:08 |
| mwhudson | get "qastaging.launchpad.net/pyrepl": found meta tag main.metaImport{Prefix:"qastaging.launchpad.net/pyrepl", VCS:"git", RepoRoot:"https://git.qastaging.paddev.net/pyrepl"} at https://qastaging.launchpad.net/pyrepl?go-get=1 | 23:08 |
| mwhudson | looks good? | 23:09 |
| mwhudson | the subsequent bits aren't going to be happy because that isn't a go project | 23:09 |
| blr | mwhudson: yes, the git case was fine, I just mangled the bzr case :) | 23:09 |
| mwhudson | blr: seems good to check :) | 23:09 |
| blr | just landing the fix branch now | 23:09 |
| mwhudson | cool | 23:09 |
| mwhudson | so qastaging will get it in an hour or so? | 23:10 |
| blr | mwhudson: yep! | 23:10 |
| wgrant | Yep, about an hour. | 23:10 |
| mwhudson | cool | 23:10 |
| mwhudson | then what's the eta until production? | 23:10 |
| mwhudson | want to get the special case removal change upstream asap | 23:10 |
| wgrant | mwhudson: We should deploy today for the MP email fix anyway, so two or three hours? | 23:11 |
| mwhudson | wgrant: AWESOME | 23:11 |
| blr | wgrant: is that reliant on the pqm fix? | 23:11 |
| wgrant | blr: No, we have a patched version of bzr anyway, which Colin's upgraded devel to in the latest revision. | 23:12 |
| blr | ah good, okay. | 23:12 |
| wgrant | bzr's PQM is broken, not ours. | 23:12 |
| blr | right | 23:12 |
| blr | vila: do you think there will be another bzr release? | 23:12 |
| blr | nice to see the less verbose MP comment email coming through, modulo the wonkiness. | 23:14 |
| wgrant | Indeed, it is a big improvement. | 23:14 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!