=== rangerpbzzzz is now known as rangerpb
[13:27] <openstackgerrit> Merged stackforge/cloud-init: Speed up a slow test.  https://review.openstack.org/198348
[13:40] <openstackgerrit> Daniel Watkins proposed stackforge/cloud-init: Move our TestCase in to the cloudinit.tests package.  https://review.openstack.org/198308
[13:48] <smoser> Odd_Bloke, how did you know about / find the mock timejump ?
[14:05] <Odd_Bloke> smoser: It's just a trick I've picked up before; all it's doing is using mock's side_effect (which lets you define fake return data).
[14:15] <smoser> Odd_Bloke, duh. i didnt' see the function you added.
[14:16] <smoser> and googled for that method name with no results.
[14:16] <smoser> now it makes more sense :)
=== smoser changed the topic of #cloud-init to: cloud-init || cloud-init 2.0 https://review.openstack.org/#/q/project:stackforge/cloud-init+status:open,n,z http://bit.ly/cloudinit-reviews
[14:22] <Odd_Bloke> smoser: ^_^
[14:24] <smoser> Odd_Bloke, just pinged in openstack-infra fro help on https://review.openstack.org/#/c/191081/
=== smoser changed the topic of #cloud-init to: cloud-init || cloud-init 2.0 http://bit.ly/cloudinit-reviews-public http://bit.ly/cloudinit-reviews
[14:27] <Odd_Bloke> smoser: Thanks. :)
[14:28] <Odd_Bloke> (I've done that several times, so we'll see if you get more attention than me :p)
[14:38] <Odd_Bloke> smoser: You're magic!
[14:44] <Odd_Bloke> smoser: Could I pick your brains about https://bugs.launchpad.net/cloud-init/+bug/1470890?
[14:46] <Odd_Bloke> smoser: I have a couple of ideas of how we could fix it: (a) implement a GCE special-case like the EC2 special case, or (b) add a DataSource.region attribute which can be used in the same way that DataSource.availability_zone is used now.
[14:46] <Odd_Bloke> smoser: (b) is preferable, because it should be more generally useful, but at the moment we only pass AZ through to the relevant parts of the code, so it will involve a bit more rejigging.
[14:47] <Odd_Bloke> smoser: Thoughts on those ideas (or additional suggestions) most appreciated.
[15:17] <Odd_Bloke> smoser: Hmm, actually threading it through wasn't too painful.
[15:17] <Odd_Bloke> Because it's pretty much only this code path that uses it.
[15:18] <Odd_Bloke> Though it may make the backport more painful. :/
[15:31] <smoser> yeah, its a convoluted path that gets there.
[15:32] <smoser> i think someone else one of hte other cpc customers wanted something similar to find their mirrors.
[15:32] <smoser> i'm fine if you clean it up. old behavior needs to be preserved is all/
[15:34] <smoser> Odd_Bloke, for stuff like https://review.openstack.org/#/c/198263/ i'd be nice if you referenced the other change-id i think. or at least some place said, we'll be getting code coverage gating via http://....
[15:38] <Odd_Bloke> smoser: Sure. :)
[16:09] <Odd_Bloke> harlowja, oh guru of all that is OpenStack CI, why hasn't Jenkins unverified https://review.openstack.org/#/c/198308/ and queued it for gate?
[16:09] <Odd_Bloke> (Is it because we already have a job waiting in the gate queue?)
[16:25] <harlowja_at_home> yo yo
[16:25] <smoser> hey. you still holiday ?
[16:25] <harlowja_at_home> nah, have oslo irc meeting on monday mornings
[16:25] <harlowja_at_home> so just finished that
[16:25] <harlowja_at_home> i'm always on holidy man
[16:25] <harlowja_at_home> lol
[16:26] <harlowja_at_home> hmmm, why isn't that review on http://status.openstack.org/zuul/
[16:26] <harlowja_at_home> thats weird
[16:26] <harlowja_at_home> openstack CI sometimes is weird
[16:27] <harlowja_at_home> bb though, heading into work lan
[16:27] <harlowja_at_home> *work land
[16:28] <harlowja_at_home> Odd_Bloke, maybe jump on #openstack-infra and ask around; seems weird
[16:34] <Odd_Bloke> Oh, hmph, coverage fail.
[16:46] <openstackgerrit> Daniel Watkins proposed stackforge/cloud-init: Don't consider version-specific code for coverage.  https://review.openstack.org/198263
[16:47] <Odd_Bloke> smoser: You actually workflow-toggled the wrong change, but it doesn't matter because it would fail anyway because of coverage.
[16:48] <smoser> hah. funny.
[16:48] <Odd_Bloke> smoser: harlowja: Review of the above appreciated; it should fix the coverage failure (though, of course, Jenkins will let us know if that is the case).
[16:51] <openstackgerrit> Daniel Watkins proposed stackforge/cloud-init: Move our TestCase in to the cloudinit.tests package.  https://review.openstack.org/198308
[17:18] <harlowja> ok bacccck
[18:52] <openstackgerrit> Merged stackforge/cloud-init: Don't consider version-specific code for coverage.  https://review.openstack.org/198263
[19:00] <openstackgerrit> Merged stackforge/cloud-init: Move our TestCase in to the cloudinit.tests package.  https://review.openstack.org/198308
=== zz_natorious is now known as natorious
=== rangerpb is now known as rangerpbzzzz
=== natorious is now known as zz_natorious