| * thumper wields a hatchet in one hand and a machete in the other | 01:18 | |
| thumper | and yet still manages to type | 01:18 |
|---|---|---|
| * thumper dives into the code | 01:18 | |
| wallyworld | thumper: how many fingers do you have left? | 01:33 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| jam | wallyworld: /wave | 05:46 |
| wallyworld | hi jam | 05:46 |
| wallyworld | can i ping you in say 30 minutes? | 05:46 |
| jam | I'm a little scattered to chat a bunch right now, but 30min should be good | 05:46 |
| wallyworld | ok, we can start talking and schedule smething for later | 05:47 |
| wallyworld | jam: you ok to talk? https://plus.google.com/hangouts/_/canonical.com/tanzanite-stand | 06:34 |
| jam | wallyworld: sorry I completely missed your message. Are you still around? | 07:48 |
| wallyworld | jam: yeah, but off to soccer soonish, can i ping you in say 3 hours? | 07:49 |
| jam | wallyworld: sure | 07:49 |
| wallyworld | ok, will do | 07:49 |
| jam | fwereade: voidspace: standup? | 09:01 |
| voidspace | jam: omw | 09:02 |
| voidspace | jam: fwereade: dooferlad: TheMue: I just got booted out, have to rejoin | 09:05 |
| voidspace | aaaand... it doesn't work | 10:15 |
| voidspace | time for some diagnostics | 10:15 |
| wallyworld | jam: you free now? | 11:04 |
| jam | wallyworld: can you give me a couple of mins? | 11:08 |
| wallyworld | sure | 11:08 |
| jam | wallyworld: I'm around now if you're up for chatting | 11:22 |
| wallyworld | sure | 11:22 |
| wallyworld | https://plus.google.com/hangouts/_/canonical.com/tanzanite-stand | 11:22 |
| jam | says trying to connect. gimme a sec I guess | 11:24 |
| jam | ah, I had to pass the magic authuser=1 | 11:24 |
| ashipika | is something wrong with the reviewboard? | 11:32 |
| mup | Bug #1472231 opened: juju-mongodb derror when bootstraping on maas <juju-core:New> <https://launchpad.net/bugs/1472231> | 11:37 |
| perrito666 | morning | 11:46 |
| wallyworld | dooferlad: hey, you around? | 12:11 |
| wallyworld | or voidspace | 12:12 |
| dooferlad | wallyworld: hi, was having lunch. How can I help? | 12:47 |
| wallyworld | dooferlad: hey, bug 1472014 is because machine address updates for state server are not triggering the machine address watcher. it looks like the state server has around 3 cloud local IP addresses but only 1 is reported via the watcher. i was wondering if you could take a look and see what might need fixing | 12:49 |
| mup | Bug #1472014: juju 1.24.0: wget cert issues causing failure to create containers on 14.04.2 with lxc 1.07 <openstack-installer> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1472014> | 12:49 |
| wallyworld | comment #4 has a summary of the core issue | 12:49 |
| dooferlad | sure, will take a look | 12:49 |
| wallyworld | ty | 12:49 |
| wallyworld | ping me if anything is unclear | 12:50 |
| wallyworld | we can pick it up and make a fix, but i'd like a hand in diagnosing | 12:50 |
| wallyworld | as i need sleep soon | 12:50 |
| dooferlad | sounds good | 12:51 |
| wallyworld | ty | 12:51 |
| mup | Bug #1472231 changed: juju-mongodb derror when bootstraping on maas <mongodb> <juju-core:New> <https://launchpad.net/bugs/1472231> | 13:22 |
| perrito666 | katco: are you going to the call? | 13:23 |
| === kadams54 is now known as kadams54-away | ||
| ionutbalutoiu | mgz: bogdanteleaga told me that you need some help with powershell. | 13:47 |
| ionutbalutoiu | mgz: I am a PowerShell Windows charmer from Cloudbase. | 13:48 |
| === kadams54 is now known as kadams54-away | ||
| mgz | ionutbalutoiu: hey there! | 13:48 |
| mgz | ionutbalutoiu: so, background is I wrote some powershell to run over winrm that gathers up the logs on a remote juju machine and sends them back | 13:50 |
| mgz | ionutbalutoiu: it all works fine, I'm just not doing exception handling and want some tps on making the code more idiomatic | 13:51 |
| mgz | ionutbalutoiu: code is in lp:juju-ci-tools remote.py - can see original review at https://code.launchpad.net/~gz/juju-ci-tools/winrm_copy/+merge/262548 | 13:53 |
| mgz | ionutbalutoiu: want to do a hangout or discuss here? | 13:53 |
| ionutbalutoiu | mgz: Let's discuss here. I can't join a hangout right now. So to be more specific, this is the piece of powershell code you're running over WinRM: http://bazaar.launchpad.net/~juju-qa/juju-ci-tools/trunk/view/head:/remote.py#L164 | 14:21 |
| mgz | ionutbalutoiu: THAT'S IT | 14:22 |
| mgz | er... caps | 14:22 |
| mgz | -shouting | 14:22 |
| mgz | so, two main things I want to do, wrap the execution in try/catch and make the return code non-zero if something goes wrong, and handle files being unreadable better | 14:24 |
| mgz | anything else you see? | 14:24 |
| ionutbalutoiu | mgz: Yes, that one and I'd recommend to add at the beginning of the script: $ErrorActionPreference = "Stop". This means that the script execution will end at the first unhandled exception. | 14:25 |
| ionutbalutoiu | mgz: The default is: $ErrorActionPreference = "Continue" and it will continue even if an exception was thrown. We also set it to "Stop" in all our charms. | 14:26 |
| mgz | what I wasn't clear on was what happens with trying to set an exit code with that | 14:27 |
| mgz | the excepton still propogates and catch code gets run I presume? | 14:27 |
| mgz | with continue, each exception gets logged at the top level and the next line in run | 14:27 |
| ionutbalutoiu | mgz: If you have $ErrorActionPreference = "Stop" and use try/catch, you're exception will be caught, catch code will be executed and there you can return with exit code different than 0, as you say. | 14:32 |
| ionutbalutoiu | mgz: but if an exception if caught it won't propagate unless thrown again, as in any other OOP language. | 14:33 |
| dooferlad | wallyworld: bug updated | 14:34 |
| ionutbalutoiu | mgz: is* | 14:34 |
| mgz | ionutbalutoiu: so, I'm thunking something like this to start with http://paste.ubuntu.com/11836093 | 14:37 |
| wallyworld | dooferlad: thanks. i'm very wary of changing network related code. do you know why only the first cloud address is stored? and why the others are discarded? what if we change it so they are all stored, what will break? | 14:37 |
| dooferlad | wallyworld: I don't know why we only pick one and the comments only tell us that we do, not why | 14:38 |
| wallyworld | dooferlad: if you communicate with dimiter, could you ask him? | 14:38 |
| wallyworld | i know he's at gophercon | 14:38 |
| dooferlad | wallyworld: sure, he should be in email contact. Will bug him about the bug. | 14:39 |
| wallyworld | ty, now i need sleep, i'll check the bug for updates when i wake up | 14:39 |
| mgz | wallyworld: sleep well | 14:39 |
| dooferlad | voidspace, TheMue: ^^ do you have any ideas? | 14:39 |
| wallyworld | will try to :-) so much juju to worry about :-) | 14:39 |
| === psivaa-afk is now known as psivaa | ||
| sinzui | alexisb: mgz Roger's projects (Go packages) have ambiguous or contradictory licensing info. https://github.com/go-errgo/errgo/tree/v1 is the most concerning. Roger holds copyright and issue it under bsd-style, but every code file us owned by Canonical under LGPL and site the Roger's LICENSE. | 15:25 |
| alexisb | sinzui, so what is the path for address the LICENSE issues? | 15:26 |
| voidspace | dooferlad: no, I don't know why we only store one cloud local address | 15:28 |
| sinzui | alexisb: I think Roger needs to reconcile the issue. If it is a mistake, that is fixable in a commit, then we are not blocked. | 15:29 |
| alexisb | sinzui, ok, can you send roger and uros a note | 15:30 |
| alexisb | roger is currently at gophercon but hopefully he will read mail | 15:30 |
| sinzui | alexisb: I am | 15:30 |
| alexisb | awesome thanks sinzui ! | 15:30 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| ahasenack | hi, does anyone know how a machine agent is told where to find the state server? | 20:05 |
| ahasenack | I ask because on a container of mine it is trying to connect to localhost, which is incorrect | 20:05 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| mup | Bug # changed: 1457205, 1464470, 1468994, 1470150 | 21:05 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| alexisb | wallyworld, thumper release call? | 21:31 |
| wallyworld | menn0: hey | 22:16 |
| menn0 | wallyworld: howdy | 22:16 |
| wallyworld | menn0: as ocr today, can i ask that you pay particular attention to any windows related PRs? as i've been told these are critical to get landed for 1.24 | 22:17 |
| menn0 | wallyworld: ok will do | 22:17 |
| wallyworld | i think there's 3 of them | 22:17 |
| wallyworld | ty | 22:17 |
| wallyworld | menn0: with the zip tools one, i've provided input on that already and it needs rework, so that's WIP so you can skip that one | 22:18 |
| wallyworld | i've talked to them online about it | 22:18 |
| menn0 | wallyworld: ok thanks | 22:18 |
| menn0 | wallyworld: did you see the changes I made to the certupdater to fix the race? | 22:19 |
| wallyworld | not yet, just in passing,but thank you for fixing my fck up | 22:19 |
| menn0 | wallyworld: I wouldn't say it was that bad. pretty subtle really, and I know you originally did that work under fairly extreme time pressure. | 22:20 |
| wallyworld | yeah, but that's how we always work right? :-) | 22:20 |
| menn0 | wallyworld: it's here anyway if you want to see it: http://reviews.vapour.ws/r/2095/ (it's in 1.24 and master) | 22:20 |
| wallyworld | \o/ ty | 22:21 |
| wallyworld | looks like there's 3 windows prs - 2106, 2109 and 2006 | 22:21 |
| waigani | thumper, menn0: environment destroy cmd: http://reviews.vapour.ws/r/2110/ | 22:23 |
| menn0 | wallyworld: i'm looking at 2106 now | 22:23 |
| thumper | waigani: cheers, I would like to look before you land it | 22:23 |
| menn0 | waigani: cool, will get to it soon | 22:23 |
| waigani | thanks both :) | 22:24 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| mup | Bug #1468354 changed: RelationUnitSuite setup fails <ci> <unit-tests> <juju-core:Fix Released> <https://launchpad.net/bugs/1468354> | 22:44 |
| mup | Bug #1468355 changed: TestAddStoreCharmPlaceholder fails <ci> <test-failure> <juju-core:Fix Released> <https://launchpad.net/bugs/1468355> | 22:44 |
| menn0 | wallyworld: all windows PRs reviewed | 22:55 |
| wallyworld | menn0: awesome, ty | 22:55 |
| menn0 | wallyworld: I think they're all pretty close | 22:56 |
| wallyworld | great yeah, still a few other issues also to unlock 1.24.3 | 22:56 |
| wallyworld | arm issue being one :-( | 22:56 |
| === kadams54 is now known as kadams54-away | ||
| menn0 | wallyworld: I'd like to get this in as well: https://github.com/juju/juju/pull/2724 | 23:10 |
| wallyworld | menn0: indeed, that would be good to land | 23:20 |
| * wallyworld relocating, afk for a bit | 23:21 | |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| === kadams54 is now known as kadams54-away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!