/srv/irclogs.ubuntu.com/2015/07/07/#launchpad-dev.txt

wgrantblr: Can you have a look at https://bugs.launchpad.net/launchpad/+bug/1471426?01:25
mupBug #1471426: AttributeError: 'BinaryPatch' object has no attribute 'get_header' <code-review> <email> <fallout> <oops> <regression> <Launchpad itself:Triaged> <https://launchpad.net/bugs/1471426>01:25
blrwgrant: sure01:28
wgrantmwhudson: Is go get happy with qastaging now?01:32
blrwgrant: seems to be, although it complains about no go source for the repos I've tested01:38
blrmwhudson may want to confirm with an actual golang repo01:38
blrwgrant: trying to write a test for this.. in what context do we have binary patches in the diff text?01:56
cjwatsonblr: You can see a couple in https://code.launchpad.net/~blr/launchpad/project-meta-go-import/+merge/26214402:01
blrcjwatson: sorry, which patches are you referring to?02:06
wgrantblr: gitbranch*.png02:06
wgrantblr: "Binary files [...] differ"02:06
blrwgrant: ah I see thanks02:08
blrgiven a binarypatch has no header, do we throw them out? there could be a comment there02:09
cjwatsonwe can't throw out anything, a comment might go anywhere02:09
mwhudsonblr: seems ok to me, fighting the fun that is qastaging codehosting02:41
blrmwhudson: great, glad something is working today >.<02:42
mwhudson OOPS-ec59fa242226c1c084ff47bddab04e8602:42
mwhudsonon trying to register a new series02:42
mwhudsonwell, actually on trying to view the new series02:43
mwhudsonhttps://qastaging.launchpad.net/pydoctor/series02:43
mwhudsonblr: known?02:43
blrmwhudson: hmm no, I wonder why I didn't see that on turnip's series page02:45
wgrantblr: Probably because therer's no default branch on that new series.02:45
mwhudsoni was about to add one :)02:45
wgrantOh, there's also a correctness bug in that path.02:47
wgrantAh, the bugs are one and the same.02:47
blrwgrant: in https://qastaging.launchpad.net/~mwhudson/pydoctor/new-trunk ?02:48
wgrantblr: ProductSeriesView.golang_import_spec is buggy.02:48
wgrantA template crashing with a LocationError usually means that the expression raised an AttributeError.02:49
wgrantThe TALES interrpreter helpfully swallows the AttributeError for you so you can't see what it actually is.02:49
blrright, have seen that before.02:49
* mwhudson twitches02:49
blrwgrant: ah, development_focus can be None02:51
wgrantblr: It can, but that's not the issue here.02:51
wgrantActually, can it? I forget.02:52
blrhmm ok02:52
wgrantIt's not the cause of this crash, though, as it is set for pydoctor.02:52
blrok have the binary patch handling sorted, just tidying up this test.03:22
blrwgrant: ah, that should just be self.context.branch03:49
blrwaiting for the binary patch branch to scan03:49
* blr rounds up the goats04:14
blrwgrant: could you have a look please https://code.launchpad.net/~blr/launchpad/golang-meta-import-buggy-productseries/+merge/26399404:15
blrmade the product series test clearer as well hopefully.04:17
wgrantblr: You pushed the test change to the wrong branch.04:25
wgrantgolang-meta-import-https-fix rather than golang-meta-import-buggy-productseries04:25
* blr sighs04:27
blrthanks04:28
blrshould have made a new branch04:28
blrpushed04:28
wgrantblr: Both reviewed, thanks.04:38
blrwgrant: thanks, I believe a BinaryPatch will always have a dirty header04:38
wgrantblr: It's still rather confusing for it to be inside that block. It doesn't need to be.04:39
blryes, agreed.04:40
blrwgrant: unblocking buildbot, then will get those two branches landed.05:41
blrand hopefully can now figure out why elmo's diff was so mangled.05:42
blrwgrant: hmm I wonder if blank newlines are not being stripped, bzrlib won't parse subsequent patches otherwise.08:29
wgrantblr: Have you got a test that reproduces it?10:12
blrwgrant: I have a failing test yep10:13
wgrantGreat.10:13
blrwill dig into bzrlib again in the morning.10:14
mwhudsonhuh, https://bugs.launchpad.net/launchpad/+bug/1465467 is deployed now, but i don'21:34
mupBug #1465467: put <meta name="go-import"> tags on project, series pages <git> <qa-ok> <trivial> <Launchpad itself:Fix Released by blr> <https://launchpad.net/bugs/1465467>21:34
mwhudsont see the meta tags ? :(21:34
cjwatsonmwhudson: I see one on https://launchpad.net/germinate21:42
cjwatsonnot on code. though21:43
mwhudsoncjwatson: hmm21:43
mwhudsoncjwatson: i was looking at https://launchpad.net/pydoctor21:43
mwhudsonbzr vs git?21:43
cjwatsonYeah, I looked at a git example21:44
cjwatsonblr: ^- looks like you have more to do here :-/21:45
mwhudsonthis simple sounding feature seems to be cursed :)21:46
blrmwhudson: did you set a default vcs?21:53
mwhudsonblr: oh right, no21:53
mwhudsonblr: is there going to be a garbo job to set that to bzr when trunk is already bzr?21:54
blrit will only render if you've one into code and set bzr (no need to change any of the form fields)21:54
blrmwhudson: good question, that would certainly be nice.21:54
mwhudsonblr: i think its essential to be able to remove the special case code from the go tool21:54
blrmwhudson: ok will discuss that with william and colin in 5m (we have our LP meeting)21:55
mwhudsonor we'd have to ask the maintainers of every go package on lp to visit the code config page...21:55
mwhudsonblr: ta21:55
blrmwhudson: looks like the tag is rendering now at least :)21:55
mwhudsonblr: can confirm that that fixes it, yeah21:55
mwhudson(forgot about that part from qastaging)21:55
blrwell, less than obvious I think. Hopefully we can run a job (we have an 'inferred_vcs' that we could potentially use to set product.vcs globally)21:56
cjwatsonah, you decided not to make it inferred_vcs?  I guess that would have performance problems.22:02
cjwatsonwe'd talked about backfilling, yes.22:02
blrcjwatson: yes, I think wgrant was concerned about performance there.22:02
cjwatsonmakes sense.22:03
blrmwhudson: we'll look at garboing that in the next few days.22:13
mwhudsonblr: thanks22:13

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!