[01:25] <wgrant> blr: Can you have a look at https://bugs.launchpad.net/launchpad/+bug/1471426?
[01:25] <mup> Bug #1471426: AttributeError: 'BinaryPatch' object has no attribute 'get_header' <code-review> <email> <fallout> <oops> <regression> <Launchpad itself:Triaged> <https://launchpad.net/bugs/1471426>
[01:28] <blr> wgrant: sure
[01:32] <wgrant> mwhudson: Is go get happy with qastaging now?
[01:38] <blr> wgrant: seems to be, although it complains about no go source for the repos I've tested
[01:38] <blr> mwhudson may want to confirm with an actual golang repo
[01:56] <blr> wgrant: trying to write a test for this.. in what context do we have binary patches in the diff text?
[02:01] <cjwatson> blr: You can see a couple in https://code.launchpad.net/~blr/launchpad/project-meta-go-import/+merge/262144
[02:06] <blr> cjwatson: sorry, which patches are you referring to?
[02:06] <wgrant> blr: gitbranch*.png
[02:06] <wgrant> blr: "Binary files [...] differ"
[02:08] <blr> wgrant: ah I see thanks
[02:09] <blr> given a binarypatch has no header, do we throw them out? there could be a comment there
[02:09] <cjwatson> we can't throw out anything, a comment might go anywhere
[02:41] <mwhudson> blr: seems ok to me, fighting the fun that is qastaging codehosting
[02:42] <blr> mwhudson: great, glad something is working today >.<
[02:42] <mwhudson>  OOPS-ec59fa242226c1c084ff47bddab04e86
[02:42] <mwhudson> on trying to register a new series
[02:43] <mwhudson> well, actually on trying to view the new series
[02:43] <mwhudson> https://qastaging.launchpad.net/pydoctor/series
[02:43] <mwhudson> blr: known?
[02:45] <blr> mwhudson: hmm no, I wonder why I didn't see that on turnip's series page
[02:45] <wgrant> blr: Probably because therer's no default branch on that new series.
[02:45] <mwhudson> i was about to add one :)
[02:47] <wgrant> Oh, there's also a correctness bug in that path.
[02:47] <wgrant> Ah, the bugs are one and the same.
[02:48] <blr> wgrant: in https://qastaging.launchpad.net/~mwhudson/pydoctor/new-trunk ?
[02:48] <wgrant> blr: ProductSeriesView.golang_import_spec is buggy.
[02:49] <wgrant> A template crashing with a LocationError usually means that the expression raised an AttributeError.
[02:49] <wgrant> The TALES interrpreter helpfully swallows the AttributeError for you so you can't see what it actually is.
[02:49] <blr> right, have seen that before.
[02:49]  * mwhudson twitches
[02:51] <blr> wgrant: ah, development_focus can be None
[02:51] <wgrant> blr: It can, but that's not the issue here.
[02:52] <wgrant> Actually, can it? I forget.
[02:52] <blr> hmm ok
[02:52] <wgrant> It's not the cause of this crash, though, as it is set for pydoctor.
[03:22] <blr> ok have the binary patch handling sorted, just tidying up this test.
[03:49] <blr> wgrant: ah, that should just be self.context.branch
[03:49] <blr> waiting for the binary patch branch to scan
[04:14]  * blr rounds up the goats
[04:15] <blr> wgrant: could you have a look please https://code.launchpad.net/~blr/launchpad/golang-meta-import-buggy-productseries/+merge/263994
[04:17] <blr> made the product series test clearer as well hopefully.
[04:25] <wgrant> blr: You pushed the test change to the wrong branch.
[04:25] <wgrant> golang-meta-import-https-fix rather than golang-meta-import-buggy-productseries
[04:27]  * blr sighs
[04:28] <blr> thanks
[04:28] <blr> should have made a new branch
[04:28] <blr> pushed
[04:38] <wgrant> blr: Both reviewed, thanks.
[04:38] <blr> wgrant: thanks, I believe a BinaryPatch will always have a dirty header
[04:39] <wgrant> blr: It's still rather confusing for it to be inside that block. It doesn't need to be.
[04:40] <blr> yes, agreed.
[05:41] <blr> wgrant: unblocking buildbot, then will get those two branches landed.
[05:42] <blr> and hopefully can now figure out why elmo's diff was so mangled.
[08:29] <blr> wgrant: hmm I wonder if blank newlines are not being stripped, bzrlib won't parse subsequent patches otherwise.
[10:12] <wgrant> blr: Have you got a test that reproduces it?
[10:13] <blr> wgrant: I have a failing test yep
[10:13] <wgrant> Great.
[10:14] <blr> will dig into bzrlib again in the morning.
[21:34] <mwhudson> huh, https://bugs.launchpad.net/launchpad/+bug/1465467 is deployed now, but i don'
[21:34] <mup> Bug #1465467: put <meta name="go-import"> tags on project, series pages <git> <qa-ok> <trivial> <Launchpad itself:Fix Released by blr> <https://launchpad.net/bugs/1465467>
[21:34] <mwhudson> t see the meta tags ? :(
[21:42] <cjwatson> mwhudson: I see one on https://launchpad.net/germinate
[21:43] <cjwatson> not on code. though
[21:43] <mwhudson> cjwatson: hmm
[21:43] <mwhudson> cjwatson: i was looking at https://launchpad.net/pydoctor
[21:43] <mwhudson> bzr vs git?
[21:44] <cjwatson> Yeah, I looked at a git example
[21:45] <cjwatson> blr: ^- looks like you have more to do here :-/
[21:46] <mwhudson> this simple sounding feature seems to be cursed :)
[21:53] <blr> mwhudson: did you set a default vcs?
[21:53] <mwhudson> blr: oh right, no
[21:54] <mwhudson> blr: is there going to be a garbo job to set that to bzr when trunk is already bzr?
[21:54] <blr> it will only render if you've one into code and set bzr (no need to change any of the form fields)
[21:54] <blr> mwhudson: good question, that would certainly be nice.
[21:54] <mwhudson> blr: i think its essential to be able to remove the special case code from the go tool
[21:55] <blr> mwhudson: ok will discuss that with william and colin in 5m (we have our LP meeting)
[21:55] <mwhudson> or we'd have to ask the maintainers of every go package on lp to visit the code config page...
[21:55] <mwhudson> blr: ta
[21:55] <blr> mwhudson: looks like the tag is rendering now at least :)
[21:55] <mwhudson> blr: can confirm that that fixes it, yeah
[21:55] <mwhudson> (forgot about that part from qastaging)
[21:56] <blr> well, less than obvious I think. Hopefully we can run a job (we have an 'inferred_vcs' that we could potentially use to set product.vcs globally)
[22:02] <cjwatson> ah, you decided not to make it inferred_vcs?  I guess that would have performance problems.
[22:02] <cjwatson> we'd talked about backfilling, yes.
[22:02] <blr> cjwatson: yes, I think wgrant was concerned about performance there.
[22:03] <cjwatson> makes sense.
[22:13] <blr> mwhudson: we'll look at garboing that in the next few days.
[22:13] <mwhudson> blr: thanks