| tsdgeos | cimi: addressed the comments on https://code.launchpad.net/~aacid/unity8/icon-actions/+merge/263909 | 07:42 |
|---|---|---|
| === duflu_ is now known as duflu | ||
| tsdgeos | can you guys repro test failure at | 09:23 |
| tsdgeos | FAIL! : qmltestrunner::ApplicationWindow::test_suspendrestartApp() Uncaught exception: Cannot read property 'transitions' of undefined | 09:23 |
| tsdgeos | ? | 09:23 |
| tsdgeos | mzanetti: dandrader: ↑ ? | 09:25 |
| mzanetti | tsdgeos, yes | 09:28 |
| tsdgeos | dednick: i can't find in that doc a screenshot like mine | 09:58 |
| === pstolowski is now known as pstolowski|lunch | ||
| === dandrader is now known as dandrader|afk | ||
| dednick | tsdgeos: page 46 | 10:35 |
| dednick | tsdgeos: and anyway, the background is speficied as 85% | 10:35 |
| tsdgeos | ok | 10:35 |
| === greyback__ is now known as greyback | ||
| cimi | tsdgeos, in that previewidget you set height instead implicitHeight, is that a mistake? | 10:46 |
| cimi | or on purpose? | 10:47 |
| tsdgeos | yes | 10:47 |
| tsdgeos | mistake probably | 10:47 |
| tsdgeos | let me re-check | 10:47 |
| tsdgeos | cimi: pushed | 10:55 |
| tsdgeos | mzanetti: https://code.launchpad.net/~aacid/unity8/fix_test_suspendrestartApp/+merge/264124 for the qmltest | 11:06 |
| ltinkl | larsu, hi, https://code.launchpad.net/~lukas-kde/gsettings-qt/queued-processing/+merge/259883 still not merged? any problems there? | 11:11 |
| mzanetti | tsdgeos, silo 36 has built. can you give it a test too please | 11:17 |
| mzanetti | on krillin/mako. I'll be flashing my arale and finding someone that changes the gu value | 11:17 |
| tsdgeos | mzanetti: sure, no changes of gu for my tests, right? | 11:17 |
| mzanetti | exactly | 11:18 |
| === MacSlow is now known as MacSlow|lunch | ||
| mzanetti | tsdgeos, how do I verify this? https://code.launchpad.net/~aacid/unity8/expandable_not_expanded_by_default/+merge/262719 | 11:39 |
| === pstolowski|lunch is now known as pstolowski | ||
| cimi | mzanetti, tsdgeos can the qml test file know if is running automatically make testPreview or manually tryPreview? | 12:02 |
| mzanetti | cimi, maybe the TestCase item has some property | 12:02 |
| mzanetti | running or so | 12:02 |
| mzanetti | just a guess tho | 12:02 |
| mzanetti | if that's not the case, you might be able to find out somehow else... I think qmltestrunner sets some context properties which uqmlscene doesn't | 12:04 |
| mzanetti | if that fails too, I guess we could set something from uqmlscene to mark it as "try" run | 12:04 |
| mzanetti | if that's really needed | 12:04 |
| cimi | seems like | 12:04 |
| cimi | tsdgeos, mind if you disable those console.log when the test is running? | 12:04 |
| mzanetti | given we have about 1k tests that did not need this, I'm not sure about it :D | 12:04 |
| cimi | ahah ok | 12:04 |
| cimi | mzanetti, just wanted to avoid a console.log we don't need, keeping log clean | 12:05 |
| cimi | talking about this https://code.launchpad.net/~aacid/unity8/icon-actions/+merge/263909 | 12:05 |
| cimi | a couple of console.log albert added for manual test | 12:05 |
| mzanetti | hmm.. not sure we really need those logs at all, do we? | 12:05 |
| mzanetti | anyhow, I see your point, yes | 12:06 |
| === dandrader|afk is now known as dandrader | ||
| larsu | ltinkl: seb128 said he was going to land it, I think | 12:33 |
| seb128 | larsu, ltinkl, sorry, I sort of dropped the ball on that one but pinged mzanetti about it some days ago who said he would add it in his queue | 12:35 |
| seb128 | I'm unsure how to test the fix/update | 12:35 |
| mzanetti | yeah, I'll land it, eventually... right now fighting with some arale things for OTA-5 still | 12:36 |
| tsdgeos | mzanetti: there's no way unless you find a scope that has it :/ | 12:37 |
| tsdgeos | cimi: what's the point? | 12:37 |
| mzanetti | ok | 12:37 |
| cimi | tsdgeos, less output in CI | 12:41 |
| tsdgeos | cimi: that's a weak point given that tests are not run in CI at the moment :D | 12:41 |
| cimi | ahah | 12:41 |
| cimi | tsdgeos, anyway if !testcase.running console.log might be enough | 12:42 |
| tsdgeos | sure pushed | 12:44 |
| cimi | tsdgeos, ehm, the other one too :P | 12:51 |
| tsdgeos | cimi: the other one doesn't output in CI, can you give me a better reason? | 12:52 |
| cimi | tsdgeos, ok fine then | 12:52 |
| cimi | tsdgeos, CI is not running so I didn't see :P | 12:52 |
| tsdgeos | cimi: pushed | 12:53 |
| === MacSlow|lunch is now known as MacSlow | ||
| tsdgeos | cimi: a warning fix for you https://code.launchpad.net/~aacid/unity8/fix_make_try_warning/+merge/264139 | 13:09 |
| tsdgeos | cimi: and a test fix https://code.launchpad.net/~aacid/unity8/fix_test_suspendrestartApp/+merge/264124 | 13:09 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| mzanetti | tsdgeos, hey, going to approve the silo now. you didn't find any blocker? | 13:55 |
| tsdgeos | mzanetti: not any yet | 13:56 |
| mzanetti | ack | 13:56 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| dandrader | greyback, MirSurfaceManager is currently a model. but unity8 is only using its surfaceCreated and surfaceDestroyed signals. Mind if I make MirSurfaceManager plain QObject? Or do you see future use for a surface model? | 16:56 |
| greyback | dandrader: I see a future for it when we start implementing window management. We'll be passing a model of surfaces to the shell with info on how/where they should be rendered | 16:58 |
| greyback | dandrader: though that could be a separate thing altogether, and you could proceed with what you're doing | 16:58 |
| greyback | dandrader: caution: we use the surfaceCreated/Destroyed for the OSK hack | 16:58 |
| dandrader | greyback, yes, I said we are using those | 16:59 |
| greyback | dandrader: yeah, I kinda skimmed the statement to get ot the question :) | 17:00 |
| greyback | yeah, make MirSurfaceManager plain QObject for now. | 17:00 |
| greyback | its job is slightly different to the WM's | 17:00 |
| greyback | -slightly | 17:00 |
| dandrader | greyback, this is actually how it's implemented in the mock Unity.Application plugin | 17:00 |
| dandrader | (plain QObject) | 17:00 |
| greyback | go for it | 17:00 |
| === dandrader is now known as dandrader|bbl | ||
| attente | hi, it's not really clear to me how to use content hub as a clipboard for copy/paste | 18:30 |
| attente | is there some special transfer object i have to obtain from the global hub instance? or a way to register myself as a source for clipboard/selection requests? | 18:32 |
| josharenson | mterry: so I see that GreeterPrivate.cpp isn't being compiled... Is there a good reason for that? | 19:07 |
| mterry | josharenson, uh... hm | 19:08 |
| mterry | josharenson, I don't remember about that one | 19:08 |
| mterry | josharenson, it might be a lost file from a refactor? | 19:08 |
| mterry | josharenson, does it get #include'd anywhere? | 19:08 |
| josharenson | mterry: I think its forward declared.... | 19:08 |
| josharenson | mterry: wondering how its actually working | 19:08 |
| josharenson | mterry: oh i think i see whats happening | 19:10 |
| josharenson | mterry: GreeterPrivate is part of integrated lightdm, so its not being compiled in my branch because my branch doesn't use it | 19:11 |
| josharenson | :-p | 19:11 |
| mterry | josharenson, hah :) | 19:12 |
| josharenson | mterry: yeah, noticed at EOD yesterday, so my brain must have been sleepy | 19:13 |
| === dandrader|bbl is now known as dandrader | ||
| josharenson | Is unity8 still not cross building, or is there a trick? | 20:27 |
| === boiko_ is now known as boiko | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!