| blr | wgrant: after the is merged, will it run, or is there a flag to set? | 01:50 |
|---|---|---|
| wgrant | blr: garbo jobs are run automatically. | 01:52 |
| wgrant | blr: Some have the ability to be enabled or disabled by feature flag, but they must implement that themselves. | 01:53 |
| blr | wgrant: ok, just uncertain about the performance profile of this job, but I see there are others that operate over the entire product collection. | 01:54 |
| wgrant | blr: It is not problematic. We have garbo jobs running over collections several orders of magnitude larger. | 01:56 |
| blr | ok good to know :) | 01:58 |
| wgrant | blr: Care to land that branch so we can deploy this afternoon? | 02:40 |
| wgrant | (if you tried before it probably got caught in the testfix) | 02:40 |
| blr | wgrant: sure, was just waiting for buildbot | 02:40 |
| wgrant | blr: Thanks. | 02:47 |
| lifeless | wgrant: webhooks; nice. | 06:48 |
| wgrant | lifeless: That's the plan. | 06:57 |
| wgrant | For Git pushes initially, but obviously once we have the infrastructure we'll look at expanding it. | 06:58 |
| wgrant | Also investigating a general event system. | 06:58 |
| wgrant | Conflict adding file lib/lp/services/webhooks.moved.moved.moved.moved. Moved existing file to lib/lp/services/webhooks.moved.moved.moved.moved.moved. | 07:16 |
| StevenK | Oh bzr <3 | 07:19 |
| lifeless | wgrant: you have one already - the public wabbit server | 08:14 |
| lifeless | wgrant: (aren't webhooks just a particular client of that ?) | 08:14 |
| wgrant | lifeless: txlongpoll would be a client of the RabbitMQ-based event system. | 08:15 |
| wgrant | lifeless: txlongpoll would need a complete redesign to be the centre of it all. | 08:15 |
| lifeless | sure | 08:16 |
| lifeless | be nice to have it outside the squishy core is all ;) | 08:16 |
| wgrant | (and the idea would be that events would also be persisted, such that activity streams can be presented, and eg. bug notifications can be responses to events) | 08:16 |
| wgrant | Oh, certainly. I consider this webhook implementation a production-ready prototype that will hopefully be obsoleted by an event system designed with things we've learned from this. | 08:17 |
| lifeless | wgrant: sounds like apache thingy. Uhm, linkedin's thing | 08:17 |
| lifeless | distributed persistent log | 08:17 |
| wgrant | Kafka? | 08:17 |
| lifeless | yes | 08:17 |
| rpadovani | Hey all, I'm lurking here for some months so it's time to introduce myself: | 17:46 |
| rpadovani | I'm Riccardo, 22 years old Computer Science (2nd year) student from Italy. | 17:46 |
| rpadovani | I contribute to Ubuntu for 3 years, beginning with my Loco and then writing code for Ubuntu Touch (core apps and webbrowser, mainly). | 17:46 |
| rpadovani | I'm quite involved (I also joined two sprints) and I have a lot of fun. Since the start of the year I'm thinking to contribute to LP, a project I really like (definitely the best bug tracker on the internet). | 17:46 |
| rpadovani | The only problem: I don't know Python :-P | 17:46 |
| rpadovani | But since April I work for a startup and now they want I learn Python, so I'm studyng on Coursera and CodeAcademy and I already completed the basic tutorial on the Python website. | 17:46 |
| rpadovani | So, what's better way to learn something new than contributing to an opensource project? | 17:46 |
| rpadovani | (Sorry for the wall of text, now questions are coming) | 17:46 |
| rpadovani | Do you think I could be useful if do some patches, starting from bitesize bugs? | 17:47 |
| rpadovani | Probably at start I'll do silly patches and I'll have some silly questions. | 17:47 |
| cjwatson | Sure, we aren't short of them | 17:47 |
| rpadovani | So, do you think I could be useful? Let me be clear: I want to help, not to be a burden for the project. | 17:47 |
| rpadovani | cjwatson, great :-) Do you think with a good commitment I can contribute to LP or it's better to start from something simpler? | 17:47 |
| cjwatson | Starting with that attitude is already a pretty good sign. | 17:47 |
| cjwatson | IMO the biggest skill (other than Python, general programming, etc.) you need to contribute effectively to LP is the ability to navigate a large codebase and not be scared by it. | 17:48 |
| cjwatson | It's pretty regularly laid out, so once you get a feel for it it isn't nearly as hard to find things as the raw size of the tree would suggest. | 17:49 |
| rpadovani | let's try then - I did a couple of patches for oxide, that is quite big | 17:49 |
| cjwatson | And the test suite coverage is for the most part excellent, which helps. | 17:49 |
| rpadovani | great to hear that | 17:49 |
| rpadovani | I'm creating the LXC container, I'll back when it will finish to download all the internet | 17:49 |
| cjwatson | Heh, it does that. | 17:50 |
| cjwatson | To start with I'd suggest that you ask us about bugs you're thinking about attacking, and we can advise you if they have any hidden horribleness | 17:50 |
| cjwatson | It's been a while since we had non-trivial contributions from outside the core team, so very happy to see somebody interested :) | 17:51 |
| rpadovani | you're not in maintenance mode anymore, so I hope also someone more skilled will come out :-) | 17:52 |
| cjwatson | Welcome, anyway | 17:52 |
| cjwatson | Is there a particular bit of the site that attracts your attention most? | 17:53 |
| rpadovani | tbh dunno yet. As I said, I really like bug trackers, so I'll take a look to bug to them - the other thing I think could be pretty improved is integration with bzr, so I'll look also to bugs about code navigations and so | 17:54 |
| rpadovani | but, whereever I could be useful I'll try to drop a bit :-) | 17:54 |
| cjwatson | OK, fair enogh | 17:54 |
| rpadovani | (bit like in 1/8 of byte) | 17:54 |
| cjwatson | *enough | 17:54 |
| rpadovani | (my english sucks btw) | 17:55 |
| rpadovani | cjwatson, do you think bug #194257 could be a good start? Seems very trivial, but could be a good way to take a look to lp tree and to take a look to the workflow | 18:00 |
| mup | Bug #194257: "Recently imported branches" doesn't just list recent ones <lp-code> <trivial> <ui> <Launchpad itself:Triaged> <https://launchpad.net/bugs/194257> | 18:00 |
| cjwatson | rpadovani: Not too hard in itself, but nearby classes in the code include "Recently registered branches" and "Recently changed branches". What would you do with those, since the same change doesn't seem like it would make sense there? | 18:04 |
| rpadovani | cjwatson, well, I think it should be evaluted case by case - if there is a check of some type on the datetime I leave the "Recently", otherwise I drop it | 18:05 |
| cjwatson | rpadovani: I wonder if a better fix would be to make the code match the text, and impose some kind of cut-off on the list of branches shown | 18:05 |
| cjwatson | rpadovani: My point is that neither "Registered branches" nor "Changed branches" makes sense as a page title. | 18:06 |
| rpadovani | Okay, so probably is better to show branches that are newer than 1(?) month | 18:06 |
| cjwatson | So maybe it would be better to add a filter so that all three of those really are recent. | 18:06 |
| rpadovani | great, I'll try this approach then - again, should be easy? | 18:07 |
| cjwatson | I'd probably go with something like 90 days, but bikeshed | 18:07 |
| cjwatson | changed is fairly easy, but both registered and imported will take you into BranchCollection to add a filter method on date_created, which isn't trivial, and you'd have to figure out how to write tests. I'd class this as relatively easy, but maybe not a first branch. | 18:09 |
| cjwatson | (BranchCollection is notably obscure - I had to understand it all recently when implementing a parallel thing for Git) | 18:10 |
| rpadovani | okay, thanks for info, so I take a look to other bugs and keep this for next weeks :-) | 18:10 |
| cjwatson | https://bugs.launchpad.net/launchpad/+bug/892259 might not be too difficult | 18:11 |
| mup | Bug #892259: Link to revision for merged MPs <trivial> <ui> <Launchpad itself:Triaged> <https://launchpad.net/bugs/892259> | 18:11 |
| cjwatson | You'd have to learn about TAL, but that's going to come up pretty quickly anyway | 18:12 |
| cjwatson | Or maybe https://bugs.launchpad.net/launchpad/+bug/530505 | 18:14 |
| mup | Bug #530505: branch_merge_proposal.createComment requires a subject, which is pointless <api> <lp-code> <trivial> <Launchpad itself:Triaged> <https://launchpad.net/bugs/530505> | 18:14 |
| rpadovani | rocketfuel-setup is still working ZzZzZz | 20:40 |
| cjwatson | Good news: you only have to do it once | 20:43 |
| rpadovani | btw, I see it creates two directories, one for branches and one as shadow, so the workflow is bzr switch -b my_little_patch / bzr push lp:~rpadovani/lp-dev/my_little_patch / bzr checkout trunk ? | 20:46 |
| cjwatson | I *cough* do things the old-fashioned way and just create a full new branch for everything | 20:47 |
| blr | morning | 20:47 |
| cjwatson | Though it's a bit slow since I have to do "utilities/link-external-sourcecode && make" in each new branch | 20:48 |
| cjwatson | wgrant has a better workflow with "bzr switch" I think | 20:48 |
| rpadovani | and you need a big hard disk :D | 20:48 |
| cjwatson | We're pretty close to switching to git, though, so don't worry about optimising that too much | 20:48 |
| blr | yes, git will make that irrelevant, for better or worse ;) | 20:48 |
| cjwatson | morning blr | 20:48 |
| blr | how was your weekend cjwatson? | 20:49 |
| cjwatson | excellent, thanks, dinner party on Saturday | 20:49 |
| cjwatson | much wine was had | 20:49 |
| rpadovani | I switched from a directory for a branch to bzr switch a couple of months ago, it has some advantages | 20:49 |
| rpadovani | blr o/ | 20:49 |
| blr | sounds pleasant! | 20:49 |
| cjwatson | rpadovani: BTW the branch URL would be lp:~rpadovani/launchpad/my_little_patch, not .../lp-dev/... | 20:49 |
| blr | hi rpadovani | 20:50 |
| cjwatson | blr: hope you aren't snowed in or whatever Melbourne has been having | 20:50 |
| blr | cjwatson: it has been bitterly cold here, but I think the snow has passed.. the frost isn't budging however. | 20:51 |
| blr | cjwatson: did you hear wgrant was without power as well! :/ | 20:51 |
| cjwatson | I did | 20:52 |
| cjwatson | still, on the upside, we don't live in Portland so http://www.newyorker.com/magazine/2015/07/20/the-really-big-one doesn't have to be immediately terrifying | 20:53 |
| blr | yes, read that this morning... I was in the 1989 bay area quake, and that was terrifying enough... | 20:54 |
| cjwatson | worst it ever gets here is basically the mild-flatulence level | 20:55 |
| cjwatson | though my mother-in-law's house and garage are separated by a fault line, which is kind of interesting | 20:55 |
| blr | seismologists seem to be discovering new faults in the south island fairly regularly.. not clear how we stand. | 20:56 |
| cjwatson | today I came up with what I think is a workable plan for the gmail filterability project, although I need to try porting something non-trivial like bugs to BaseMailer to see how feasible it is | 20:57 |
| blr | ok, a change in direction from your earlier plan, or along the same lines? | 20:57 |
| cjwatson | same lines, just a little better fleshed out in that I found a plausible place to put the common code | 20:57 |
| cjwatson | and confirmed that gmail actually lets you do reasonable searches/filters for that kind of thing | 20:58 |
| cjwatson | looking back through old bugs, it looks like the former Code team developed BaseMailer, and then the tentative plan was for other teams to port stuff to it but mostly nobody ever got round to it | 20:58 |
| cjwatson | so I think it's a decent direction | 20:58 |
| cjwatson | sometimes I think my job title should be something more like Vinge's "programmer-archaeologist" | 21:00 |
| blr | heh, I suppose that's not in the category of jobs that do not exist yet then :) | 21:00 |
| rpadovani | I've all up and running \o/ I'm almost moved | 21:28 |
| wgrant | cjwatson: I didn't realise BaseMailer was actually used that widely. That's convenient. | 22:16 |
| rpadovani | cjwatson, so, I tried to write the patch to the bug you pointed me to. I hope it's good :-) | 22:28 |
| rpadovani | https://code.launchpad.net/~rpadovani/launchpad/link-revision-merged-mp/+merge/264654 | 22:28 |
| blr | rpadovani: hopefully that points you in the right direction, let us know how you get on. | 23:09 |
| blr | wgrant: potentially it does make sense to have a redirect on code/project/branch/revision/revno perhaps? | 23:10 |
| cjwatson | I don't think a slow redirect through the webapp is going to improve people's lives, really. | 23:11 |
| cjwatson | rpadovani: You should also figure out how to write and run a test for this. | 23:12 |
| cjwatson | rpadovani: The process of doing that would likely have shown up your mistake here. | 23:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!