| === zz_natorious is now known as natorious | ||
| === natorious is now known as zz_natorious | ||
| Odd_Bloke | smoser: I've added the things you wanted in https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1411582/+merge/264831 | 12:09 |
|---|---|---|
| smoser | Odd_Bloke, ok. reading now. | 13:18 |
| smoser | first hthing : | 13:18 |
| smoser | LOG.debug('Ensuring that we have a real device, not a symbolic link') | 13:18 |
| smoser | that is pretty useless tatement. | 13:18 |
| smoser | i think, no? it doesn't tell you anything. | 13:18 |
| Odd_Bloke | smoser: Well, it tells you that (a) you have reached a particular point in the code, and (b) that if you are seeing a discrepancy between what you have configured and what the following log messages say that there might be a reason for it. | 14:01 |
| Odd_Bloke | smoser: But I'm happy to improve it. | 14:01 |
| smoser | Odd_Bloke, i'll merge, if you can do me a favor | 15:17 |
| smoser | :) | 15:17 |
| smoser | tox -e py26 is busted on 0.7 trunk right now. | 15:17 |
| smoser | i believe due to mock changes. | 15:18 |
| smoser | Odd_Bloke, i've fixed tests at https://code.launchpad.net/~smoser/cloud-init/fix-mock-tests/+merge/265410 | 16:04 |
| smoser | harlowja, or Odd_Bloke a review of my sanity there would be good. | 16:04 |
| smoser | it really seems like upstream mock fixed a bug and now our tests that should not have passed actually do not pass :) | 16:04 |
| === zz_natorious is now known as natorious | ||
| === natorious is now known as zz_natorious | ||
| harlowja | smoser u have been determined to not be sane | 16:57 |
| harlowja | sanity review completed | 16:57 |
| harlowja | smoser looks ok to me, i had similar mock fixups in taskflow | 16:58 |
| smoser | you think your tests were bad and incorrectly passing also ? | 16:59 |
| harlowja | smoser i know it :) | 17:01 |
| harlowja | http://lists.openstack.org/pipermail/openstack-dev/2015-July/069156.html | 17:02 |
| harlowja | smoser i even got taskflow mentioned in ^ | 17:02 |
| harlowja | lol | 17:02 |
| harlowja | 'One of the improvements in mock is to fail when a bad method is called.' | 17:02 |
| smoser | nice. | 17:02 |
| === zz_natorious is now known as natorious | ||
| === natorious is now known as zz_natorious | ||
| === zz_natorious is now known as natorious | ||
| === natorious is now known as zz_natorious | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!