=== zz_natorious is now known as natorious === natorious is now known as zz_natorious [12:09] smoser: I've added the things you wanted in https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1411582/+merge/264831 [13:18] Odd_Bloke, ok. reading now. [13:18] first hthing : [13:18] LOG.debug('Ensuring that we have a real device, not a symbolic link') [13:18] that is pretty useless tatement. [13:18] i think, no? it doesn't tell you anything. [14:01] smoser: Well, it tells you that (a) you have reached a particular point in the code, and (b) that if you are seeing a discrepancy between what you have configured and what the following log messages say that there might be a reason for it. [14:01] smoser: But I'm happy to improve it. [15:17] Odd_Bloke, i'll merge, if you can do me a favor [15:17] :) [15:17] tox -e py26 is busted on 0.7 trunk right now. [15:18] i believe due to mock changes. [16:04] Odd_Bloke, i've fixed tests at https://code.launchpad.net/~smoser/cloud-init/fix-mock-tests/+merge/265410 [16:04] harlowja, or Odd_Bloke a review of my sanity there would be good. [16:04] it really seems like upstream mock fixed a bug and now our tests that should not have passed actually do not pass :) === zz_natorious is now known as natorious === natorious is now known as zz_natorious [16:57] smoser u have been determined to not be sane [16:57] sanity review completed [16:58] smoser looks ok to me, i had similar mock fixups in taskflow [16:59] you think your tests were bad and incorrectly passing also ? [17:01] smoser i know it :) [17:02] http://lists.openstack.org/pipermail/openstack-dev/2015-July/069156.html [17:02] smoser i even got taskflow mentioned in ^ [17:02] lol [17:02] 'One of the improvements in mock is to fail when a bad method is called.' [17:02] nice. === zz_natorious is now known as natorious === natorious is now known as zz_natorious === zz_natorious is now known as natorious === natorious is now known as zz_natorious