=== bkerensa_ is now known as bkerensa
dholbachgood morning06:54
dholbachmhall119, if you have a bit of time, maybe you can take a look at https://code.launchpad.net/~dholbach/developer-ubuntu-com/generalise-external-docs-branches/+merge/266383? (if you'd prefer I can propose it against proper lp:developer-ubuntu-com)09:56
mhall119dholbach: if lp:~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import is still waiting on review, you can just land this merge and it'll be reviewed before landing in trunk13:20
dholbachmhall119, ok... davidcalle and I started using lp:~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import to work on the feature together13:20
dholbachbut as he's on paternity leave right now I was looking for somebody else to have a look at it :-)13:21
dholbachbut sure, I can propose the whole thing against developer.u.c and we can take it from there13:21
dholbachthe code still contains a few FIXMEs though13:21
mhall119ah, I see13:22
dholbachit'd be good to get your input13:22
mhall119so looking over the diff, I'm concerned about is_snappy_branch and the number of places it's used13:22
dholbachparticularly on the issue of recreating pages with every import13:22
dholbachmhall119, we started off with just wanting to import snappy docs13:23
dholbachie ./docs in lp:snappy and ./docs from lp:snappy/15.04 for example13:23
dholbachto better explain that there's multiple versions we add some pointers to that13:24
dholbachnow we saw that we want to import ./docs form lp:snapcraft too13:24
dholbachwhich doesn't need the same handling13:24
dholbachbut sure... I can try to minimise the use of is_snappy_branch13:24
dholbachgood point13:25
mhall119dholbach: for me it was more of a warning sign that this may not be easily done in a generic way13:25
dholbachI'll group the use of is_snappy_branch and make it clearer13:26
dholbachall rightie, I call it a day - see you all tomorrow!16:45
=== Pici` is now known as Pici

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!