=== bkerensa_ is now known as bkerensa [06:54] good morning [09:56] mhall119, if you have a bit of time, maybe you can take a look at https://code.launchpad.net/~dholbach/developer-ubuntu-com/generalise-external-docs-branches/+merge/266383? (if you'd prefer I can propose it against proper lp:developer-ubuntu-com) [13:20] dholbach: if lp:~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import is still waiting on review, you can just land this merge and it'll be reviewed before landing in trunk [13:20] mhall119, ok... davidcalle and I started using lp:~developer-ubuntu-com-dev/developer-ubuntu-com/snappy-docs-import to work on the feature together [13:21] but as he's on paternity leave right now I was looking for somebody else to have a look at it :-) [13:21] but sure, I can propose the whole thing against developer.u.c and we can take it from there [13:21] the code still contains a few FIXMEs though [13:22] ah, I see [13:22] it'd be good to get your input [13:22] so looking over the diff, I'm concerned about is_snappy_branch and the number of places it's used [13:22] particularly on the issue of recreating pages with every import [13:23] mhall119, we started off with just wanting to import snappy docs [13:23] ie ./docs in lp:snappy and ./docs from lp:snappy/15.04 for example [13:24] to better explain that there's multiple versions we add some pointers to that [13:24] now we saw that we want to import ./docs form lp:snapcraft too [13:24] which doesn't need the same handling [13:24] but sure... I can try to minimise the use of is_snappy_branch [13:25] good point [13:25] dholbach: for me it was more of a warning sign that this may not be easily done in a generic way [13:25] right [13:26] I'll group the use of is_snappy_branch and make it clearer [16:45] all rightie, I call it a day - see you all tomorrow! === Pici` is now known as Pici