| smoser | harlowja, yeah. git archive is probably sufficient. i know we can find stuff. | 01:59 |
|---|---|---|
| smoser | fiddle. | 02:00 |
| smoser | harlowja, you can push that if you want. | 02:00 |
| smoser | Odd_Bloke, https://code.launchpad.net/~smoser/cloud-init/trunk.reporting/ | 12:27 |
| smoser | its not in a great state right now (not acutally functiona) but i'd appreciate your thoughts on the chagnes i've made / additions to the reporting stuff. | 12:27 |
| smoser | i'll flesh it out more today | 12:28 |
| Odd_Bloke | smoser: Oh, hm, I was going to refactor the reporting stuff a bit, which might make it hard to take changes back. | 14:01 |
| smoser | well more consider this as input to the work you're doing. | 14:02 |
| smoser | things really there are | 14:02 |
| smoser | a.) i've got a context handler that seems useful (ReportingStack) | 14:02 |
| smoser | b.) i made event have success/fail/warn | 14:02 |
| Odd_Bloke | smoser: Would it make sense to submit those changes to 2.0, so that we can maintain a wholesale backport? | 14:04 |
| smoser | yeah. | 14:04 |
| smoser | i'm just in need of getting a reporting functional on 1. so i'm pushing through implementation to learn things and see how it goes. | 14:05 |
| smoser | and those things that i thin i've learned, i'm interested in your thoughts on | 14:05 |
| smoser | that make sense? | 14:05 |
| smoser | s/1/0.7x./ | 14:05 |
| smoser | s/typo/other typo/ | 14:05 |
| Odd_Bloke | smoser: Yeah, both the context manager and the WARN addition look broadly sensible. | 14:13 |
| Odd_Bloke | smoser: I do have some comments, but it'd be easier to make those in some sort of code review tool *COUGH*gerrit*COUGH*. ;) | 14:13 |
| smoser | well, i can propose to merge into 0.7 | 14:15 |
| smoser | then you can use that other code review tool if you'd like. | 14:15 |
| Odd_Bloke | Doing it that way around will make backporting any other reporting changes in the future more painful. | 14:18 |
| Odd_Bloke | I'd like to get reporting to a done-ish state before we backport it. | 14:18 |
| Odd_Bloke | If that's a problem, ask Andreas who on his team he's going to commit to cloud-init work. ¬.¬ | 14:18 |
| Odd_Bloke | Sorry, shouldn't be so grumpy. | 14:20 |
| Odd_Bloke | But I think it will cause pain in the future. | 14:20 |
| smoser | bah. proposing for review does not mean accepting for review | 14:23 |
| smoser | you mentioned you wanted to comment on it. | 14:23 |
| smoser | i proposed a way you could comment | 14:23 |
| smoser | that i'd then address and get into suitable path | 14:24 |
| smoser | which woudl then be submitted for review to 2.0 | 14:24 |
| Odd_Bloke | Sure. | 14:25 |
| Odd_Bloke | Let's do that. :) | 14:26 |
| smoser | Odd_Bloke, https://code.launchpad.net/~smoser/cloud-init/trunk.reporting/+merge/266578 | 14:49 |
| smoser | Odd_Bloke, if you coudl take a look i'd appreciate it. | 14:52 |
| smoser | i'm planning on spending the rest of my day on this, so .. | 14:52 |
| Odd_Bloke | Yeah, looking now. | 14:52 |
| === natorious is now known as zz_natorious | ||
| Odd_Bloke | smoser: There you go. | 15:33 |
| smoser | mercy | 15:33 |
| smoser | oh this is not good | 15:34 |
| smoser | i can't see your comments | 15:34 |
| smoser | :) | 15:34 |
| smoser | do you see them. ? | 15:35 |
| smoser | Odd_Bloke, | 15:35 |
| Odd_Bloke | smoser: No, I think because you pushed new commits. | 15:36 |
| Odd_Bloke | s/new/different/ | 15:36 |
| smoser | joy | 15:36 |
| smoser | new | 15:36 |
| smoser | not different | 15:36 |
| Odd_Bloke | mumble mumble gerrit mumble :p | 15:36 |
| Odd_Bloke | They _might_ be in the email LP should send at some point. | 15:36 |
| harlowja | what u guys doing, lol | 15:37 |
| Odd_Bloke | So lets wait for that before I go through and try and remember everything. | 15:37 |
| smoser | Odd_Bloke, yeah, i'm looking at email | 15:38 |
| smoser | Odd_Bloke, the printHandler is just garbage for debugging . was easier than opening up the log :) | 15:39 |
| smoser | stderr makes sense for sure. | 15:39 |
| smoser | but so does possibly just dropping it. | 15:39 |
| Odd_Bloke | smoser: Right; either drop it or remove it from default config. :) | 15:40 |
| smoser | comments back! | 15:44 |
| smoser | hm.. or they were. | 15:45 |
| smoser | odd | 15:45 |
| === zz_natorious is now known as natorious | ||
| === natorious is now known as zz_natorious | ||
| openstackgerrit | Daniel Watkins proposed stackforge/cloud-init: Refactor handlers out of main reporting module. https://review.openstack.org/207979 | 16:11 |
| smoser | Odd_Bloke, sometimes its good to explain *why* you're making a change. | 16:12 |
| === zz_natorious is now known as natorious | ||
| openstackgerrit | Daniel Watkins proposed stackforge/cloud-init: Refactor handlers out of main reporting module. https://review.openstack.org/207979 | 16:15 |
| Odd_Bloke | smoser: Yep, not totally used to the commit _being_ the review proposal yet. | 16:15 |
| Odd_Bloke | Updated with more reasoning. | 16:15 |
| openstackgerrit | Merged stackforge/cloud-init: Refactor handlers out of main reporting module. https://review.openstack.org/207979 | 20:39 |
| claudiupopa | Odd_Bloke, smoser: late to the party, I left a comment for #207979. | 20:48 |
| === natorious is now known as zz_natorious | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!