[01:59] harlowja, yeah. git archive is probably sufficient. i know we can find stuff. [02:00] fiddle. [02:00] harlowja, you can push that if you want. [12:27] Odd_Bloke, https://code.launchpad.net/~smoser/cloud-init/trunk.reporting/ [12:27] its not in a great state right now (not acutally functiona) but i'd appreciate your thoughts on the chagnes i've made / additions to the reporting stuff. [12:28] i'll flesh it out more today [14:01] smoser: Oh, hm, I was going to refactor the reporting stuff a bit, which might make it hard to take changes back. [14:02] well more consider this as input to the work you're doing. [14:02] things really there are [14:02] a.) i've got a context handler that seems useful (ReportingStack) [14:02] b.) i made event have success/fail/warn [14:04] smoser: Would it make sense to submit those changes to 2.0, so that we can maintain a wholesale backport? [14:04] yeah. [14:05] i'm just in need of getting a reporting functional on 1. so i'm pushing through implementation to learn things and see how it goes. [14:05] and those things that i thin i've learned, i'm interested in your thoughts on [14:05] that make sense? [14:05] s/1/0.7x./ [14:05] s/typo/other typo/ [14:13] smoser: Yeah, both the context manager and the WARN addition look broadly sensible. [14:13] smoser: I do have some comments, but it'd be easier to make those in some sort of code review tool *COUGH*gerrit*COUGH*. ;) [14:15] well, i can propose to merge into 0.7 [14:15] then you can use that other code review tool if you'd like. [14:18] Doing it that way around will make backporting any other reporting changes in the future more painful. [14:18] I'd like to get reporting to a done-ish state before we backport it. [14:18] If that's a problem, ask Andreas who on his team he's going to commit to cloud-init work. ¬.¬ [14:20] Sorry, shouldn't be so grumpy. [14:20] But I think it will cause pain in the future. [14:23] bah. proposing for review does not mean accepting for review [14:23] you mentioned you wanted to comment on it. [14:23] i proposed a way you could comment [14:24] that i'd then address and get into suitable path [14:24] which woudl then be submitted for review to 2.0 [14:25] Sure. [14:26] Let's do that. :) [14:49] Odd_Bloke, https://code.launchpad.net/~smoser/cloud-init/trunk.reporting/+merge/266578 [14:52] Odd_Bloke, if you coudl take a look i'd appreciate it. [14:52] i'm planning on spending the rest of my day on this, so .. [14:52] Yeah, looking now. === natorious is now known as zz_natorious [15:33] smoser: There you go. [15:33] mercy [15:34] oh this is not good [15:34] i can't see your comments [15:34] :) [15:35] do you see them. ? [15:35] Odd_Bloke, [15:36] smoser: No, I think because you pushed new commits. [15:36] s/new/different/ [15:36] joy [15:36] new [15:36] not different [15:36] mumble mumble gerrit mumble :p [15:36] They _might_ be in the email LP should send at some point. [15:37] what u guys doing, lol [15:37] So lets wait for that before I go through and try and remember everything. [15:38] Odd_Bloke, yeah, i'm looking at email [15:39] Odd_Bloke, the printHandler is just garbage for debugging . was easier than opening up the log :) [15:39] stderr makes sense for sure. [15:39] but so does possibly just dropping it. [15:40] smoser: Right; either drop it or remove it from default config. :) [15:44] comments back! [15:45] hm.. or they were. [15:45] odd === zz_natorious is now known as natorious === natorious is now known as zz_natorious [16:11] Daniel Watkins proposed stackforge/cloud-init: Refactor handlers out of main reporting module. https://review.openstack.org/207979 [16:12] Odd_Bloke, sometimes its good to explain *why* you're making a change. === zz_natorious is now known as natorious [16:15] Daniel Watkins proposed stackforge/cloud-init: Refactor handlers out of main reporting module. https://review.openstack.org/207979 [16:15] smoser: Yep, not totally used to the commit _being_ the review proposal yet. [16:15] Updated with more reasoning. [20:39] Merged stackforge/cloud-init: Refactor handlers out of main reporting module. https://review.openstack.org/207979 [20:48] Odd_Bloke, smoser: late to the party, I left a comment for #207979. === natorious is now known as zz_natorious