[01:40] <blr> wgrant: so it looks like $LANG is unset in a hook execution context
[01:42] <blr> which can lead to utf-8 weirdness in some libraries (envdir uses codecs.open, rather than open for some reason)
[01:42] <blr> as a workaround I'm forcing en_US.UTF-8
[01:52] <wgrant> blr: What does it break?
[01:55] <blr> wgrant: codecs.open drops back to ASCII, even in 3.4 weirdly
[01:55] <wgrant> As it should.
[01:55] <wgrant> But does that break anything?
[01:55] <blr> wgrant: it breaks envdir
[01:56] <blr> setting LANG in the charm works, it just seems like an odd thing to have to do
[02:01] <blr> wgrant: is it reasonable to expect LANG in the juju context?
[02:03] <wgrant> blr: https://github.com/juju/juju/issues/133
[02:03] <wgrant> blr: But why does envdir care? Is it writing out non-ASCII?
[02:06] <blr> wgrant: it builds it's setuptools description from a few different files, presumably one of them contains non ascii characters
[02:06] <blr> https://github.com/jezdez/envdir/blob/master/setup.py
[02:07] <blr> not sure why he's used codecs.open there
[03:57] <mwhudson> today's lesson: cross compiling go from pcc64le to amd64 doesn't work
[07:21] <cjwatson> blr: C.UTF-8 is a better choice; unlike en_US.UTF-8, it's available on all Ubuntu systems, even the most minimal ones, without needing to install anything extra
[08:01] <blr> cjwatson: excellent, thanks I'll use that.
[09:13] <cjwatson> wgrant,blr: I'm rather blocked on reviews, if either of you get some time.  I'm going to sidestep that today by having a go at some more of the BaseMailer stuff.
[09:39] <wgrant> cjwatson: I have snapbuild-basic-model pretty much done, just wanted to give it a few hours to percolate before I actually hit the r=me. Will look over again now.
[09:39] <wgrant> Meant to do it earlier but rabbitmq ate me.
[09:44] <wgrant> The whole privacy thing worries me.
[09:44] <wgrant> But it is little more intractable than eg. recipes.
[09:45] <cjwatson> Hopefully a good bit better since it doesn't involve descending into Soyuz.
[10:49] <cjwatson> Converting team notifications to BaseMailer looks pretty tractable and likely to be an improvement in terms of consistency/filterability, but is involving a lot of very careful thinking!
[10:49] <cjwatson> (Not least because each notification has potentially multiple teams involved, so I'm having to think carefully about which one gets the @ notation in X-Launchpad-Message-Rationale.)
[10:57] <wgrant> I don't actually recall if we send two if you're on both ends.
[10:57] <wgrant> I'd think not, but I don't know.
[11:00] <cjwatson>         # The member's email address may be in admin_addrs too; let's remove
[11:00] <cjwatson>         # it so the member don't get two notifications.
[11:00] <cjwatson> Which is just as well as otherwise it's a pain to BaseMailerify.
[11:00] <cjwatson> Though, hmm, I wonder how to handle the multiple templates.
[11:02] <wgrant> It'll have to be two separate mailer invocations, I suspect.
[11:03] <cjwatson> Yeah, I don't think I can convert notify_team_join into a single mailer instance.
[20:39] <blr> morning