mupBug #1480298 changed: unknown object type "Charms" <blocker> <ci> <compatibility> <regression> <juju-core:Fix Released by cherylj> <https://launchpad.net/bugs/1480298>00:17
perrito666menn0: it appears memoserv is not as useful as it used to02:34
menn0perrito666: why not? I've never used it before and was just looking at its help.02:35
menn0perrito666: review is all done btw02:35
perrito666menn0: well I found you before memoserv :)02:35
perrito666it only works when people identify02:35
menn0perrito666: I did see the message when I logged in but I didn't know what is what about02:36
menn0perrito666: I only just checked now02:36
perrito666oh I see, it used to be waaay more crude02:38
perrito666iirc it was a message thrown at you upon identification02:38
perrito666menn0: are you sure about makeEnvironment in 1.24?02:41
menn0perrito666: no, I was looking at master so there's a chance it's not there in 1.24.02:42
perrito666it isnt, just checked02:42
menn0perrito666: you could copy it back if you wanted02:42
perrito666well, Ill address all other points and if by then its still today Ill do it02:43
menn0perrito666: no problems02:45
* perrito666 is running dangerously low on today reserves02:45
perrito666menn0: It is too late for me, I pushed as much as I could please take a look, re master my patch will deppend on will's one so you might need to add a seccond look at his patch pending (the one with 70 files)04:15
menn0ok will look at both before I EOD04:16
menn0go to bed man!04:16
mupBug #1461888 changed: Units stuck in agent-state: down state <juju-core:Expired> <https://launchpad.net/bugs/1461888>04:29
menn0perrito666: I see you've responded to most of the issues I raised but I don't see the pushed changes05:05
voidspacedimitern: ping07:33
dimiternvoidspace, pong07:34
voidspacedimitern: do you have a minute to talk about spaces and subnets?07:34
dimiternvoidspace, sure, hangout?07:35
voidspacestdup hangout?07:35
dimiternok, omw07:35
wallyworldjam: i see you're looking at the doc :-) still WIP,  i need to break for dinner but will come back to it after07:54
jamwallyworld: sgtm07:54
dooferladdimitern: hangout?09:05
dooferladjam: ^^09:05
jamdooferlad: oops, omw09:05
=== rogpeppe1 is now known as rogpeppe
voidspacedimitern: I can see you editing my work :-)09:49
dimiternvoidspace, I hope you don't mind :)10:15
perrito666hey  I have http://reviews.vapour.ws/r/2297/ and its master version http://reviews.vapour.ws/r/2299/ both fixing  https://bugs.launchpad.net/juju-core/+bug/1479289 in case anyone feels like reviewing11:41
mupBug #1479289: statushistory uses sequence, fails in multi-env state servers <blocker> <jes> <status> <juju-core:In Progress by hduran-8> <https://launchpad.net/bugs/1479289>11:41
perrito666dimitern: those are the patches you are looking for, if you think they are mergeable feel free to now I really need some sleep11:45
dimiternperrito666, ack, thanks12:11
voidspacedimitern: ping13:03
dimiternvoidspace, pong13:05
voidspacedimitern: apiserver/testing/stub_network.go13:05
voidspacedimitern: if initialised with spaces sets up a few spaces, including a duplicate13:06
voidspacedimitern: the duplicate has the comment  "duplicates are ignored when caching spaces."13:06
voidspacedimitern: however, of course, AllSpaces is returning this duplicate13:06
voidspacedimitern: do you know why the duplicate is there and what the comment means?13:06
voidspacealso FakeSpace only stores subnet IDs and is unable to return real subnet information - so I guess I have to expand it13:07
voidspacedimitern: if you don't know I can ask dooferlad13:08
dimiternvoidspace, that whole complicated logic around caching spaces is overengineered I'm afraid13:09
voidspacedimitern: where is that done?13:10
dimiternvoidspace, needs to be simplified and get rid of the cache, but that's not affecting you I guess?13:10
voidspaceI can see a reference to it in apiserver/subnets/subnets.go13:10
voidspacewell, the cache isn't directly affecting me I don't think13:10
dimiternvoidspace, the duplicates are there to verify they are ignored13:10
voidspacedimitern: but I think I'll need some logic now in the fake AllSpaces method to ignore them there too13:11
dimiternvoidspace, that sounds good to me13:11
dimiternvoidspace, I can have a look at some point if you want13:11
voidspaceand the FakeSpace will need to be more sophisticated to construct real Subnets to return from AllSpaces13:12
voidspacethe FakeSpace doesn't have references to the actual subnets, just their ids13:12
voidspacebut I can work my way through that13:12
* TheMue slams his head on his desk13:14
TheMuewhole time hunting a so far non existent failure in a test case, but introduced it himself by changing some of the test data13:16
dimiternTheMue, bad luck :/13:20
TheMuedimitern: yeah, so dumb13:24
mupBug # changed: 1452422, 1459785, 1464335, 1466969, 1468581, 1474606, 1475271, 147735813:28
mupBug # opened: 1452422, 1459785, 1464335, 1466969, 1468581, 1474606, 1475271, 147735813:31
voidspacedimitern: where does the caching stuff exist?13:33
voidspacedimitern: FakeSpace.SubnetIds seems to be unused13:33
voidspacedimitern: I'd like to replace SubnetIds with Subnets13:34
voidspaceif I get rid of the SubnetIds from the test stub SetUp nothing seems to fail13:34
voidspace(nothing in apiserver anyway)13:34
voidspaceso it looks like it's safe to modify13:34
mupBug # changed: 1452422, 1459785, 1464335, 1466969, 1468581, 1474606, 1475271, 147735813:37
voidspaceno references to cache in apiserver/spaces13:37
voidspaceapiserver/subnets/subnets.go has a reference to a spaces cache13:38
dimiternvoidspace, yes, I only needed the ids then, so feel free to extend it as you need13:38
voidspacedimitern: but getting rid of the ids doesn't seem to cause any tests to fail13:39
voidspaceI can't see where they're used...13:39
voidspacedimitern: ok, I'll proceed carefully :-)13:39
dimiternvoidspace, the caching stuff is in apiserver/subnets on create13:41
voidspacedimitern: ok, thanks13:41
dimiternvoidspace, TheMue, dooferlad, guys, the induction sprint will be 1-4 Sept in London; now it's being requested and we should sort the travel details as soon as we have the req num13:53
voidspacedimitern: ok13:53
dooferladdimitern: sounds good13:53
TheMuedimitern: fine, already marked a flight at my favourite site for flight information retrieval13:54
dimiternvoidspace, was August, 31 the UK bank holiday?13:57
=== benji is now known as Guest8348
dimiterndooferlad, ^^13:58
dooferladdimitern: yes13:59
dimiterndooferlad, ta! added to the calendar13:59
=== benji_ is now known as benji
wwitzel3ericsnow: ping14:01
perrito666well the day I decide to go cut my hair, the barber shop is closed, such is my luck14:10
dimiternjam, TheMue, (as you'll be the only ones beside me booking flights) the sprint request is approved, please sort your flights14:15
TheMuedimitern: yep, having the req num and I can book. already looked for a flight14:19
jamdimitern: TheMue: alexisb: the Sprint Request includes Monday, but I'm pretty sure we decided just Tues-Fri14:39
alexisbjam, that is my fault14:39
jamalexisb: k. just making sure I didn't miss a conversation14:39
jamI replied to your Sprint email14:39
dimiternjam, I assumed the same14:40
alexisbthat is what happens when you are trying to do 5 things at once14:40
jamalexisb: no harm. just getting confirmation and thanks a ton for pushing so fast on it.14:40
dimiternalexisb, yes, thanks a lot for organizing it so quickly!14:42
voidspacealexisb: yep, thanks14:58
TheMuealexisb: ping, hangout15:05
alexisbTheMue, heya, sorry my current meeting is running over15:05
TheMuealexisb: ok, leaving and wait until you ping me then ;)15:06
dooferladvoidspace: we don't do anything about the hotel booking, right?15:12
alexisbok TheMue , I am jumping on15:18
TheMuealexisb: /me too ;)15:18
voidspacedooferlad: that's the usual situation15:29
xwwtmgz:  Can you join the windows call?16:33
perrito666bbl, construction site checking :D18:08
ericsnowwwitzel3: could you give me a couple quick reviews?  http://reviews.vapour.ws/r/2301/ and http://reviews.vapour.ws/r/2300/18:41
wwitzel3ericsnow: sure, once I cut myself out of these weeds19:37
ericsnowwwitzel3: :)19:38
wwitzel3ericsnow: I have one test giving me a hard time21:11
ericsnowwwitzel3: np21:12
ericsnowwwitzel3: can I help?21:12
wwitzel3ericsnow: mind taking a look? been stuck on it a while21:12
wwitzel3ericsnow: in moonstone21:12
menn0perrito666: ping21:31
perrito666menn0: pong21:31
perrito666menn0: no, I actually found no one willing to review those21:31
menn0perrito666: for some reason your latest changes to the statushistory PR aren't showing on RB21:32
* perrito666 headbutts the kb21:32
menn0perrito666: but i've looked on Github and things look good there21:32
menn0perrito666: the only problem I can see is that the tests in state/upgrades_test.go aren't checking the error return from the upgrade funcs21:32
menn0perrito666: other than that ship it!21:32
perrito666menn0: oops, I missed that?21:33
menn0perrito666: yep21:34
menn0perrito666: i'll update the review anyway and then you can start merging21:35
menn0perrito666: note that I also updated the ticket so that both master and 1.24 series are shown21:35
perrito666menn0: I seem to have missed that in only one21:35
perrito666menn0: I did see the email pass21:36
perrito666well for a bug fix that was a big patch21:37
menn0perrito666: review updated21:39
menn0perrito666: that happens :)21:40
perrito666menn0: $$merged$$ now lets wait21:45
perrito666sometimes I reall miss subversion where I could do tests/commits while working in something else21:45
perrito666menn0: how do you feel about repeating the hit with http://reviews.vapour.ws/r/2299/21:46
perrito666you will have to look at ghub too21:46
perrito666while you where not here fwereade's large patch was merged21:48
menn0perrito666: rather than having to review the whole thing again, can you point me at the parts where you had to make significant changes?21:54
perrito666menn0: finally I did not do any change, the only sifnificant differences is megawatcher became allwatcher (but the file contents did not change) and makeEnvironment was already there21:55
menn0perrito666: well in that case, just merge away21:56
perrito666seems the bot is a bit lazy today21:57
axwalexisb: will be a couple of mins23:00
alexisbaxw, no worries23:00
alexisbwait I should so no wuckers23:01
alexisbthumper, menn0, cherylj can you all please make sure that bug https://bugs.launchpad.net/juju-core/+bug/1481368 gets updated with the latest status and your eod23:02
alexisbit is being closely tracked23:02
perrito666Both patches for https://bugs.launchpad.net/juju-core/+bug/1479289  have landed (and include in them the uncommente test that caused the bug report in first place, working)23:36
mupBug #1479289: statushistory uses sequence, fails in multi-env state servers <blocker> <jes> <status> <juju-core:Fix Committed by hduran-8> <juju-core 1.24:Fix Committed by hduran-8> <https://launchpad.net/bugs/1479289>23:36
perrito666bbl dinner23:43
thumperis archive.ubuntu.com down for anyone else?23:52
thumperapt-get update inside my container is having issues23:53
anastasiamacthumper: i can reach archive.ubuntu.com23:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!