[00:17] <mup> Bug #1480298 changed: unknown object type "Charms" <blocker> <ci> <compatibility> <regression> <juju-core:Fix Released by cherylj> <https://launchpad.net/bugs/1480298>
[02:34] <perrito666> menn0: it appears memoserv is not as useful as it used to
[02:35] <menn0> perrito666: why not? I've never used it before and was just looking at its help.
[02:35] <menn0> perrito666: review is all done btw
[02:35] <perrito666> menn0: well I found you before memoserv :)
[02:35] <perrito666> it only works when people identify
[02:36] <menn0> perrito666: I did see the message when I logged in but I didn't know what is what about
[02:36] <menn0> perrito666: I only just checked now
[02:38] <perrito666> oh I see, it used to be waaay more crude
[02:38] <perrito666> iirc it was a message thrown at you upon identification
[02:41] <perrito666> menn0: are you sure about makeEnvironment in 1.24?
[02:42] <menn0> perrito666: no, I was looking at master so there's a chance it's not there in 1.24.
[02:42] <perrito666> it isnt, just checked
[02:42] <menn0> cool
[02:42] <menn0> perrito666: you could copy it back if you wanted
[02:43] <perrito666> well, Ill address all other points and if by then its still today Ill do it
[02:45] <menn0> perrito666: no problems
[02:45]  * perrito666 is running dangerously low on today reserves
[04:15] <perrito666> menn0: It is too late for me, I pushed as much as I could please take a look, re master my patch will deppend on will's one so you might need to add a seccond look at his patch pending (the one with 70 files)
[04:15] <perrito666> cheers
[04:16] <menn0> ok will look at both before I EOD
[04:16] <menn0> go to bed man!
[04:29] <mup> Bug #1461888 changed: Units stuck in agent-state: down state <juju-core:Expired> <https://launchpad.net/bugs/1461888>
[05:05] <menn0> perrito666: I see you've responded to most of the issues I raised but I don't see the pushed changes
[07:33] <voidspace> dimitern: ping
[07:34] <dimitern> voidspace, pong
[07:34] <voidspace> dimitern: do you have a minute to talk about spaces and subnets?
[07:35] <dimitern> voidspace, sure, hangout?
[07:35] <voidspace> ok
[07:35] <voidspace> stdup hangout?
[07:35] <dimitern> ok, omw
[07:54] <wallyworld> jam: i see you're looking at the doc :-) still WIP,  i need to break for dinner but will come back to it after
[07:54] <jam> wallyworld: sgtm
[09:05] <dooferlad> dimitern: hangout?
[09:05] <dooferlad> jam: ^^
[09:05] <jam> dooferlad: oops, omw
[09:49] <voidspace> dimitern: I can see you editing my work :-)
[10:15] <dimitern> voidspace, I hope you don't mind :)
[11:41] <perrito666> hey  I have http://reviews.vapour.ws/r/2297/ and its master version http://reviews.vapour.ws/r/2299/ both fixing  https://bugs.launchpad.net/juju-core/+bug/1479289 in case anyone feels like reviewing
[11:41] <mup> Bug #1479289: statushistory uses sequence, fails in multi-env state servers <blocker> <jes> <status> <juju-core:In Progress by hduran-8> <https://launchpad.net/bugs/1479289>
[11:45] <perrito666> dimitern: those are the patches you are looking for, if you think they are mergeable feel free to now I really need some sleep
[12:11] <dimitern> perrito666, ack, thanks
[13:03] <voidspace> dimitern: ping
[13:05] <dimitern> voidspace, pong
[13:05] <voidspace> dimitern: apiserver/testing/stub_network.go
[13:06] <voidspace> dimitern: if initialised with spaces sets up a few spaces, including a duplicate
[13:06] <voidspace> dimitern: the duplicate has the comment  "duplicates are ignored when caching spaces."
[13:06] <voidspace> dimitern: however, of course, AllSpaces is returning this duplicate
[13:06] <voidspace> dimitern: do you know why the duplicate is there and what the comment means?
[13:07] <voidspace> also FakeSpace only stores subnet IDs and is unable to return real subnet information - so I guess I have to expand it
[13:08] <voidspace> dimitern: if you don't know I can ask dooferlad
[13:09] <dimitern> voidspace, that whole complicated logic around caching spaces is overengineered I'm afraid
[13:10] <voidspace> dimitern: where is that done?
[13:10] <dimitern> voidspace, needs to be simplified and get rid of the cache, but that's not affecting you I guess?
[13:10] <voidspace> I can see a reference to it in apiserver/subnets/subnets.go
[13:10] <voidspace> well, the cache isn't directly affecting me I don't think
[13:10] <dimitern> voidspace, the duplicates are there to verify they are ignored
[13:11] <voidspace> dimitern: but I think I'll need some logic now in the fake AllSpaces method to ignore them there too
[13:11] <dimitern> voidspace, that sounds good to me
[13:11] <voidspace> ok
[13:11] <dimitern> voidspace, I can have a look at some point if you want
[13:12] <voidspace> and the FakeSpace will need to be more sophisticated to construct real Subnets to return from AllSpaces
[13:12] <voidspace> the FakeSpace doesn't have references to the actual subnets, just their ids
[13:12] <voidspace> but I can work my way through that
[13:14] <TheMue> aaaaaaaaaaaaaargh!
[13:14]  * TheMue slams his head on his desk
[13:16] <TheMue> whole time hunting a so far non existent failure in a test case, but introduced it himself by changing some of the test data
[13:16] <TheMue> gnah!
[13:20] <dimitern> TheMue, bad luck :/
[13:24] <TheMue> dimitern: yeah, so dumb
[13:28] <mup> Bug # changed: 1452422, 1459785, 1464335, 1466969, 1468581, 1474606, 1475271, 1477358
[13:31] <mup> Bug # opened: 1452422, 1459785, 1464335, 1466969, 1468581, 1474606, 1475271, 1477358
[13:33] <voidspace> dimitern: where does the caching stuff exist?
[13:33] <voidspace> dimitern: FakeSpace.SubnetIds seems to be unused
[13:34] <voidspace> dimitern: I'd like to replace SubnetIds with Subnets
[13:34] <voidspace> if I get rid of the SubnetIds from the test stub SetUp nothing seems to fail
[13:34] <voidspace> (nothing in apiserver anyway)
[13:34] <voidspace> so it looks like it's safe to modify
[13:37] <mup> Bug # changed: 1452422, 1459785, 1464335, 1466969, 1468581, 1474606, 1475271, 1477358
[13:37] <voidspace> no references to cache in apiserver/spaces
[13:38] <voidspace> apiserver/subnets/subnets.go has a reference to a spaces cache
[13:38] <dimitern> voidspace, yes, I only needed the ids then, so feel free to extend it as you need
[13:39] <voidspace> dimitern: but getting rid of the ids doesn't seem to cause any tests to fail
[13:39] <voidspace> I can't see where they're used...
[13:39] <voidspace> dimitern: ok, I'll proceed carefully :-)
[13:41] <dimitern> voidspace, the caching stuff is in apiserver/subnets on create
[13:41] <voidspace> dimitern: ok, thanks
[13:53] <dimitern> voidspace, TheMue, dooferlad, guys, the induction sprint will be 1-4 Sept in London; now it's being requested and we should sort the travel details as soon as we have the req num
[13:53] <voidspace> dimitern: ok
[13:53] <dooferlad> dimitern: sounds good
[13:54] <TheMue> dimitern: fine, already marked a flight at my favourite site for flight information retrieval
[13:55] <dimitern> cheers!
[13:57] <dimitern> voidspace, was August, 31 the UK bank holiday?
[13:58] <dimitern> dooferlad, ^^
[13:59] <dooferlad> dimitern: yes
[13:59] <dimitern> dooferlad, ta! added to the calendar
[14:01] <wwitzel3> ericsnow: ping
[14:10] <perrito666> well the day I decide to go cut my hair, the barber shop is closed, such is my luck
[14:15] <dimitern> jam, TheMue, (as you'll be the only ones beside me booking flights) the sprint request is approved, please sort your flights
[14:19] <TheMue> dimitern: yep, having the req num and I can book. already looked for a flight
[14:39] <jam> dimitern: TheMue: alexisb: the Sprint Request includes Monday, but I'm pretty sure we decided just Tues-Fri
[14:39] <alexisb> jam, that is my fault
[14:39] <jam> alexisb: k. just making sure I didn't miss a conversation
[14:39] <jam> I replied to your Sprint email
[14:39] <alexisb> thanks
[14:40] <dimitern> jam, I assumed the same
[14:40] <alexisb> that is what happens when you are trying to do 5 things at once
[14:40] <jam> alexisb: no harm. just getting confirmation and thanks a ton for pushing so fast on it.
[14:42] <dimitern> alexisb, yes, thanks a lot for organizing it so quickly!
[14:44] <TheMue> +1
[14:58] <voidspace> alexisb: yep, thanks
[15:05] <TheMue> alexisb: ping, hangout
[15:05] <alexisb> TheMue, heya, sorry my current meeting is running over
[15:06] <TheMue> alexisb: ok, leaving and wait until you ping me then ;)
[15:12] <dooferlad> voidspace: we don't do anything about the hotel booking, right?
[15:18] <alexisb> ok TheMue , I am jumping on
[15:18] <TheMue> alexisb: /me too ;)
[15:29] <voidspace> dooferlad: that's the usual situation
[15:29] <voidspace> bbiab
[16:33] <xwwt> mgz:  Can you join the windows call?
[16:34] <mgz> omw
[18:08] <perrito666> bbl, construction site checking :D
[18:41] <ericsnow> wwitzel3: could you give me a couple quick reviews?  http://reviews.vapour.ws/r/2301/ and http://reviews.vapour.ws/r/2300/
[19:37] <wwitzel3> ericsnow: sure, once I cut myself out of these weeds
[19:38] <ericsnow> wwitzel3: :)
[21:11] <wwitzel3> ericsnow: I have one test giving me a hard time
[21:12] <ericsnow> wwitzel3: np
[21:12] <ericsnow> wwitzel3: can I help?
[21:12] <wwitzel3> ericsnow: mind taking a look? been stuck on it a while
[21:12] <wwitzel3> ericsnow: in moonstone
[21:31] <menn0> perrito666: ping
[21:31] <perrito666> menn0: pong
[21:31] <perrito666> menn0: no, I actually found no one willing to review those
[21:32] <menn0> perrito666: for some reason your latest changes to the statushistory PR aren't showing on RB
[21:32]  * perrito666 headbutts the kb
[21:32] <menn0> perrito666: but i've looked on Github and things look good there
[21:32] <menn0> perrito666: the only problem I can see is that the tests in state/upgrades_test.go aren't checking the error return from the upgrade funcs
[21:32] <menn0> perrito666: other than that ship it!
[21:33] <perrito666> menn0: oops, I missed that?
[21:34] <menn0> perrito666: yep
[21:35] <menn0> perrito666: i'll update the review anyway and then you can start merging
[21:35] <menn0> perrito666: note that I also updated the ticket so that both master and 1.24 series are shown
[21:35] <perrito666> menn0: I seem to have missed that in only one
[21:36] <perrito666> menn0: I did see the email pass
[21:37] <perrito666> well for a bug fix that was a big patch
[21:39] <menn0> perrito666: review updated
[21:40] <menn0> perrito666: that happens :)
[21:45] <perrito666> menn0: $$merged$$ now lets wait
[21:45] <perrito666> sometimes I reall miss subversion where I could do tests/commits while working in something else
[21:46] <perrito666> menn0: how do you feel about repeating the hit with http://reviews.vapour.ws/r/2299/
[21:46] <perrito666> you will have to look at ghub too
[21:48] <perrito666> while you where not here fwereade's large patch was merged
[21:54] <menn0> perrito666: rather than having to review the whole thing again, can you point me at the parts where you had to make significant changes?
[21:55] <perrito666> menn0: finally I did not do any change, the only sifnificant differences is megawatcher became allwatcher (but the file contents did not change) and makeEnvironment was already there
[21:56] <menn0> perrito666: well in that case, just merge away
[21:57] <perrito666> seems the bot is a bit lazy today
[23:00] <axw> alexisb: will be a couple of mins
[23:00] <alexisb> axw, no worries
[23:01] <alexisb> wait I should so no wuckers
[23:02] <alexisb> thumper, menn0, cherylj can you all please make sure that bug https://bugs.launchpad.net/juju-core/+bug/1481368 gets updated with the latest status and your eod
[23:02] <alexisb> it is being closely tracked
[23:05] <thumper> ack
[23:36] <perrito666> Both patches for https://bugs.launchpad.net/juju-core/+bug/1479289  have landed (and include in them the uncommente test that caused the bug report in first place, working)
[23:36] <mup> Bug #1479289: statushistory uses sequence, fails in multi-env state servers <blocker> <jes> <status> <juju-core:Fix Committed by hduran-8> <juju-core 1.24:Fix Committed by hduran-8> <https://launchpad.net/bugs/1479289>
[23:43] <perrito666> bbl dinner
[23:52] <thumper> hmm...
[23:52] <thumper> is archive.ubuntu.com down for anyone else?
[23:53] <thumper> hmm...
[23:53] <thumper> apt-get update inside my container is having issues
[23:57] <anastasiamac> thumper: i can reach archive.ubuntu.com