/srv/irclogs.ubuntu.com/2015/08/13/#juju-dev.txt

mupBug #1484308 opened: MachineSuite fails <ci> <intermittent-failure> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1484308>00:24
mwhudsondavechen1y: yeah, i should reply to that00:27
=== meetingology` is now known as meetingology
perrito666Hey guys I am going to sleep I won't make it awake to the team meeting01:48
natefinchperrito666: heh, good night.01:48
natefinchericsnow: you around?01:54
wwitzel3natefinch: I am if that helps02:21
natefinchwwitzel3: there's a line in the hook context's flush that looks dangerous/bad02:29
natefinchwwitzel3: https://github.com/juju/juju/blob/feature-proc-mgmt/process/context/context.go#L20602:30
natefinchwwitzel3: when we flush, we set updates to nil, but the rest of the code expects that updates will be non-nil02:30
wwitzel3natefinch: I thought we explictly checked for len(c.updates) in all those places?02:32
wwitzel3natefinch: or we have a !ok check for the key accessor02:33
wwitzel3natefinch: if not, we should02:33
natefinchwwitzel3: we don't, so we should.  Or just not set it to nil, just set it to an empty map.02:33
wwitzel3natefinch: yeah, might as well just set it to an empty map02:37
axwwallyworld: re your comment in http://reviews.vapour.ws/r/2330/. I would rather not add that assertion. it's done in other tests already. these tests are big and unwieldy already, I'm trying to make them a bit more targeted02:49
wallyworldaxw: sure, np02:50
axwwallyworld: did you want to review http://reviews.vapour.ws/r/2332/ (azure volume source), or should I go ahead and land it?03:18
wallyworldaxw: looks like it's had 2 others, so go for it i reckon03:18
axwI do so like an unblocked master03:20
axwwallyworld: 2nd point in follow-ups in description: "- update storage provisioner to set status when detaching or destroying"03:37
axwwallyworld: I can do it in this branch if you prefer03:38
wallyworldah03:38
wallyworldtis ok, sorry i missed that03:38
huwshimithumper: Quick question about jujulib, I'm trying to find the package for python-websocket. I couldn't see anything on pypi.04:00
thumper:)04:00
thumperhuwshimi: websocket_client04:00
huwshimithumper: Ah hah!04:01
thumperhuwshimi: quick hangout?04:01
huwshimithumper: Sure04:01
thumperhuwshimi: https://plus.google.com/hangouts/_/canonical.com/onyx-standup04:01
menn0davechen1y: https://github.com/juju/juju/pull/2977 please05:25
voidspaceTheMue: morning07:43
=== anthonyf is now known as Guest27914
mupBug #1484403 opened: provider/openstack: default block source not set to "cinder" <openstack-provider> <juju-core:Triaged> <https://launchpad.net/bugs/1484403>08:07
mupBug #1484419 opened: Local provider: fail to download charm from state server when using an isolated network <landscape> <juju-core:New> <https://launchpad.net/bugs/1484419>08:55
voidspacedooferlad: ping09:05
=== urulama_ is now known as urulama
TheMueyeeeehaw, mini provider mock and envrion work for test10:16
mupBug #1307445 changed: openstack: instances with multiple nics on the same network don't have deterministic private-addresses <addressability> <amd64> <apport-bug>10:29
mup<ec2-images> <network> <openstack-provider> <trusty> <juju-core:Triaged> <juju-core (Ubuntu):Triaged> <https://launchpad.net/bugs/1307445>10:29
perrito666marcoceppi: ping?12:08
marcoceppiperrito666: yooooo12:09
perrito666liberal icmp protocol12:09
marcoceppiicmp for the 21st centry12:09
perrito666marcoceppi: can you take a look at this review comment and give me your opinion on how we should display the new available version on tabular format? http://reviews.vapour.ws/r/2314/#comment1567012:11
perrito666ill give some context12:11
perrito666I have added a new tools version availability check12:11
marcoceppicontext is for chumps, I dive right in and make uninformed decisions on everything I do ;)12:11
perrito666that will display, in status, whenever a new version is available for upgrade12:11
marcoceppiso, that will only display when you have a newer version of tools available?12:13
perrito666yep12:13
marcoceppiperrito666: aesthetically I'd prefer it if had a header, something like [Juju] and then just a Running: and Available: key, but that's really just personal opinion to keep everything inline style wise. No one is going to be parsing the tabular output so I'm fine whatever people choose. My only real concern is the amount of realestate it takes, if it's going to consume 4 lines at the top it better be damn important because in deployments of >12:16
marcoceppi5 services and 10 units info on normal displays start to truncate while running watch12:16
marcoceppiperrito666: also, how does this look in yaml and json? is it parsable there?12:16
perrito666marcoceppi: in yaml and json is parsable12:18
perrito666it is at the same level as environment12:19
marcoceppicool12:19
marcoceppiperrito666: so, tl;dr; I'd prefer a heading and simple output (just the keys) but I don't have a strong opinion on the subject, I'd just find it pleasing to the eye12:20
perrito666marcoceppi: well you are more of a user than we are12:20
perrito666and position, top?12:20
marcoceppiperrito666: hum, that's a good question. Considering most people won't be upgrading the moment a new release comes out (IS, for example) having that nag as the top item seems wasteful. I'd probably possition it between machines and units but that feels weird too12:25
marcoceppiperrito666: having it at the bottom is fine too. I think it's a bit foolish to assume juju is the most important thing to display in the output. To us it may be, to the user I think they're more concerned about their workload12:27
perrito666well shame on them12:27
* perrito666 is about to go fix mramm's connection12:28
perrito666marcoceppi: thanks for your imput12:28
voidspacedimitern: TheMue: if you have time http://reviews.vapour.ws/r/2360/12:57
voidspacerelatively straightforward12:57
=== anthonyf is now known as Guest46427
voidspacedimitern: TheMue: dammit, it's not ready yet - belay that12:58
=== Guest46427 is now known as anthonyjf
voidspacedimitern: TheMue: ok, it's ready now...13:04
voidspace(again...)13:04
marcoceppiwhy do we hardcode series in Juju?13:23
natefinchmarcoceppi: just to piss everyone off13:28
natefinchmarcoceppi: including ourselves13:28
marcoceppinatefinch: but like, I'm serious. What's the use for it in juju? I'm trying to understand the justification13:28
marcoceppi(without reading a bunch of go code)13:29
natefinchmarcoceppi: ostensibly it's so we can know if someone is using a series that's too old.  Though I would think the lack of tools would be a perfectly acceptable way to stop them from deploying to a machine where it wouldn't work.13:30
* marcoceppi considers ripping all this out and just submitting a patch13:30
jcastroyeah so, we're broken on OSX and Windows because of this13:30
jcastronatefinch: what do you need from us to help?13:31
natefinchhonestly, what we should do is hardcode the series that are too old, since those are static.13:31
* marcoceppi hates the idea of hard coding anything13:31
natefinchjcastro: what problem are you seeing?13:31
marcoceppiSimplestreams seems to be the best means13:31
jcastrodoesn't work on OSX El Capitan or Windows 1013:31
natefinchle sigh13:32
jcastrolike, we don't work at all currently13:32
natefinchfor the client... we shouldn't look at series at all. If the code can run enough to look at series, it's probably fine.13:32
jcastro+5013:33
jcastronatefinch: in the meantime: https://github.com/AdamIsrael/juju/commit/909bf8e3074c0bae25579e84f41a71996fe61a3f13:34
natefinchjcastro: gah, yeah.  Send a PR13:36
marcoceppinatefinch: https://github.com/juju/juju/pull/296913:37
jcastronatefinch: we'll need a fix for Windows 10 as well, which is actually released and in the wild.13:38
jcastronatefinch: incoming from marco in a few minutes13:40
natefinchjcastro: cool.  I told CI to merge the OSX one13:40
marcoceppiOK13:48
marcoceppiI understand why we have series matching for client, it appears to be able to map caveats for things?13:49
marcoceppilike on Linux do this on Windows do this and on OSX do this?13:49
natefinchmarcoceppi: we don't need series for that, just OS, and Go gives us OS detected (i.e. darwin vs linux vs windows).  What it doesn't give us is, for example, trusty vs Wily or centos vs ubuntu13:50
marcoceppinatefinch: I'm just trying to figure out how to remove hard coding versions all together13:50
marcoceppilike, why do we need to know what version of osx or windows you're running at that point?13:50
natefinchmarcoceppi: I am all for that13:50
marcoceppinatefinch: well, you'13:50
marcoceppill love this patch13:50
natefinchmarcoceppi: one trick is local provider13:51
marcoceppiigaf about local provider, since it's only Ubuntu and we should be able to detect ubuntu fairly well given we created the OS13:51
marcoceppiidgaf*13:52
* katco sitting in the standup all by my lonesome, wwitzel3 natefinch ericsnow 14:03
perrito666katco: introspective standup :p14:04
bogdanteleagaanybody in for a fast one? http://reviews.vapour.ws/r/2361/14:11
aisraelnatefinch: Sorry, I fixed the failing test for that osx patch14:11
natefinchaisrael: cool14:11
TheMuedimitern: I'm postponing the test of isNetworkingEnvironment() in cmd/jujud/agent/manchine.go. as we talked about this morning SupportsNetworking() does not rely on the feature flag but on a type assertion of the environment14:13
TheMuedimitern: will add a card for it14:14
natefinchaisrael: can you add back a test for version 16 producing series unknown etc?14:23
aisraelnatefinch: done14:24
ericsnowcmars: I'd like to have a chat about dependency engine at some point today if you have some time14:39
katcowwitzel3: you going to be around for our 1:1?14:47
wwitzel3katco: hey, sorry, just woke up15:29
katcowwitzel3: no worries... in a meeting atm15:39
dimiternTheMue, sounds good15:58
katcowwitzel3: k sorry... are you up for a 1:1? or is your throat too sore?16:30
mupBug #1484606 opened: bootstrap fails if control bucket not specified and exists <juju-core:New> <https://launchpad.net/bugs/1484606>16:54
mupBug #1484617 opened: Juju doesn't honour agent-stream: released in the config <blocker> <ci> <regression> <streams> <juju-core:Triaged> <https://launchpad.net/bugs/1484617>17:45
=== natefinch is now known as natefinch-afk
perrito666Bbl19:33
mupBug #1484688 opened: [Juju HA] Past logs do not get synced to new slave state servers <juju-core:New> <https://launchpad.net/bugs/1484688>20:45
alexisbcherylj, you around?21:05
alexisbo you are in standup21:05
cheryljalexisb: in standup21:05
alexisbnm, ping me post standup please21:05
cheryljalexisb: will do21:05
mupBug #1478232 changed: juju 1.24 poor performance <cpec> <sts> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1478232>21:24
thumpermramm: ping?21:33
mupBug #1450092 changed: juju fails to bootstrap local provider with vivid and upstart <systemd> <upstart> <vivid> <juju-core:Won't Fix> <juju-core 1.23:Won't Fix> <juju-core 1.24:Won't Fix> <https://launchpad.net/bugs/1450092>22:12
mupBug #1460087 changed: quickstart deployment fails to add relations when bootstrap goes "down" <deploy> <quickstart> <juju-deployer:Triaged> <https://launchpad.net/bugs/1460087>22:12
mupBug #1484718 opened: String config values can't be set as all integers <juju-core:New> <https://launchpad.net/bugs/1484718>22:12
mupBug #1410876 changed: Error executing lxc-clone: lxc_container: utils.c: mkdir_p 220 Not a directory - Could not destroy  snapshot %s - failed to allocate a pty; Insufficent privileges to control  juju-trusty-lxc-template <lxc> <oil> <openstack-provider> <stakeholder-critical> <trusty> <uosci>22:42
mup<juju-core:Invalid> <lxc:New> <https://launchpad.net/bugs/1410876>22:42
mupBug #1473450 changed: upgrade-juju from 1.18 to 1.20.14 leaves some agents down <sts> <upgrade-juju> <juju-core:Fix Released> <https://launchpad.net/bugs/1473450>22:42
perrito666mm, gce as a provider works really well, cheers wwitzel3 and eric23:43

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!