[07:08] <blr> wgrant: a css improvement for diffs here (~blr/launchpad/diff-code-select-bug-1483925), making the lineno column unselectable. I think in almost every case you would _not_ want the line numbers when copy/pasting, however potentially you might want the diff markers?
[07:09] <blr> could render them with the same style, making only the code selectable.
[07:09] <blr> haven't forgotten your MPs btw, lost a bit of time to lxc this afternoon
[07:10] <wgrant> Yep
[07:11] <blr> I think preserving the diff markers is the correct thing to do.
[07:14] <blr> wgrant: did the charm changes look sane?
[07:14] <blr> certainly makes the template simpler.
[07:14] <wgrant> blr: Let me see.
[07:16] <wgrant> blr: You have a conflict, otherwise that looks good.
[07:16] <blr> ah thanks, will fix that up.
[07:51] <wgrant> blr: I agree that the diff markers should be preserved.
[07:51] <wgrant> blr: What is the behaviour in side-by-side mode?
[22:21] <blr> wgrant: are you aware of any mechanism for limiting text selection to a given column? Firefox has support for that, but it seems strangely absent in other browsers.
[23:06] <wgrant> blr: Oh, I didn't know even Firefox supported it.
[23:06] <wgrant> blr: In loggerhead we don't use a table, and lay out the DOM such that the line numbers are totally separate.
[23:14] <blr> wgrant: yep, seems like a useful feature, pity chrome doesn't have something similar.. don't think there's any way to emulate that with css
[23:49] <blr> wgrant: why is logout() required, is that not handled by the admin_logged_in() context?
[23:50] <blr> err sorry context, looking at the bugtask attachment fix
[23:50] <wgrant> blr: The *_logged_in context managers temporarily switch out the interaction, but they restore the old one afterwards.
[23:50] <blr> ah I see
[23:50] <wgrant> So you end up with an anonymous interaction, rather than the no interaction at all required by webservice tests.
[23:50] <blr> that's good to know
[23:57] <blr> testtools matchers are handy, I should make use of those more often.
[23:57] <wgrant> They are marvellous once you get the hang of them.