[03:19] Unit193: I think your ochosi-lock might be on [03:20] Unit193: as far as I can tell, that looks good! :) [03:20] Unless it doesn't. :D [03:20] Yye. [03:21] There's actually 3 total. [03:25] cool [03:25] if you need me to try to review anything, let me know [03:25] but its my bedtime, so it'd be tomorrow [03:25] g'night === SwissBot_ is now known as SwissBot [10:38] bluesabre: that sidebar looks awesome, rly nice work! [10:38] Unit193: sorry too afk atm for reviews [10:39] might be out until at least tomorrow or the day after ror reasons previously disclosed, but which i dont wanna repeat here [10:40] all who need to know know already [10:40] keeping private a bit private and all ;) [10:41] so yeah, off for some afk time [10:41] bbl [11:29] seeya ochosi [19:23] heeey, i added a logo to the tracker today! :D [19:53] wee [19:54] i guess we have to celebrate, eh? ;) [19:56] slickyma1ter: friendly reminder: please schedule a meeting! :) [20:40] hey ochosi [20:40] hey knome [20:40] hey sean! [20:41] oh goodie [20:41] screenshot time [20:41] weeee [20:42] http://i.imgur.com/w39zw21.png [20:42] http://i.imgur.com/7O8ZRxq.png [20:43] nice work! [20:43] I think its a lot nicer (and simpler) than the dialogs that were previously there [20:43] yeah [20:43] much better [20:43] feels "lighter" [20:44] btw, greybird's fault the cog-button isn't pressed? [20:44] no, a bit of hackiness there... [20:44] oh ok, i hoped you would say that ;) [20:44] using a treeview, and embedding a button in a treeview is more annoying than one might imagine [20:44] oh wow, yeah [20:44] i thought you weren't using a treeview there [20:45] so there is a hidden widget under each where the popovers are attached [20:45] I tried using a listview, but its signal management is horrible [20:45] wowza [20:45] yeah, last i heard was the listview [20:46] anyway, this is *so* much nicer [20:46] that hover effect really is awesome [20:46] faster too, both the calendar and extensions entry apply instantly now [20:46] only tiny oddness (if i may pixel-nitpick) is that the radio button doesnt look horizontally centered [20:46] it might be off by 1 or 2px [20:47] to the left, compared to the checkbox [20:47] (or the other icons) [20:47] possibly [20:47] could also be greybird's fault (again) [20:47] I'll take a look, but that might be a fix in 1.3.1 [20:47] yeah [20:47] surely [20:47] trying to get a functional thing out today/tomorrow :) [20:48] yeah, makes sense for FF :) [20:48] another thing i wanted to suggest [20:48] if nothing is found, a centered huge-font label would be nice [20:48] instead of the tiny statusbar [20:48] I can see that [20:49] I'll try to work that it [20:49] and before anything is entered into the searchbar, that huge-font label could say what the tooltip of the searchbox says now [20:49] (and byebye tooltip) [20:49] yeah, that sounds like a nice improvement [20:50] and for 1.3.1 i'll work out some visual improvements for those calendar widgets [20:51] i mean it's nice, and a good improvement over the status quo [20:51] mhm [20:51] but i'm sure it could look a little nicer (which is partly greybird's fault, no calendar popover theming) [20:52] hm, also, is an "ok" button or anything not needed in that popover? [20:52] (or actually both) [20:52] and we might want to add theming for Popover > CheckButton [20:52] no ok button needed, and they're kind of wrong in a popover [20:54] mhm, you mean for the menu? === therealnanotube is now known as nanotube [20:54] yeah [20:54] I'll eventually do that the right way... but it does currently look normal in numix and adwaita fwiw :) [20:54] hm, alright, i'll take a look [20:54] heh, ok : [20:54] ) [20:55] i'll fix that then [20:55] what about the view-switcher? [20:55] does that one work in adwaita/numix? [20:55] i felt the hover was a bit off [20:55] (hover for the full row is a bit weird) [20:56] also, is all you showed in the video pushed so i can look and fix greybird some more? [20:56] one sec, I'll push what I have currently [20:57] pushed [20:57] ok, pulled [20:58] I can probably disable the hover style for the view-switcher in the code [20:58] i'll see what makes sense there first [21:01] frankly: [21:01] when clicking custom, that popover should immediately pop up [21:01] the cog feels a bit too much [21:01] same with "other" [21:01] makes sense [21:07] should be an easy fix... anything else? [21:10] ctrl+q as quit shortcut? :) [21:11] crap, the popover really does look fairly normal with adwaita [21:11] meh, and numix [21:14] oh i see... [21:15] will do [21:15] stepping out to get some food now, bbabl [21:15] ok, so some indicator as to how to enter the file extensions would be great too [21:15] oh [21:15] now i see the empty label [21:15] that looks ok [21:18] bluesabre: pushed fix for popover menu [21:18] should look ok now with greybird [21:18] hopefully no drawbacks or regressions for that fix