| ericsnow | perrito666: it's buried away in the connection code in provider/gce/google | 00:00 |
|---|---|---|
| perrito666 | k tx :) ill dig it up | 00:00 |
| ericsnow | perrito666: k | 00:00 |
| ericsnow | perrito666: gotta run; catch me in the morning if you have more questions | 00:01 |
| perrito666 | tx a lot ericsnow | 00:01 |
| ericsnow | perrito666: np, good luck :) | 00:01 |
| marcoceppi | ericsnow: ping on https://github.com/juju/juju/pull/3044 | 01:37 |
| perrito666 | marcoceppi: eric left a bit over an hour ago | 01:42 |
| menn0 | master is unblocked again people | 04:10 |
| anastasiamac | menn0: tyvm :D | 04:12 |
| mup | Bug #1486675 changed: supportedSeriesWindowsSuite.TestSupportedSeries fails <blocker> <ci> <regression> <unit-tests> <windows> <juju-core:Fix Released by bteleaga> <https://launchpad.net/bugs/1486675> | 04:14 |
| mup | Bug #1486675 opened: supportedSeriesWindowsSuite.TestSupportedSeries fails <blocker> <ci> <regression> <unit-tests> <windows> <juju-core:Fix Released by bteleaga> <https://launchpad.net/bugs/1486675> | 04:23 |
| mup | Bug #1486675 changed: supportedSeriesWindowsSuite.TestSupportedSeries fails <blocker> <ci> <regression> <unit-tests> <windows> <juju-core:Fix Released by bteleaga> <https://launchpad.net/bugs/1486675> | 04:32 |
| dooferlad | dimitern / TheMue: please take a look: http://reviews.vapour.ws/r/2423/ | 07:39 |
| dimitern | dooferlad, sure, looking | 07:40 |
| dimitern | dooferlad, so you went with returning an error with --networks given and these are the only tests that failed? | 07:42 |
| dooferlad | dimitern: yeo | 07:42 |
| dooferlad | yep | 07:42 |
| dimitern | dooferlad, good! | 07:43 |
| * dooferlad tries testing juju with go 1.5 for fun | 07:45 | |
| dimitern | dooferlad, reviewed | 07:47 |
| dimitern | dooferlad, btw do you have a windows machine around that you can try running juju unit tests on? | 07:47 |
| dooferlad | dimitern: not really. I have my gaming box, but I haven't got it set up for development | 07:48 |
| dooferlad | dimitern: https://aws.amazon.com/windows/ ? | 07:48 |
| dimitern | dooferlad, it's fine then, np | 07:49 |
| dimitern | dooferlad, after the yesterday's sync up with master net-cli *almost* got blessed :) | 07:49 |
| dimitern | dooferlad, a couple of tests remaining, one of which is windows specific and "native" to net-cli - bug 1469807 | 07:50 |
| mup | Bug #1469807: ListSuite.TestOutputFormats fails on Windows <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Incomplete> <juju-core net-cli:Triaged> <https://launchpad.net/bugs/1469807> | 07:50 |
| dimitern | dooferlad, we need to sort this out before we can merge net-cli into master | 07:51 |
| mattyw | cmars, tasdomas wallyworld https://github.com/wallyworld/juju/pull/29 | 08:00 |
| cmars | mattyw, tasdomas fwereade wallyworld PTAL, http://reviews.vapour.ws/r/2432/ | 08:13 |
| dooferlad | dimitern: are you sure you want me to remove the SupportsNetworking check in deploy.go? | 08:26 |
| dooferlad | dimitern: do we make sure that networking is supported somewhere else? | 08:26 |
| dimitern | dooferlad, since we'll be using constraints, it's fine to drop that | 08:31 |
| dimitern | dooferlad, because constraints are not guaranteed to be supported and are verified at provisioning time anyway | 08:31 |
| dooferlad | dimitern: thanks. Pushing changes now and will $$merge$$ | 08:32 |
| TheMue | dimitern: I yesterday fixed the comments for my latest branch, only go logical trouble with the test of the FinishedWorker. the fact, that the runner stops a worker after Wait() returned nil is tested elsewhere, so due to the simpleness of the FW we need only to assure that it implements worker (simple static assignment) and if Wait() returns nil | 08:34 |
| TheMue | dimitern: so I would like to drop the one I added and create a new real finishedworker_test.go | 08:35 |
| * dooferlad thinks that localServerSuite.TestNetworkInterfaces has a race | 08:35 | |
| * TheMue fetches his chequered flag | 08:36 | |
| dooferlad | dimitern: have you seen this? http://pastebin.ubuntu.com/12134188/ | 08:46 |
| dimitern | TheMue, let's discuss it during standup? | 08:52 |
| dimitern | dooferlad, looking | 08:52 |
| TheMue | dimitern: sure | 08:52 |
| dimitern | dooferlad, yes, but it's hard to reproduce on my machine | 08:53 |
| dooferlad | dimitern: I think I have seen the problem, but I wanted to check I wasn't duplicating work | 08:53 |
| dimitern | dooferlad, there's a bug about it | 08:53 |
| TheMue | dimitern: could you point me again to the test you mentioned? | 09:31 |
| dimitern | TheMue, have a look how newWorkerStarter() is used | 09:39 |
| TheMue | dimitern: do you mean newTestWorkerStarter()? | 09:42 |
| dimitern | TheMue, yes, that's the one | 09:43 |
| TheMue | dimitern: yeah, it works with the newTestWorkerStarter, which works with the testWorker which really has a goroutine in the backend. we don't have that. | 09:45 |
| TheMue | dimitern: IMHO TestOneWorkerFinish() tests that any worker finishes if Wait() returns nil | 09:47 |
| TheMue | dimitern: opposite to TestOneWorkerRestart() | 09:48 |
| TheMue | dimitern: but here this is achieved by telling the goroutine to end with err == nil | 09:49 |
| dimitern | TheMue, ok, then no need to test the finishedworker in runner_test? | 09:57 |
| TheMue | dimitern: that's what I meant, yes. only one that says "yes, I'm a Worker" and "yes, I return nil on Wait()". | 09:58 |
| dimitern | TheMue, just check newAddresser in cmd/jujud/agent/machine.go returns FinishedWorker{} when disabled? | 09:58 |
| TheMue | dimitern: that's in the worker_test right now, but can see how to do it in machine_test too | 10:00 |
| dimitern | TheMue, in machine_test, I'd suggest saving the original agent.NewAddresser value (from export_test), then patching it with another which calls it internally and asserts the result is finishedworker | 10:02 |
| TheMue | dimitern: ok | 10:02 |
| TheMue | all: core team meeting? | 10:03 |
| dimitern | I'll skip it this time I'm afraid | 10:04 |
| mattyw | wallyworld, axw is this basically what you wanted? https://github.com/wallyworld/juju/pull/31/files#diff-abee59b3dd781e907de49c2651b6a332R32 | 10:04 |
| perrito666 | hey people I need to take my wife to work I cant make it to the meeting sorry | 10:09 |
| dooferlad | dimitern: goamz has changed a lot :-| at least I found a real bug in juju (TestNetworkInterfaces relied on map ordering) | 11:07 |
| dooferlad | dimitern: ah, go-amz, not goamz | 11:08 |
| dimitern | dooferlad, yeah | 11:29 |
| dimitern | :) | 11:29 |
| dimitern | dooferlad, what's the ordering bug about? | 11:29 |
| mup | Bug #1486965 opened: Destroying the leader sets the service status to terminated <juju-core:New> <https://launchpad.net/bugs/1486965> | 11:42 |
| mup | Bug #1486965 changed: Destroying the leader sets the service status to terminated <juju-core:New> <https://launchpad.net/bugs/1486965> | 11:54 |
| mup | Bug #1486965 opened: Destroying the leader sets the service status to terminated <juju-core:New> <https://launchpad.net/bugs/1486965> | 12:00 |
| dooferlad | dimitern: that is https://github.com/juju/juju/pull/3052 | 12:21 |
| dooferlad | dimitern: no idea why I didn't create a pull request before lunch | 12:21 |
| dooferlad | it was a map ordering problem | 12:22 |
| dooferlad | https://github.com/go-amz/amz/pull/61 is about thread safety | 12:22 |
| dooferlad | and now, windows! | 12:22 |
| dimitern | dooferlad, awesome! looking | 12:22 |
| dimitern | dooferlad, both approved and the goamz one merged | 12:30 |
| dooferlad | dimitern: thanks! | 12:30 |
| fwereade | tasdomas, cmars: I think we should talk about uniter availability again, I don't quite get how that last branch solves the problem | 12:40 |
| tasdomas | cmars, fwereade sure | 12:40 |
| wallyworld | fwereade: https://github.com/wallyworld/juju/pull/32 | 12:56 |
| wallyworld | axw: https://github.com/wallyworld/juju/pull/32 | 12:56 |
| fwereade | dooferlad, TheMue: dimitern is battered by storms and without power | 13:14 |
| dooferlad | fwereade: thanks for the update. Yikes! | 13:14 |
| perrito666 | yet he manages to communicate with the guy in an island :p | 13:18 |
| fwereade | perrito666, and whose own power is out again, the house is being rewired :) | 13:20 |
| perrito666 | lol | 13:21 |
| mattyw | wallyworld, could you take a look at https://github.com/wallyworld/juju/pull/31 and let me know if it seems reasonable? | 13:21 |
| mattyw | fwereade, you might be interested as well ^^ | 13:21 |
| frankban | ericsnow: when you ahev time, could you please take a look at https://github.com/juju/juju/pull/3035 ? it's a mp for a long-running branch that we are using to implement the embedded gui story. thanks! | 13:28 |
| bac | hi i've got a juju-core pull request on github and reviewboard. with a 'shipit' vote from davecheney. does it require a second? when ready to merge, do you just press the 'shipit' button on reviewboard? | 13:29 |
| abentley | sinzui: Want to talk about weekly test candidates? | 13:32 |
| sinzui | abentley: indeed. have you been listening to my thoughts this morning? | 13:33 |
| wwitzel3 | ericsnow: ping | 13:33 |
| abentley | sinzui: Err, not intentionally? | 13:35 |
| sinzui | dooferlad: or anyone working on net-cli, ping who when bug 1469807 has a fix merged. I want to enure we test it | 13:35 |
| mup | Bug #1469807: ListSuite.TestOutputFormats fails on Windows <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Incomplete> <juju-core net-cli:Triaged> <https://launchpad.net/bugs/1469807> | 13:35 |
| dooferlad | sinzui: I am looking at it now. Will let you know | 13:37 |
| dooferlad | TheMue: Could you take a look at https://github.com/juju/cmd/commit/4a5e8abce36462f89d92d28bd69b54c7845db818 please? | 13:48 |
| dooferlad | TheMue: I pushed to the wrong branch, but I have tested that this works :-( | 13:49 |
| TheMue | dooferlad: yep | 13:56 |
| TheMue | dooferlad: a direct usage of target with the defer of it's closing isn't possible? | 13:59 |
| dooferlad | TheMue: no, because the type of target doesn't have a Close | 13:59 |
| dooferlad | but File does | 13:59 |
| TheMue | dooferlad: ah, and the assigning is a kind of downcast, yes | 13:59 |
| TheMue | dooferlad: ok | 13:59 |
| katco | natefinch: standup? | 14:04 |
| natefinch | katco: oops, coming | 14:05 |
| ericsnow | frankban: yeah, I'll take a look | 14:06 |
| frankban | ericsnow: ty! | 14:07 |
| TheMue | Ah, my last strange tests are now working too, phew. | 14:07 |
| mattyw | wallyworld, another one https://github.com/wallyworld/juju/pull/34 | 14:07 |
| TheMue | Grmpf, still an issue. Those two tests running together by pattern work, also isolated, but inside the whole suite they don't work. | 14:21 |
| TheMue | Error is "connection is shut down" when using the api in the MachineSuite of jujud/agent/machine_test.go | 14:24 |
| dooferlad | TheMue: http://reviews.vapour.ws/r/2437/ | 14:29 |
| TheMue | dooferlad: *click* | 14:30 |
| dooferlad | Just a rev bump to bring in the change I just made to cmd/juju | 14:30 |
| TheMue | dooferlad: done | 14:30 |
| dooferlad | TheMue: thanks! | 14:31 |
| === xwwt_ is now known as xwwt | ||
| TheMue | dooferlad: yw | 14:31 |
| TheMue | dooferlad: I'm still looking for my strange test failures. normally one test shouldn't effect another one. my both work when called single or together, but with the whole suite one fails | 14:32 |
| dooferlad | TheMue: timeouts? | 14:32 |
| dooferlad | TheMue: races? | 14:33 |
| TheMue | dooferlad: connection of the API | 14:33 |
| TheMue | dooferlad: here I have an idea | 14:33 |
| TheMue | dooferlad: I exchange a function variable, so this has to be done atomically | 14:34 |
| ericsnow | cmars: you have a patch up to run the feature tests only upon request? | 14:54 |
| cmars | ericsnow, correct. though, that will be set by default in jenkins | 14:54 |
| cmars | ericsnow, so it is on request in your dev env | 14:54 |
| ericsnow | cmars: a big +1 from me, but why the change from opt-out? | 14:55 |
| ericsnow | cmars: BTW, this might have helped :/ http://reviews.vapour.ws/r/1647/ | 14:56 |
| cmars | ericsnow, unit tests are appropriate for development, integration tests are appropriate for CI | 14:56 |
| ericsnow | cmars: totally agree; perhaps I'm assuming too much to think there was a rationale for opt-out originally | 14:56 |
| ericsnow | cmars: PTAL @ my review on http://reviews.vapour.ws/r/2432/ | 15:02 |
| TheMue | dooferlad: seen the mail? do you know the branches? | 15:22 |
| dooferlad | TheMue: just replied | 15:22 |
| dooferlad | TheMue: no, there is nothing on his github | 15:22 |
| TheMue | dooferlad: just seen your reply | 15:23 |
| TheMue | ;) | 15:23 |
| dooferlad | TheMue: I assume he is working on https://canonical.leankit.com/Boards/View/101652562/116729781 and maybe https://canonical.leankit.com/Boards/View/101652562/116652760 | 15:24 |
| TheMue | dooferlad: yeah, and I don't see branches for it in his account | 15:26 |
| TheMue | dooferlad: but at least I found my failure, a misunderstanding of the helpers of the test suite | 15:58 |
| marcoceppi | ericsnow: ping | 16:20 |
| ericsnow | marcoceppi: hey | 16:21 |
| marcoceppi | ericsnow: I had some questions on https://github.com/juju/juju/pull/3044 | 16:21 |
| ericsnow | marcoceppi: yep | 16:21 |
| marcoceppi | ericsnow: > for clarification does this mean that if I have a script called `juju-foo` in my path `juju foo` will no longer work? | 16:22 |
| katco | marcoceppi: no different concept of plugins | 16:22 |
| marcoceppi | cool, thanks | 16:22 |
| katco | marcoceppi: this has nothing to do with juju plug-ins | 16:22 |
| marcoceppi | just making sure | 16:22 |
| * marcoceppi puts all the red flags away | 16:22 | |
| dimitern | dooferlad, TheMue, o/ | 16:23 |
| ericsnow | marcoceppi: yeah, what katco said :) | 16:24 |
| dooferlad | dimitern: o/ | 16:24 |
| natefinch | marcoceppi: we are disabling bundles and the config-changed hook, though | 16:25 |
| dimitern | dooferlad, so I need to merge your changes from net-cli into my branch and push it | 16:25 |
| ericsnow | marcoceppi: I should have made it more clear that this relates to the workload processes feature | 16:25 |
| dooferlad | dimitern: ok, I will look out for a review request | 16:26 |
| dooferlad | dimitern: will let you get on with it for now. Ping me if there is anything you want. I am idling/hangout out with the daughter (first steps!) until given somethine else to do. | 16:27 |
| dimitern | dooferlad, cheers, I'll try to be quick | 16:27 |
| dooferlad | (since it is EOD) | 16:27 |
| dimitern | dooferlad, :) ok, sounds good | 16:27 |
| dooferlad | I will see what I can do this evening once she is in bed. | 16:28 |
| dooferlad | (if anything is needed) | 16:28 |
| marcoceppi | natefinch: wait...what | 16:50 |
| natefinch | marcoceppi: lol | 16:52 |
| natefinch | marcoceppi: just messing with you | 16:52 |
| natefinch | ericsnow: you around? | 17:33 |
| ericsnow | natefinch: yep | 17:33 |
| natefinch | ericsnow: have you tried the process removal code? I call it and returns no errors and... then the process still exists. Maybe I'm missing something somewhere | 17:35 |
| ericsnow | natefinch: there are tests, but we certainly may have missed something between the layers | 17:36 |
| natefinch | cannot for the life of me get log level = trace to work | 17:42 |
| TheMue | dimitern: ah, back online. I'm idling here too for any task. latest branch is ready for 2nd review (after fighting with testing troubles this afternoon) | 17:50 |
| dimitern | TheMue, cool, I'll have a look then | 17:51 |
| wwitzel3 | cmars: ping | 17:51 |
| dimitern | I'm ready with mine as well - all tests pass, now need to merge | 17:51 |
| TheMue | top | 17:52 |
| dimitern | TheMue, reviewed | 18:06 |
| TheMue | dimitern: thx, will take a look in a few moments | 18:24 |
| natefinch | gah, rolling over a 401k is such an outdated process... mailing paperwork and then mailing paper checks... what is this, 1970? | 18:29 |
| * natefinch is going to receive a check in the mail worth approximately half the cost of his house :/ | 18:29 | |
| natefinch | old brokerage: "But we're sending it priority mail, so we can track it." Fantastic. | 18:30 |
| dimitern | dooferlad, TheMue, if any of you are still around I'd appreciate a quick look on this; it's quite big, but it's also well tested, including a feature test which confirms CLI works end-to-end to state for spaces list|create | 18:39 |
| dooferlad | dimitern: can do | 18:39 |
| dimitern | dooferlad, TheMue, tyvm, http://reviews.vapour.ws/r/2440/ | 18:41 |
| TheMue | *click* | 18:41 |
| dooferlad | dimitern: I almost had several comments, but it looks good! | 18:58 |
| dimitern | dooferlad, awesome! | 18:58 |
| dimitern | dooferlad, I have a similar one for subnets CLI, but it's already very late | 18:59 |
| dooferlad | dimitern: up to you. I can come back after I have eaten | 18:59 |
| dimitern | dooferlad, well, if I'm not done within the next half hour with it, it won't happen, but there are a few tests still left | 19:00 |
| TheMue | dimitern: reviewd | 19:16 |
| dimitern | TheMue, thanks! | 19:18 |
| katco | ericsnow: hey going to be just a little late | 19:58 |
| ericsnow | katco: no worries | 19:59 |
| mup | Bug #1487191 opened: TestAddOkay mismatch <ci> <regression> <unit-tests> <juju-core:Incomplete> <juju-core feature-proc-mgmt:Triaged> <https://launchpad.net/bugs/1487191> | 20:16 |
| mup | Bug #1487191 changed: TestAddOkay mismatch <ci> <regression> <unit-tests> <juju-core:Incomplete> <juju-core feature-proc-mgmt:Triaged> <https://launchpad.net/bugs/1487191> | 20:25 |
| bogdanteleaga | did the procedure for using development tools change? I can't seem to be able to bootstrap anymore, it complains about tools not found | 20:35 |
| bogdanteleaga | http://paste.ubuntu.com/12137669/ | 20:36 |
| mup | Bug #1487191 opened: TestAddOkay mismatch <ci> <regression> <unit-tests> <juju-core:Incomplete> <juju-core feature-proc-mgmt:Triaged> <https://launchpad.net/bugs/1487191> | 20:37 |
| cherylj | bogdanteleaga: have you tried using --upload-tools? | 20:46 |
| bogdanteleaga | nope, I have them uploaded somewhere and I'm using agent-metadata-url | 20:47 |
| bogdanteleaga | it was a permissions issue though I fixed it now | 20:48 |
| cherylj | bogdanteleaga: ah, cool | 20:48 |
| bogdanteleaga | though, it still seems like it defaults to devel even though I tried specifying releases | 20:48 |
| cherylj | bogdanteleaga: iirc, wallyworld was doing some work around that, but I'm not sure where things landed. | 20:49 |
| bogdanteleaga | cherylj, I found this https://github.com/juju/juju/pull/2985 | 20:49 |
| bogdanteleaga | I'll try again soon, it may have tried to read devel anyway for no reason and fail like that | 20:50 |
| cherylj | anyone else having problems with reviewboard not creating review requests for PRs? | 22:03 |
| waigani | cherylj: I just put one up, worked for me | 22:30 |
| thumper | abentley: call? | 23:07 |
| abentley | waigani, thumper: Sure. I'm in https://plus.google.com/hangouts/_/canonical.com/jes-feature?authuser=1 | 23:08 |
| thumper | abentley: we are in the one defined in the calendar | 23:08 |
| thumper | jes-testing | 23:08 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!