[00:15] <anastasiamac> proposed http://reviews.vapour.ws/r/2469/
[01:10] <davechen1y> ping http://reviews.vapour.ws/r/2470/
[01:37] <sinzui> waigani: davechen1y: can you review http://reviews.vapour.ws/r/2471/ to prepare to the 1.25-alpha1 release? This is a merge of net-cli into master.
[01:40] <davechen1y> reviewed
[01:40] <davechen1y> can someone review http://reviews.vapour.ws/r/2470/
[01:40] <davechen1y> thanks
[01:40] <anastasiamac> davechen1y: looking
[01:40] <sinzui> thank you davechen1y
[01:48] <anastasiamac> davechen1y: done ;)
[02:05] <davechen1y> anastasiamac: thanks
[02:06] <anastasiamac> davechen1y: replied :)
[04:22] <mup> Bug #1421260 changed: juju 1.21.1 bootstrap timeout <bootstrap> <oil> <oil-bug-1372407> <juju-core:Expired> <https://launchpad.net/bugs/1421260>
[04:22] <mup> Bug #1468365 changed: internal compiler error: fault <ci> <intermittent-failure> <juju-core:Expired> <juju-core 1.24:Expired> <https://launchpad.net/bugs/1468365>
[06:56] <mup> Bug #1487727 changed: TestAddresserWorkerStopsWhenAddressDeallocationNotSupported fails on precise and windows <blocker> <ci> <intermittent-failure> <precise>
 <unit-tests> <windows> <juju-core:Fix Released> <juju-core net-cli:Fix Released by dimitern> <https://launchpad.net/bugs/1487727>
[08:39] <dimitern> who can review this http://reviews.vapour.ws/r/2475/ fix for bug 1455627, which is causing a lot of issues in CI ?
[08:39] <mup> Bug #1455627: TestAgentConnectionDelaysShutdownWithPing fails <ci> <intermittent-failure> <lxc> <test-failure> <unit-tests> <windows> <juju-core:In Progress by dimitern> <https://launchpad.net/bugs/1455627>
[08:40] <dimitern> TheMue, voidspace ^^ ?
[08:42] <voidspace> dimitern: can do, need to make a phone call first
[08:45] <dimitern> voidspace, sure
[08:55] <voidspace> dimitern: interesting technique
[08:56] <voidspace> dimitern: looks ok to me
[08:56] <TheMue> dimitern: doing it
[08:56] <dimitern> voidspace, thanks :)
[08:59] <voidspace> dimitern: so devices work is on master, not 1.24
[08:59] <voidspace> dimitern: so it needs adding to the release notes
[08:59] <voidspace> dimitern: I'll add something
[09:00] <dimitern> voidspace, awesome, ta!
[09:01] <dimitern> voidspace, TheMue, standup?
[09:01] <voidspace> dimitern: omw
[09:43] <voidspace> dimitern: I added release notes for devices, maybe too long
[09:45] <dimitern> voidspace, tyvm! it's ok - it's still a draft, so we'll polish it for the release
[10:39] <frobware> fwereade, I sent you a HO invite; feel free to move it to what works for you...
[10:40] <fwereade> frobware, thanks, that should be fine, see you shortly :)
[11:33] <mattyw> wallyworld, you in bed yet?
[11:33] <mattyw> fwereade, I'd love a review of http://reviews.vapour.ws/r/2459/ when you have a moment
[11:33] <mattyw> fwereade, I feel like I really need some advice about what I should be doing
[11:35] <wallyworld> mattyw: hey
[11:36] <mattyw> wallyworld, so my last pr actually broke loads of stuff, would you mind taking another look http://reviews.vapour.ws/r/2466/diff/#
[11:37] <mattyw> wallyworld, I do miss you, but I'm glad we weren't in the same room for the batting collapse
[11:37] <wallyworld> mattyw: yeah, i was sus about it, hence i added a card to audit what we have in that area even if the tests can pass. we still need to do that even once this lands
[11:38] <wallyworld> mattyw: hard to gloat when the ashes are lost
[11:38] <wallyworld> worst ashes series ever
[11:38] <wallyworld> no test went for 5 days, each was one sided
[11:39]  * rick_h_ is trying to figure out if you all are talking code or cricket :P
[11:40] <wallyworld> rick_h_: cricket :-D
[11:40] <wallyworld> should have used Test
[11:40] <wallyworld> and Ashes
[11:40] <rick_h_> lol
[11:41] <mattyw> wallyworld, reckon that branch should land?
[11:42] <mattyw> rick_h_, we'll come up with some sport banter in chicago if you like
[11:42] <wallyworld> mattyw: if the tests pass, sure. we can iterate. i added a card to make sure we go back and audit everything
[11:42] <mattyw> wallyworld, was the card on the uniter sprint board?
[11:42] <wallyworld> mattyw: yeah
[11:43] <wallyworld> mattyw: https://canonical.leankit.com/Boards/View/116558647/116837709
[11:43] <wallyworld> i put a few words in the description
[11:45] <mattyw> wallyworld, awesome, I'll take a look at that later I think
[11:45] <mattyw> wallyworld, you really should be in bed though right?
[11:46] <wallyworld> mattyw: yeah, meant to be on a swap day. but i have a meeting in an hour
[11:46] <wallyworld> timezones are wonderful
[12:50] <mattyw> wallyworld, fwereade ClearResolvedFlag() doesn't seem to be being called anywhere except in tests. And it doesn't exist on the operation.Callbacks interface anymore
[12:50] <mattyw> ^^ any thoughts?
[12:50] <mattyw> ashipika, ^^
[12:51] <wallyworld> mattyw: it's gone
[12:51] <wallyworld> not needed anymore
[12:51] <mattyw> wallyworld, ok - so we can remove any reference to it
[12:52] <mattyw> wallyworld, why is it not needed anymore?
[12:52] <wallyworld> mattyw: yes, but any tests will need to be checked to ensure some sort of equivalent behaviour doesn't need to be tested, but mostly i expect they could be deleted. needs ti be case by case
[12:53] <wallyworld> mattyw: eg the RemoteState snapshot may need to be udated
[12:53] <wallyworld> depends on the test etc
[12:54] <mattyw> wallyworld, ack
[13:03] <TheMue> dimitern: voidspace: frobware: maas hangout
[13:21] <mattyw> wallyworld, regarding what we just discussed http://reviews.vapour.ws/r/2476/
[13:22] <voidspace> TheMue: oh, dammit
[13:22] <voidspace> TheMue: is it still on?
[13:22] <TheMue> voidspace: yep
[13:23] <voidspace> ok, omw
[13:37] <wallyworld> mattyw: lgtm. but i still have a feeling we need to add different tests that test the new resolved model. theres several similar such things we need tests for too. so we'll need to check all that once we think we've gt everything passing
[13:38] <mattyw> wallyworld, ack - I'm still trying to get my head around this part of the code, shall I add a card for that?
[13:38] <wallyworld> mattyw: yeah, it will be a mega card - we can break it up later - but good to have as a reminder
[13:39] <wallyworld> mattyw: we can have a hangout to discuss this work maybe in a day or 2
[13:39] <wallyworld> once we get the stuff we know about passing
[13:40] <mattyw> wallyworld, I'll add something the calendar feel free to move it around as you see fit
[13:40] <wallyworld> mattyw: sgtm, i'm too tired to do much else right now
[13:40] <mattyw> wallyworld, ack np
[14:15] <rogpeppe> ultra-trivial review anyone? (one line dependency change. https://github.com/juju/juju/pull/3097
[14:15] <rogpeppe> or http://reviews.vapour.ws/r/2477/
[14:18] <dimitern> rogpeppe, ship it!
[14:18] <rogpeppe> dimitern: ta!
[14:33] <mup> Bug #1488523 opened: Azure provider attempts to reuse dying vnet <azure-provider> <bootstrap> <ci> <destroy-environment> <reliability> <repeatability> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1488523>
[14:39] <mup> Bug #1488523 changed: Azure provider attempts to reuse dying vnet <azure-provider> <bootstrap> <ci> <destroy-environment> <reliability> <repeatability> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1488523>
[14:42] <mup> Bug #1488523 opened: Azure provider attempts to reuse dying vnet <azure-provider> <bootstrap> <ci> <destroy-environment> <reliability> <repeatability> <juju-core:Triaged> <juju-core 1.24:Triaged> <https://launchpad.net/bugs/1488523>
[15:42] <mup> Bug #1488554 opened: wily + 1.24.5: Failed to execute operation: Unit name /etc/systemd/system/juju-clean-shutdown.service is not valid <amulet> <openstack> <uosci> <juju-core:Triaged> <https://launchpad.net/bugs/1488554>
[15:57] <mup> Bug #1488554 changed: wily + 1.24.5: Failed to execute operation: Unit name /etc/systemd/system/juju-clean-shutdown.service is not valid <amulet> <openstack> <uosci> <juju-core:Triaged> <https://launchpad.net/bugs/1488554>
[16:00] <mup> Bug #1488554 opened: wily + 1.24.5: Failed to execute operation: Unit name /etc/systemd/system/juju-clean-shutdown.service is not valid <amulet> <openstack> <uosci> <juju-core:Triaged> <https://launchpad.net/bugs/1488554>
[16:09] <mup> Bug #1488554 changed: wily + 1.24.5: Failed to execute operation: Unit name /etc/systemd/system/juju-clean-shutdown.service is not valid <amulet> <openstack> <uosci> <juju-core:Triaged> <https://launchpad.net/bugs/1488554>
[16:21] <mup> Bug #1488573 opened: Juju treats transient vnet failures as permanent <azure-provider> <bootstrap> <ci> <deploy> <intermittent-failure> <reliability> <repeatability> <juju-core:Triaged> <https://launchpad.net/bugs/1488573>
[16:51] <mup> Bug #1488576 opened: TestAddresserWorkerStopsWhenAddressDeallocationNotSupported fails on pp64el <ci> <intermittent-failure> <ppc64el> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1488576>
[16:51] <mup> Bug #1488581 opened: TestFindToolsExactInStorage fails for some archs <blocker> <ci> <i386> <ppc64el> <regression> <storage> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1488581>
[17:34] <perrito666> anybody knows the whereabouts of the OCR?
[17:35] <alexisb> natefinch-afk, ping ^^
[17:35] <alexisb> wwitzel3, ping (for something unrelated)
[17:37] <natefinch> 'allo... sorry, have been neglecting my duties
[17:37] <perrito666> aghh afk
[17:38] <perrito666> why people wont use the actual away feature on irc
[17:38] <natefinch> perrito666: irc has features?
[17:38] <perrito666> and why on earth my client does not realize that natefinch-afk is natefinch
[17:38] <perrito666> you are using it wrong </steve jobs>
[18:04] <natefinch> sinzui: what version of Go are we going to be building with for 1.26?
[18:05] <sinzui> natefinch: its not decided. We remain on 1.2 until we confirm 1.5 works every where and Ubuntu can put it every where
[18:05]  * natefinch prays for 1.5
[20:42] <natefinch> ericsnow: are there corresponding changes to juju-process-docker to support the changes in your patch for plugins to packages?
[20:42] <ericsnow> natefinch: yep
[20:42] <ericsnow> natefinch: http://reviews.vapour.ws/r/2426/
[21:47] <davecheney> cherylj: http://reviews.vapour.ws/r/2482/
[21:47] <davecheney> ship it
[21:48] <wallyworld> cherylj: you are awesome for fixing that bug - was going to be somthing i did today and i looked to see you'd already done it :-)
[21:56] <cherylj> thanks davecheney, wallyworld
[21:57] <cherylj> wallyworld: regarding your review comment, I think we do need it.  My reasoning behind it is in the bug https://bugs.launchpad.net/juju-core/+bug/1488581/comments/2
[21:57] <mup> Bug #1488581: TestFindToolsExactInStorage fails for some archs <blocker> <ci> <i386> <ppc64el> <regression> <storage> <unit-tests> <juju-core:In Progress by cherylj> <https://launchpad.net/bugs/1488581>
[21:58] <wallyworld> cherylj: fair enough. perhaps then use arch.AMD64 instead of "amd64" to be consistent with the other lines in the test?
[21:59] <cherylj> wallyworld: sure, I'll do that
[21:59] <wallyworld> ty
[23:14] <wallyworld> axw_: anastasiamac: perrito666: running late, will ping when ready, soon
[23:14] <perrito666> k
[23:14] <anastasiamac> wallyworld: k :D
[23:32] <wallyworld> axw_: anastasiamac: perrito666: there now
[23:58] <davecheney> cherylj: thanks for your fix
[23:59] <davecheney> don't worry about adding those extra patch values
[23:59] <davecheney> i'll take care of them with my change set
[23:59] <davecheney> the goal is to remove version.Current.Arch
[23:59] <davecheney> so they won't compile
[23:59] <davecheney> and i'll find them and fix them