| blr | wgrant: cjwatson: is there much to be gained by using request's collection pooling/sessions do you think? | 03:30 |
|---|---|---|
| wgrant | blr: Not for this. Several HTTP requests are alreadymade per dispatch. | 03:34 |
| wgrant | If this were an otherwise fast path then sure. | 03:34 |
| blr | wgrant: thanks, I didn't think so (we use it in the git hosting client) | 03:35 |
| wgrant | blr: Oh, you probably can't use requests here anyway | 03:36 |
| blr | wgrant: err why's that? | 03:36 |
| blr | from the build master? | 03:37 |
| wgrant | blr: buildd-manager is all asynchronous Twisted, so blocking requests are a bad idea. You could deferToThread, but the requests are simple enough that using native twisted.web is probably easier | 03:37 |
| blr | wgrant: ah, I appear to have wasted most of the day :) | 03:38 |
| blr | hmm | 03:38 |
| blr | well, the interface is probably fine | 03:39 |
| wgrant | Likely, will just need to be deferred-ified | 03:40 |
| blr | wgrant: will have a look at twisted.web.. sorry, I should have talked to you about this in more depth perhaps | 03:40 |
| wgrant | I should have remembered you hadn't properly encountered twisted in depth before | 03:41 |
| wgrant | twisted.web isn't too bad, compared to the classic python librariea | 03:41 |
| wgrant | s | 03:41 |
| blr | wgrant: so I gather I want an Agent? | 03:50 |
| blr | ah found, some client documentation that is more informative than the api docs. | 03:52 |
| wgrant | blr: twisted.web.client.downloadPage is used in a few places, and may be sufficient for your needs. | 04:13 |
| wgrant | I forget the details, but let me know if your digging is unsuccessful. | 04:13 |
| blr | wgrant: thanks | 04:14 |
| === anthonyf is now known as Guest39525 | ||
| cjwatson | wgrant: https://code.launchpad.net/~cjwatson/launchpad/answers-mail-permissions/+merge/269241 if you're still up, otherwise I'll self-review in a bit to fix the current qa-bad | 16:27 |
| cjwatson | OK, SRing | 16:38 |
| === lifeless1 is now known as lifeless | ||
| === blr_ is now known as blr | ||
| blr | wgrant: colin mentioned there was a method which took a build type argument, do you recall which that was - I only see snappy used explicitly in the builder browser code | 22:47 |
| cjwatson | blr: The build behaviour tells the slave which of its build managers to use: in this case, SnapBuildBehaviour.composeBuildRequest | 23:24 |
| cjwatson | blr: The build manager in question is called "snap", not "snappy", which is perhaps why your search failed | 23:25 |
| blr | ah thanks cjwatson | 23:25 |
| cjwatson | And you can follow through the build argument handling from there | 23:26 |
| cjwatson | There's a build behaviour for each build type | 23:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!