perrito666bbl dinner00:12
wallyworldaxw: i've updated the pr when you are back00:22
anastasiamacI am OCR next Tuesday but am on holidays - anyone keen to swap? :D00:46
axwwallyworld: shipit01:15
axwwallyworld: I think we should eventually tease out those model representations from api/uniter, and move them into the worker/uniter package itself, wrapping a flat API01:17
axwwallyworld: then we can think about auto-generating the API client code01:17
axwnot today obviously, just thinking about things we can do to improve quality in future01:18
wallyworldyeah, there's room for improvement in that area. we need to rethink a few of our initial design deceisions01:18
wallyworldnot that we are hitting these pain points01:18
axwwallyworld: well we are with testing. and writing API clients isn't *hard* but it's more work than necessary01:18
axwtime better spent elsewhere01:19
davecheneyaxw: I have a question about tools storage02:28
davecheneytools_test.go:331: c.Assert(url, gc.Equals, ""+version.Current.String())02:28
davecheney... obtained string = ""02:28
davecheney... expected string = ""02:28
davecheneyi've been tinkering with something and have a test failure02:28
davecheneybut I think the expected message is wrong02:28
davecheneywhy would the expected want tools withotu a series and an arch ?02:28
axwdavecheney: sec, finding the code to refresh memory02:28
axwdavecheney: yeah, it should be the binary string... version.Current is a verison.Binary in master, did you change its type?02:31
davecheneyi did02:32
axwdavecheney: show me your diff?02:32
davecheneyit's very large02:33
davecheneyso when you say binary string02:33
davecheneyit should be the output of version.Binary.String() ?02:33
axwdavecheney: yep02:33
thumpermenn0: got time to talk migrations?02:34
menn0thumper: yep02:34
davecheneyaxw: i see the problem02:35
davecheneyaxw: https://github.com/juju/juju/compare/master...davecheney:remove-version-arch?expand=102:35
davecheneyif you want to see the whole thing02:35
* thumper peeks02:35
davecheneyaxw: the error mesage above is back to front02:36
davecheneythe expected is being constructed incorrect ...02:36
davecheneythe expected is being constructed incorrectly ...02:36
axwdavecheney: I think you just want to s/version.Current/current/ on the last line of TestToolsURLGetter02:38
axwdavecheney: the URL returned *should* include arch/series02:38
axwit's a URL to download a specific tools archive02:39
davecheneyyeah, i understand what is going on now02:39
mupBug #1491226 opened: juju status hangs at 'connection established to' until jujud-machine-0 restarted <juju-core:New> <https://launchpad.net/bugs/1491226>04:30
thumperI'm just popping out again to take sad daughter with sadder laptop back down to repair person04:45
thumperdying hard disk05:19
thumperthere goes another $15005:19
davecheneythumper: version.Binary.OS is _always_ derrived from version.Current.Series ...05:47
davecheneywe don't need to put that on the struct05:47
davecheneywe can recover it with a function05:47
thumperright, I don't know who did, or why exactly05:47
thumperperhaps look for the commit that added it and look at the review?05:47
thumperI'm guessing it was added as a "helper"05:47
thumperwhere a plain function would have been better05:48
davecheneyhaving it on the value does have one advantage05:49
davecheneyit's always known to be valid05:49
davecheneyrecovering it from version.Current.Series when needed does mean you have to handle the error there05:49
davecheneythat doesn't look like too much of a problem05:50
davecheneyand that means version.Binary goes back to being just Number, Series and Arch05:50
davecheneyi think it's worth the cost05:50
davecheney_especially_ as most of the callers that use version.Binary.OS, are actually asking ... is this windows05:50
davecheneyis this centos05:50
davecheneythey don't want to switch on the versin05:50
davecheneyjust check if they shold enable something or not05:50
davecheneyI have not found one case where we overwrite vesion.Current.OS05:50
davecheneyI think i'll move the OS stuff out of version/ into juju/os05:51
davecheneylike we have juju/arch05:51
thumpersounds good to me05:57
thumperalso good to have explicit functions for checking OS05:58
thumperI'm getting called for dinner05:58
thumperchat tomorrow05:58
=== akhavr1 is now known as akhavr
mupBug #1491353 opened: workers ignore stop channel <juju-core:New> <https://launchpad.net/bugs/1491353>11:58
=== akhavr1 is now known as akhavr
mgzbogdanteleaga: I have some bugs for you13:18
mupBug #1491398 opened: RebootSuite test failures on windows <ci> <regression> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1491398>13:35
mupBug #1491399 opened: TestInstallMongodServiceExists fails on precise <ci> <precise> <regression> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1491399>13:35
niemeyer_natefinch, mgz: Can you please see if the IPv6 test is now working again?13:37
mgzniemeyer_: sure thing13:37
niemeyer_mgz: Thanks!13:38
wwitzel3ericsnow: what is the state of the workload plugins to libs?13:41
mgzniemeyer_: all good, <http://paste.ubuntu.com/12253283>13:41
wwitzel3ericsnow: want me to pick it up? my resolve storage variables is being blocked by it13:41
ericsnowwwitzel3: basically all done13:41
niemeyer_mgz: Sweet13:42
ericsnowwwitzel3: I split it up; first: http://reviews.vapour.ws/r/2541/13:42
niemeyer_mgz: Still need to do more for the full IPv6 address resolution story, but at least addresses are working properly again13:42
mupBug #1491398 changed: RebootSuite test failures on windows <ci> <regression> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1491398>13:47
mupBug #1491399 changed: TestInstallMongodServiceExists fails on precise <ci> <precise> <regression> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1491399>13:47
mupBug #1491398 opened: RebootSuite test failures on windows <ci> <regression> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1491398>13:50
mupBug #1491399 opened: TestInstallMongodServiceExists fails on precise <ci> <precise> <regression> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1491399>13:50
mupBug #1491451 opened: [Juju 2.x] Remove command aliases <juju-core:New> <https://launchpad.net/bugs/1491451>14:53
katcoericsnow: wwitzel3: natefinch: new card on the board for removing the cloudsigma feature flag. if one of you could pick that up in the next few days, that'd be great15:09
katcoericsnow: wwitzel3 natefinch why is "massachusetts names" at the top of the spec?15:18
natefinchmistype sorry15:21
bogdanteleagacan someone take a look at this? http://reviews.vapour.ws/r/2557/15:30
=== natefinch is now known as natefinch-afk
mupBug #1491547 opened: [upgrade-juju] Poor user experience <juju-core:New> <https://launchpad.net/bugs/1491547>19:03
mupBug #1491547 changed: [upgrade-juju] Poor user experience <juju-core:New> <https://launchpad.net/bugs/1491547>19:12
alexisbcherylj, ping19:15
* alexisb looks at the calendar and sees cherylj is on vacation19:16
mupBug #1491547 opened: [upgrade-juju] Poor user experience <docteam> <juju-core:New> <https://launchpad.net/bugs/1491547>19:18
=== natefinch-afk is now known as natefinch
lazyPowerGreetings core hackers o/ I've run into an interesting scenario that appears to be a dupe of this bug: https://bugs.launchpad.net/juju-core/+bug/1416928 - juju has picked the wrong interface to atttempt to communicate with the state server20:03
mupBug #1416928: juju agent using lxcbr0 address as apiaddress instead of juju-br0 breaks agents <api> <lxc> <network> <juju-core:Fix Released by dooferlad> <juju-core 1.21:Fix Released by dimitern> <juju-core 1.22:Fix Released by dooferlad> <https://launchpad.net/bugs/1416928>20:03
lazyPowerin this particular case its the docker0 bridge interface, and none of the LXC interfaces. Is there a suggested work around?20:03
natefinchlazyPower: I presume you're on a version of juju that has the fixes to that bug?20:04
mbruzeknatefinch: it is  a customer who is encountered this and they are at
lazyPowernatefinch: 1.25.1 to be exact.20:05
lazyPowersorry mbruzek is correct.
mbruzeknatefinch http://paste.ubuntu.com/12256492/20:07
mbruzeknatefinch: I can see Juju dialing "wss://
mbruzeknatefinch: then I see Juju trying to download
natefinchmbruzek, lazyPower:  yeah, looking at the fix, the bugfix was very specifically targetted at lxc, so it wouldn't filter out other bridge adapters, like docker's.20:17
lazyPowernatefinch: i can file a follow up bug if thats helpful20:18
lazyPowerwe have enough log output and i see what happened in the deployment well enough to outline whats happened.20:18
mbruzeknatefinch: is that the right bug 1416928 ?20:18
mupBug #1416928: juju agent using lxcbr0 address as apiaddress instead of juju-br0 breaks agents <api> <lxc> <network> <juju-core:Fix Released by dooferlad> <juju-core 1.21:Fix Released by dimitern> <juju-core 1.22:Fix Released by dooferlad> <https://launchpad.net/bugs/1416928>20:18
mbruzekCan I have them watch that one for a fix?  Or where?20:19
natefinchlazyPower: yes please.  I'm sure it's the exact same thing, just the fix explicitly just uses lxc-net to find the lxc bridge20:19
natefinchmbruzek: watch the new one lazyPower makes.  And lazyPower, please link to that lxc bug.  Hopefully we can find a more general solution that won't break whenever something else adds its own bridge20:20
mupBug #1491578 opened: [wily] When adding a machine, can't find the juju-local metapackage  <juju-core:New> <https://launchpad.net/bugs/1491578>20:30
natefinchkatco: I just reread https://bugs.launchpad.net/juju-core/+bug/1486553 and only now noticed the linked bug at the bottom of the description that is a private bug.... it seems like there's no actual juju-core bug to reproduce.  Yes, there's a network timeout when running deploy, but that's not a bug, that's the network being the network.20:30
mupBug #1486553: i/o timeout errors can cause non-atomic service deploys <cisco> <landscape> <juju-core:Triaged by natefinch> <https://launchpad.net/bugs/1486553>20:30
natefinchkatco: It seems like that big is "theoretically, something bad could happen" not "something bad has actually happened"20:31
katconatefinch: we have customer sites that this is affecting20:31
natefinchkatco: nothing in the bug says what problems they're having, other than a network timeout.... after which they look at the environment and the deploy succeeded.20:32
katconatefinch: let me find someone you can talk to20:32
natefinchkatco: that would be helpful :)20:32
katconatefinch: talk to landscape/beret (dean)20:34
natefinchBeret: I'm looking into https://bugs.launchpad.net/juju-core/+bug/1486553   hoping you can help me understand how core can help.20:35
mupBug #1486553: i/o timeout errors can cause non-atomic service deploys <cisco> <landscape> <juju-core:Triaged by natefinch> <https://launchpad.net/bugs/1486553>20:35
Beretnatefinch, bad stuff does indeed happen20:35
Beretand happens often20:35
Beretahasenack, around?20:36
Beretnatefinch, did you see Dimiter's comment?20:36
natefinchBeret: yes, but I'm not sure if that's the specific problem the customers are seeing.20:38
dpb1_natefinch: wdyn20:40
natefinchdpb1_: the bug https://bugs.launchpad.net/juju-core/+bug/1486553 doesn't tell me what specific problem the customer is seeing, other than a network timeout, which is sorta out of my jurisdiction.20:41
mupBug #1486553: i/o timeout errors can cause non-atomic service deploys <cisco> <landscape> <juju-core:Triaged by natefinch> <https://launchpad.net/bugs/1486553>20:41
ahasenacknatefinch: we had two occurances related to that timeout20:41
ahasenacknatefinch: a) juju deploy returned a timeout, we retried it, it then said the service already exists20:42
mupBug #1491578 changed: [wily] juju add-machine, can't find the juju-local metapackage <juju-core:New> <https://launchpad.net/bugs/1491578>20:42
ahasenacknatefinch: b) juju deploy returned a timeout, service was deployed but without the configuration we asked  (just its defaults)20:42
ahasenacknatefinch: I'm a bit less clued in the (b) case, I know what was reported in the bug in that case20:42
ahasenacknatefinch: but about (a), we see that rather often, as in a few times per week20:42
ahasenacknatefinch: we found out the (b) case when we started handling the "service already exists" error for when we retry. We assumed it was all good, but later found out the service config options were not what we set20:43
natefinchahasenack: b) is much more concerning to me.  a) seems like the price we pay for an unreliable network... though perhaps there's some bug causing the timeout.  b) is definitely just a bug that should be fixed (though I'm sure it'll be tricky).20:46
ahasenacknatefinch: it's tricky to workaround as well, we would have to remove the service and deploy again to be sure20:47
ahasenacknatefinch: it's when we hit (b) that the bug got escalated, since we have a workaround in place for (a)20:47
ahasenack"if it says service is already deployed, good, let's just move on"20:47
ahasenacknatefinch: iirc the timeout was to localhost,20:47
ahasenacknatefinch: not between us (client) and state server20:48
ahasenacknatefinch: gotta run now20:48
mupBug #1491578 opened: [wily] When adding a machine, can't find the juju-local metapackage  <juju-core:New> <https://launchpad.net/bugs/1491578>20:48
natefincha timeout to localhost is pretty bogus, for sure20:49
ahasenackAug 7 20:45:06 job-handler-1 INFO Traceback (failure with no frames): <class 'canonical.juju.errors.RequestError'>: cannot add service "mongodb": read tcp i/o timeout20:56
ahasenackthat's what I meant with timeout to localhost20:56
ahasenackjob-handler is our juju client in this scenario20:57
ahasenacknatefinch: so if true, it's not a networking issue, more like a local high load perhaps, short timeout, all threads occupied, etc, scenario20:57
natefinchahasenack: yeah,  I was going to say... what's the timeout?20:58
natefinchlike length of time20:58
ahasenackours? don't know, would have to check20:59
natefinchdeploy *should* be quick, but it depends on if you're doing a deploy of a local charm, etc...20:59
ahasenackbut that is to localhost, so it's on your end20:59
ahasenackthat message, "read tcp i/o timeout", comes back from juju, no?21:00
ahasenackour connection is still up and fine21:00
natefinchahasenack: ahh ok, sorry, was getting confused by the extra stuff on the beginning of the error.   Yes, the 'cannot add service "foo" ' is our message.21:02
natefinchahasenack: any more info you can put in that bug would help... like, the type of environments you've seen this in, etc.  You shouldn't be connecting to localhost unless you're running local provider or running the client on the state machine21:03
ahasenacknatefinch: for what is worth, we deploy a lot of containers, so disk i/o is intense21:03
ahasenacknatefinch: we do not connect to localhost21:03
natefinchahasenack: sorry, I mean that juju should not be connecting to localhost21:03
ahasenacklandscape ---------> |17070:state server -> mongo:37017|21:03
ahasenackis that a fair diagram?21:04
natefinchahasenack: oh, yes, duh, ok21:04
natefinchahasenack: I gotta run, it's dinner time here.... I'll work on this some more tonight, see if I can reproduce, or induce a reproduction.21:04
ahasenacknatefinch: cheers, thx21:04
mupBug #1491592 opened: local provider uses the wrong interface <customer-support> <local-provider> <networking> <juju-core:New> <https://launchpad.net/bugs/1491592>21:18
mbruzekHello juju-devs this bug that mup just referenced is from a customer.21:19
mbruzekI see that natefinch has already left https://bugs.launchpad.net/juju-core/+bug/149159221:19
mupBug #1491592: local provider uses the wrong interface <customer-support> <local-provider> <networking> <juju-core:New> <https://launchpad.net/bugs/1491592>21:19
mbruzekIt is a networking related problem with the local kvm provider21:20
rogpeppewallyworld: i think you might have been involved in some of this code. perhaps you might want to review this fix? https://github.com/juju/utils/pull/14821:58
wallyworldrogpeppe: sure thing, just have to finish a meting first21:59
rogpeppewallyworld: thanks!22:00
mupBug #1491608 opened: importing juju/utils should not side-effect http.DefaultTransport <juju-core:New> <https://launchpad.net/bugs/1491608>22:18
alexisbaxw, I will be a few minutes late23:01
axwalexisb: np, ping when you're there please23:01
alexisbaxw, I am on the hangout when you are ready23:15

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!