| cjwatson | wgrant: https://code.launchpad.net/~cjwatson/launchpad/team-mail/+merge/269382 could use another look; as well as the obvious changes to fix your review comments, I converted it to use async jobs to make sure that there are no security proxy problems with this branch. (Might be easiest to look at just r17707.) | 02:48 |
|---|---|---|
| cjwatson | And now to bed. | 02:49 |
| wgrant | cjwatson: Thanks, those X-L-N-Ts make a tonne more sense now. | 02:49 |
| wgrant | Night. | 02:49 |
| cjwatson | PersonTransferJob is kind of a weird home for this, but it already had membership status change notifications ... | 02:50 |
| wgrant | Yep | 02:50 |
| === danilos` is now known as danilos | ||
| cjwatson | wgrant: Was there a particular reason you preferred ArchiveJob over DistributionJob for package upload mail? AFAIK neither is really very relevant - the values saved for the job would be PackageUpload.id, PackageUploadStatus, and summary_text | 11:33 |
| cjwatson | So it's maybe more modern-feeling but I'm not seeing how it would actually matter, either would be just for expediency | 11:33 |
| cjwatson | I guess it sort of categorises them, and it's as good as anything. | 13:51 |
| wgrant | cjwatson: I simply have a great distaste for anything Soyuz-related talking about distributions when the thing is in fact about an archive. | 23:09 |
| wgrant | See silly things like Distribution.getPublishedSources | 23:09 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!