[00:14] whats up [03:03] mwhudson, hey [03:03] well then === work_alkisg is now known as alkisg === alkisg is now known as work_alkisg === darkxst_ is now known as darkxst === Tm_Tr is now known as Guest83949 === brainwash_ is now known as brainwash [13:50] Hi, can someone please review https://code.launchpad.net/~fred-wang/ubuntu/wily/firefox/fix-for-1473552/+merge/268213 ? [15:45] i'm building a library with a handmade makefile, and i'm struggling to find the proper rules to build debian library and header packages for it. Essentially i'm installing the files in $(DESTDIR)/usr/lib/ in my Makefile (which I suspect is wrong) and dh_install is not finding them in debian/tmp/usr/lib (since they apparently go to debian/pkg-name1/usr/lib) and fails [15:45] Anyone got an example of a library package without autotools, by any chance? [15:46] sidi: can you pastebin your debian/rules? [15:46] and the Makefile as well, ideally [15:53] cjwatson, sure, one sec [15:54] Makefile: http://pastebin.com/6MhFyQKG // debian/rules: http://pastebin.com/NRNu3Qqn (pretty much as was generated) [15:57] Straight outta bed [16:00] sidi: that looks OK (except for the MAKEVARS setting which doesn't seem to do anything and if it did ought to be in a different place). how about the debian/*install files? === BirthdayHandler is now known as nhandler [16:02] my preloadlogger1.install is usr/lib/lib*.so.* (which I've taken from other library-like packages) [16:02] the -dev is usr/lib/lib*.so, plus etc/security/* [16:03] sidi: should be fine, how about debian/compat? [16:04] cjwatson, 9? [16:04] sidi: that should be OK. at this point I think it'd be helpful if you could put a full example source package somewhere so I can test it [16:04] cjwatson, bzr+ssh://bazaar.launchpad.net/+branch/activityfinder/preload-logger/ [16:05] building the whole thing is really fast, it's a tiny library [16:05] ... most of the commits being me attempting silly things to build the package [16:07] this isn't the problem, but your Makefile would work better (i.e. install wouldn't have to repeat the build) if you had better dependencies - perhaps as a starting point, use "libPreloadLogger.so.0.9" as a target name rather than "lib", so that make knows it's already built [16:08] this is the sort of thing not using a handmade Makefile does better at :-) [16:09] oh I see [16:09] sidi: you don't have preload-logger-dev defined in debian/control [16:09] so debhelper is using its there's-only-one-package logic which is inappropriate here [16:10] ah. [16:10] (also, should be libpreload-logger1 and libpreload-logger-dev, really) [16:12] well, the file i build is indeed a library but it's not really intended to be linked against for building other apps [16:12] it's a LD_PRELOAD module loaded with PAM for process monitoring [16:13] though I can change it [16:13] I understand that but it doesn't change the library binary package naming rules [16:14] i'll change it [16:20] i think it's working better... [16:20] still had a mistake in the libpreload-logger-dev.install [16:22] cjwatson, once again, thank you! [16:22] I suspect you're gonna end up in my thesis's acknowledgements section :-) [16:26] heh [16:26] no problem [17:14] Does anyone know who is in charge of reviewing patches for the Firefox package? [17:14] chrisccoulson is listed in the latest git revisions but these date back from 2012... [18:04] fredw1: It would be chrisccoulson, yes, and if you're only seeing patches from 2012 then that must be because you're looking at an inactive branch. [18:04] https://code.launchpad.net/~mozillateam/firefox/firefox.wily [18:05] cjwatson: thank you. I was looking at https://code.launchpad.net/~ubuntu-branches/ubuntu/wily/firefox/wily