/srv/irclogs.ubuntu.com/2015/09/08/#juju-dev.txt

waiganiwallyworld: fix: http://reviews.vapour.ws/r/2603/00:41
wallyworldty, looking00:41
wallyworldwaigani: we need a test also00:42
waiganiwallyworld: okay, I'll add that now00:42
wallyworldin general, any bug fix should be accompanied by a test00:42
wallyworldty00:42
waiganiwallyworld: test added00:56
wallyworldlooking00:56
axwwallyworld: so just so I understand the status history change: previously we didn't store the latest status in history, and now we do? and because of that, returning history would duplicate the latest?00:59
wallyworldwaigani: lgtm but are there any call sites to update (see comment in review)00:59
waiganilooking01:00
wallyworldaxw: yes - william did a whole lot of refactoring there and changed how status history was recorded, but the retrieval method wasn't unit tested nor updated to match01:00
axwwallyworld: ok01:01
wallyworldaxw: tested live, works nicely01:01
wallyworldwaigani: actually, how do we handle the "never logged in" case now in a new 1.26 install?01:02
waiganiwallyworld: so user.LastLogin() will return a time.Time{} but the API server will still return a nil. See checkCreds func in apiserver/admin.go for example.01:12
waiganiwallyworld: there is also a feature test to ensure we display the correct "never connected" message, e.g. TestSystemEnvironmentsCommand01:12
axwwallyworld: reviewed01:14
wallyworldwaigani: without being overly familar with the code, would it be better to return a NeverLoggedInError ? ie is there a record that we just should not write out during the upgrade if last login is nil01:15
wallyworldaxw: thanks, looking01:16
wallyworldaxw: with HistoricalUnit, I think I ran into the same issues as in the uniter work recently - too much existing code being called back into. i'll double check though if i can rework it01:20
axwwallyworld: thanks01:20
waiganiwallyworld: you're talking about the upgrade step? If user has never logged in, skip creating a lastLoginDoc? Actually, yes that makes more sense.  As user.LastLogin() returns neverConnectedErr for a missing lastLoginDoc.01:21
wallyworldwaigani: exactly01:21
waiganiwallyworld: I'll redo fix01:21
wallyworldta01:21
wallyworldi was a bit hastely with my shipit :-)01:22
davechen1yhttps://github.com/juju/juju/pull/322601:42
davechen1yhere is an easy one01:42
waiganiwallyworld: third time lucky: http://reviews.vapour.ws/r/2603/01:46
wallyworldlooking01:46
davechen1ywaigani: your branch failed to merge02:48
waiganidavechen1y: I saw. I can't see how the panics are related to my changes. I'm halfway through running all unit tests locally.02:49
davechen1yusual background test failures i'd say03:08
waiganidavechen1y, wallyworld: fix merged. updating bug...03:34
wallyworldawesome, ty03:34
wallyworldjam: i got a surprise - i looked at juju/charm.v5 and see that there's already a Series metadata attribute which contains a single series. But I can see any charms which use it (I didn't look hard). So I think we could attempt to parse both a scalar and a list maybe and if a scalar, emit a deprecation warning and make it a single value list. What do you think?03:58
jamwallyworld: it should be "serieses", clearly :)03:58
wallyworldbarf03:59
davechen1yseries is an irregular noun04:00
davechen1ylike sheep04:00
jamyes, I realize that the plural of series is series, it is just fun to be silly.04:00
jamhence the smiley04:00
wallyworldindeed04:00
jamwallyworld: Sounds fine to me to go with a single-or-list sort of parsing, though it probably complicates our internal structure.04:01
wallyworldi'll mark the parsing tolerant04:01
wallyworldi'll also asl eco who uses it04:01
jamwallyworld: I wonder if we actually have it there because we use that spot internally to store what we cached the charm for04:02
jamas in, it isn't for the data in charm's metadata file, but instead for what we store in the DB04:02
jamLooking at: https://github.com/juju/charm/blob/v5/meta.go that only has "bson" notation, which means its for the DB, right?04:02
wallyworldi couldn't see any obvious usages in juju code, but will look harder04:02
wallyworldyeah, that could be right actually04:03
wallyworldmakes sense04:03
wallyworldbut that sure now complicates it04:03
wallyworldmight have to go with "os-series"04:03
wallyworldthat's what mark changed it to in the spec originally04:04
wallyworldjam: also, i need to get the resources spec moving again. are you able to schedule some time to have another look before it goes to mark?04:05
jamwallyworld: so IIRC it seemed good enough before I left, but if you want me to look at it again, I can.04:05
wallyworldjam: i added stuff to the vcs and web source bits, mainly around authentication etc04:06
wallyworldi think those are well enough defined for a mvp04:06
wallyworldsince i added material after you last looked, a once over would be great04:06
wallyworldjam: i looked harder at meta.go, and there is a yaml serialisation tag for Series. so seems like it can be defined in metadata.yaml04:16
* fwereade has just discovered it's a public holiday today06:35
* fwereade has *also* been being a terrible person and failing to look at reviews he should06:51
fwereadeaxw, don't suppose you're free to take a very quick look at the uniter interactions in http://reviews.vapour.ws/r/2593/ ?06:52
axwfwereade: sorry was out. I'll take a look08:11
axwfwereade: seems fine, apart from growing complexity.08:26
fwereadeaxw, I was mainly thinking about "how does it interact with the maltese-falcon changes"08:27
axwfwereade: I see. still looks fine.08:59
rogpeppefwereade: aargh, i just made a bunch of replies to http://reviews.vapour.ws/r/2597 and reviewboard seems to have lost them all. doesn't it save replies as drafts?09:03
fwereaderogpeppe, I thought it did09:03
rogpeppefwereade: ah, false alarm. for some reason they just weren't showing for me.09:04
jamwallyworld: hey, I'm not feeling great. Since rick can't be at the meeting anyway, can we just do it tomorrow, more around 6UTC ?11:59
wallyworldjam: sure, works for me12:00
wallyworldhope you're feeling btter12:00
jamthanks. I started some antibiotics today, so I expect to be doing better12:00
wallyworldwe can move on resources also12:01
rogpeppewallyworld, anyone else: http://reviews.vapour.ws/r/2606/ move to using charm.v6-unstable12:03
wallyworldrogpeppe: looking12:03
rogpeppewallyworld: thanks12:03
wallyworldrogpeppe: says there are conflicts, were you aware?12:04
rogpeppewallyworld: i resolved them12:04
rogpeppewallyworld: perhaps i should take the conflict messages out of the PR description12:05
wallyworldtis ok, i now know, but yeah12:05
rogpeppewallyworld: done (well, I edited the PR description in github - i'm hoping that's sufficient)12:06
wallyworldnp :-)12:06
wallyworldrogpeppe: just started looking - are all those dependencies.tsv changes deliberate?12:09
rogpeppewallyworld: yes12:09
rogpeppewallyworld: i tried to make them as minimal as possible12:09
wallyworldnp, ty12:09
rogpeppewallyworld: new deps are on the latest version12:09
wallyworldrogpeppe: and the new deps has charm.v5-unstable?12:10
rogpeppewallyworld: ues12:10
rogpeppeyes12:10
wallyworldnot v6?12:10
rogpeppeah, no12:10
rogpeppeit *should* have v6-unstable12:10
rogpeppelet me check12:10
rogpeppewallyworld: looks right to me12:11
rogpeppewallyworld: uses charm.v6-unstable12:12
wallyworldrogpeppe: gopkg.in/juju/charmstore.v5-unstablegita921c6c69d74361c38a99a95d2aceec76533038d2015-08-27T20:19:40Z12:13
wallyworldi copied that from the review board diff12:13
rogpeppewallyworld: that's charmstore, not charm12:13
wallyworldoh ffs12:13
wallyworldsorry, is late here12:14
rogpeppewallyworld: np12:14
wallyworldsigh12:14
rogpeppewallyworld: i've made that mistake several times before :)12:14
wallyworldrogpeppe: wow. so much churn. i miss python where you could update *one* file to change a dep. that's what i was refering to before in the email :-)12:20
wallyworldit's a hell of a lot to look over for a dep change. imo churn should be avoided :-)12:20
rogpeppewallyworld: yeah, i have to say i think there should be a better way. haven't found one yet though.12:21
perrito666wallyworld: all is fun and games until you return an object from the wrong version of a lib :p12:21
wallyworlduse python :-D12:21
wallyworldalso maks me wonder if we've done the right thing threading charm store dependency through so many of our files12:23
rogpeppewallyworld: charm store dependency != charm dependency12:23
wallyworlds/charmstore/charm12:23
wallyworldsorry, mistyped12:23
rogpeppewallyworld: it's not that surprising - charms are at the heart of what juju does12:24
wallyworldtrue, was musing out loud maybe it could be encapsulated in some helpers12:25
wallyworldbut probably a crap iea12:25
wallyworldjust annoyed by the churn and trying to think of how to isolate it :-)12:25
rogpeppewallyworld: it would be nice if there was a way to view diffs without showing changes that were just import path changes12:26
wallyworldyeah, that would be nice12:27
rogpeppewallyworld: at least with the change from v6-unstable to v6, the change will be *entirely* automatic - you won't even need to look through the diff12:29
wallyworldtrue12:30
wallyworldrogpeppe: +1 but i dislike the error message changes :-)12:33
rogpeppewallyworld: thing is that now those URLs can refer to both charms and bundles12:34
rogpeppewallyworld: so "charm URL" is technically wrong12:34
wallyworldso "charm or bundle" then ?12:34
wallyworldentity has no meaning for an end user12:34
rogpeppewallyworld: yeah. i'm not keen on "entity" either12:36
rogpeppewallyworld: but "charm or bundle" seems clumsy12:36
wallyworldcan it be changed?12:36
wallyworldaccurate and clear12:36
wallyworldthough12:36
wallyworldor even "charm/bundle not found" works12:36
wallyworldmaybe not with the / as that could be confusing12:37
wallyworldbut still "entity" kinda sucks12:37
rogpeppewallyworld: i'd prefer to change it in another PR if that's OK12:37
wallyworldsure, that's why i didn;t mark it a blocker, just a whine :-)12:38
rogpeppewallyworld: :)12:38
wallyworldright, i better get sleep before i confuse charm and charmstore again12:38
rogpeppehmm, if this bug https://bugs.launchpad.net/juju-core/+bug/1493016 is marked as fix-committed, why is master still blocked? http://juju.fail/12:41
mupBug #1493016: Panic on upgrade from 1.22 <blocker> <ci> <regression> <upgrade-juju> <juju-core:Fix Committed by waigani> <https://launchpad.net/bugs/1493016>12:41
frobwaredimitern, you joining the MAAS HO?13:04
dimiternfrobware, yeah, omw13:12
frobwaredimitern, too late. Call just dropped. :)13:12
dimiternfrobware, oh :/ too bad13:12
frobwaredimitern, 10 minutes and you're out!13:12
frobware:)13:12
dimiternfrobware, I was fighting until a few minutes ago to fix my config here13:12
frobwaredimitern, want to HO around the SubnetsAvailabilityZoneNames card?13:13
dimiternfrobware, I managed to break bash, unity, emacs and dbus with just a few edits in the wrong places :)13:13
dimiternfrobware, all fixed now though ..13:13
frobwaredimitern, well the Emacs is obviously bad; the rest? meh... :)13:13
=== coreycb` is now known as coreycb
dimiternfrobware, sure, but as I need to go to the store now, how about to do it in ~30m?13:14
frobwaredimitern, yep np13:14
dimiternfrobware, hey, I'm back13:47
frobwaredimitern, want to use the standup HO?13:48
dimiternfrobware, joining our 1:1 HO13:48
dimiternfrobware, :)13:48
voidspacedimitern: ping14:01
* perrito666 returns from the mecanic and figures he chose the wrong career14:13
natefinchperrito666: lol that is what I think every time I have to pay someone to do something for me.14:31
perrito666natefinch: well, he had to rebuild the whole engine cooling system, Its not like I can complain14:32
mgzperrito666: well I'm glad the mechanic could fix you14:42
mgzwould be a shame to have to sell you for scrap14:42
voidspacefrobware: ping14:45
perrito666mgz: lol14:48
frobwarevoidspace, pong; in a HO with dimitern15:15
voidspacefrobware: ok15:27
mupBug #1493016 changed: Panic on upgrade from 1.22 <blocker> <ci> <regression> <upgrade-juju> <juju-core:Fix Released by waigani> <https://launchpad.net/bugs/1493016>15:30
mupBug #1493444 opened: juju upgrade from 1.24-beta2 to 1.24.5 broken <juju-core:New> <https://launchpad.net/bugs/1493444>16:22
mupBug #1493444 changed: juju upgrade from 1.24-beta2 to 1.24.5 broken <juju-core:New> <https://launchpad.net/bugs/1493444>16:25
mrammCould someone respond to this bug: https://bugs.launchpad.net/juju-core/+bug/149086516:27
mupBug #1490865: destroy-environment on an unbootstrapped MAAS environment can release all my nodes <cloud-installer> <oil> <juju-core:New> <MAAS:Triaged> <https://launchpad.net/bugs/1490865>16:27
mupBug #1493444 opened: juju upgrade from 1.24-beta2 to 1.24.5 broken <juju-core:New> <https://launchpad.net/bugs/1493444>16:31
marcoceppiwho did the status-history stuff?16:31
mgzwhat's the new way of connecting directly to mongodb on the state server?16:31
mgzmarcoceppi: perrito666 mostly16:31
marcoceppiperrito666: you around? I'm trying to figure out the API endpoint for status-history16:32
mrammFor bug #1490865 I am interested in people's opinion16:33
mupBug #1490865: destroy-environment on an unbootstrapped MAAS environment can release all my nodes <cloud-installer> <oil> <juju-core:New> <MAAS:Triaged> <https://launchpad.net/bugs/1490865>16:33
marcoceppiIs there a list of the API endpoints? or doc on that?16:35
mrammthat bug reportedly has juju destroying nodes it didn't create16:36
mrammand it is reproducable16:36
mrammBUT it does require passing --force --yes  to destroy environment on an non-existent environment.16:36
marcoceppimramm: having been bitten by this, it's a huge problem16:39
mrammwere you bit by this recently?16:39
marcoceppiI had a similar issue 10 months ago on MAAS16:40
marcoceppiissue/experience16:40
mrammthat was a separate issue IIRC16:40
mrammwe added behavior to juju to not kill things it doesn't know about in MAAS16:40
mrammeven if they are by the same user16:40
marcoceppiack16:40
mrammBUT in this case, we can't know about anything as there is no juju server to talk to16:41
mrammI expect that calling "destroy-environment --force --yes maas" on a non-existent environment to be dangerous16:42
mgzmramm: this would not be an issue were it not for the fact ever tearing down juju properly requires --force --really --super-hard16:42
mgzdestroy-environment without flags just leaves stuff half-torn down too much of the time to do anything else...16:43
mrammto fix this we would need to know how to reliably differentiate juju deployed maas instances from those that are not juju deployed.16:44
mrammthe current implication does this -- but requires an active juju state server to talk to (since it knows)16:45
mrammpossibly we could just include maas-agent-name in the config even before we bootstrap16:45
mrammwhich isn't 100% reliable (unless we use a GUID for the name)16:46
mupBug #1493458 opened: backups restore: fails when machine number differs <juju-core:New> <https://launchpad.net/bugs/1493458>17:10
mupBug #1489087 changed: certificate verify failed <juju-quickstart:New> <https://launchpad.net/bugs/1489087>17:28
mupBug #1490552 changed: local hostname not in /etc/hosts <juju-core:New> <https://launchpad.net/bugs/1490552>17:28
perrito666marcoceppi: back, UnitStatusHistory17:28
marcoceppithanks perrito66617:28
perrito666marcoceppi: sorry for the delay17:35
=== bdx_ is now known as bdx
ericsnowperrito666: could you take a look at http://reviews.vapour.ws/r/2610/?18:47
ericsnowperrito666: it relates to one of your recent merges18:47
perrito666ericsnow: did I remove the tests? :|18:48
perrito666no, that seems like my patch :p did you?18:48
ericsnowperrito666: I accidentally disabled them in June18:49
perrito666ericsnow: june? some of the things you are adding are from status-available which is fairly recent18:49
ericsnowperrito666: your recent patch would not have passed the tests on 1.25 otherwise18:49
perrito666oh18:49
perrito666ok18:49
perrito666ericsnow: can it wait about 1h need to run an errand (bad day for my concentration)18:50
ericsnowperrito666: right, when you merged from 1.25 you had conflicts and appear to have removed the changes rather than fixing them <wink>18:50
ericsnows/from 1.25/to 1.25/18:50
perrito666ericsnow: In the meantime, is the removal of the huge block from dimitern to begin with?18:50
perrito666ericsnow: mm damn, ill have to review master too then, thanks for that18:50
perrito666anyway gtg, bbl18:51
ericsnowperrito666: don't worry, I'll fix master too18:51
natefinchyou know what bugs the hell out of me?19:07
natefinchfunc (c *Settings) <something>19:07
natefinchc? Really?19:07
perrito666Ce-tings works in Spanish :p19:15
perrito666Ericsnow19:15
ericsnowperrito666: yep19:16
perrito666So the only thing troubling me is the big chunk from network being removed19:16
ericsnowperrito666: what is removed?19:16
ericsnowperrito666: keep in mind that apiserver/params/status.go has everything19:16
perrito666Ok re reviewed the patch19:20
perrito666Ericsnow so this patch looks as if re applying the agentversion work for tests can you expand on what happened?19:21
perrito666And the removed chunk is http://reviews.vapour.ws/r/2610/diff/#419:22
ericsnowperrito666: your forward-port from 1.24 was missing several changes due to merge conflicts so I added them back in19:22
perrito666Ahhh duh I see it now, sad19:23
perrito666And re http://reviews.vapour.ws/r/2610/diff/#419:24
xwwt__jog: I will likely miss the meeting today.  Are you cool with running that?19:26
jogsure19:26
jogI'm planning to use this sheet as a discussion point: https://docs.google.com/spreadsheets/d/1CWq1CAIYjJLetnageShXVU0-0etxAE2O0KtRgc3-D_8/edit#gid=019:27
xwwt__kk19:27
jogExample of the various issues we see with the charm tests19:27
jogThe point I want to make is that there are many charm related failures that need investigation. Most of these look like charm issues (not infrastructure)19:28
natefinchyou know your tests aren't isolated enough when you change the signature of a method and find 1 place in production code that calls it, and 30 in test helpers.19:32
* TheMue is grumpy about his current network status. from fri to sat total breakdown and today every few minutes *hmpf*19:36
natefinchman, I hate that juju deploy can't just take config options on the command line, and that if you pass a file to --config, you have to put the charm name in the file, like mysql:  option:value20:16
perrito666ericsnow: ?20:19
ericsnowperrito666: yeah20:19
perrito666ericsnow: sorry I was chatting on a phone, now back to the computer: "And the removed chunk is http://reviews.vapour.ws/r/2610/diff/#4"20:19
ericsnowperrito666: all that code is superflous; it was moved over to apiserver/params/status.go in June20:20
ericsnowperrito666: looks like you accidentally pulled it back in during a merge20:21
perrito666ericsnow: then lgtm20:21
ericsnowperrito666: k20:21
ericsnownatefinch, katco: could I get a quick review of http://reviews.vapour.ws/r/2610/?20:27
katcoericsnow: will review before EOD, trying to get tests passing before release standup20:28
ericsnowkatco: k20:28
mupBug #1491132 changed: TestNetworkInterfaces fails <juju-core:New> <https://launchpad.net/bugs/1491132>20:28
mupBug #1491547 changed: [upgrade-juju] Poor user experience <docteam> <upgrade-juju> <juju-core:New> <https://launchpad.net/bugs/1491547>20:40
natefinchstate's export_test is 443 lines long20:42
mupBug #1491547 opened: [upgrade-juju] Poor user experience <docteam> <upgrade-juju> <juju-core:New> <https://launchpad.net/bugs/1491547>20:43
=== natefinch is now known as natefinch-afk
mupBug #1491547 changed: [upgrade-juju] Poor user experience <docteam> <upgrade-juju> <juju-core:New> <https://launchpad.net/bugs/1491547>20:59
perrito666mm, that last one seems to be duplicated20:59
mupBug #1178312 changed: ERROR state: TLS handshake failed: x509: certificate signed by unknown authority <config> <cts-cloud-review> <sts> <ui> <juju-core:Fix Released> <https://launchpad.net/bugs/1178312>21:02
mupBug #1325040 changed: juju upgrade-juju is utterly confusing <canonical-is> <ui> <upgrade-juju> <usability> <juju-core:Triaged> <https://launchpad.net/bugs/1325040>21:02
mupBug #1492241 changed: juju upgrade-juju cli doesn't provide clear feedback on action being taken <canonical-bootstack> <ui> <upgrade-juju> <juju-core:New> <https://launchpad.net/bugs/1492241>21:02
mupBug #1178312 opened: ERROR state: TLS handshake failed: x509: certificate signed by unknown authority <config> <cts-cloud-review> <sts> <ui> <juju-core:Fix Released> <https://launchpad.net/bugs/1178312>21:05
mupBug #1325040 opened: juju upgrade-juju is utterly confusing <canonical-is> <ui> <upgrade-juju> <usability> <juju-core:Triaged> <https://launchpad.net/bugs/1325040>21:05
mupBug #1492241 opened: juju upgrade-juju cli doesn't provide clear feedback on action being taken <canonical-bootstack> <ui> <upgrade-juju> <juju-core:New> <https://launchpad.net/bugs/1492241>21:05
mupBug #1178312 changed: ERROR state: TLS handshake failed: x509: certificate signed by unknown authority <config> <cts-cloud-review> <sts> <ui> <juju-core:Fix Released> <https://launchpad.net/bugs/1178312>21:08
mupBug #1325040 changed: juju upgrade-juju is utterly confusing <canonical-is> <ui> <upgrade-juju> <usability> <juju-core:Triaged> <https://launchpad.net/bugs/1325040>21:08
mupBug #1492241 changed: juju upgrade-juju cli doesn't provide clear feedback on action being taken <canonical-bootstack> <ui> <upgrade-juju> <juju-core:New> <https://launchpad.net/bugs/1492241>21:08
xwwt__sinzui: are you able to join standup?21:32
thumperwallyworld: holy shit...22:07
thumperwallyworld: that uniter branch is quite far reaching22:07
wallyworldit is22:07
wallyworlddoc being worked on now22:08
perrito666do all worker facades need to be nouns?22:20
* perrito666 thinks we are being a bit exagerated with that22:20
thumper wallyworld got time for a quick chat?22:50
wallyworldsure22:51
wallyworldthumper: in 1:122:54

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!