/srv/irclogs.ubuntu.com/2015/09/25/#ubuntu-desktop.txt

sethjandyrock, I was able to reproduce the lock screen/keyboard layout bug. It's not 100% consistent, but I did get it to trigger two of out 5 times.01:14
sethjI take it the EOL scripts haven't been run as I'm finding a lot of really old bugs..01:33
=== hikiko-lpt is now known as hikiko
hikikohello05:14
pittiGood morning05:30
didrockshello!06:14
pittibonjour didrocks !06:23
didrocksça va pitti ?06:23
pittididrocks: ça va bien, et toi ? Dieu merci c'est vendredi :-)06:24
didrockspitti: en effet, c'est vendredi ! Moi, je suis encore malade06:24
didrockspitti: j'ai le nez bien bouché et je me sens comme dans du coton06:24
didrocks(oreilles bouchées, cerveau moyennement actif…)06:25
pittididrocks: hm -- replace work chair with a hot bath?06:25
didrockspitti: would love to, however, yesterday evening, I was given some snappy stuff to do before this afternoon…06:26
didrockspitti: manager's preparation for next week…06:26
pittioh noes06:26
seb128good morning desktopers06:27
pittibonjour seb128 !06:27
seb128hey didrocks pitti06:27
seb128pitti, wie gehts?06:27
didrocksre seb128!06:27
pittiseb128: prima, danke!06:30
pittiseb128: as-tu encore reçu le stollen ?06:30
seb128pitti, non, pas encore06:30
TheMusoHey desktoppers. :) Heading off for the weekend, and indeed for a week off. You see you folks in a week or so. :)06:33
* TheMuso -> EOD06:33
seb128hey TheMuso, enjoy your w.e!06:33
didrocksenjoy your week off TheMuso!06:34
seb128and your holidays as well06:34
larsugood morning!06:34
larsubye TheMuso :)06:34
didrocksgreat morning larsu06:35
larsusalut didrocks06:36
larsuça va?06:36
seb128hey larsu06:36
didrockslarsu: bof, toujours malade…06:36
larsudidrocks: ugh, sorry to hear :/06:36
larsuseb128: hola! que tal?06:37
seb128larsu, prima, danke!06:37
FJKonggood afternoon06:38
seb128hey FJKong06:40
larsuhi FJKong06:40
seb128just as a note, I'm going to be offline in the afternoon06:40
larsuFriday \o/06:40
seb128travelling, so working a bit offline and going to catch up a bit after arriving06:40
FJKongseb128: larsu hey~06:40
didrocksafternoon FJKong06:41
didrocksseb128: safe driving!06:41
seb128didrocks, thanks :-)06:41
FJKongit seems that I need to learn more about golang if we work on snappy.06:41
FJKongright/06:41
FJKongs/\/?06:42
seb128FJKong, not everybody is going to work on snappy06:44
seb128but you can have a look to go if you want, doesn't hurt06:44
FJKongjust look at some demo apps, I find most of them are written with golang06:45
willcookegood morning you fine fellows07:52
hikikohello willcooke07:53
willcookemorning hikiko.  That bug from yesterday, I can't reproduce it, so I dont know why I marked it as rls-w-incoming07:53
willcookeyou can close if you want07:53
hikikothanks willcooke :)07:54
seb128hey willcooke hikiko07:54
willcookemorning seb12807:55
larsumorning all07:55
willcookeg'day larsu07:55
larsuthis is n²...07:56
larsuat least it comes in waves :)07:56
willcookeI prefer to think of it as The Waltons effect07:58
larsuheh07:58
willcookehttp://www.ubuntu.com/usn/usn-2743-3/08:00
willcookeseb128, did you see that ^^ ?08:00
hikikohi seb128 larsu et al08:01
seb128willcooke, saw now, "fun"08:01
Laneyyo08:03
seb128hey Laney08:03
didrocksgood morning willcooke, hikiko, Laney!08:04
didrocks3 in a row \o/08:05
hikikohi didrocks :)08:05
seb128Laney, seems like we got adwaita-icon-theme-full on the iso, unsure if that's wanted?08:07
seb128(I guess not, otherwise the split becomes useless?)08:07
Laneyyes08:07
Laneyyou looking at it?08:08
seb128not yeah, I don't have it installed on my desktop, so probably a recommends somewhere08:11
seb128need to download a daily iso I guess ;-)08:11
larsuhi Laney :)08:11
larsupesky recommend!08:11
larsu*recommends08:12
Laneyhey larsu and didrocks and seb128 btw :)08:12
Laneyseb128: I would usually check http://people.canonical.com/~ubuntu-archive/germinate-output/ubuntu.wily/all first08:12
Laney(probably don't open that in your browser)08:12
Laney(firefox...)08:12
didrocksbtw, if anyone wants to debug the media keys not working, I'm again in a session with that state08:13
didrocksas yesterday08:13
didrocksas the day before…08:13
didrocksand such :p08:13
willcookehey didrocks, how are you feeling today?08:13
didrocksTrevinho: once you are here, I thought you were looking into this race? ^08:13
didrockswillcooke: worse than yesterday, speaking heavily from the nose…08:14
willcooke:(08:14
didrocks(add that to a French accent :p)08:14
willcooke;)08:14
larsulol08:14
* larsu hugs didrocks 08:14
* didrocks hugs larsu back (IRC germ firewall FTW \o/)08:14
seb128larsu, Laney, do we want gnome-themes-standard on the iso?08:16
seb128it's what pulls in adwaita-icon-theme-full08:16
Laneywhy is that there?08:17
larsuseb128: I thought this was not needed anymore?!08:17
larsumaybe it has the gtk2 theme?08:18
Laneycalm08:18
Trevinhohi08:47
Trevinhodidrocks: media keys...08:47
Trevinhomh08:47
didrocksTrevinho: media and shorcuts08:48
didrockslike ctrl+alt+t, and such08:48
Trevinhoyeah, the code is the same08:48
didrocksremember, we talked about a race that started to happen last cycle if I'm right?08:48
didrocksyeah08:48
TrevinhoI don't remember we did... But might be :)08:48
didrocksso, I'm in that state currently (happened quite more recently than before)08:48
Trevinholast cycle the API changed, but I never got issues because of tat08:49
Trevinhothat*08:49
didrockslike once every 4 login08:49
didrockswillcooke experienced it for sure08:49
* willcooke me toos08:49
Trevinhodidrocks: when it happens have you tried to give dbus-monitor a check?08:49
didrocksTrevinho: what do you want me to monitor in particular?08:49
willcookeheh, dbus monitor is broken, right larsu :)08:49
Trevinhowell, see what's dispatched and how08:50
Trevinhowell, mh it's on interface org.gnome.Shell08:50
Trevinhosignal AcceleratorActivated08:51
* didrocks stops the workrave08:51
didrocksok, let's see08:51
didrocksbecause workrave is spamming dbus08:51
Trevinhobut... well, that might not work if it has not been registered08:51
didrocksTrevinho: ok, signal is sent08:51
Trevinhodidrocks: ahhh... actually better, maybe trying to initctl restart unity-settings-daemon?08:51
didrockshttp://paste.ubuntu.com/12552555/08:51
didrocksfor instance08:51
Trevinhono, dono't do that then08:51
didrocksTrevinho: killing unity-settings-daemon doesn't work normally08:52
TrevinhoSo.... registration of keybindings on startup is done, so unity is aware and it does the right thing...08:52
Trevinhonow, I guess it's still u-s-s that should receive the AcceleratorActivated signal and do what expected08:52
Trevinhoattente: is this right, correct?08:52
seb128he's probably sleeping08:53
didrocksI don't remember what it spawing those, I think you are right, it's u-s-s08:53
didrocksu-s-d*08:53
Trevinhoyaeah, ...-d :P08:54
didrocksI can see the MediaKeys interface on the bus08:55
didrocksorg.gnome.SettingsDaemon.Keyboard08:55
larsuyeah people, don't use dbus-monitor with a destination match08:55
larsuit's broken08:55
larsu`busctl --match destination=...` works08:56
larsuor dbus-monitor and ... err .... grep08:56
larsu(bug is filed)08:56
didrocksdestination=(null destination)08:56
didrocksis that supposed to be the case?08:56
didrocks(it's what we have for a broadcast, I guess?)08:56
larsudidrocks: sorry, I meant when you give a specific destination08:58
larsulike, dbus-monitor destination=org.freedesktop.Notifications08:58
larsuyou will *not* see bus traffic to notification daemon08:58
didrockslarsu: but those media keys don't have any destination in the normal case, right (do you mind checking by giving it a try?)08:58
larsuit works if you leave off the destination match, or use busctl08:58
larsudidrocks: in a 1:1 right now. Is there a bug I can get the summary from?08:59
didrocksas you are in a working state, and I hope to keep my broken state to debug it08:59
didrockswillcooke opened one, let me check if I can find it08:59
didrocksbug #148218109:01
ubot5bug 1482181 in unity-settings-daemon (Ubuntu) "Media keys (ctrl-alt-t, brightness, play/pause) don't work randomly after logging" [Undecided,Triaged] https://launchpad.net/bugs/148218109:01
larsuah *this* problem09:01
larsuI've had this09:01
larsudidrocks: please STAY in the broken state. I'll be with you in a few minutes09:01
didrocksthx!09:02
* didrocks commented09:02
didrocksand stay broken09:02
didrocks(broken and sick, nice Friday! :p)09:02
larsudidrocks: :1.28 is u-s-d? (busctl status --user :1.28)09:04
didrockslarsu: no, it's compiz09:05
didrocksit's the compiz gnome plugin IIRC which handles the keys09:06
didrocks(as we have some special build process for that)09:06
didrocksso compiz gets the press event, and broadcast it correctly09:06
didrocksthen, the other side (which should listen on that iface and launch the corresponding app) doesn't work09:07
didrocksI wonder if that couldn't be a side effect of the "listen to a signal, and then read the key"09:07
didrocks(in gsettings)09:07
didrockson the receiver side09:07
larsugsettings shouldn't be involved here09:08
didrockssorry, I meant the glib signal change09:08
didrocksbut yeah09:09
didrockssorry ECONFUSED ;)09:09
larsuso we don't use u-s-d media keys plugin?09:09
didrocksnot for listening in the unity settings, no09:10
didrocks(we never had since unity)09:10
didrocksit's the compiz-gnome plugin09:10
larsumedia keys plugin is active though..09:11
didrocksyeah, unsure why…09:11
larsumaybe these two step on each other's feet?09:12
* willcooke fires up his test laptop09:12
larsulet me check the bus traffic09:12
larsu(working for me right now09:12
larsu)09:12
didrocksyeah09:12
didrocksso, what is the listening interface on the other side to receive the signal and spawn a process?09:13
didrockssounds like compiz, not that the interface is GnomeShell?09:13
larsuwow, 10 messages for one key09:13
larsuoh, with returns09:13
didrocksI only have one?09:13
didrocksyeah, just one here09:14
didrocksand no returns :p09:14
larsudidrocks: the gnome shell interface is exposed by unity09:14
didrocksso it's back on Trevinho's plate? :)09:14
didrockslarsu: yeah, that's what I'm seeing from the .service file09:14
larsudidrocks: you should at least also get messages to notify-osd and "backlight-changed" or similar09:14
didrockslarsu: no, nothing, (and of course, no notify-osd)09:15
larsuthis is because it's broken, right?09:15
didrocksyep09:15
larsuholy shit whatever is sending the notify thing is asking the daemon about it's capabilities all the time09:16
larsu*sigh*09:17
didrockslarsu: just in case, "did you change yet?" :p09:17
larsuhaha09:17
willcookeLaney, wallpaper judging has begun....09:18
didrocksso, if I use a Method like UngrabAccelerator(0), I get a return value09:18
Laneygood!09:18
didrocksthere is clearly something listening on the other side09:18
didrocksbut not at signals on that iface?09:18
willcookedesktoppers:  Take a look at the wallpaper entries... https://www.flickr.com/groups/ubuntu-fcs-1510/pool/09:18
didrockslarsu: so, seems like to be in Unity code?09:19
larsudidrocks: you see the signal though, right?09:19
larsujust not the "result"09:19
larsuwhy would unity send itself a signal via dbus, I wonder09:19
didrockslarsu: yeah, I have the signal, but no response09:19
didrockslarsu: because it's 2 different plugins handling it? :p09:20
larsuhah09:20
=== hikiko-lpt is now known as hikiko
larsuhm, unity-settings-daemon is talking to itself09:21
Laneyseb128: did you look at it or should I?09:21
didrocksit seems that GnomeGrabber::Impl::activateAction isn't called for whatever reason09:22
Laneyseb128: seems either metacity or gnome-themes-standard or both could fix this09:22
didrockslarsu: I guess it's where we are blocking on Trevinho to have a look now09:22
larsusorry, brb09:24
seb128Laney, I didn't, sorry, busy with something else and travelling this afternoon, feel free if you want09:26
Laneythx09:26
seb128otherwise it's likely going to be on monday for me09:26
Laneynp09:26
seb128thanks09:27
seb128larsu, didrocks, just for info https://code.launchpad.net/~attente/unity/gnome-key-grabber was the changeset to use those interfaces09:29
seb128it might make easier to see the code impacted from the diff of the feature landing09:29
seb128but basically unity should do the grabbing and dbus message u-s-d which does the actions09:30
hikikohttps://code.launchpad.net/~hikiko/compiz/compiz.fix-811591/+merge/272359 Trevinho could you approve this? (it's a bug from ages sam proposed that solution that works for me but it was never added to ubuntu)09:36
hikikoor andyrock ^09:36
* hikiko gets rid of bugs :p09:36
* Trevinho on it09:37
Trevinhomh hikiko don't comment code, or if you do add some explaination please. However, I'd just go by dropping those lines. In case bzr annotate or log will help to understand what changed09:38
hikikook :)09:38
hikikosec09:39
larsuseb128: thanks!09:39
larsudidrocks: you're getting the signal, so I'm guessing the problem is in settings-daemon09:40
larsuwhich actually has two plugins talking to themselves on the bus :/09:40
hikikoTrevinho, fixed09:41
Laneyhi u-s-d, how are you?09:41
Laneyfind u-s-d, and you?09:42
Laneyfine*09:42
Laneygreat thanks u-s-d!09:42
seb128didrocks, larsu, isn't media-key what has the handlers for those dbus calls?09:42
seb128what is the second plugin?09:42
larsuseb128: the media key plugin calls the org.gnome.SettingsDaemon.Power.Screen.GetPercentage09:43
larsuand then .StepUp09:43
larsubut all of this doesn't seem to be happening for didrocks09:43
seb128why does it call that?09:44
larsuto chnage brightness (the media key I pressed)09:44
larsufor volume, I guess it calls pulse directly?09:44
seb128oh, I see09:45
seb128ok, good desktop people I need to drop offline, going for lunch and then travelling09:46
seb128I'm going to work a bit offline and should be back betwee 17-1809:46
larsuhehe enjoy!09:46
seb128see you later or have a good w.e for those who call it a day by then09:46
seb128thanks!09:47
larsuyou too!09:47
willcookecya seb12809:47
larsudidrocks: can you paste the output of `busctl --user call org.freedesktop.DBus /org/freedesktop/DBus org.freedesktop.DBus.Debug.Stats GetAllMatchRules` please09:47
didrockslarsu: sorry, in a HO09:53
didrocksjust read last line but: http://paste.ubuntu.com/12552889/09:53
larsudidrocks: no worries, that was the only interesting one09:56
didrockslarsu: ok, can focus more on this, and opened to any experience that doesn't include physical danger :p10:05
larsudidrocks: ha ok10:09
larsuso, you have the match rule10:09
larsucurrently going through u-s-d code to see what could go wrong10:10
didrockslarsu: but it's not u-s-d which spawn the process, it's only handling the notification communication?10:10
didrocksmeaning, we would have:10:10
didrockscompiz-gnome -> send signal10:10
didrocks1. u-s-d grab it and send notification10:10
didrocks2. unity grabs it and launch the corresponding action/process10:11
didrocks?10:11
didrocks(like for ctrl+alt+t, launch the terminal)10:11
larsuright, unity grabs some keys10:11
larsubut volume and brightness are handled directly10:11
larsuthey all don't work for you, right?10:11
didrocksyeah, all10:11
didrocksso media keys are per see, and other command shorcuts10:12
didrockslet me try to see if I see different traffic for ctrl+alt+t10:12
didrocksargh,and of course, I tried ctrl+alt+t to have a terminal to monitor the traffic…10:12
larsutry volume10:13
didrocksok, same with ctrl+alt+t, just getting the broadcast signal10:13
larsuor brightness10:13
didrocksvolume is what I tried in my previous paste10:13
larsuok, then unity is not involved at all10:13
didrocksso, same, just getting broadcast signal in both case10:13
didrocksyeah, can be dbus not delivering to any of them?10:13
larsuhm?10:14
larsusomeone has the match rule, so it should arrive10:14
larsuand that someone is most likely u-s-d10:14
didrocksshouldn't we have 2 then?10:14
didrocks(matching)10:14
didrocksu-s-d for media keys10:14
didrocksunity for shorcuts10:14
larsudoes unity also listen on the gnome shell interface?10:15
didrocksand then, they filter and only care about some part of the answer10:15
larsuunity *is* the gnome shell interface10:15
larsuI hope they simply handle Ctrl+Alt+T internally?!10:15
didrockswell, if this was internally handled, it would work, right?10:15
didrocksseems like it's using the exact same pipe10:15
larsuindeed10:15
larsumaybe u-s-d handles all of those?10:17
didrockslarsu: maybe (as it's working for you), set some new env variable to u-s-d10:18
didrocksthen ctrl+alt+t10:18
didrocksand see if the terminal gets them?10:18
didrocksthat would tell us if it's unity or u-s-d spawning the app?10:18
didrocksTrevinho: maybe you know this workflow, what is supposed to launch a terminal for instance on ctrl+alt+t, is it unity?10:20
didrocksor does compiz-gnome just grab the keys, and forward them to the gnomeshell iface?10:21
Trevinhodidrocks: unity only grabs the keys, the it's up to u-s-d to launch10:21
larsuright10:21
didrocksok, so at least, none of them working makes sense10:21
didrocksso, the issue is in u-s-d10:22
didrocksthanks Trevinho10:22
larsudidrocks: gsettings reset org.gnome.settings-daemon.plugins.media-keys terminal10:23
larsudoes this make the terminal key work?10:23
* didrocks tries10:24
didrockslarsu: nope10:24
didrocksthe value didn't change (I did a get before), and still the default: '<Primary><Alt>t'10:25
larsuah10:25
larsutry changing it to something10:25
didrocksok10:25
didrockslarsu: yeah, after changing, it works10:25
didrocksresetting though, doesn't10:25
larsuFUCK10:26
larsuok10:26
larsubut resetting after changing keeps it working, right?10:26
didrocksnope10:26
larsuoh?10:26
didrocksI resetted it (and so '<Primary><Alt>t' again)10:26
didrocksand it doesn't work10:26
larsubut if yo set it to something else it does?10:26
TrevinhoWeird10:27
didrocksyep, I tried Alt + t10:27
didrockswant me to try with the volume keys?10:27
didrocksto confirm this10:27
larsuyes please10:28
didrockssame10:28
didrocksso setting it to Alt +t, I can increase the volume10:28
didrocksgsettings reset it10:28
larsushould be the same changed signal10:28
didrocksand then, the media key doesn't work10:28
larsuthis is awesome :)10:28
didrocksisn't it? :p10:28
Trevinholovely10:28
didrockslet me dbus-monitor this10:28
didrocksto ensure that it's still unity grabbing the key in the second case10:29
didrocks(when setting it to something else)10:29
didrocksso: http://paste.ubuntu.com/12553084/10:31
didrocksand then, getting all the dbus spam with notification, panel service…10:31
* didrocks looks for the send id10:31
didrocksinteresting btw10:32
didrocksthe old key still send a signal10:32
Trevinhousing dbus-monitor --session "interface='org.gnome.Shell'"  does help in filtering?10:32
didrockscan be, but I see enough here10:33
didrockssender=:1.28 in both case10:33
didrocksstill weird that the previous old volume up key send the signal10:33
didrocksso something is wrong unity-side for sure already10:33
didrocksoh10:33
didrocksthe first arg has different values10:33
larsuare you sure? You always get ths signal, regardless of whether the key works, right?10:34
didrocksyeah10:34
Trevinhoaction id maybe is not well defined10:34
didrocksso, I changed to Alt+t, right?10:34
didrocksfor volume up10:34
didrocksand then:10:34
didrockshttp://paste.ubuntu.com/12553099/10:35
didrocksthe first value of that signal is the keycode pressed (the values are different) right? it's not a "capability index" like volume up or such?10:35
larsuno, it's the accel id10:35
didrocksso, it should be the same between the 2 calls?10:36
didrocksor at least, it's unique for "volume up"?10:36
larsuno, u-s-d gets a new one from GrabAccelerator() every time it does a grab10:36
didrocksok10:36
larsuif I understand this correctly10:36
larsubasically it works like this: u-s-d asks unity to grab "Alt+T" and gets an id10:37
larsuand the unity sends signals with that id - so that u-s-d knows which accel was hit10:37
didrocksthat's why you thought reset would work, right? like reasking to regrab "volume up"10:37
larsuyes10:37
didrocksand the bug would have been u-s-d starting before unity10:37
larsuindeed10:37
larsubut since it stops working again when you regrab the old key, this doesn't seem to be the case10:38
didrocksyeah…10:38
larsubut we're onto something10:38
larsutry this:10:38
larsudbus-monitor interface=org.gnome.Shell10:38
larsugsettings set org.gnome.settings-daemon.plugins.media-keys terminal "<Alt>t"10:39
larsugsettings reset org.gnome.settings-daemon.plugins.media-keys terminal10:39
larsugsettings set org.gnome.settings-daemon.plugins.media-keys terminal "<Alt>t"10:39
larsuin between, hit Alt+T and Ctrl+Alt+T10:39
larsuand send the log of the monitor10:39
didrocksk10:39
larsuthanks for being so patient!10:39
didrocksno worry, I'm eager to see it fixed, this waited for too long :)10:40
didrockslarsu: here we go, with annotation: http://paste.ubuntu.com/12553139/10:43
larsuyou're the best!10:43
* didrocks hugs larsu10:43
didrocksso, the weird thing10:43
didrocksUngrabAccelerator10:44
didrocksthe id isn't the one for Primary alt T10:44
larsuyeah10:44
larsulooks like it's getting confused?!10:44
didrocksyeah10:44
didrocksif I keep pressing it10:44
didrocksresetting*10:45
didrocksI always have a GrabAccelerator -> id 310:45
didrocksbut an ungrab id incrementing10:45
didrocks   uint32 73610:45
didrocks   uint32 73710:45
didrocks10:45
didrocks(and I just gsettings reset in loop, didn't set it anything else in between)10:45
larsubut also Activated() doesn't send the right accel id10:46
didrocksyep10:46
larsuso that's *clearly* wrong10:46
didrocksindeed10:47
didrocksand that explains why unity doesn't ungrab10:47
larsuunless...... there's an old grab that u-s-d forgot to ungrab10:47
larsuand unity only sends signals for one grab10:47
larsuthis interface is the biggest shit I've ever seen10:47
larsuso many problems10:47
didrockslarsu: I'm sure you can always find worse! :)10:47
larsulol10:47
larsuit should work like this: hey unity, I'm interested in these 10 keys!10:48
didrocksah, remapping rather than incremental?10:48
larsuok :1.xyz, I'll send signals for these keys until you die10:48
larsuor tell me a new set of keys10:48
didrocksyeah10:48
larsuit needs to check lifetime anyway, in case it crashes10:49
larsuso ungrab() is completely useless10:49
didrocksindeed10:49
larsuand apparently causing the problems here10:49
didrocksI don't have any crash of u-s-d, in case this would have been the issue…10:49
didrockslike asked for grabbing, crashing and using weird id10:50
didrocksthat's… weird10:50
didrocksso: here is another try:10:50
larsuno I think it doesn't crash but gets the ungrabbing wrong10:51
didrockshttp://paste.ubuntu.com/12553213/10:51
didrocksso, the id for alt + T which is grabbed when pressed is different from the one set? (always 3)10:52
larsuoh wait, 3 is input, not return10:52
didrocksah yeah, it's a flag10:53
larsudidrocks: sorry I have a lunch date with systemd hackers now. I think I have enough information to figure this out now10:54
larsudidrocks: thanks a lot again. I might have more questions in an hour or two10:54
didrockslarsu: no worry, keeping it broken for the day. Thanks for looking at it!10:55
didrocksenjoy your lunch :)10:55
larsuman, this totally works for me thougj10:56
larsuI bet it gets confused at startup for you10:56
larsuand then stays in some weird state10:56
larsudidrocks: thanks! Eating bulgarian10:56
didrockssounds nice! :)10:56
didrockslarsu: yeah, I think there is something at startup and that's why it's lost then *forever*10:56
larsuindeed10:57
=== alan_g is now known as alan_g|lunch
willcookedesktoppers:  https://goo.gl/jqRgRC11:15
didrockscute!11:16
Trevinhonice11:16
TrevinhoDual landing, then! :(11:17
Trevinho:) ^11:17
didrocksahah11:17
willcooke:D11:21
attentegood morning11:28
didrockshey attente!11:28
attentehi didrocks!11:29
willcookeo/ attente11:34
attenteo/11:35
=== hikiko is now known as hikiko|ln
andyrockgood morning!11:48
willcookehey andyrock11:51
=== hikiko|ln is now known as hikiko
=== alan_g|lunch is now known as alan_g
Trevinhodidrocks: so, I was looking further... And I noticed that the gnomecompat plugin in compiz is still enabled (actually we should remove it from our list nowadays), and that it tries to grab Ctrl+Alt+t... So maybe disabling that plugin (or keybinding) should explain why the activated signal is emitted anyway when chaning setting12:58
didrocksTrevinho: can be, yeah13:00
TrevinhoOh, well no... Actually it shouldn't be there /usr/share/session-migration/scripts/00_remove_gnomecompat_in_unity_session.py13:00
Trevinho(as per this, but maybe it doesn't work?)13:00
* Trevinho tries a clean session13:00
didrocksit's not enable here13:00
didrocksenabled*13:00
Trevinhoah, ok fine13:00
Trevinhoso no troubles from that... It's all in unity13:01
Trevinhobut I don't see unity behave badly... I mean, it should do what expected.13:01
didrocksyeah, it seems to be more on the u-s-d side maybe13:01
didrocksor unity doesn't ungrab the first key13:01
Trevinhodidrocks: if you've installed libxpathselect, you might be able to try to run these AP test autopilot/unity/tests/test_gnome_key_grabber.py13:03
Trevinhothey play with the interface...13:03
TrevinhoSo you might check if ungrabbing happens also13:04
andyrockwillcooke: congrats!! :D13:05
willcookethanks andyrock :)13:05
kgunntjaalton: ping13:22
Trevinhodidrocks: oh... Actually I was looking at the ungrab code... And well it's probably not working well13:22
Trevinhodidrocks: did you try to manually call the UngrabAccelerator command with a valid id and see what's returning?13:23
Trevinhoif it's false, as I believe it might do, then... we're into problems13:23
qenghogood morning13:28
willcookehey qengho13:29
larsuTrevinho: well, unity does some things wrong13:35
larsufor example, it sends the AccelaratorActivated signal to everyone13:36
larsueven though only one process can know about the id13:36
* larsu wonders if gnome shell gets this right13:36
larsuah, seems to13:38
Trevinholarsu: well, that's right... But since the ID is generated with methods, others shouldn't listen that13:38
Trevinhohowever, i was mostly concerned by this didn't work, but it actualyl does http://pastebin.ubuntu.com/12554355/13:38
larsuwell, others get woken up13:39
larsuand then ignore the message because it doesn't have an id they know about13:39
larsucould set up a match rule with arg0 set to the id13:40
larsu... for every key13:40
larsuman this interface is dumb13:40
Trevinhowe should emit the id to the register only, true... To do that we should change our glib::DBusObject too, but feasible13:41
didrockssorry guys, still on a HO13:54
didrockslarsu: Trevinho: do you want still me to try to manually call the ungrabAccel (I'm unsure about the first key id which was set though)14:01
Trevinhodidrocks: well, in theory it's the same id you get when you use the key and unity emits the signal14:04
didrocksTrevinho: oh sure, let me try14:04
didrocksok, called ungrabbed14:05
didrocksreturned true14:05
didrockspressing and working now14:05
didrockswith another id14:05
didrocksso, yeah, the key is registered twice14:05
didrocksand unity only send the first one14:05
didrocksso, this starts to make sense14:06
didrockslarsu: Trevinho ^14:06
didrocksto sum up:14:06
didrocks-> key id was 3314:06
didrocksI ungrabbed(33)14:06
didrockspress again14:06
didrocksand now, it's 72014:06
didrocksand the notification popups and such14:06
TrevinhoOk, makes sense... So we need to ensure that an action is just registered once14:06
didrocksyep14:06
didrocksas it will stop at the first match I guess14:07
Trevinhoand no register again if someone tries to do that14:07
didrocksbut then, it means there is one case where it registers twice14:07
didrockswithout ungrabbing?14:07
Trevinhounless there's an ungrab (best if from the same who asked to grab, but I wouldn't do that for avoiding trobules :P)14:07
didrocks(for all keys, with some racy start condition?)14:07
didrocksyeah14:07
didrocksungrab is always called before grabbin?14:07
didrocksgrabbing*14:08
* didrocks looks14:08
didrocksat least, seems so from the logs14:08
didrocksso it's supposed to work14:08
Trevinholarsu: do you want me also to emit the signal only to the one who registered the grab? Although, if u-s-s crashes, we need to re-register every keybinding... it seems too much noise, considering that security isn't there ayway14:08
didrocks(your strategy to not reregister)14:08
didrocksgood call on the crash case, you will need to track and reregister14:09
didrockswhere broadcast only enable you to "not care"14:09
* Trevinho takes the occasion to semplify this stuff14:10
didrocksTrevinho: ok, confirmed with another key where I didn't do any reset/set14:11
didrocksand of course, the id is way smaller (89)14:11
didrocksdoesn't fix the real bug where is this something registering twice at startup though14:11
didrocksbut weird, especially with no u-s-d crash14:12
willcookedidrocks, so we have got to the bottom of the issue then?14:13
didrockswillcooke: well, we know how it happens, Trevinho is working on a fix (I guess?), we don't know exactly why it goes to that state sometimes though14:15
willcookeoki, progress though, thanks all14:16
didrocksyeah, at least, this should be fixed from an user perspective :)14:16
Trevinhoyeah, working on that14:16
larsuTrevinho: hm? You need to watch the service anyway to unregister the ids (in case it crashes)14:16
didrockswould be good to understand exactly why this happens, as this kinds of things are always stricking back in a worse case14:17
Trevinholarsu: yes, that's true... But I don't think it's something done right now... I was doing that, anyways...14:18
Trevinholarsu: i guess that's the reason why we didn't replace actions before14:18
larsuactions?14:20
TrevinhoI mean keybindings... The problem was that we were just adding new keys ignoring the old ones14:21
larsuright, that's the problem didrocks is seeing?14:21
Trevinhoso, when restarting usd, we were just adding the same keybindings twice14:21
Trevinhoyeah... To reproduce just do something like14:22
Trevinhogdbus call --session --dest org.gnome.Shell --object-path /org/gnome/Shell --method org.gnome.Shell.GrabAccelerator "<Shift><Control>x" 014:22
Trevinhotwice or more...14:22
TrevinhoWe don't return false14:22
larsuindeed14:22
larsuso this is the issue?14:23
larsudidrocks' u-s-d crashes14:23
larsuonce on startup?14:23
* larsu checks14:23
Trevinhono, it adds twice the same shortcuts..14:23
larsuwell, it adds them again when restarting14:23
Trevinhoso only the first id is used by ucc, but unity sends the last registered one14:24
larsuand unity doesn't delete the old ones14:24
larsuoh14:24
TrevinhoWell, that wouldn't be an issue, as restarting adds new ones...14:24
larsuit only registers them once for me14:24
larsuTrevinho: except for the obvious memory leak ;)14:24
Trevinhohere's what I get http://pastebin.ubuntu.com/12554875/14:25
didrockslarsu: I don't have anything in /var/crash14:25
didrocksas told14:25
Trevinhoyeah, I just think that for some reason you get the method called twice14:25
didrocksyep14:25
didrocksand without ungrab in the middle14:25
larsuTrevinho: I don't see it twice in didrocks' logs14:26
Trevinhodidrocks: for double checking, you might set UNITY_TEST_LOG_SEVERITY="<root>error;unity.key.gnome.grabber=debug" for your session and see if you get anything relevant14:26
Trevinholarsu: I guess it happens on startup..14:26
Trevinhoerr, sorry wrong env name14:26
didrocksTrevinho: well, it's not a one 100% startup case, but yeah, I can do that for future logins14:27
Trevinhodidrocks: it's UNITY_LOG_SEVERITY="<root>error;unity.key.gnome.grabber=debug" for your session and see if you get anything relevant14:27
Trevinhodidrocks: yeah, I know, but you might try to relogin tons of times :)14:27
didrocksTrevinho: unsure about now, I have quite some stuff opened and working on, but yeah, adding for later :)14:28
Trevinhodidrocks: sure, no worries14:28
* Trevinho has an uptime of weeks generally, so... I also never leave my session :)14:28
didrockslarsu: so, let's say I press volume down, I see the "32" key id being fired14:30
didrockslarsu: then, I ungrab(32)14:30
didrockslarsu: I press again, and I get another event with key id 89, everything now works14:30
didrockslarsu: so, there are been at some point, 2 grab() calls without ungrab14:30
didrocksand unity only send the first match14:31
didrockswhere u-s-d expects the second14:31
larsuya14:31
didrocks(which is, I guess for it, the only valid one)14:31
larsucrashing u-s-d is enough to trigger this for me14:31
larsuI guess for the same reason14:31
didrocksthe weird part is u-s-d didn't crash for me14:31
larsuTrevinho: you need to watch the name and remove all grabs when it disappears14:31
larsus/you/unity :P14:32
larsudidrocks: thank!14:32
didrocksso, there is a case where 2 grabs are called, without ungrab in between14:32
didrocksyw!14:32
larsuright14:32
larsuwhich is the case when it crashes14:32
didrockslarsu: I do expect Trevinho to look at every laptop and watch for the grabs :)14:32
didrocksyep14:32
larsuhaha14:32
larsuTrevinho: do you want to fix it or should we make a better API?14:33
* larsu wonders what else is using this14:33
Trevinholarsu: well, as you prefer... I was about to use this API as it was the same gnome uses, but we can also make a new one14:35
Trevinholarsu: what would you prefer? I'd say the new one, right?14:35
larsuTrevinho: do you know if anyone else is using this interface?14:35
Trevinholarsu: I was about asking you the same :)14:36
larsubecause if you need to implement it anyways, we might as well keep it14:36
Trevinholarsu: well... let me see... We use it for menus I believe, but not sure if it's unity module or we do in unity (/me checks)14:36
didrockswell… we need something for wily though14:36
didrocksand I don't think you want to introduce the new API now :p14:37
willcookeyes!14:37
Trevinhono, we do that internally for menus, so I don't think anyone would use14:37
Trevinhowell... private stuff... :P14:37
willcookedidrocks, yes, as in, no - no you dont14:37
TrevinhoOk, I'm reusing the old one....14:37
larsugood point14:37
didrocksstill, behavior change and such, you can still do a bandaid for now14:38
didrocksand nothing prevents to work on the new API now :)14:38
didrocksbut first bandaid I would say ;)14:38
* Trevinho hates bandaids...14:39
Trevinhobut yeah...14:39
didrockswell, as everything, it's a risk/benefit assement :)14:39
Trevinholarsu: let's decide it now though... as actually I'd avoid to do things twice and probably it's not the best thing to rewrite this in u-s-d and unity. Considering we can rewrite just one side14:40
larsuya14:40
Trevinho(keeping u-s-d even closer to upstream)14:40
larsuok, so nothing needed from me?14:43
didrockslarsu: don't you think we should investigate why the grab can happen twice at some startup?14:44
didrocks(and without an ungrab in between)14:44
larsuah right you said it's not because it crashed14:44
didrocksyeah…14:44
didrocksthat worries me14:44
didrocksmaybe we just get lucky most of the time and the last grab is what unity sees14:44
didrocksbut maybe sometimes…14:44
didrocksand so, we would double grab for everyone at every login?14:45
larsusigh14:46
didrockslarsu: so, I just looks at /proc/pid/maps14:47
didrockslarsu: it doesn't load (phew) the g-s-d media keys plugin14:47
didrocksI wonder though why I have every plugin listed 4 times?14:47
larsuhaha good idea14:47
larsuhm? in maps?14:47
didrocksyep14:48
didrockseven libwacom and such14:48
didrocksthat might be "normal", I would have expected to see it only once though14:48
larsuthat's all libs though, not only the plugins14:48
larsuat least for me14:48
didrocksyeah14:48
didrockssale14:48
didrockssame*14:49
didrocksok, so "normal"14:49
didrocksI guess it spawns multiple memory chunks14:49
didrocksso, it's not the g-s-d plugin interfering, so, in the code itself…14:49
tjaaltonkgunn: pong, EOW already, but if you have a bug just assign it to me :)14:49
kgunntjaalton: no worries, i'll just email you...oh, i'm assuming you're the person to talk to about mesa uploads ?14:50
tjaaltonkgunn: yes, did 11.0.0 break something?14:51
kgunntjaalton: yep :) so just wanted to establish some kinda of communication/agreement between us14:52
tjaaltonfirst point release will arrive today, i'll push it next week14:52
tjaaltonah14:52
kgunnbusted our mir ci jobs for wily14:52
tjaaltonwell the FFE was filed a month ago and raof tested it iirc14:53
tjaaltonbut i hear you14:53
didrockshave a good week-end guys!16:02
=== alan_g is now known as alan_g|EOW
Laneybye!17:11
willcookegnight Laney17:12
willcookegnight all17:12
TrevinhoGood weekend folks!18:11
attentebye!21:49

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!